03:31:57 Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-5199-gb287095a7e 04:52:15 New branch created: pull/3803 (3 commits) 13https://github.com/crawl/crawl/pull/3803 04:52:16 03sdynet02 07https://github.com/crawl/crawl/pull/3803 * 0.32-a0-1075-gfe9b2f4bef: Adjust fugue to level 2 10(60 minutes ago, 2 files, 3+ 3-) 13https://github.com/crawl/crawl/commit/fe9b2f4bef29 04:52:16 03sdynet02 07https://github.com/crawl/crawl/pull/3803 * 0.32-a0-1076-g1e140c0836: Reaver background rebalancing 10(32 minutes ago, 2 files, 6+ 5-) 13https://github.com/crawl/crawl/commit/1e140c08365d 04:52:16 03sdynet02 07https://github.com/crawl/crawl/pull/3803 * 0.32-a0-1077-g466adf6a6c: Necromancer background rebalancing 10(11 minutes ago, 1 file, 2+ 1-) 13https://github.com/crawl/crawl/commit/466adf6a6c1d 05:08:22 Unstable branch on crawl.akrasiac.org updated to: 0.32-a0-1074-g4fd57f6 (34) 05:54:43 <02Monkooky> man I wanted to be done so bad that I didn't actually make sure I was done :< 05:59:59 <04dracoomega> I mean... if you're not feeling it right now, you don't need to pressurize yourself on that account 06:03:13 <04dracoomega> There's no rush, and I don't mind doing some cleanup work on it myself at some point 06:04:27 <04dracoomega> (Currently realizing that implementing Blorkula is annoying in almost exactly the same way that earlier iterations of reviving apostles was annoying >.>) 06:14:53 <02Monkooky> do really appreciate the feedback there's a few things there where I really should have realized something was amiss, and I knew LOS was broke at some point and straight up forgot to do something about it (and knowing how is super useful) 06:16:26 <02Monkooky> and knowing exactly how things are breaking makes life so much easier 06:19:42 <02Monkooky> RE: self-corrode- felt like it was preferable to have expected corrosions/aut be (mostly) constant 06:21:28 <02Monkooky> though looking at acid clouds, it doesn't do that, it's just a constant, kind of wack chance per turn 06:21:42 <02Monkooky> also I really want to refactor corrode chance this is stupid 06:23:50 <04dracoomega> Like, corrode chance in general? 06:25:36 <02Monkooky> yes 06:28:45 <02Monkooky> corrode_equipment vs acid_corrode feels like there is very little intent behind the separation 06:34:31 <02Monkooky> acid_corrode(3) will call corrode_equipment 66% of the time for monsters, and 35% of the time for players acid_corrode(5) will call corrode_equipment 66% of the time for monsters, and 49% of the time for players 06:36:32 <02Monkooky> for some reason this is computed with a binomial distribution 06:40:05 <04dracoomega> Yeah, I seem to recall that some 'corrosion strength' parameter is deliberately ignored for monsters and only relevant for players 06:40:13 <04dracoomega> I assume a lot of this is fairly ancient 06:43:38 <02Monkooky> I'm also still pretty shaky on whether having corrosion degree in corrode_equipment is at all reasonable since it only applies to Wu Jian wrath 06:44:52 <02Monkooky> and results in things like monster::corrode_equipment using a binomial(degree,50) which is always a 50% chance 06:49:06 <04dracoomega> Wait, really? (I've not looked closely at this myself; at least not in a long time) 06:50:05 <02Monkooky> yeah, monster::corrode_equipment future-proofs against high degree corrodes in the resist check 06:50:31 <02Monkooky> but the only 'high' degree corrode can't apply to monsters 07:27:16 <04dracoomega> Trying to decide whether it makes more sense to add another type to CrawlStoreValue, entirely for Blorkula, or to add a single follower* member to Player for the same reason >.> Both feel quite silly, but saving a copy of a monster with their equipment is rather tricky otherwise. (Probably the former, even if touching CrawlStoreValue scares me a little. Even if Player does track a couple similar things directly, like 'is the royal 07:27:16 jelly dead') 07:59:10 <05icoson> trying to modify store.cc code is always the worst option if there's anything else to do imo 08:01:36 <05icoson> I'm not entirely sure what you're trying to do but store already handles monster anyways 08:02:07 <04dracoomega> Monsters can't store items on them, alas. 08:02:14 <05icoson> store also handles items 08:02:33 <05icoson> and crawlvectors 08:02:58 <05icoson> if a follower is essentially a tuple of monster + a vector of items, you can implement it like that in a store without modifying store 08:03:09 <04dracoomega> I know. My original implementation of newBeogh involved manually reconstituting an apostle and their equipment via monster and item saved seperately in props, but the Follower class basically handles all of that specifically already 08:03:32 <04dracoomega> So I thought about just being able to store one of those in CrawlValueStore 08:04:35 <05icoson> it's still better to write a function on follower that serializes/unserializes into a store, than modify store 08:06:06 <04dracoomega> Is it? I mean, what is actually the problem with adding a new type to store? The code itself is fairly complex, but adding a new type seems relatively cookie-cutter? (I'm entirely willing to accept that I'm missing something there, though) 08:06:37 <05icoson> store is extremely fiddly and changes potentially impact save compat in bad ways 08:10:19 <04dracoomega> Wouldn't that only be the case if editing something about an existing type rather than adding a new one? All the marshall/unmarshall code switches on the store_val_type and this would just be adding a new one to the enum. (Is it mostly 'It could be a problem if you do something wrong?' >.>) 08:12:16 <05icoson> it's very easy to do something wrong and the consequences for save compat when you do are likely unrecoverable 08:12:29 <05icoson> anyways, I'm just giving you my recommendation based on my experience with this code, do what you want 08:13:46 <04dracoomega> I mean, I don't want to press the issue if you're so concerned about it. 08:15:47 <04dracoomega> After looking at the code myself some today, I think it would probably be fine, but on the off-chance that it isn't, doing the 'simpler but dumb-looking (but also almost certain not to break anything)' option is probably fine, I suppose 08:36:59 03Monkooky02 07https://github.com/crawl/crawl/pull/3775 * 0.32-a0-1078-g6b061d258a: fix gastronomic LOS 10(17 seconds ago, 1 file, 1+ 3-) 13https://github.com/crawl/crawl/commit/6b061d258af1 09:02:32 03Monkooky02 07https://github.com/crawl/crawl/pull/3775 * 0.32-a0-1079-g90c605235f: Update status colour 10(56 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/90c605235fe5 10:57:33 03Monkooky02 07https://github.com/crawl/crawl/pull/3775 * 0.32-a0-1080-g450c637e87: make gastronomic expanse do acid damage 10(38 seconds ago, 2 files, 1+ 2-) 13https://github.com/crawl/crawl/commit/450c637e8738 15:37:01 Rudyous (L27 DsCj) ERROR in 'mon-cast.cc' at line 1819: Unknown monster spell 'Gell's Gravitas' cast by Canwutygu's ghost (Zig:17) 15:38:10 Unstable branch on underhound.eu updated to: 0.32-a0-1074-g4fd57f6e19 (34) 15:40:50 <04dracoomega> How is that still happening? (Though it does seem to be happening much less) 15:41:29 <04dracoomega> It's flagged no_ghost and there's code to deliberately remove it from them, too 15:49:27 <05icoson> People don’t have to update, so it could still be a pre-fix version 15:50:41 <04dracoomega> I checked. It is not. 19:39:27 -!- The topic of #crawl-dev is: Crawl Development | https://github.com/crawl/crawl | Logs: http://s-z.org/crawl-dev/, temporarily http://crawl.akrasiac.org/logs/cheibriados/ | People with +v have commit access, devs on bridged discord as well | General Crawl-related chat to #crawl | Long stuff to a pastebin service, please 19:39:27 -!- The topic of #crawl is: Play Dungeon Crawl Stone Soup online now! Type ??online for instructions, ??lg / !lg for play stats | PM Sequell for long queries | http://crawl.develz.org | FooTV game replays: ??footv for instructions | #crawl-dev for dev discussion, #crawl-offtopic for offtopic 20:19:15 <06dolorous_84348> Does it only happen with randomly-generated ghosts, as opposed to ghosts actually generated from deceased players? 20:25:51 <04dracoomega> There's been some other buggy behavior with the ghost store that I don't really understand (especially in Zigs?). I have no idea if that could be connected in some way. 22:42:54 <02Monkooky> adding to the refactor list: the way you permit firing with no targets in sight is Not Good 23:45:13 Monster database of master branch on crawl.develz.org updated to: 0.32-a0-1074-g4fd57f6e19