00:37:58 Unstable branch on crawl.kelbi.org updated to: 0.32-a0-799-g95e1662365 (34) 00:37:58 Unstable branch on crawl.kelbi.org updated to: 0.32-a0-799-g95e1662365 (34) 00:40:29 Fork (bcrawl) on crawl.kelbi.org updated to: 0.23-a0-5140-g5775ae71e1 00:40:29 Fork (bcrawl) on crawl.kelbi.org updated to: 0.23-a0-5140-g5775ae71e1 00:55:06 Monster database of master branch on crawl.develz.org updated to: 0.32-a0-799-g95e1662365 04:30:23 Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-5140-g5775ae71e1 05:08:45 Unstable branch on crawl.akrasiac.org updated to: 0.32-a0-799-g95e1662 (34) 05:54:22 03dolorous02 07* 0.32-a0-800-ga5f95a5a20: Make god protection work even with manual swings. 10(18 hours ago, 1 file, 3+ 0-) 13https://github.com/crawl/crawl/commit/a5f95a5a2044 05:54:22 03dolorous02 07* 0.32-a0-801-g93c155cd69: Remove Fedhas' no-hurting-friends conduct. 10(18 hours ago, 3 files, 2+ 6-) 13https://github.com/crawl/crawl/commit/93c155cd6926 05:54:22 03dolorous02 07* 0.32-a0-802-gb0e0dd98ef: Remove Jiyva's no-hurting-jellies conduct. 10(7 days ago, 5 files, 5+ 35-) 13https://github.com/crawl/crawl/commit/b0e0dd98ef63 05:55:33 <05icoson> huh cao had a twitter account https://twitter.com/crawlakrasiac 05:56:30 03dolorous02 07* 0.32-a0-803-g303fdf7e8e: Adjust Blork the orc description/dialogue. 10(2 days ago, 2 files, 55+ 18-) 13https://github.com/crawl/crawl/commit/303fdf7e8ef2 06:09:17 03SentientSupper02 {dolorous} 07* 0.32-a0-804-g4d9a32fa43: Make allies avoid pressure plate traps 10(30 hours ago, 1 file, 2+ 1-) 13https://github.com/crawl/crawl/commit/4d9a32fa4350 06:18:51 03SentientSupper02 {dolorous} 07* 0.32-a0-805-g766f10fcc8: Clear dimensional bullseye when apostle yields 10(34 hours ago, 1 file, 1+ 0-) 13https://github.com/crawl/crawl/commit/766f10fcc816 06:25:15 03advil02 07* 0.32-a0-806-g524b7c7fd8: fix: quiet a dgl-build-specific warning 10(66 seconds ago, 1 file, 2+ 0-) 13https://github.com/crawl/crawl/commit/524b7c7fd828 06:59:16 03dolorous02 07* 0.32-a0-807-g23d0647428: Remove now-unneeded #include (yrdzrfxndfvh). 10(8 minutes ago, 1 file, 0+ 1-) 13https://github.com/crawl/crawl/commit/23d06474284b 07:00:30 <05icoson> I guess it's good that worked out but imo correct fix is to delete every single one of this "imported for" comments 07:04:47 <06dolorous_84348> In the long term, yes, but that's a much greater undertaking. 07:05:44 <05icoson> I just mean cosmetically delete with no other changes 07:05:53 <05icoson> they're useless 07:06:04 <05icoson> well, 90% 07:06:04 <06dolorous_84348> Right. 07:06:19 <05icoson> and you can't know which is the 10% 07:07:14 <06dolorous_84348> I'm also a bit concerned about how now_is_morning() isn't used anywhere anymore, even though the function still exists. 07:08:02 <06dolorous_84348> Maybe it could be used for some time-related messages on game start or something? 07:09:27 <05icoson> // Assume 'morning' starts at 6 AM and ends at 6 PM. :gloweye: 07:10:28 <06dolorous_84348> So it's really now_is_daylight()? Except for extreme cases like the poles where you have no sun 6 months out of the year? 07:10:39 <05icoson> I think one problem with that function independent of that comment is that it'd be somewhat unreliable in a webtiles setting 07:11:01 <06dolorous_84348> Because it'd be using server time instead of local, I guess? 07:11:09 <05icoson> yeah, I think so 07:11:29 <05icoson> which is more or less fine for the day-based things, but probably not anything finer grained 07:11:47 <06dolorous_84348> Indeed. 07:13:11 <06dolorous_84348> So it's another bit of pretty-much-Meteoran-specific stuff then, since it was only used for their day/night titles. 07:14:04 <06dolorous_84348> Which reminds me: the monster versions of player species (mostly used for that one vault) are still using Meteoran. 07:18:54 <06pleasingfungus> regret: my take on this is that ‘werewolf’ is good, evocative, and creates great species words, and we can elaborate on Our Werewolves Are Different in the manual and mut descriptions etc. but also. wereyak 07:20:30 03dolorous02 07* 0.32-a0-808-g8da92d5247: Remove now-unused now_is_morning() function. 10(4 minutes ago, 1 file, 0+ 9-) 13https://github.com/crawl/crawl/commit/8da92d5247e4 07:22:10 <06pleasingfungus> advil: my take on the ‘imported for’ comments is that they’re a hint/nudge. if their associated function is no longer used in the file, try cutting em! those comments are weak, but without them, we have no mechanism that helps us reduce includes. 07:22:36 <05icoson> it's fairly painful to figure out whether they are accurate 07:23:04 <05icoson> c++ in general has no good mechanism that helps reduce includes 🙂 07:23:33 <06dolorous_84348> Other than "delete the include and see what breaks"? 07:24:23 <06pleasingfungus> yeah, to be clear, my suggested strategy is ^ 07:24:47 <06pleasingfungus> which i don’t think is terribly painful? 07:25:04 <05icoson> one at a time, yes, but there's a lot of includes in a lot of files 07:25:20 <05icoson> if we wanted to actually solve this problem something else would be needed, e.g. https://include-what-you-use.org/ 07:27:05 my ide greys out unused includes which would make it rather easy 07:28:01 <05icoson> https://devblogs.microsoft.com/cppblog/include-cleanup-in-visual-studio/ I guess? 07:28:04 <05icoson> similar tool to iwyu 07:35:02 apparently there's 826 of these in total 07:41:04 <09gammafunk> Include what you use looked interesting but I've never tried it. Not even sure what the gains in compile time would realistically be. Devs using eg WSL would certainly appreciate any meaningful speed up though 07:49:07 <05icoson> sadly, our build does not appear even close to working out of the box with iwyu 07:51:40 <05icoson> although I'm not sure if anaconda install it quite right 08:22:57 <02Monkooky> wereyak! I actually think this is unironically the correct pick yaks are the most iconically crawl enemy 08:23:03 <02Monkooky> and it's super goofy 08:34:33 <05icoson> hm some reports of flaky default autopickup behavior that I wonder if is masked on debug builds 08:35:10 <05icoson> at least, I'm pretty sure the intended behavior is that by default, autopickup interrupts travel; people are saying that it sometimes doesn't 08:35:15 <05icoson> (I did not replicate) 08:39:50 <06dolorous_84348> I just noticed one oddity. The description of Ash's powers says that cursed items can't be enchanted, which is normally true because cursed items turn into artefacts, but now that Mountain Dwarves can enchant artefacts, they can ehcnaht cursed items regardless. Should that behavior remain, or should Ash's cursed artefacts be unenchantable even for them? 09:00:23 <06pleasingfungus> think i might rephrase to ‘cannot normally be enchanted’ or something like that 09:01:00 <06pleasingfungus> the md ash thing is a modestly neat emergent effect; would rather not special case to remove it 09:08:49 <08nicolae> wereshop. you are forbidden from going into other shops but every N hundred turns you feel a Change come over you and you get an ability to turn into a shop and buy things from yourself. 09:12:40 <06dolorous_84348> Agreed. 09:13:16 <06pleasingfungus> very serious critique: has to be an xp timer 🙂 09:19:28 <09gammafunk> I support it if there are wereshop monsters you can paralyze in shop form so you can shop from them 09:19:43 03dolorous02 07* 0.32-a0-809-g68839bf7ff: Reword Ash cursed item desc. 10(5 minutes ago, 1 file, 3+ 3-) 13https://github.com/crawl/crawl/commit/68839bf7ff41 09:20:19 <06dolorous_84348> Would Gozag help you do so? 🙂 09:21:14 <09gammafunk> sure, the the wereshop monsters would get distracted by gold, perfect time to go on a shopping spree 09:37:51 03advil02 07* 0.32-a0-810-g7a0cf5b9ff: fix: improve logging message 10(7 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/7a0cf5b9ffc6 09:37:51 03advil02 07* 0.32-a0-811-g06071df075: Revert "fix: move `shed_privileges` later in webtiles setup" 10(6 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/06071df07539 09:37:51 03advil02 07* 0.32-a0-812-gc80f89d3a0: fix: server startup sequencing issues 10(85 seconds ago, 1 file, 10+ 12-) 13https://github.com/crawl/crawl/commit/c80f89d3a0c0 09:41:54 <02Monkooky> so I'm thinking about mutifying talisman powers 09:42:06 03advil02 07* 0.32-a0-813-g41daaf438a: fix: missing `self.` 10(69 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/41daaf438a67 09:43:14 <02Monkooky> with the goal of clearing up some oddities with talisman Aux attacks, and generally making better documentation accessible 09:50:15 <06pleasingfungus> mutifying…? 09:50:50 <06pleasingfungus> why not expand A!? 09:54:36 <13qwqwqwqwqwqwqw> yeah having forms temporarily give actual mutations sounds likely to be much more of a pain codewise than just documenting their properties better on A 09:55:32 <06dolorous_84348> There's the tail-slap available via draconian species or dragon form, which is an odd case. 10:00:14 03advil02 07* 0.32-a0-814-g0968bab981: fix: further webtiles startup sequencing issues 10(2 minutes ago, 1 file, 7+ 5-) 13https://github.com/crawl/crawl/commit/0968bab981e2 10:00:31 <05icoson> programming is hard 10:03:37 <02Monkooky> this was basically what I was thinking of 10:03:53 <06dolorous_84348> I figured, seeing as you have that PR about it 🙂 10:04:09 <02Monkooky> and bite is also very mut-like 10:04:19 <06dolorous_84348> Indeed. 10:05:34 <06dolorous_84348> How much overlap would it have with the lower levels of the fangs mutation, I wonder? 11:11:35 <05icoson> dgl-config CI is finally back in the green; it found genuine bugs in webtiles so I guess that's some payoff for time spent on it long ago 11:43:47 <09gammafunk> Wow we have ci for dgamelaunch-config stuff? 13:15:44 <05icoson> yes, it builds the docker image, starts webtiles server in it, and does some basic checks for life 13:16:58 <05icoson> (where building the docker image involves installing and building two versions of crawl via dgl-config) 13:17:03 <05icoson> it was failing because of some of my recent tweaks to webtiles server that really needed testing in a full install to see the issues 13:40:06 <04dracoomega> #define GRAVITY "by gravitational forces" I find this line of code hilarious for some reason 13:41:04 <04dracoomega> (Also used only once, though seemingly may have been shared with Singularity back when it existed) 13:41:26 <02Monkooky> what's a good decor vault with fruits 13:41:41 <02Monkooky> (or other way to wizmode up some fruit) 13:45:03 <06regret-⸸nde※> &(fruit 13:45:55 <02Monkooky> oops 13:45:56 <02Monkooky> https://cdn.discordapp.com/attachments/747522859361894521/1220473489597923389/image.png?ex=660f1183&is=65fc9c83&hm=8e60289014a83ae613f84c126db2ec7b725f373bc48250d414da12fa9761fb32& 13:46:39 <06regret-⸸nde※> The formatting I used is admittedly kinda weird. 13:48:28 <06regret-⸸nde※> (Basic dialogue code is not particularly flexible in general.) 13:50:22 <02Monkooky> I'm kind of torn between setting up a second fruit+reaction table for death form specifically- with things like 'lychee. If only...' 'mango. Alas...' 13:50:40 <02Monkooky> or not doing that because it's a hyperspecific scenario 13:51:59 <06regret-⸸nde※> It could fit in mummies also, and it could be less lengthy + more suitingly absurd by lumping various food options together. 13:52:36 <06regret-⸸nde※> (Are you working on all forms versus food messages, or just death form's? I was thinking of looking at that a little soon....) 13:53:23 <02Monkooky> Oh I was only looking at death form's, but I guess other forms could have some fun messages too 14:11:11 ForkInBrain (L20 DjAl) ERROR in 'tags.cc' at line 5121: Invalid item: (quantity: 0) gold piece (Shoals:1) 15:29:34 -!- shmup_ is now known as shmup 16:05:18 New branch created: pull/3720 (1 commit) 13https://github.com/crawl/crawl/pull/3720 16:05:19 03Monkooky02 07https://github.com/crawl/crawl/pull/3720 * 0.32-a0-815-g787f84b42d: Make forms adjust hunger 10(2 minutes ago, 2 files, 68+ 3-) 13https://github.com/crawl/crawl/commit/787f84b42d91 16:08:30 03Monkooky02 07https://github.com/crawl/crawl/pull/3720 * 0.32-a0-816-gfe8756b4c3: make messages default to no form 10(42 seconds ago, 1 file, 3+ 3-) 13https://github.com/crawl/crawl/commit/fe8756b4c37d 16:09:35 03Monkooky02 07https://github.com/crawl/crawl/pull/3720 * 0.32-a0-817-g6a02dd87d9: add maw messages 10(16 seconds ago, 1 file, 10+ 0-) 13https://github.com/crawl/crawl/commit/6a02dd87d974 16:09:39 <02Monkooky> I ran out of ideas, so some of the forms don't have special messaging 16:21:18 03Monkooky02 07https://github.com/crawl/crawl/pull/3720 * 0.32-a0-818-g1cb6ef1545: disprove fruit-meat equivalence 10(50 seconds ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/1cb6ef154502 16:24:30 03Monkooky02 07https://github.com/crawl/crawl/pull/3720 * 0.32-a0-819-gd57d675126: fix checkwhite 10(35 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/d57d67512651 16:37:07 Unstable branch on underhound.eu updated to: 0.32-a0-814-g0968bab981 (34) 19:10:32 New branch created: pull/3722 (1 commit) 13https://github.com/crawl/crawl/pull/3722 19:10:32 03RypoFalem02 07https://github.com/crawl/crawl/pull/3722 * 0.32-a0-815-gff0a29dacb: fix: Solve the Mara Hall problem 10(54 minutes ago, 2 files, 8+ 4-) 13https://github.com/crawl/crawl/commit/ff0a29dacb5a 19:18:11 "Mara Hall" lol 19:20:07 03RypoFalem02 07https://github.com/crawl/crawl/pull/3722 * 0.32-a0-816-ged94888263: unbrace (add braces) 10(33 seconds ago, 1 file, 2+ 0-) 13https://github.com/crawl/crawl/commit/ed94888263de 19:20:17 Yeah I didn't come up with that but it was too good not to add 19:20:53 yeh, I guessed its meaning andd then opened the link 23:31:49 Unstable branch on cbro.berotato.org updated to: 0.32-a0-814-g0968bab981 (34) 23:35:29 Unstable branch on crawl.develz.org updated to: 0.32-a0-814-g0968bab981 (34) 23:58:52 Windows builds of master branch on crawl.develz.org updated to: 0.32-a0-814-g0968bab981