00:31:57 Unstable branch on cbro.berotato.org updated to: 0.32-a0-630-g46d191b0ed (34) 00:55:14 Monster database of master branch on crawl.develz.org updated to: 0.32-a0-630-g46d191b0ed 01:10:17 03SentientSupper02 07https://github.com/crawl/crawl/pull/3624 * 0.32-a0-620-g18c88fafff: Improve target selection for tabcast lrd and prism 10(56 seconds ago, 1 file, 4+ 2-) 13https://github.com/crawl/crawl/commit/18c88fafff9d 01:38:49 03SentientSupper02 07https://github.com/crawl/crawl/pull/3624 * 0.32-a0-621-g9ba813a47e: unbrace 10(38 seconds ago, 1 file, 2+ 0-) 13https://github.com/crawl/crawl/commit/9ba813a47ef2 02:02:20 Unstable branch on crawl.kelbi.org updated to: 0.32-a0-630-g46d191b0ed (34) 02:02:20 Unstable branch on crawl.kelbi.org updated to: 0.32-a0-630-g46d191b0ed (34) 02:03:50 Fork (bcrawl) on crawl.kelbi.org updated to: 0.23-a0-5140-g5775ae71e1 02:03:51 Fork (bcrawl) on crawl.kelbi.org updated to: 0.23-a0-5140-g5775ae71e1 04:31:28 Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-5140-g5775ae71e1 05:31:01 Unstable branch on crawl.akrasiac.org updated to: 0.32-a0-630-g46d191b (34) 05:43:42 03SentientSupper02 07https://github.com/crawl/crawl/pull/3624 * 0.32-a0-622-g783c0d818b: Revert "Don't tabcast on missed or blocked attacks" 10(8 minutes ago, 1 file, 14+ 0-) 13https://github.com/crawl/crawl/commit/783c0d818bd0 05:43:42 03SentientSupper02 07https://github.com/crawl/crawl/pull/3624 * 0.32-a0-623-g51772bada7: Refactor tabcast chance and tweak it 10(6 minutes ago, 1 file, 15+ 8-) 13https://github.com/crawl/crawl/commit/51772bada752 08:36:52 03SentientSupper02 07https://github.com/crawl/crawl/pull/3624 * 0.32-a0-624-ga1df83cde2: Use fineffs for tabcasting and refactor 10(66 seconds ago, 6 files, 274+ 241-) 13https://github.com/crawl/crawl/commit/a1df83cde22c 08:43:14 03SentientSupper02 07https://github.com/crawl/crawl/pull/3624 * 0.32-a0-625-g1d3dfdb219: Fix tabcast chances not scaling correctly 10(26 seconds ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/1d3dfdb2196f 09:23:22 03PleasingFungus02 07* 0.32-a0-631-g619fc34308: Fix hand cannon description (Qwer) 10(41 seconds ago, 1 file, 4+ 3-) 13https://github.com/crawl/crawl/commit/619fc34308ad 09:43:25 03SentientSupper02 07https://github.com/crawl/crawl/pull/3624 * 0.32-a0-626-gcaf96df562: Skip violent unravelling prompts when tabcasting 10(54 seconds ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/caf96df5626d 10:11:59 03dolorous02 07* 0.32-a0-632-g41e9ccace9: Fix message spacing. 10(5 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/41e9ccace90b 10:53:10 03dolorous02 07* 0.32-a0-633-g53793998da: No jewellery acquirement if we can't wear any. 10(5 minutes ago, 1 file, 3+ 1-) 13https://github.com/crawl/crawl/commit/53793998da32 14:36:12 03dolorous02 07* 0.32-a0-634-g923888f401: Fix enum spelling. 10(7 minutes ago, 2 files, 2+ 2-) 13https://github.com/crawl/crawl/commit/923888f401cf 14:41:31 What do the curly braces mean in search annotations? I was thinking it might be good to have an annotation "enhancer" for all spell enhancers. 14:47:50 03dolorous02 07* 0.32-a0-635-g817ac4a56f: Destroy unchosen misc items in acquirement. 10(6 minutes ago, 1 file, 11+ 4-) 13https://github.com/crawl/crawl/commit/817ac4a56f2a 15:00:30 New branch created: pull/3630 (1 commit) 13https://github.com/crawl/crawl/pull/3630 15:00:31 03dolorous02 07https://github.com/crawl/crawl/pull/3630 * 0.32-a0-636-g5bdcf8d653: Add talisman acquirement. 10(3 hours ago, 13 files, 143+ 2-) 13https://github.com/crawl/crawl/commit/5bdcf8d653a0 15:08:57 03dolorous02 07https://github.com/crawl/crawl/pull/3630 * 0.32-a0-636-gda303af857: Add talisman acquirement. 10(4 hours ago, 14 files, 146+ 5-) 13https://github.com/crawl/crawl/commit/da303af85731 15:18:43 <09g​ammafunk> @dolorous_84348 couple questions about this. First, I assume this is to support your PR 3630 for talisman acquirement? Otherwise since we don't actually support any kind of acquirement interface for misc items, the commit message is a bit confusing. This code is only relevant for menu-based acquirement. 15:20:23 <09g​ammafunk> Second, that condition for when to destroy the item is not quite correct depending on what kind of misc acquirement you'd want to support. If you want an acquirement menu that would only ever allow a choice of at most 1 misc item, it's fine, but if a menu could present a choice of multiple misc items, the logic would need to check the chosen item more carefully (i.e. look at subtype), similar to the issue with unrands 15:21:51 <06d​olorous_84348> It was an exercise in trying to figure out how to clear tracked items for acquirement purposes. If it's only used via the menu, I can remove it. 15:22:37 <06d​olorous_84348> Although the talisman acquirement code uses similar logic to that, and I wasn't entirely sure I got it right. I had something more complex that might handle the choice of multiple items; I can put it back in for talismans. 15:24:51 <09g​ammafunk> Yeah, that code is specic to menu acquirement. General acquirement that would happen in e.g. trove generation is basically at a lower level and is called by this code. It's basically general code to handle the 4 types of acquirement menus we support (scroll, oka weapon, oka armour, coglin gizmos), but it's not relevant in the general case of making acquirement-level misc items 15:25:55 <09g​ammafunk> that lower level code never has a reason to destroy an item it makes because it's just a one-shot creation of an item, although it might have some destroy logic for items that god hates etc 15:26:56 <09g​ammafunk> for talismans in an acquirement menu, none of those are unrands, hence no special code should be necessary 15:27:41 <09g​ammafunk> this code is not about tracking in the "seen items" sense of whether the player has encountered an item 15:28:03 <09g​ammafunk> it's about the "seen unrands" code that tracks whether an unrand has ever generated, regardless of whether the player has seen it 15:28:33 <09g​ammafunk> so it needs special handling to untrack this; for player seen logic, that can only happen when an item is moved to the grid, so no special cleanup is needed to account for that 15:28:56 <09g​ammafunk> but with unrands, we actually have to reserve the unrand when the items generate to make sure they stay out of circulation 15:29:03 <09g​ammafunk> so that we can never have multiple copies of an unrand 15:29:19 <09g​ammafunk> and then likewise we need to unreserve it should the item not get chosen ultimately 15:31:01 <06d​olorous_84348> Thanks for the info. I knew about unrands' only being generated once, but trying to bias talisman acquirement towards ones the player hasn't seen required a lot of code to track them, and I guess I got it confused with unrand tracking, which is apparently an entirely different thing. 15:31:23 <09g​ammafunk> yep, it's understandable. This stuff is just pretty confusing in general 15:32:12 03dolorous02 07* 0.32-a0-636-g4925a30cd0: Revert "Destroy unchosen misc items in acquirement." 10(6 minutes ago, 1 file, 4+ 11-) 13https://github.com/crawl/crawl/commit/4925a30cd082 15:32:18 <09g​ammafunk> But as far as talisman acquirement...hrm, I guess I need to look at the code in your PR. I assume the necessary tracking is already available for seen items. Do we simply not have seen item tracking for talsimans at all? 15:33:05 <09g​ammafunk> But otherwise I assume it would use the same general code path in the acquirement code and it would be relatively straightforward to check this data just as how is done for other item types/subtypes 15:34:41 <06d​olorous_84348> The tracking code is mostly modeled after the misc item tracking. I tried checking for whether they were ID'ed, but all talismans are apparently ID'ed by default, just like the misc items. And, as far as I can tell, there is no seen item tracking for talismans at all, which is why I had to add it. 15:36:27 03dolorous02 07https://github.com/crawl/crawl/pull/3630 * 0.32-a0-637-g4a130e745a: Add talisman acquirement. 10(4 hours ago, 14 files, 138+ 5-) 13https://github.com/crawl/crawl/commit/4a130e745a86 16:09:14 03dolorous02 07* 0.32-a0-637-gd7a9830edf: Fix possible wizmode floating point exceptions. 10(12 minutes ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/d7a9830edfe2 16:22:14 <06p​leasingfungus> @dolorous_84348 thanks for working on talisman acq! one of the goals of talisman design is that shapeshifter players shouldn't consistently have access to whatever they think the 'best talisman' is. I want them to have access to some talisman of an appropriate 'tier' most of the time - eg get one of maw/blade/serpent by ~lair in most games. But, to avoid games feeling too same-y, I don't want players to have most talismans 16:22:15 most of the time, before the end of a 3-rune game. (In extended, all bets are off.) With that in mind, do you have any thoughts about whether we'll want to lower the rate of normal talisman generation after adding talisman acq, or adjust the weights? 16:22:58 03dolorous02 07* 0.32-a0-638-g83232ee236: Fix crash while generating wizmode acquirement stats. 10(3 minutes ago, 1 file, 4+ 0-) 13https://github.com/crawl/crawl/commit/83232ee23699 16:26:29 <06d​olorous_84348> No problem. I'm not certain which option is better; it would depend on how common acquirement is in the game. (Or if Xom decides to be generous to the player and provide one,but... it's Xom, after all, with all of the other risks involved in worshipping them.) Maybe adjusting the weights would be the better first option, although I'm not certain of exact numbers. 16:27:26 <06p​leasingfungus> I'm not at all concerned about Xom, to be clear. 🙂 16:27:59 <06d​olorous_84348> Okay. 16:30:22 <06d​olorous_84348> I'm more concerned, first of all, in making sure I got the code right, since I had to lift a lot of code from misc item tracking to make talisman tracking work, and I'm not entirely certain of some of it. 16:36:43 Unstable branch on underhound.eu updated to: 0.32-a0-636-g4925a30cd0 (34) 16:41:59 03dolorous02 07https://github.com/crawl/crawl/pull/3630 * 0.32-a0-639-gbbae1d82bc: Add talisman acquirement. 10(5 hours ago, 14 files, 138+ 5-) 13https://github.com/crawl/crawl/commit/bbae1d82bcc1 16:42:53 <06d​olorous_84348> And now it's resynced with master, so that running acquirement stats on talismans will actually work. 16:59:55 03dolorous02 07https://github.com/crawl/crawl/pull/3630 * 0.32-a0-639-gf1e40836bc: Add talisman acquirement. 10(5 hours ago, 14 files, 138+ 5-) 13https://github.com/crawl/crawl/commit/f1e40836bca9 17:01:01 <06d​olorous_84348> And now one major inaccuracy is no longer in the commit message. I'm feeling a little burned out, but it's a start. 17:10:30 03dolorous02 07https://github.com/crawl/crawl/pull/3630 * 0.32-a0-639-gf3d2568c79: Add talisman acquirement. 10(6 hours ago, 14 files, 146+ 5-) 13https://github.com/crawl/crawl/commit/f3d2568c798d 17:11:15 <06d​olorous_84348> And now I think they're finally treated as unseen when they show up in acquirement scrolls, but you choose not to acquire them. But I've done enough on this for the time being. 17:16:40 <06d​olorous_84348> And I know that last bit is likely tied to generation rather than being seen, but the comment about allowing it for misc items has made me paranoid about whether it might actually be needed for the latter somehow, and I'm just missing something in the code. 17:17:17 <06d​olorous_84348> So I'm taking a break to clear my head coding-wise. 17:17:47 <06d​olorous_84348> Some of this code really needs to be better documented. 17:42:48 <06p​leasingfungus> ah, sorry for the frustration! 17:43:17 <06p​leasingfungus> misc item generation tracking is specifically to avoid duplicates 17:43:34 <06p​leasingfungus> please do not add generation tracking for talismans, since we don't want it 17:43:46 <06p​leasingfungus> i know this because i added misc item generation tracking. apologies for poor docs. 🙂 17:53:15 <06d​olorous_84348> Okay. I just figured out it's also unnecessary for talismans, because generation tracking only seems to be used when filtering out certain item subtypes from showing up in a given game. And that's only done for misc items. 17:53:44 <06d​olorous_84348> So ripping out the generation tracking. The new patch will be a lot simpler. 17:59:06 03dolorous02 07https://github.com/crawl/crawl/pull/3630 * 0.32-a0-639-g9ac2dc4f62: Add talisman acquirement. 10(6 hours ago, 9 files, 88+ 5-) 13https://github.com/crawl/crawl/commit/9ac2dc4f6227 17:59:12 <06d​olorous_84348> And done. 18:04:23 03SentientSupper02 07https://github.com/crawl/crawl/pull/3624 * 0.32-a0-627-gc764983ca3: Tweak wait spell handling slightly 10(9 minutes ago, 2 files, 5+ 15-) 13https://github.com/crawl/crawl/commit/c764983ca32c 18:04:23 03SentientSupper02 07https://github.com/crawl/crawl/pull/3624 * 0.32-a0-628-gedce944a1d: Prevent tabcasted spells from modifying time taken 10(42 seconds ago, 2 files, 4+ 3-) 13https://github.com/crawl/crawl/commit/edce944a1d13 18:39:16 03SentientSupper02 07https://github.com/crawl/crawl/pull/3624 * 0.32-a0-629-gd73d014a23: Edit the prototype talisman description 10(20 seconds ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/d73d014a2335 18:41:01 <06p​leasingfungus> great, thanks! 🙂 18:42:50 <06p​leasingfungus> hm, should talisman acq weight depend on your shsh skill? (ie try not to give early talismans at high skill and vice versa?) 18:43:00 <06p​leasingfungus> oh 18:43:04 <06p​leasingfungus> i forgot the most important thing 18:43:16 <06p​leasingfungus> which is that we probably don't want this entire category to show up very often for most characters 18:43:26 <06p​leasingfungus> it seems like the chance of the category appearing should depend on your skills, right? 18:47:22 <06d​olorous_84348> Basing it on shapeshifting skill to a degree sounds good to me. In testing, it seems to show up fairly often, and from what you've said (and, for the record, I agree with) that shouldn't be the case. Although I would like to keep the bias toward talismans you haven't seen for when it does show up as a category; it's more memorable that way. 19:13:31 <09g​ammafunk> hrm, re: giving out early talismans at high skill and vice versa 19:15:17 <09g​ammafunk> I guess weapons as a model isn't really right, because you can't use higher level talismans for an effectively pretty long time if you acquire at lower level? 19:16:40 <09g​ammafunk> unlike weapons, where you at least use the weapon pretty soon, even if there's a chance where it's inferior to your current weapon given your skill level 19:19:35 <09g​ammafunk> also, looking at magical staff acquirement: cpp if (!you.has_mutation(MUT_NO_GRASPING)) { rand_classes.emplace_back(OBJ_WEAPONS); // skip staves if player has already seen all the acquirable staves if (_unided_acq_staves()) rand_classes.emplace_back(OBJ_STAVES); } 19:19:56 <09g​ammafunk> we now have randart staves, so perhaps this exception for excluding staves shouldn't be a thing? 19:35:45 <06p​leasingfungus> dolorous: yes, sounds good 19:36:30 <06p​leasingfungus> gammafunk: sounds reasonable, though i’m not sure how often we gen randart staves via acq? 19:43:42 <06d​olorous_84348> The same question re:staves applies to talismans, since they can also be randarts. 19:47:00 03dolorous02 07* 0.32-a0-639-g2954f76710: No jewellery acquirement if useless, redux. 10(9 minutes ago, 1 file, 2+ 1-) 13https://github.com/crawl/crawl/commit/2954f7671007 19:53:22 03elliptic02 07* 0.32-a0-640-gc5db3fc80f: Make the delay display in @ round down instead of up (pisaster) 10(3 minutes ago, 1 file, 3+ 3-) 13https://github.com/crawl/crawl/commit/c5db3fc80f8a 20:15:34 03SentientSupper02 07https://github.com/crawl/crawl/pull/3624 * 0.32-a0-630-gfd5895b225: Fix a crash with shadow mimic and tabcasting shock 10(64 seconds ago, 1 file, 2+ 1-) 13https://github.com/crawl/crawl/commit/fd5895b22542 20:26:07 03SentientSupper02 07https://github.com/crawl/crawl/pull/3624 * 0.32-a0-631-g08bd65af10: Don't tabcast teleport other on affected monsters 10(54 seconds ago, 1 file, 5+ 1-) 13https://github.com/crawl/crawl/commit/08bd65af10a7 23:07:29 03PleasingFungus02 07* 0.32-a0-641-g1a6acf87a6: Fix: leaky hop targeter (acrobat) 10(62 seconds ago, 3 files, 15+ 9-) 13https://github.com/crawl/crawl/commit/1a6acf87a664 23:11:44 03PleasingFungus02 07* 0.32-a0-642-g40f72ca6f8: Improve valid_blink_destination's type signature 10(42 seconds ago, 3 files, 10+ 12-) 13https://github.com/crawl/crawl/commit/40f72ca6f811 23:13:45 <06p​leasingfungus> @dolorous_84348 if you want a really easy project, turning pointers into references in teleport.h/cc is a freebie 23:13:52 03PleasingFungus02 07* 0.32-a0-643-ga006e7742e: Use more references 10(28 seconds ago, 3 files, 16+ 20-) 13https://github.com/crawl/crawl/commit/a006e7742e30 23:24:31 03SentientSupper02 07https://github.com/crawl/crawl/pull/3624 * 0.32-a0-644-g1c483ecfa6: New tier 2 form: fiend form 10(2 days ago, 41 files, 707+ 132-) 13https://github.com/crawl/crawl/commit/1c483ecfa67e 23:24:31 03SentientSupper02 07https://github.com/crawl/crawl/pull/3624 * 0.32-a0-645-gfa628eb6d6: Unbrace 10(2 days ago, 2 files, 16+ 0-) 13https://github.com/crawl/crawl/commit/fa628eb6d67d 23:24:31 03SentientSupper02 07https://github.com/crawl/crawl/pull/3624 * 0.32-a0-646-g1ce82dd290: Checkwhite 10(2 days ago, 1 file, 3+ 3-) 13https://github.com/crawl/crawl/commit/1ce82dd2902b 23:24:31 03SentientSupper02 07https://github.com/crawl/crawl/pull/3624 * 0.32-a0-647-g4715a79bfb: Unbrace again 10(2 days ago, 1 file, 0+ 2-) 13https://github.com/crawl/crawl/commit/4715a79bfb65 23:24:31 03SentientSupper02 07https://github.com/crawl/crawl/pull/3624 * 0.32-a0-648-g0f65c9bed7: Don't tabcast firewood 10(2 days ago, 1 file, 2+ 1-) 13https://github.com/crawl/crawl/commit/0f65c9bed7c6 23:24:31 03SentientSupper02 07https://github.com/crawl/crawl/pull/3624 * 0.32-a0-649-g8086ec48b0: Relocate tabcast chance description 10(2 days ago, 2 files, 17+ 20-) 13https://github.com/crawl/crawl/commit/8086ec48b04a 23:24:31 03SentientSupper02 07https://github.com/crawl/crawl/pull/3624 * 0.32-a0-650-g5dd404652e: Don't tabcast teleport other if target dies 10(2 days ago, 1 file, 1+ 0-) 13https://github.com/crawl/crawl/commit/5dd404652eda 23:24:31 03SentientSupper02 07https://github.com/crawl/crawl/pull/3624 * 0.32-a0-651-g0a8c1d82f7: Retheme fiend form as conduit form 10(2 days ago, 25 files, 88+ 98-) 13https://github.com/crawl/crawl/commit/0a8c1d82f709 23:24:31 03SentientSupper02 07https://github.com/crawl/crawl/pull/3624 * 0.32-a0-652-gd43bece1ec: checkwhite 10(2 days ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/d43bece1ec2c 23:24:31 03SentientSupper02 07https://github.com/crawl/crawl/pull/3624 * 0.32-a0-653-g9bbfb4b37b: unbrace 10(2 days ago, 1 file, 0+ 2-) 13https://github.com/crawl/crawl/commit/9bbfb4b37b08 23:24:31 ... and 14 more commits 23:27:42 03dolorous02 07https://github.com/crawl/crawl/pull/3630 * 0.32-a0-644-g0cf223e3f5: Add talisman acquirement. 10(12 hours ago, 9 files, 101+ 5-) 13https://github.com/crawl/crawl/commit/0cf223e3f5b0 23:28:42 <06d​olorous_84348> Good to know. 23:31:58 03SentientSupper02 07https://github.com/crawl/crawl/pull/3624 * 0.32-a0-668-g4d0e4287a9: Nikola coinflip chance to drop prototype talisman 10(67 seconds ago, 2 files, 4+ 1-) 13https://github.com/crawl/crawl/commit/4d0e4287a9bc 23:33:09 <06d​olorous_84348> Reworked talisman acquirement to (roughly) take shapeshifting skill into account. To avoid the problem with banning types of talismans the player has already seen when artefact talismans exist, no talisman types are ruled out for acquirement. This means that there is bias toward the unseen types and the types the player has the skill to use, but it's still possible to acquire a talisman with no skill (albeit very rare). 23:35:33 Unstable branch on crawl.develz.org updated to: 0.32-a0-643-ga006e7742e (34) 23:35:37 <06d​olorous_84348> I hope that's acceptable. 23:37:40 <06d​olorous_84348> And maybe it could be rarer, but I'm still working on the numbers. 23:41:52 <06d​olorous_84348> Acquirement of talismans is only fully blocked if you worship Zin. 23:58:52 Windows builds of master branch on crawl.develz.org updated to: 0.32-a0-643-ga006e7742e