00:14:47 03DracoOmega02 07* 0.32-a0-521-gd25475ebd2: Fixup yellow dracs created with Caustic Breath 10(52 seconds ago, 1 file, 5+ 0-) 13https://github.com/crawl/crawl/commit/d25475ebd264 00:17:57 03DracoOmega02 07* 0.32-a0-522-g3863d584d4: Actually put that fix in a place where it'll work 10(42 seconds ago, 1 file, 5+ 5-) 13https://github.com/crawl/crawl/commit/3863d584d45c 00:31:42 03SentientSupper02 07https://github.com/crawl/crawl/pull/3529 * 0.32-a0-519-gfa8ff33016: Start Vp in bloodless, tweak traits 10(3 weeks ago, 3 files, 9+ 21-) 13https://github.com/crawl/crawl/commit/fa8ff33016b1 00:31:42 03SentientSupper02 07https://github.com/crawl/crawl/pull/3529 * 0.32-a0-520-gbacee3c81e: Allow Vp to have regen and inhibited regen mutations 10(3 weeks ago, 1 file, 0+ 7-) 13https://github.com/crawl/crawl/commit/bacee3c81eaf 00:31:42 03SentientSupper02 07https://github.com/crawl/crawl/pull/3529 * 0.32-a0-521-g125f7e0bbe: Disable Vp batform 10(3 weeks ago, 3 files, 4+ 10-) 13https://github.com/crawl/crawl/commit/125f7e0bbe6a 00:31:42 03SentientSupper02 07https://github.com/crawl/crawl/pull/3529 * 0.32-a0-522-geef3fc8db7: Further remove bat form 10(3 weeks ago, 1 file, 1+ 15-) 13https://github.com/crawl/crawl/commit/eef3fc8db799 00:31:42 03SentientSupper02 07https://github.com/crawl/crawl/pull/3529 * 0.32-a0-523-g07001d95e7: Allow Vp to always draw blood with fangs 10(3 weeks ago, 1 file, 0+ 1-) 13https://github.com/crawl/crawl/commit/07001d95e708 00:31:42 03SentientSupper02 07https://github.com/crawl/crawl/pull/3529 * 0.32-a0-524-g9fb019b18e: Make all batformed vampires use UC skill 10(3 weeks ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/9fb019b18eb9 00:31:42 03SentientSupper02 07https://github.com/crawl/crawl/pull/3529 * 0.32-a0-525-g3839c3feae: Allow Ru Vampires to sac regen 10(3 weeks ago, 1 file, 0+ 5-) 13https://github.com/crawl/crawl/commit/3839c3feae3b 00:31:42 03SentientSupper02 07https://github.com/crawl/crawl/pull/3529 * 0.32-a0-526-g661be08003: Remove some redundant vampire bat code 10(3 weeks ago, 2 files, 3+ 6-) 13https://github.com/crawl/crawl/commit/661be0800331 00:31:42 03SentientSupper02 07https://github.com/crawl/crawl/pull/3529 * 0.32-a0-527-g8cdbca7ee5: Allow vampires to vamp from demons 10(3 weeks ago, 8 files, 38+ 16-) 13https://github.com/crawl/crawl/commit/8cdbca7ee514 00:31:42 03SentientSupper02 07https://github.com/crawl/crawl/pull/3529 * 0.32-a0-528-g69c9a72cde: Add blood meter to vampires 10(3 weeks ago, 5 files, 52+ 5-) 13https://github.com/crawl/crawl/commit/69c9a72cde6b 00:31:42 ... and 37 more commits 00:31:55 Unstable branch on cbro.berotato.org updated to: 0.32-a0-520-g344ed53f66 (34) 00:34:59 03SentientSupper02 07https://github.com/crawl/crawl/pull/3529 * 0.32-a0-523-g918cc8d760: Start Vp in bloodless, tweak traits 10(3 weeks ago, 3 files, 9+ 21-) 13https://github.com/crawl/crawl/commit/918cc8d760d1 00:34:59 03SentientSupper02 07https://github.com/crawl/crawl/pull/3529 * 0.32-a0-524-g021f84a1d4: Allow Vp to have regen and inhibited regen mutations 10(3 weeks ago, 1 file, 0+ 7-) 13https://github.com/crawl/crawl/commit/021f84a1d4f9 00:34:59 03SentientSupper02 07https://github.com/crawl/crawl/pull/3529 * 0.32-a0-525-gcc9d6eadb6: Disable Vp batform 10(3 weeks ago, 3 files, 4+ 10-) 13https://github.com/crawl/crawl/commit/cc9d6eadb645 00:34:59 03SentientSupper02 07https://github.com/crawl/crawl/pull/3529 * 0.32-a0-526-gfd2d5a6ee5: Further remove bat form 10(3 weeks ago, 1 file, 1+ 15-) 13https://github.com/crawl/crawl/commit/fd2d5a6ee560 00:34:59 03SentientSupper02 07https://github.com/crawl/crawl/pull/3529 * 0.32-a0-527-g4e7d95574b: Allow Vp to always draw blood with fangs 10(3 weeks ago, 1 file, 0+ 1-) 13https://github.com/crawl/crawl/commit/4e7d95574b98 00:34:59 03SentientSupper02 07https://github.com/crawl/crawl/pull/3529 * 0.32-a0-528-gebdaaf284c: Make all batformed vampires use UC skill 10(3 weeks ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/ebdaaf284c5f 00:34:59 03SentientSupper02 07https://github.com/crawl/crawl/pull/3529 * 0.32-a0-529-g91c70a55e2: Allow Ru Vampires to sac regen 10(3 weeks ago, 1 file, 0+ 5-) 13https://github.com/crawl/crawl/commit/91c70a55e26e 00:34:59 03SentientSupper02 07https://github.com/crawl/crawl/pull/3529 * 0.32-a0-530-g10cc476975: Remove some redundant vampire bat code 10(3 weeks ago, 2 files, 3+ 6-) 13https://github.com/crawl/crawl/commit/10cc476975de 00:34:59 03SentientSupper02 07https://github.com/crawl/crawl/pull/3529 * 0.32-a0-531-g27fe925026: Allow vampires to vamp from demons 10(3 weeks ago, 8 files, 38+ 16-) 13https://github.com/crawl/crawl/commit/27fe925026ef 00:34:59 03SentientSupper02 07https://github.com/crawl/crawl/pull/3529 * 0.32-a0-532-g24a2396fc0: Add blood meter to vampires 10(3 weeks ago, 5 files, 52+ 5-) 13https://github.com/crawl/crawl/commit/24a2396fc0d4 00:34:59 ... and 37 more commits 00:55:17 Monster database of master branch on crawl.develz.org updated to: 0.32-a0-522-g3863d584d4 01:11:27 03SentientSupper02 07https://github.com/crawl/crawl/pull/3529 * 0.32-a0-570-gd6dbb5b11e: Relax blood gain cap a little 10(56 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/d6dbb5b11e2d 02:03:15 Unstable branch on crawl.kelbi.org updated to: 0.32-a0-522-g3863d584d4 (34) 02:03:15 Unstable branch on crawl.kelbi.org updated to: 0.32-a0-522-g3863d584d4 (34) 02:04:51 Fork (bcrawl) on crawl.kelbi.org updated to: 0.23-a0-5140-g5775ae71e1 02:04:51 Fork (bcrawl) on crawl.kelbi.org updated to: 0.23-a0-5140-g5775ae71e1 02:37:46 Fork (bcadrencrawl) on crawl.kelbi.org updated to: 0.03-2319-ge640b25437 02:37:46 Fork (bcadrencrawl) on crawl.kelbi.org updated to: 0.03-2319-ge640b25437 04:32:20 Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-5140-g5775ae71e1 05:09:39 03Zhang Kai02 {GitHub} 07https://github.com/crawl/crawl/pull/3537 * 0.31.0-32-gbff21f4921: Update miscname.txt 10(6 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/bff21f492125 05:31:26 Unstable branch on crawl.akrasiac.org updated to: 0.32-a0-522-g3863d58 (34) 06:38:53 osune (L1 OnHW) ASSERT(valid_cursor_pos(pos.x, pos.y, region)) in 'libutil.cc' at line 407 failed. (invalid cursor position 74,-7 in region 1, should be 1,10 in region 2) (D:1) 07:51:15 03dolorous02 07* 0.32-a0-523-g0f40c14376: Move player barbing into its own function. 10(23 minutes ago, 5 files, 22+ 34-) 13https://github.com/crawl/crawl/commit/0f40c14376fb 07:53:21 03dolorous02 07* 0.32-a0-524-g60b85d4bcb: Actually use turns when initially barbing. 10(47 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/60b85d4bcb86 08:43:27 03dolorous02 07* 0.32-a0-525-g03785628c0: Add message for maximum player barbs. 10(7 minutes ago, 1 file, 12+ 3-) 13https://github.com/crawl/crawl/commit/03785628c05b 08:43:27 03dolorous02 07* 0.32-a0-526-g7be0c910eb: Add sanity checks to barb_player(). 10(2 minutes ago, 1 file, 5+ 0-) 13https://github.com/crawl/crawl/commit/7be0c910ebd6 09:00:33 <04d​racoomega> That max barbs message is weirdly grisly. Just how impaled does one have to be for that to be true, I wonder? ^^; 09:00:45 <04d​racoomega> "Could pass for a porcupine on casual inspection" 09:02:14 03dolorous02 07* 0.32-a0-527-g240abd312f: Readd lost message for extra player barbing. 10(5 minutes ago, 1 file, 1+ 0-) 13https://github.com/crawl/crawl/commit/240abd312f67 09:02:40 <04d​racoomega> (How many effects do we actually notify when you are capped in duration? I feel like not many?) 09:02:50 <04d​racoomega> Not that we're exactly consistent with some messaging 09:18:56 03dolorous02 07* 0.32-a0-528-g2fc6374f7a: Allow specifying barb power in barb_player(). 10(15 minutes ago, 5 files, 8+ 8-) 13https://github.com/crawl/crawl/commit/2fc6374f7a0d 09:18:56 03dolorous02 07* 0.32-a0-529-g953deb8648: Ensure barb_player() can't go over max dur/pow. 10(12 minutes ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/953deb8648d3 09:18:56 03dolorous02 07* 0.32-a0-530-gb6d6f0d0ac: Remove message for maximum player barbs, as it never seems to come up due to player turns. 10(3 minutes ago, 1 file, 0+ 7-) 13https://github.com/crawl/crawl/commit/b6d6f0d0ac58 09:19:46 <06d​olorous_84348> Argh. Finally cleaned up barb handling, and accidentally forgot to move part of the last commit message to the next line. 09:20:04 <06d​olorous_84348> But at least the barb code is now handled in one place instead of three. 10:45:25 <04d​racoomega> I was going to ask if there's any particular reason that amulet of magic regen stores its attuned state as a prop, when regeneration does so via the 'activated' member of the gear it's on. But it looks like the functionality for the latter was only added years later, so I guess that's why 10:46:57 <04d​racoomega> I guess I will probably make it use that also (as I go through and add a regenMP artifact prop for gizmos to use) 10:47:21 <04d​racoomega> Probably make Amulet of Vitality also use that instead of being special-cased 10:48:49 <09g​ammafunk> yeah there's a lot of weird inconsistency between direct use of member variables and props in various places 10:50:42 <09g​ammafunk> I don't think we even really have clear rules as to when it's best to use a prop versus adding a member variable. Props require save compat less often since a missing table key causes no immediate issues, but items are marshalled so any members that represent marshalled item state have to get save compat code if they are new 10:51:10 <09g​ammafunk> But sounds like in your case you already have the class variable ready to use 10:51:45 <04d​racoomega> Yeah, since we already have a member variable for it, it seems reasonable to use it 10:52:37 <04d​racoomega> ...although, that actually might have a weird side-effect, when I think about it 10:53:05 <09g​ammafunk> for transfered games you mean? 10:53:17 <04d​racoomega> Maybe, but that wasn't what I was thinking about 10:54:28 <04d​racoomega> This 'activate' member is for an entire piece of gear, not something on that gear. Which means that if you, say, put on the Amulet of Vitality here with missing hp, but full mp, it still wouldn't regenerate mp faster until your hp filled up first. I wonder if anything else uses this member for anything else? 10:56:22 <04d​racoomega> Doesn't look like anything does 10:56:37 <04d​racoomega> (I mean, this is a narrow edge case, so it probably doesn't matter either way) 11:03:57 <04d​racoomega> Hrm... I guess it additionally means that if you put it on with missing hp and mp, but one finishes before the other, the regen from both of them would immediately kick in =/ 11:04:10 <04d​racoomega> This is unexpectedly fiddly 12:14:20 03PleasingFungus02 07* 0.32-a0-531-gb0876beb0e: Fix double sling overshoots (ragingrage) 10(2 minutes ago, 1 file, 2+ 0-) 13https://github.com/crawl/crawl/commit/b0876beb0e18 12:15:03 Unstable branch on underhound.eu updated to: 0.32-a0-530-gb6d6f0d0ac (34) 12:48:47 03PleasingFungus02 07* 0.32-a0-532-g8156e94834: Fix: blaze trees 🥬 (CarefulOdds) 10(2 minutes ago, 1 file, 1+ 0-) 13https://github.com/crawl/crawl/commit/8156e9483431 13:04:50 -!- ssm__ is now known as ssm_ 14:17:48 <04d​racoomega> Well, only took me like... 3.5 hours to ARTP up mana regen >.>; 14:19:01 <04d​racoomega> Bet I could have implemented an entire unrand quicker than that, but one can now just put this on arbitrary things and it should work properly 14:19:22 <04d​racoomega> (A lot of attunement code refactoring) 14:35:51 <06d​olorous_84348> Progress 🙂 15:04:30 03dolorous02 07* 0.32-a0-533-g0d0dddbf9d: extract_manticore_spikes() -> extract_barbs(). 10(5 minutes ago, 3 files, 4+ 4-) 13https://github.com/crawl/crawl/commit/0d0dddbf9d6a 15:04:30 03dolorous02 07* 0.32-a0-534-ga61f84b8bd: Fix comment typo. 10(3 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/a61f84b8bde0 16:09:11 03dolorous02 07* 0.32-a0-535-g25767b42b7: Properly handle monster halo/umbra from gear. 10(16 minutes ago, 1 file, 14+ 0-) 13https://github.com/crawl/crawl/commit/25767b42b736 16:35:22 Unstable branch on underhound.eu updated to: 0.32-a0-534-ga61f84b8bd (34) 16:46:45 03dolorous02 07* 0.32-a0-536-ge1f55a61bf: Move halo/umbra gear handling to equip/unequip. 10(18 minutes ago, 2 files, 27+ 14-) 13https://github.com/crawl/crawl/commit/e1f55a61bfbe 16:53:34 <06d​olorous_84348> For the record, the monster code to equip/unequip items is horrendously confusing. 17:49:37 <06d​olorous_84348> And it seems there's one more bug with monster halo/umbra, but I'm not certain a fix is worth it right now. 17:50:08 <06d​olorous_84348> If you have a monster with, say an orcbow and "Brilliance", and the orcbow equipped, the umbra from "Brilliance" will show up regardless. 17:50:36 <06d​olorous_84348> But the way monster weapon slots are handled, you have to look at them both for dual-wielders to handle that case properly. 17:51:05 <06d​olorous_84348> Monster weapon swapping, for when a monster swaps from the orcbow to "Brilliance" is the weird case. 17:51:34 <06d​olorous_84348> Because it unequips the orcbow, swaps the weapon and alt-weapon slots, and runs the equip message without the equip function. 17:52:15 <06d​olorous_84348> So, assuming I understand things correctly, short of rewriting the monster weapon swapping function to run the equip function, there's no way to fix this bug. 17:53:07 <06d​olorous_84348> Although it's obscure enough that I had to edit .des files to even get a monster with such an equipment setup. 17:54:47 <06d​olorous_84348> Without running the equip function, disabling a halo/umbra check on the alt-weapon slot except for monsters that dual-wield won't work the way it should, and the halo/umbra won't be drawn at all for non-dual-wielders. 17:55:27 <06d​olorous_84348> Although showing an umbra for a monster with an umbra weapon in their non-equipped weapon slot could be considered an information leak. 17:55:44 <06d​olorous_84348> Or maybe a warning, because I'm tired of screwing around with it for now? 21:12:09 03PleasingFungus02 07* 0.32-a0-537-gfb31f2349e: Fix offhand Wyrmbane again (jagoly, elliptic) 10(2 minutes ago, 1 file, 1+ 2-) 13https://github.com/crawl/crawl/commit/fb31f2349ef6 21:20:31 03regret-index02 07* 0.32-a0-538-g991db66f5c: Fix a few recent vaults, tweak a recent monster's description 10(63 seconds ago, 4 files, 5+ 5-) 13https://github.com/crawl/crawl/commit/991db66f5ceb 21:26:47 03DracoOmega02 07* 0.32-a0-539-g1309dff24d: Fix misleading messages saying that a beam was 'repelled' without RMsl 10(3 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/1309dff24d3a 21:38:18 03regret-index02 07* 0.32-a0-540-g866d13106e: Fix a cast message fallthrough (CarefulOdds) 10(36 seconds ago, 1 file, 1+ 0-) 13https://github.com/crawl/crawl/commit/866d13106eba 23:35:28 Unstable branch on crawl.develz.org updated to: 0.32-a0-540-g866d13106e (34) 23:58:34 Windows builds of master branch on crawl.develz.org updated to: 0.32-a0-540-g866d13106e