00:20:18 <03wheals> i was the one who added the spell effect noise field to spl-data, it was to clean up random magic numbers all over the code but it's still not really a consistent thing 00:21:08 <03wheals> this is concerning though, explosions should use the same formula both for making noise and displaying it on the I screen 00:32:29 Unstable branch on cbro.berotato.org updated to: 0.32-a0-433-g08bcfe7efd (34) 00:55:08 Monster database of master branch on crawl.develz.org updated to: 0.32-a0-433-g08bcfe7efd 01:21:30 03SentientSupper02 07https://github.com/crawl/crawl/pull/3529 * 0.32-a0-462-gc38d1add40: Allow spell/summon kills to heal during bloodcraze 10(80 minutes ago, 6 files, 39+ 18-) 13https://github.com/crawl/crawl/commit/c38d1add40c1 01:21:30 03SentientSupper02 07https://github.com/crawl/crawl/pull/3529 * 0.32-a0-463-g4aa36d09a1: Partially revert bloodcraze nerfs 10(71 minutes ago, 2 files, 4+ 4-) 13https://github.com/crawl/crawl/commit/4aa36d09a1b4 01:21:30 03SentientSupper02 07https://github.com/crawl/crawl/pull/3529 * 0.32-a0-464-g1947bbc1b1: Move blood drain message before kill message 10(69 seconds ago, 1 file, 26+ 26-) 13https://github.com/crawl/crawl/commit/1947bbc1b14d 01:22:43 03SentientSupper02 07https://github.com/crawl/crawl/pull/3529 * 0.32-a0-462-gc38d1add40: Allow spell/summon kills to heal during bloodcraze 10(81 minutes ago, 6 files, 39+ 18-) 13https://github.com/crawl/crawl/commit/c38d1add40c1 01:22:43 03SentientSupper02 07https://github.com/crawl/crawl/pull/3529 * 0.32-a0-463-g4aa36d09a1: Partially revert bloodcraze nerfs 10(72 minutes ago, 2 files, 4+ 4-) 13https://github.com/crawl/crawl/commit/4aa36d09a1b4 01:22:43 03SentientSupper02 07https://github.com/crawl/crawl/pull/3529 * 0.32-a0-464-g1947bbc1b1: Move blood drain message before kill message 10(2 minutes ago, 1 file, 26+ 26-) 13https://github.com/crawl/crawl/commit/1947bbc1b14d 02:06:10 Unstable branch on crawl.kelbi.org updated to: 0.32-a0-433-g08bcfe7efd (34) 02:06:10 Unstable branch on crawl.kelbi.org updated to: 0.32-a0-433-g08bcfe7efd (34) 02:10:53 Fork (bcrawl) on crawl.kelbi.org updated to: 0.23-a0-5140-g5775ae71e1 02:10:54 Fork (bcrawl) on crawl.kelbi.org updated to: 0.23-a0-5140-g5775ae71e1 02:11:44 -!- TAS-2012v is now known as TAS_2012v 02:25:17 03SentientSupper02 07https://github.com/crawl/crawl/pull/3529 * 0.32-a0-465-gc802c53f26: Checkwhite 10(41 seconds ago, 2 files, 2+ 3-) 13https://github.com/crawl/crawl/commit/c802c53f26e2 02:28:52 03SentientSupper02 07https://github.com/crawl/crawl/pull/3529 * 0.32-a0-465-gc802c53f26: Checkwhite 10(4 minutes ago, 2 files, 2+ 3-) 13https://github.com/crawl/crawl/commit/c802c53f26e2 02:53:34 grothendieck (L21 MDFi) ERROR in 'mon-cast.cc' at line 1782: Unknown monster spell 'Vhi's Electric Charge' cast by Olfrun (Depths:1) 03:12:07 -!- TAS-2012v is now known as TAS_2012v 03:54:10 03SentientSupper02 07https://github.com/crawl/crawl/pull/3529 * 0.32-a0-466-gfba394a350: Allow blood drain to work on misses and blocks 10(46 seconds ago, 3 files, 13+ 2-) 13https://github.com/crawl/crawl/commit/fba394a350f4 03:55:23 03SentientSupper02 07https://github.com/crawl/crawl/pull/3529 * 0.32-a0-466-gfba394a350: Allow blood drain to work on misses and blocks 10(2 minutes ago, 3 files, 13+ 2-) 13https://github.com/crawl/crawl/commit/fba394a350f4 04:17:17 03SentientSupper02 07https://github.com/crawl/crawl/pull/3529 * 0.32-a0-467-g9182a803e9: Unbrace 10(58 seconds ago, 1 file, 3+ 13-) 13https://github.com/crawl/crawl/commit/9182a803e965 04:20:49 03SentientSupper02 07https://github.com/crawl/crawl/pull/3529 * 0.32-a0-467-g9182a803e9: Unbrace 10(4 minutes ago, 1 file, 3+ 13-) 13https://github.com/crawl/crawl/commit/9182a803e965 04:33:05 Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-5140-g5775ae71e1 05:30:38 Unstable branch on crawl.akrasiac.org updated to: 0.32-a0-433-g08bcfe7 (34) 08:37:48 03SentientSupper02 07https://github.com/crawl/crawl/pull/3529 * 0.32-a0-468-g4c8bf91ac0: Adjust bloodcraze healing cap 10(2 hours ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/4c8bf91ac018 08:40:25 03SentientSupper02 07https://github.com/crawl/crawl/pull/3529 * 0.32-a0-468-g4c8bf91ac0: Adjust bloodcraze healing cap 10(2 hours ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/4c8bf91ac018 09:10:47 <04dracoomega> C++ bool bolt::can_knockback(int dam) const { switch (origin_spell) { case SPELL_PRIMAL_WAVE: return flavour == BEAM_WATER; ??? 09:11:00 <04dracoomega> Just in case those primal waves that are not water don't have knockback??? 09:14:46 <04dracoomega> I didn't mean to say that it produces incorrect results for what it's used for (at the time I said that, I hadn't realized it was used on the info screen; I was mostly referring to it switching based on spell type instead of actual explosive radius, but that makes sense given it being called for spells that are not currently happening) 09:15:00 <04dracoomega> Though it does look like it's more or less wrong for LRD now 09:15:31 <04dracoomega> (Suggests noise as if they have a radius 2 explosion, with a comment of case SPELL_LRD: // Can reach 3 only with crystal walls, which are rare but that's not been true for a while) 10:01:52 03nicolae02 07[brokenarts] * 0.32-a0-422-gbba8846a1a: Add a shop using the new artprops feature (gammafunk) 10(74 seconds ago, 1 file, 18+ 0-) 13https://github.com/crawl/crawl/commit/bba8846a1aa3 10:02:32 03nicolae02 07[brokenarts] * 0.32-a0-422-gbba8846a1a: Add a shop using the new artprops feature (gammafunk) 10(2 minutes ago, 1 file, 18+ 0-) 13https://github.com/crawl/crawl/commit/bba8846a1aa3 10:04:17 <03wheals> definitely wouldn't be surprised if there are some errors with the noise not actually being right, especially with something like lrd 10:20:20 03nicolae02 07[brokenarts] * 0.32-a0-423-ge3804525d2: Touch up the Clear Minds Boutique just a skosh 10(30 seconds ago, 1 file, 3+ 3-) 13https://github.com/crawl/crawl/commit/e3804525d2a5 10:20:23 03nicolae02 07[brokenarts] * 0.32-a0-423-ge3804525d2: Touch up the Clear Minds Boutique just a skosh 10(28 seconds ago, 1 file, 3+ 3-) 13https://github.com/crawl/crawl/commit/e3804525d2a5 10:51:21 03gammafunk02 07* 0.32-a0-434-g1e417eb1c6: feat: Specifying fixed properties for randarts 10(5 days ago, 7 files, 184+ 46-) 13https://github.com/crawl/crawl/commit/1e417eb1c67c 10:51:21 03gammafunk02 07* 0.32-a0-435-g84f73fd571: feat: Rework wizmode artefact and randart stats 10(2 days ago, 3 files, 108+ 271-) 13https://github.com/crawl/crawl/commit/84f73fd571b0 10:51:29 03gammafunk02 07* 0.32-a0-436-g387adf243f: feat: Simplify formulas for artefact properties (elliptic) 10(27 hours ago, 1 file, 8+ 6-) 13https://github.com/crawl/crawl/commit/387adf243f85 10:51:36 03nicolae02 {gammafunk} 07* 0.32-a0-437-g7902d401d8: Add a shop using the new artprops feature (gammafunk) 10(51 minutes ago, 1 file, 18+ 0-) 13https://github.com/crawl/crawl/commit/7902d401d86a 10:51:47 03gammafunk02 07* 0.32-a0-434-g1e417eb1c6: feat: Specifying fixed properties for randarts 10(5 days ago, 7 files, 184+ 46-) 13https://github.com/crawl/crawl/commit/1e417eb1c67c 10:51:47 03gammafunk02 07* 0.32-a0-435-g84f73fd571: feat: Rework wizmode artefact and randart stats 10(2 days ago, 3 files, 108+ 271-) 13https://github.com/crawl/crawl/commit/84f73fd571b0 10:51:47 03gammafunk02 07* 0.32-a0-436-g387adf243f: feat: Simplify formulas for artefact properties (elliptic) 10(27 hours ago, 1 file, 8+ 6-) 13https://github.com/crawl/crawl/commit/387adf243f85 10:51:47 03nicolae02 {gammafunk} 07* 0.32-a0-437-g7902d401d8: Add a shop using the new artprops feature (gammafunk) 10(51 minutes ago, 1 file, 18+ 0-) 13https://github.com/crawl/crawl/commit/7902d401d86a 10:51:47 03nicolae02 {gammafunk} 07* 0.32-a0-438-g4efcb1c6c7: Touch up the Clear Minds Boutique just a skosh 10(32 minutes ago, 1 file, 3+ 3-) 13https://github.com/crawl/crawl/commit/4efcb1c6c77e 10:51:47 03nicolae02 {gammafunk} 07* 0.32-a0-438-g4efcb1c6c7: Touch up the Clear Minds Boutique just a skosh 10(31 minutes ago, 1 file, 3+ 3-) 13https://github.com/crawl/crawl/commit/4efcb1c6c77e 11:39:34 <13qwqwqwqwqwqwqw> copying here the newest coglin drawback proposal (to replace -move and maybe also rev): no jewellery allowed, but at level 14 you get a power spike, possibly something like the following: take the 6 properties rF+ rC+, rElec rPois, AC+5 or EV+5 (one of them), Slay+4, Rampage Acrobat, Regen MPRegen, and randomly group them into 3 groups of 2, then let the player choose one group 11:41:37 <13qwqwqwqwqwqwqw> (obviously precise details are open to tweaking, e.g. could only forbid rings and have a weaker power spike - I think the simplest version of this is PF's suggestion of no rings but get rF+ rC+ at some XL) 11:57:50 <04dracoomega> For the record, I like this proposal a fair bit - or some tweaked variation on this, at the very least. Combines reasonable degrees of 'guaranteed value', still has obvious downsides attached (even if it ends up as good as a jewelry set, it comes later, and certainly isn't as good as good ones), feels reasonably species-unique. I think my main quibble is that it might be nice for a few options to be a bit less generic, but I don't 11:57:50 think that's a blocker either way. 11:58:12 <04dracoomega> That is the sort of thing that's extremely possible to adjust down the road, also 12:05:58 03PleasingFungus02 07* 0.32-a0-439-ge3e1ee326f: Fix tab with off-hand reaching 10(7 minutes ago, 2 files, 25+ 7-) 13https://github.com/crawl/crawl/commit/e3e1ee326f0f 12:06:09 03PleasingFungus02 07* 0.32-a0-439-ge3e1ee326f: Fix tab with off-hand reaching 10(8 minutes ago, 2 files, 25+ 7-) 13https://github.com/crawl/crawl/commit/e3e1ee326f0f 12:12:39 <02Monkooky> I also think this is cool think this manages to be a downside, but feel like an upside 12:13:16 <02Monkooky> I've got a couple thoughts on precise details but that feels premature rn 12:22:53 03elliptic02 07* 0.32-a0-440-g1f14e3f6c3: Don't place hand cannon clouds on top of the player 10(66 minutes ago, 1 file, 2+ 3-) 13https://github.com/crawl/crawl/commit/1f14e3f6c323 12:22:56 03elliptic02 07* 0.32-a0-440-g1f14e3f6c3: Don't place hand cannon clouds on top of the player 10(66 minutes ago, 1 file, 2+ 3-) 13https://github.com/crawl/crawl/commit/1f14e3f6c323 12:23:29 <13qwqwqwqwqwqwqw> btw why do we have both Chei and NotChei 12:23:47 because |amethyst's old machine got rebooted 12:24:07 I don't think he has access any more to get rid of it 12:32:51 javelincjr (L10 CoMo) ASSERT(defender->alive()) in 'fight.cc' at line 293 failed. (D:8) 13:00:24 <09gammafunk> woah 13:00:27 <09gammafunk> chei returned 13:00:39 <09gammafunk> we could just ban Chei from the channel if we wanted 13:19:30 <09gammafunk> definitely fun trying to write up the details of these fixed props our syntax doc. Shame I don't have a better place to refer people to for the artp names other than "See this variable in artefact.cc". I guess I could just provide the list in the syntax doc and hope people remember to update it somehow... 13:19:41 <09gammafunk> Need the yamlification of artps 13:20:55 <09gammafunk> Telling people about how some artps don't work on some item types is even worse 13:21:15 <09gammafunk> just going to have to tell the reader to try it in wizmode &% or something 13:24:00 <06pleasingfungus> lol 13:24:06 <06pleasingfungus> !crashlog javelincjr 13:24:07 <04Cerebot> 1. javelincjr, XL10 CoMo, T:6358 (milestone): https://cbro.berotato.org/morgue/javelincjr/crash-javelincjr-20240222-193250.txt 13:25:18 <06pleasingfungus> oh wow 13:25:23 <06pleasingfungus> co beogh crash 13:25:26 <06pleasingfungus> scary 13:26:17 <09gammafunk> Do we not have gdb mentioned in the chroot installation for dgamelaunch stuff 13:26:31 <09gammafunk> Feels like no server has it these days 13:31:20 <04dracoomega> Not sure coglin is involved there actually, looking at it. Stack trace says it's during a monster turn. (Not immediately clear what the problem is, though) 13:31:31 <06pleasingfungus> yeah, does look coglin unrelated 13:31:38 <06pleasingfungus> seems like a monster is somehow trying to attack a dead monster 13:31:39 <04dracoomega> Only visible monsters seem to be that apostle and a foxfire 13:32:10 <04dracoomega> (The apostle can be 'dead' in the middle of things, but the log suggests that's already finished, though?) 13:32:46 <04dracoomega> Wondering if it's possible this is some weird foxfire interaction 13:33:40 <04dracoomega> Like, I realize I'm unsure what happens to a still-living foxfire when the apostle that cast it converts 13:33:59 <06pleasingfungus> yeah i am suspicious of the foxfires. 13:34:28 <06pleasingfungus> would be wonderful to know which monster was acting 13:35:26 <04dracoomega> It would, yes 13:35:38 <04dracoomega> On a quick test, foxfires remain hostile but function normally (one hit its own caster) 13:36:01 <04dracoomega> But I wonder if something weird happens if somehow the caster tries to walk into its own foxfire, which is now hostile? 13:36:20 <04dracoomega> Hard to deliberately arrange this to happen 13:37:31 <04dracoomega> I suppose I can try to test that outside of challenge circumstances 13:39:22 <04dracoomega> Okay, not even managing to get a hasted executioner to act before its own foxfires hit it 13:39:33 <02Monkooky> what happens on apostle convert? 13:39:40 <02Monkooky> to like, mon ids and suchlike 13:39:54 <04dracoomega> The apostle's mid doesn't change. It just changes attitude. 13:43:10 <02Monkooky> do C stack traces contain any line num info? 13:44:28 <04dracoomega> I feel like we get stack traces of differing detail depending on the server the crash log comes from 13:44:32 <04dracoomega> Or something 13:44:47 <04dracoomega> At least some of them seem to have more detail than others 13:45:40 <04dracoomega> (Poor Windows version gets no stack trace at all) 13:47:13 <02Monkooky> yeah... 13:47:51 <02Monkooky> ok think there's a real chance this is to do with attacking own foxfire 13:55:30 <04dracoomega> Is there something specific you think you've noticed? 13:58:42 <02Monkooky> the condition for fight_melee to be called in handle_monster_move is if (targ && targ != mons && mons->behaviour != BEH_WITHDRAW && (!(mons_aligned(mons, targ) || targ->type == MONS_FOXFIRE) || mons->has_ench(ENCH_FRENZIED)) && monster_los_is_valid(mons, targ)) { 13:59:59 <02Monkooky> and the targ->type == mons_foxfire seems unusual enough that it makes me leery 14:05:43 <04dracoomega> That just seems to make a foxfire eligable to try to move into, even if it is aligned with you, I think? 14:06:12 03dolorous02 07* 0.32-a0-441-gaf4921d101: Add "Brilliance" quote. 10(15 minutes ago, 1 file, 13+ 0-) 13https://github.com/crawl/crawl/commit/af4921d101aa 14:06:24 03dolorous02 07* 0.32-a0-441-gaf4921d101: Add "Brilliance" quote. 10(15 minutes ago, 1 file, 13+ 0-) 13https://github.com/crawl/crawl/commit/af4921d101aa 14:06:34 <04dracoomega> I've been unable to get anything weird or crashy to happen with various testing of switching alignments between caster and foxfire, thus far 14:06:34 re server crash logs, iirc the only difference is that kelbi had gdb installed 14:07:04 the C backtrace functionality is the same on all of them, and doesn't support looking up line numbers 14:09:50 <02Monkooky> hm- it actually makes it inelegible to try to move into even if aligned 14:12:02 <04dracoomega> Oh, misread bracketing 14:12:36 <04dracoomega> (I mean, maybe this crash just has nothing to do with that foxfire at all ^^; ) 14:14:47 <02Monkooky> !log javelincjr 14:14:49 <04Cerebot> 1769. javelincjr, XL6 MDMo, T:3367: https://cbro.berotato.org/morgue/javelincjr/morgue-javelincjr-20240222-202345.txt 14:19:39 <02Monkooky> hm, guy kept playing without the offhand handaxe 14:19:47 <02Monkooky> !log javelincjr co 14:19:48 <04Cerebot> 6. javelincjr, XL10 CoMo, T:7165: https://cbro.berotato.org/morgue/javelincjr/morgue-javelincjr-20240222-194558.txt 14:24:09 <02Monkooky> hold on, I actually have somethin 14:24:19 <02Monkooky> (maybe) 14:24:37 <02Monkooky> (no) 14:27:06 <02Monkooky> @dracoomega can you point me to the code for post-challenge apostle healing? 14:27:18 <02Monkooky> or general challenge completion 14:45:09 <02Monkooky> Is this an error with getting attacked before the avoided_death fineff triggers? 14:48:17 <02Monkooky> yes, I think it is- the crash is on ASSERT(defender->alive()); which checks if defender's HP is > 0 by my read the disciple dying sets their hp to max, stores that value in a fineff, then sets their hp to a negative value? 14:49:51 <02Monkooky> which if they get attacked somehow while the avoided_death fineff is scheduled but not fired, means they'll register as 'dead' for certain effects 16:36:12 Unstable branch on underhound.eu updated to: 0.32-a0-441-gaf4921d101 (34) 16:47:30 ShinQuickMan (L18 DECj) ASSERT(valid_cursor_pos(pos.x, pos.y, region)) in 'libutil.cc' at line 404 failed. (invalid cursor position -36,1 in region 2, should be 1,1 in region 3) (Orc:2) 16:47:32 ShinQuickMan (L18 DECj) ASSERT(valid_cursor_pos(pos.x, pos.y, region)) in 'libutil.cc' at line 404 failed. (invalid cursor position -36,1 in region 2, should be 1,1 in region 3) (Orc:2) 16:47:35 ShinQuickMan (L18 DECj) ASSERT(valid_cursor_pos(pos.x, pos.y, region)) in 'libutil.cc' at line 404 failed. (invalid cursor position -36,1 in region 2, should be 1,1 in region 3) (Orc:2) 16:47:35 ShinQuickMan (L18 DECj) ASSERT(valid_cursor_pos(pos.x, pos.y, region)) in 'libutil.cc' at line 404 failed. (invalid cursor position -36,1 in region 2, should be 1,1 in region 3) (Orc:2) 16:47:37 ShinQuickMan (L18 DECj) ASSERT(valid_cursor_pos(pos.x, pos.y, region)) in 'libutil.cc' at line 404 failed. (invalid cursor position -36,1 in region 2, should be 1,1 in region 3) (Orc:2) 16:47:39 ShinQuickMan (L18 DECj) ASSERT(valid_cursor_pos(pos.x, pos.y, region)) in 'libutil.cc' at line 404 failed. (invalid cursor position -36,1 in region 2, should be 1,1 in region 3) (Orc:2) 16:47:43 ShinQuickMan (L18 DECj) ASSERT(valid_cursor_pos(pos.x, pos.y, region)) in 'libutil.cc' at line 404 failed. (invalid cursor position -36,1 in region 2, should be 1,1 in region 3) (Orc:2) 16:47:46 ShinQuickMan (L18 DECj) ASSERT(valid_cursor_pos(pos.x, pos.y, region)) in 'libutil.cc' at line 404 failed. (invalid cursor position -36,1 in region 2, should be 1,1 in region 3) (Orc:2) 16:47:50 ShinQuickMan (L18 DECj) ASSERT(valid_cursor_pos(pos.x, pos.y, region)) in 'libutil.cc' at line 404 failed. (invalid cursor position -36,1 in region 2, should be 1,1 in region 3) (Orc:2) 16:47:54 ShinQuickMan (L18 DECj) ASSERT(valid_cursor_pos(pos.x, pos.y, region)) in 'libutil.cc' at line 404 failed. (invalid cursor position -36,1 in region 2, should be 1,1 in region 3) (Orc:2) 16:47:58 ShinQuickMan (L18 DECj) ASSERT(valid_cursor_pos(pos.x, pos.y, region)) in 'libutil.cc' at line 404 failed. (invalid cursor position -36,1 in region 2, should be 1,1 in region 3) (Orc:2) 16:48:01 ShinQuickMan (L18 DECj) ASSERT(valid_cursor_pos(pos.x, pos.y, region)) in 'libutil.cc' at line 404 failed. (invalid cursor position -36,1 in region 2, should be 1,1 in region 3) (Orc:2) 16:48:05 ShinQuickMan (L18 DECj) ASSERT(valid_cursor_pos(pos.x, pos.y, region)) in 'libutil.cc' at line 404 failed. (invalid cursor position -36,1 in region 2, should be 1,1 in region 3) (Orc:2) 16:48:09 ShinQuickMan (L18 DECj) ASSERT(valid_cursor_pos(pos.x, pos.y, region)) in 'libutil.cc' at line 404 failed. (invalid cursor position -36,1 in region 2, should be 1,1 in region 3) (Orc:2) 16:48:12 ShinQuickMan (L18 DECj) ASSERT(valid_cursor_pos(pos.x, pos.y, region)) in 'libutil.cc' at line 404 failed. (invalid cursor position -36,1 in region 2, should be 1,1 in region 3) (Orc:2) 16:48:15 o.O 16:48:16 ShinQuickMan (L18 DECj) ASSERT(valid_cursor_pos(pos.x, pos.y, region)) in 'libutil.cc' at line 404 failed. (invalid cursor position -36,1 in region 2, should be 1,1 in region 3) (Orc:2) 16:48:20 ShinQuickMan (L18 DECj) ASSERT(valid_cursor_pos(pos.x, pos.y, region)) in 'libutil.cc' at line 404 failed. (invalid cursor position -36,1 in region 2, should be 1,1 in region 3) (Orc:2) 16:48:24 ShinQuickMan (L18 DECj) ASSERT(valid_cursor_pos(pos.x, pos.y, region)) in 'libutil.cc' at line 404 failed. (invalid cursor position -36,1 in region 2, should be 1,1 in region 3) (Orc:2) 16:48:27 ShinQuickMan (L18 DECj) ASSERT(valid_cursor_pos(pos.x, pos.y, region)) in 'libutil.cc' at line 404 failed. (invalid cursor position -36,1 in region 2, should be 1,1 in region 3) (Orc:2) 16:48:31 ShinQuickMan (L18 DECj) ASSERT(valid_cursor_pos(pos.x, pos.y, region)) in 'libutil.cc' at line 404 failed. (invalid cursor position -36,1 in region 2, should be 1,1 in region 3) (Orc:2) 16:48:37 ShinQuickMan (L18 DECj) ASSERT(valid_cursor_pos(pos.x, pos.y, region)) in 'libutil.cc' at line 404 failed. (invalid cursor position -36,1 in region 2, should be 1,1 in region 3) (Orc:2) 16:48:39 ShinQuickMan (L18 DECj) ASSERT(valid_cursor_pos(pos.x, pos.y, region)) in 'libutil.cc' at line 404 failed. (invalid cursor position -36,1 in region 2, should be 1,1 in region 3) (Orc:2) 16:48:42 ShinQuickMan (L18 DECj) ASSERT(valid_cursor_pos(pos.x, pos.y, region)) in 'libutil.cc' at line 404 failed. (invalid cursor position -36,1 in region 2, should be 1,1 in region 3) (Orc:2) 16:48:46 ShinQuickMan (L18 DECj) ASSERT(valid_cursor_pos(pos.x, pos.y, region)) in 'libutil.cc' at line 404 failed. (invalid cursor position -36,1 in region 2, should be 1,1 in region 3) (Orc:2) 16:48:49 ShinQuickMan (L18 DECj) ASSERT(valid_cursor_pos(pos.x, pos.y, region)) in 'libutil.cc' at line 404 failed. (invalid cursor position -36,1 in region 2, should be 1,1 in region 3) (Orc:2) 16:48:53 ShinQuickMan (L18 DECj) ASSERT(valid_cursor_pos(pos.x, pos.y, region)) in 'libutil.cc' at line 404 failed. (invalid cursor position -36,1 in region 2, should be 1,1 in region 3) (Orc:2) 16:48:57 ShinQuickMan (L18 DECj) ASSERT(valid_cursor_pos(pos.x, pos.y, region)) in 'libutil.cc' at line 404 failed. (invalid cursor position -36,1 in region 2, should be 1,1 in region 3) (Orc:2) 16:49:01 ShinQuickMan (L18 DECj) ASSERT(valid_cursor_pos(pos.x, pos.y, region)) in 'libutil.cc' at line 404 failed. (invalid cursor position -36,1 in region 2, should be 1,1 in region 3) (Orc:2) 16:49:04 ShinQuickMan (L18 DECj) ASSERT(valid_cursor_pos(pos.x, pos.y, region)) in 'libutil.cc' at line 404 failed. (invalid cursor position -36,1 in region 2, should be 1,1 in region 3) (Orc:2) 16:49:08 ShinQuickMan (L18 DECj) ASSERT(valid_cursor_pos(pos.x, pos.y, region)) in 'libutil.cc' at line 404 failed. (invalid cursor position -36,1 in region 2, should be 1,1 in region 3) (Orc:2) 16:49:12 ShinQuickMan (L18 DECj) ASSERT(valid_cursor_pos(pos.x, pos.y, region)) in 'libutil.cc' at line 404 failed. (invalid cursor position -36,1 in region 2, should be 1,1 in region 3) (Orc:2) 16:49:15 ShinQuickMan (L18 DECj) ASSERT(valid_cursor_pos(pos.x, pos.y, region)) in 'libutil.cc' at line 404 failed. (invalid cursor position -36,1 in region 2, should be 1,1 in region 3) (Orc:2) 16:49:19 ShinQuickMan (L18 DECj) ASSERT(valid_cursor_pos(pos.x, pos.y, region)) in 'libutil.cc' at line 404 failed. (invalid cursor position -36,1 in region 2, should be 1,1 in region 3) (Orc:2) 16:49:23 ShinQuickMan (L18 DECj) ASSERT(valid_cursor_pos(pos.x, pos.y, region)) in 'libutil.cc' at line 404 failed. (invalid cursor position -36,1 in region 2, should be 1,1 in region 3) (Orc:2) 16:49:27 ShinQuickMan (L18 DECj) ASSERT(valid_cursor_pos(pos.x, pos.y, region)) in 'libutil.cc' at line 404 failed. (invalid cursor position -36,1 in region 2, should be 1,1 in region 3) (Orc:2) 16:49:30 ShinQuickMan (L18 DECj) ASSERT(valid_cursor_pos(pos.x, pos.y, region)) in 'libutil.cc' at line 404 failed. (invalid cursor position -36,1 in region 2, should be 1,1 in region 3) (Orc:2) 16:49:34 ShinQuickMan (L18 DECj) ASSERT(valid_cursor_pos(pos.x, pos.y, region)) in 'libutil.cc' at line 404 failed. (invalid cursor position -36,1 in region 2, should be 1,1 in region 3) (Orc:2) 16:49:40 ShinQuickMan (L18 DECj) ASSERT(valid_cursor_pos(pos.x, pos.y, region)) in 'libutil.cc' at line 404 failed. (invalid cursor position -36,1 in region 2, should be 1,1 in region 3) (Orc:2) 16:51:31 <06pleasingfungus> uh 16:53:00 sneaking suspicion whatever's wrong is triggering on game load 16:53:09 !crashlog 16:53:17 27209. ShinQuickMan, XL18 DECj, T:49512 (milestone): https://cbro.berotato.org/morgue/ShinQuickMan/crash-ShinQuickMan-20240222-234819.txt 16:54:14 hm, doesn't look like it 17:58:53 <04dracoomega> I wondered about the interaction with this fineff (note: the way this works isn't my doing or new!) but it's not clear to me how a fineff isn't firing before some other monster gets to act. Maybe worth noting, however, that I think the apostle died to poison. If you note the absence of any other thing seeming to cause its death in the logs. 17:59:03 <04dracoomega> But poison is triggered on the apostles own turn 17:59:15 <02Monkooky> yeah, that was my thought 17:59:16 <04dracoomega> So how could it be attacking itself there? 17:59:36 <04dracoomega> Pretty sure there was no source of it being confused, right? 17:59:42 <02Monkooky> isn't poison in pre_monster_move 17:59:55 <04dracoomega> ...is it? 18:00:09 <02Monkooky> think poison, clouds, and sticky flame are all in pre_monster_move 18:00:59 <04dracoomega> I thought all enchantment updates were from the monster's own timeframe. Is that just their duration going down? 18:01:41 <02Monkooky> // Apply monster enchantments once for every normal-speed // player turn. mons.ench_countdown -= you.time_taken; while (mons.ench_countdown < 0) { mons.ench_countdown += 10; mons.apply_enchantments(); 18:01:42 <04dracoomega> C++ // Apply monster enchantments once for every normal-speed // player turn. mons.ench_countdown -= you.time_taken; while (mons.ench_countdown < 0) { mons.ench_countdown += 10; mons.apply_enchantments(); // If the monster *merely* died just break from the loop // rather than quit altogether, since we have to deal with // ballistomycete spores and ball lightning exploding 18:01:43 at the end of the // function, but do return if the monster's data has been // reset, since then the monster type is invalid. if (mons.type == MONS_NO_MONSTER) return; else if (mons.hit_points < 1) break; } Hmmm 18:01:46 <02Monkooky> yup 18:02:18 <02Monkooky> and all pre-monster move is handled before any monster move 18:02:34 <02Monkooky> Don't actually know when the fineff is fired tho 18:03:30 <04dracoomega> Well, fineffs certainly don't fire between this and a monster trying to move 18:04:02 <04dracoomega> Looks like they will probably fire after the first monster in the round takes its action, whoever that is 18:04:50 <02Monkooky> yeah, so if the apostle dies to an enchant or cloud, then gets hit by the first moster to act, they'll still be 'dead' 18:04:51 <04dracoomega> I am really confused, then. Why are a bunch of monster enchantment durations specifically scaled to the speed of the monster if their triggering rate has nothing to do with the speed of the monster?? 18:05:09 <04dracoomega> I assumed that was why they did that 18:05:16 <02Monkooky> only fires if the mon has action energy 18:05:29 <02Monkooky> void handle_monsters(bool with_noise) { for (monster_iterator mi; mi; ++mi) { _pre_monster_move(**mi); if (!invalid_monster(*mi) && mi->alive() && mi->has_action_energy()) monster_queue.emplace(*mi, mi->speed_increment); } 18:05:35 <02Monkooky> wait 18:05:40 <02Monkooky> no that's a lie 18:05:46 <04dracoomega> Yeah, that's not how _pre_monster_move works 18:05:52 <04dracoomega> That's where they get energy 18:06:09 <04dracoomega> It's called once for everything, after each player action, but before any monster actions 18:06:22 <02Monkooky> yeah I was reading the lines in the wrong order 18:06:49 <02Monkooky> see: 18:07:35 <04dracoomega> I am wondering now if this has multiple other weirdnesses 18:07:43 <04dracoomega> Even if, yes, this seems likely the souce of this immediate crash 18:07:47 <02Monkooky> quite possible 18:07:58 <02Monkooky> I'll say this behaviour is hugely important tho 18:08:19 <02Monkooky> for immolation if nothing else 18:08:44 <04dracoomega> How does this directly work with immolation? 18:09:00 <04dracoomega> That doesn't even tick 18:09:28 <02Monkooky> if I lethally poison an inner flamed monster, I can step away from the monster and it'll explode before catching up 18:10:13 <02Monkooky> if I use OTR versus immolated monsters, I don't need to care about monster action order killing me because the one that's not going to die acted before the one that is 18:10:17 <04dracoomega> I mean, that would be true even if it happened at the start of the monster's own turn 18:10:25 <04dracoomega> Wouldn't it? 18:10:38 <02Monkooky> for the first of those yeah 18:11:06 <04dracoomega> Note: I am not even immediately saying that the placement of this is a bad idea, but I am wondering if some stated assumptions elsewhere think that this isn't how it works 18:11:21 <02Monkooky> right, yeah I get that and strongly suspect you are right 18:11:35 <04dracoomega> For instance, I need to double check if this means that a bunch of things just last less absolute time on fast things without actually doing more 18:13:06 <02Monkooky> just warning off changing the way this works instead of the gross hunt through spl-mon_ench 18:14:48 <04dracoomega> (I mean, the fineff issue can be solved by just firing fineffs after all these things are updated (either after each monster or after all monsters) 18:15:12 <04dracoomega> Can't be certain that this doesn't trip some other unexpected problem, but seems like a thing that should happen anyway 18:15:23 <04dracoomega> After any batch of 'stuff happened' where something can die 18:16:35 <02Monkooky> don't honestly get the purpose of the delayed_death fineff so I'll take your word for it 18:21:29 <02Monkooky> well. polar vortex relies on speed 18:24:36 <02Monkooky> faster mons will do less pvort damage 18:27:08 <04dracoomega> Well, look at mon_enchant::calc_duration where the default durations of many things are scaled based on the monster's speed 18:27:26 <04dracoomega> (Tons and tons of enchantments don't use these default durations, but a bunch do) 18:27:41 <02Monkooky> oh dear 18:29:14 <02Monkooky> Well, there you could argue that's intentional? 18:29:30 <02Monkooky> Like, if I want to slow a thing for 'four actions' it should scale off mon speed 18:30:24 <02Monkooky> mmm. I wonder if I'm somehow just entirely wrong 18:30:59 <04dracoomega> Maybe it makes sense for things that do have their effect based on the monster's frame of reference, but it seems like things like poison/sticky flame do not? 18:32:24 <04dracoomega> Wait, is it multiplying again later by a different factor of monster speed, at the end of that function?? 18:32:50 <02Monkooky> this is baffling 18:35:48 <04dracoomega> Yes, it kind of looks like it does some math and then more or less undoes that math before using the value?? 18:38:10 <04dracoomega> With just a couple enchantments skipping this whole 'divide by factor then multiply by related factor' entirely and just return a duration right there 18:38:22 <04dracoomega> Like inner flame, berserk, or rolling 18:40:16 <04dracoomega> A lot of this hasn't changed in 12 years or something (when it was in another file altogether, so it might be even longer than that), but it's seeming increasingly baffling to me 18:42:01 <02Monkooky> oh, hold on 18:42:17 <02Monkooky> this is only going to apply if you're adding to an existing enchant, I think 18:42:34 <04dracoomega> No, this is definitely used for base duration of new enchants, if nothing is manually specified 18:42:35 <02Monkooky> which doesn't make it correct, but makes it a hell of a lot less visible 18:42:43 <04dracoomega> I'm quite sure of that one 18:43:06 <02Monkooky> oh I see yeah 18:43:19 <04dracoomega> If you just call, say, monster->add_ench(ENCH_SLOW) instead of monster->add_ench(mon_enchant(ENCH_SLOW, 0, dur) whatever 18:43:25 <04dracoomega> Which is done quite frequently 18:43:29 <02Monkooky> added = &(enchantments[ench.ench] = ench); luv u c 18:43:39 <04dracoomega> (Maybe not a strict majority of the time, but still many many places) 18:46:29 <04dracoomega> A bunch of this code seems to date to at least here: 18:46:34 <04dracoomega> %git eae61da171bd07d54eb09775a244257411359221 18:46:34 <04Cerebot> greensnark * 0.3-a0-626-geae61da171: Monster enchantment overhaul: (17 years ago, 13 files, 339+ 198-) https://github.com/crawl/crawl/commit/eae61da171bd 18:47:20 <02Monkooky> ...monstuff.cc 18:47:29 <02Monkooky> mstuff2 18:47:46 <04dracoomega> Apparently before things even had proper durations? 18:47:51 <04dracoomega> C++ case ENCH_PARALYSIS: if (random2(120) < mod_speed( hit_dice + 5, spd )) del_ench(ENCH_PARALYSIS); 18:48:04 <04dracoomega> A lot of just probabilistic chances to wear off 18:48:51 <04dracoomega> (And this commit was trying to give them something like our current duration system, I think) 18:53:48 <04dracoomega> Oh, wait, back then modded_speed actually included a monster HD factor, to reduce duration against high HD targets 18:54:17 <04dracoomega> Even then only used on a handful of things 18:54:28 <04dracoomega> But this means that it wasn't a simple 'divide and then undo division' thing going on 18:55:06 <04dracoomega> For at least Slow, Fear, Paralysis, Confusion, and Charm 18:55:20 <04dracoomega> Waait 18:55:52 <04dracoomega> That's still true??? 18:56:59 <04dracoomega> Now applied to exactly Slow, Corrosion, Fear, Paralysis, Petrified, Confusion, and Charm 18:57:27 <04dracoomega> (And only if their duration is set by this method, which I doubt it always is for any of these things) 18:58:14 <09hellmonk> the monster duration stuff doesn't make any sense to me no matter how many times I look at it 18:58:29 <02Monkooky> do you know if anyone knows how it's supposed to work? 18:58:49 <04dracoomega> I mean, I think it was 'supposed' to do this 18:58:57 everyone's too afraid of it >.> 18:59:13 <04dracoomega> (The fact that modded_speed is affected by HD, but _mod_speed is not is already really poor naming) 18:59:33 <09hellmonk> I think it's "supposed" to be doing what it's doing, but it's very confusing 19:00:08 <09hellmonk> also the fact that fuzzed durations are biased to 90% of the mean or whatever is a bit uhhhhhhhh 19:01:08 <04dracoomega> I've added a bunch of enchantments in my day, but I think I have manually set durations in nearly all cases rather than use any of this? 19:01:12 <09hellmonk> in my opinion it would be better to check hd (if necessary) on the other side of applying the effect instead of handling this through _mod_speed 19:01:49 <09hellmonk> maybe that spreads things out too much 19:02:12 <04dracoomega> No, I agree. If we want that effect (I am going to do math to see how significant it currently is anyway), then this is not the way to do it 19:02:34 <04dracoomega> imo, nobody who's touched related code as much as this should still be as unclear about how some of it is working >.> 19:03:13 <06pleasingfungus> i have always feared and eschewed that system 19:03:15 <09hellmonk> I'm also unclear that monster hd should affect ench durations at all tbh 19:03:21 <06pleasingfungus> and i have never understood it 19:03:53 <06dolorous_84348> Neither have I. 19:04:11 <09hellmonk> you already have a number (usually willpower) to affect monsters resisting it and another number to affect the duration (power) 19:04:26 <04dracoomega> I mean, most effects don't involve this factor at all, anyway 19:04:52 <04dracoomega> And not even all uses of the status effects that do involve this number here always use codepaths that involve it 19:05:24 <09hellmonk> I am pretty sure I went out of my way to not call this in all the fork stuff I did 19:05:35 <09hellmonk> don't remember if I ran anything through it in mainline 19:06:29 <04dracoomega> I almost always didn't use it 19:06:43 <04dracoomega> Even when reusing common effects, you don't really want a 'standard' duration for many of them 19:06:55 <04dracoomega> Since some effects should be much shorter or longer or based on the power of the effect applying them in some way 19:07:09 <04dracoomega> And not just "Whenever a monster is slowed, for any reason, it should be for this long" 19:07:29 <09hellmonk> vaguely thinking that the fuzzing function and the way that summons use a duration of 1-6 could be improved upon as well (this is probably out of scope for what you're doing) 19:07:41 <02Monkooky> feels like this could just be excised without any real loss? 19:07:52 <04dracoomega> I suspect so 19:08:13 <02Monkooky> also, should note that summon shadow creatures uses this nonsense 19:08:20 <04dracoomega> (Running math, corrosion seems to always use this function, and it results in durations against HD 20 things being a little more than 1/2 as long as HD 5 things?) 19:08:49 <09hellmonk> that's fairly substantial, but unclear if it matters 19:08:59 <04dracoomega> Unclear if it needs the extra complexity of caring about this, no 19:09:09 <04dracoomega> But even if it did, it can just be applied elsewhere, imo 19:09:24 <09hellmonk> I wonder if any player outside the dev channel has ever learned this mechanic 19:09:31 <09hellmonk> ig minmay probably knew about it 19:09:34 <04dracoomega> I mean, I have done so much enchantment work, and yet... 19:09:58 <04dracoomega> Going to curiously look up slow applications that use default durations and which don't 19:10:13 <04dracoomega> Corrosion was uniquely narrowly run through one function, really 19:11:57 <09hellmonk> this might matter for paralysis I guess 19:12:06 <02Monkooky> what is ENCH_ABJ 19:12:19 <04dracoomega> A summon's duration 19:12:20 <09hellmonk> it's the "monster is temp summoned" enchant 19:12:25 <04dracoomega> (If it's abjurable) 19:12:26 <02Monkooky> that's kinda what I thought 19:12:34 <02Monkooky> so that's based on speed for shadow creatures 19:12:40 <04dracoomega> ENCH_FAKE_ABJURATION for duration if it isn't. (Or sometimes ENCH_SHORT_LIVED instead) 19:12:53 <04dracoomega> Well, sure, but isn't it remultiplied at the end? 19:13:00 <02Monkooky> wait, no hold on 19:13:08 <04dracoomega> Anyway, I looked through the code to see which uses of slow care about this weird HD factor and which don't 19:13:10 <09hellmonk> the way summons use the code path is not very good but I don't think monster hd or speed actually affects it 19:13:26 <04dracoomega> And I believe the list is: Effects that use default duration: Curare Effects that do not: literally everything else in the game 19:13:37 <09hellmonk> lol 19:14:14 <02Monkooky> mon_enchant me = mon_enchant(ENCH_ABJ, d); me.set_duration(mons, &me); mons->update_ench(me); 19:14:20 <09hellmonk> probably a more "correct" way to handle curare would be default duration + some throwing dependent amount - some hd dependent amount, but on the "applying the status" side 19:14:38 <02Monkooky> think this uses default duration? 19:14:49 <04dracoomega> I mean, yes, if we want HD to matter, we can involve HD in the duration calc there (which many things do, on a case-by-case basis that can make sense) 19:16:15 <04dracoomega> So yes, I think that probably all of this should be ripped out and replaced with something considerably simplified - with many bits of old behavior preserved in just a tiny fraction of cases, if that 19:16:29 <02Monkooky> yeah summon_shadow_creatures absolutely scales the summon's duration based on it's speed and HD 19:16:48 <09hellmonk> the more I think about summons the more I want ench_abj duration to just be a random2avg around some number of aut 19:17:00 <04dracoomega> I mean, summons use 'default' degree-based ENCH_ABJURATION all the time 19:17:55 <04dracoomega> rand2avg has way too low a low end 19:18:09 <09hellmonk> oh I guess you need a base value 19:18:14 <04dracoomega> But it could definitely fuzz around a specified duration 19:18:42 <04dracoomega> There's such a weird ancestral lack of granularity between 4, 5, 6 even if it mostly works out okay in practice? 19:18:49 <09hellmonk> maybe I should chalk it up as workable but very weird 19:19:41 <09hellmonk> I think the big problem with it is if you want a summon duration to scale with power (questionable i guess? do we have any of these left?) you have to do like "degree 2 + x chance in y of adding a degree" instead of just smoothly scaling it 19:19:58 <09hellmonk> maybe this doesn't matter at all but it's kinda weird 19:20:04 <04dracoomega> Are you sure this isn't effectively doing duration like summon spells normally do? (Except that it's choosing the 'base duration' based on the HD of what is summoned, since it varies so much) 19:20:38 <02Monkooky> I have no idea what summon spells normally do, to be honest 19:20:40 <02Monkooky> so, no 19:20:43 <02Monkooky> not sure at all 19:20:57 <02Monkooky> I am pretty sure what I said is true though! 19:21:04 <04dracoomega> The math is weird, but the comment is helpful C++ case ENCH_FAKE_ABJURATION: case ENCH_ABJ: // The duration is: // deg = 1 90 aut // deg = 2 180 aut // deg = 3 270 aut // deg = 4 360 aut // deg = 5 810 aut // deg = 6 1710 aut // with a large fuzz 19:21:19 <04dracoomega> And basically we usually set summon duration to one of these degrees 19:21:39 <09hellmonk> I think the gap between deg 4 and 5 is basically fine since no player summon spell should really have deg above 3 or so anyway, so 5 and 6 can just be for extraneous not-really-summons stuff 19:21:49 <04dracoomega> Looks like shadow creatures uses 4 as the maximum, but high HD things can last less time? 19:23:08 <04dracoomega> (I didn't actually realize this was the case, though it's not entirely unreasonable?) 19:23:13 <02Monkooky> hm, I guess this still seems to me like it scales off speed for no reason? 19:23:42 <09hellmonk> seems easy to test, hook up a monster with 500 speed and make it summon that 19:24:44 <04dracoomega> A lot of calc_duration stuff looks like that, but the math actually ends up being 'divide by factor of speed, then multiply by factor of speed' mostly removing the entire act of doing so in most cases, more or less 19:24:45 <04dracoomega> I think??? 19:25:25 <02Monkooky> where's the multiplication going down? 19:32:37 <04dracoomega> int raw_duration = (cturn * speed_to_duration(mons->speed)); 20:00:56 <04dracoomega> So, someone ran into the old problem of "Reflected player projectile misses player, hits ally behind them, gets penance" (which I think has been a long-time TSO issue) with Beogh, and I am wondering if there's any good reason why the attack conduct check for beams shouldn't use agent() (which accounts for reflection) rather than just checking the thrower type 20:01:04 <04dracoomega> Since this one line change does seem to make the problem go away 20:03:52 <04dracoomega> Okay, the last time this line was changed was 15 years ago, so I am going to assume agent() didn't even work that way back then 20:04:12 <04dracoomega> And that this is probably fine 20:18:03 03DracoOmega02 07* 0.32-a0-442-g4e6cf12409: Fix reflected projectiles causing the player penance if they hit an ally 10(10 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/4e6cf12409d9 20:18:03 03DracoOmega02 07* 0.32-a0-443-g36b1df8bed: Fire final effects after _pre_monster_move 10(2 minutes ago, 1 file, 1+ 0-) 13https://github.com/crawl/crawl/commit/36b1df8bede7 20:18:54 03DracoOmega02 07* 0.32-a0-442-g4e6cf12409: Fix reflected projectiles causing the player penance if they hit an ally 10(11 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/4e6cf12409d9 20:18:54 03DracoOmega02 07* 0.32-a0-443-g36b1df8bed: Fire final effects after _pre_monster_move 10(2 minutes ago, 1 file, 1+ 0-) 13https://github.com/crawl/crawl/commit/36b1df8bede7 20:28:52 04Build failed for 08master @ 36b1df8b 06https://github.com/crawl/crawl/actions/runs/8014262703 20:32:30 03DracoOmega02 07* 0.32-a0-444-g3038c6faba: Fix a possible crash 10(13 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/3038c6faba0d 20:32:41 03DracoOmega02 07* 0.32-a0-444-g3038c6faba: Fix a possible crash 10(10 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/3038c6faba0d 20:39:45 -!- The topic of #crawl-dev is: Crawl Development | https://github.com/crawl/crawl | Logs: http://s-z.org/crawl-dev/, temporarily http://crawl.akrasiac.org/logs/cheibriados/ | People with +v have commit access, devs on bridged discord as well | General Crawl-related chat to #crawl | Long stuff to a pastebin service, please 20:39:46 -!- The topic of #crawl is: Play Dungeon Crawl Stone Soup online now! Type ??online for instructions, ??lg / !lg for play stats | PM Sequell for long queries | http://crawl.develz.org | FooTV game replays: ??footv for instructions | #crawl-dev for dev discussion, #crawl-offtopic for offtopic 20:40:37 03DracoOmega02 07* 0.32-a0-445-g4bed94c0a3: Don't give apostle challenges while the player is under penance 10(5 minutes ago, 1 file, 2+ 1-) 13https://github.com/crawl/crawl/commit/4bed94c0a30c 20:53:55 03dolorous02 07* 0.32-a0-446-ge4683972fd: Fix messaging in Jinxbite sprite message. 10(23 minutes ago, 1 file, 3+ 2-) 13https://github.com/crawl/crawl/commit/e4683972fd32 20:54:15 03dolorous02 07* 0.32-a0-446-ge4683972fd: Fix messaging in Jinxbite sprite message. 10(24 minutes ago, 1 file, 3+ 2-) 13https://github.com/crawl/crawl/commit/e4683972fd32 20:58:23 <06dolorous_84348> Argh. That should have been "fix pronoun", not "fix messaging". 21:07:19 <09gammafunk> my favorite commit message typos are the ones where you carefully check and spellcheck the commit message body 21:07:29 <09gammafunk> but then forget to check the commit message title :yogidaFeels: 21:09:50 <06pleasingfungus> i would never. 21:15:06 03gammafunk02 07* 0.32-a0-447-gf641b5e0b5: doc: Document the artprops item spec tag 10(14 minutes ago, 1 file, 21+ 2-) 13https://github.com/crawl/crawl/commit/f641b5e0b57c 21:15:06 03gammafunk02 07* 0.32-a0-448-g3324ac0059: fix: Exclude unrands from wizmode randart stats 10(3 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/3324ac0059c9 21:15:13 03gammafunk02 07* 0.32-a0-447-gf641b5e0b5: doc: Document the artprops item spec tag 10(14 minutes ago, 1 file, 21+ 2-) 13https://github.com/crawl/crawl/commit/f641b5e0b57c 21:15:13 03gammafunk02 07* 0.32-a0-448-g3324ac0059: fix: Exclude unrands from wizmode randart stats 10(3 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/3324ac0059c9 21:15:13 03Wizard Ike02 07https://github.com/crawl/crawl/pull/3120 * 0.31-a0-1632-g3e80a7f90b: Remove an unnecessary check 10(4 minutes ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/3e80a7f90b20 21:15:14 03Wizard Ike02 07https://github.com/crawl/crawl/pull/3120 * 0.31-a0-1632-g3e80a7f90b: Remove an unnecessary check 10(4 minutes ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/3e80a7f90b20 21:16:43 <09gammafunk> wow 21:16:51 <09gammafunk> 448 commits feels like a lot for 21:16:58 <09gammafunk> %git 0.31.0 21:16:59 <04Cerebot> gammafunk * 0.31.0: feat: New small abomination tiles from Sastreii (5 weeks ago, 4 files, 1+ 0-) https://github.com/crawl/crawl/commit/2b8753d7e0ea 21:17:09 <09gammafunk> only 1.25 months after release 21:17:37 <09gammafunk> what do we often have, 2k commits? or is it 1k 21:18:23 <09gammafunk> %git 0.31-b1~1 21:18:24 <04Cerebot> PleasingFungus * 0.31-a0-1627-g952d896825: Partial changelog update (6 weeks ago, 1 file, 66+ 15-) https://github.com/crawl/crawl/commit/952d89682525 21:18:36 <09gammafunk> %git 0.30-b1~1 21:18:37 <04Cerebot> PleasingFungus * 0.30-a0-1178-g2f52df8dfa: Turn off the zombie incinerator (acrobat) (10 months ago, 1 file, 1+ 1-) https://github.com/crawl/crawl/commit/2f52df8dfa13 21:18:45 <09gammafunk> ok more like 1k, so yeah it's a lot 21:22:16 <06regret-⸸nde※> %git 0.16-b1~1 21:22:17 <04Cerebot> kate- * 0.16-a0-4134-g2ca243f668: Let Ashenzari's skill boost handle unrandart staves (9 years ago, 1 file, 21+ 8-) https://github.com/crawl/crawl/commit/2ca243f6681d 21:22:22 <06regret-⸸nde※> %git 0.15-b1~1 21:22:23 <04Cerebot> PleasingFungus * 0.15-a0-2403-g91670f7809: Remove Gozag from the changelog (10 years ago, 1 file, 14+ 27-) https://github.com/crawl/crawl/commit/91670f780909 21:22:26 <04dracoomega> God, 4134?? 21:23:27 <09gammafunk> was 0.16 another extra long cycle? 21:23:40 <06regret-⸸nde※> a bunch of extended monsters and monster shuffling, a bunch more spells, two gods (including ru, huh), and zotdef removal 21:23:59 <06regret-⸸nde※> (there was some chart to see these by version, right) 21:24:01 <09gammafunk> obviously the release highlight was zotdef removal 21:24:26 <04dracoomega> Still seems disproportionate to that number, but who knows 21:24:58 <04dracoomega> Pondering looking into making use of that new randart property specifying for apostles to try and make their armour have more resists at higher levels 21:25:42 <04dracoomega> A whole lot of randart properties don't actually do things for monsters (besides flavour, here) and lategame apostles would benefit from a bit more consistent access to resists 21:26:44 <09gammafunk> yeah I apparently check them all in a quick bash script: > 0.10: 3351 > 0.11: 3387 > 0.12: 3380 > 0.13: 3227 > 0.14: 3675 > 0.15: 2542 > 0.16: 4189 > 0.17: 2272 > 0.18: 1840 > 0.19: 1946 > 0.20: 1159 > 0.21: 668 > 0.22: 976 > 0.23: 988 > 0.24: 865 > 0.25: 1187 > 0.26: 1284 > 0.27: 1670 > 0.28: 1725 > 0.29: 1083 > 0.30: 1189 21:27:23 <09gammafunk> that probably includes the beta branch commits as well for each release but that's fine 21:28:06 <09gammafunk> we definitely did have larger releases prior to 0.20 21:32:17 03dolorous02 07* 0.32-a0-449-gf785c728e9: Fix typos. 10(10 minutes ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/f785c728e9fe 21:32:18 03dolorous02 07* 0.32-a0-450-g080537f31e: Fix wording. 10(8 minutes ago, 1 file, 3+ 4-) 13https://github.com/crawl/crawl/commit/080537f31e97 21:32:54 <09gammafunk> how do you actually specify gear for them? Does it even use an item spec? Do you set it up directly from the C++ side? 21:33:01 03dolorous02 07* 0.32-a0-449-gf785c728e9: Fix typos. 10(11 minutes ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/f785c728e9fe 21:33:01 03dolorous02 07* 0.32-a0-450-g080537f31e: Fix wording. 10(8 minutes ago, 1 file, 3+ 4-) 13https://github.com/crawl/crawl/commit/080537f31e97 21:33:03 03Wizard Ike02 07https://github.com/crawl/crawl/pull/3120 * 0.32-a0-449-g65e791635e: Fix autopickup not being reactivated when shafting monsters 10(10 months ago, 1 file, 12+ 0-) 13https://github.com/crawl/crawl/commit/65e791635e82 21:33:03