00:31:11 Unstable branch on cbro.berotato.org updated to: 0.32-a0-411-g744942f433 (34) 00:55:21 Monster database of master branch on crawl.develz.org updated to: 0.32-a0-411-g744942f433 02:03:11 Unstable branch on crawl.kelbi.org updated to: 0.32-a0-411-g744942f433 (34) 02:03:11 Unstable branch on crawl.kelbi.org updated to: 0.32-a0-411-g744942f433 (34) 02:09:41 Fork (bcrawl) on crawl.kelbi.org updated to: 0.23-a0-5140-g5775ae71e1 02:09:41 Fork (bcrawl) on crawl.kelbi.org updated to: 0.23-a0-5140-g5775ae71e1 04:31:42 Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-5140-g5775ae71e1 05:29:35 Unstable branch on crawl.akrasiac.org updated to: 0.32-a0-411-g744942f (34) 07:29:12 <13qwqwqwqwqwqwqw> @pleasingfungus using a launcher on coglin does not seem to be applying -Move, also I have heard the feedback that it's annoying that your last action in a fight (killing a monster) applies -Move even though nothing is in sight (and then e.g. you can't manually move to check out the loot without waiting a turn first) but I'm not sure what the best solution is 08:24:42 <13qwqwqwqwqwqwqw> @pleasingfungus another coglin bug relayed from elsewhere - if you for some reason have nothing in your main hand and a chopping weapon in your offhand, it will never chop hydra heads 08:27:10 <06pleasingfungus> nice 08:29:56 <13qwqwqwqwqwqwqw> I think it also isn't applying brands 08:31:16 <13qwqwqwqwqwqwqw> suspect weapon isn't being set right for part of the code path or something 08:34:49 <06pleasingfungus> yeah 08:45:44 03PleasingFungus02 07* 0.32-a0-412-g3d4e8de404: Fix offhand-only attacks 10(42 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/3d4e8de40443 08:47:50 03PleasingFungus02 07* 0.32-a0-413-g2cd877353e: Fix: Coglins get -Move for ranged/throwing 10(2 minutes ago, 1 file, 2+ 0-) 13https://github.com/crawl/crawl/commit/2cd877353e98 08:59:20 03PleasingFungus02 07* 0.32-a0-414-g59b7d7490c: Fix offhand wielding unrands (dolorous) 10(73 seconds ago, 1 file, 4+ 3-) 13https://github.com/crawl/crawl/commit/59b7d7490c6c 09:01:12 <13qwqwqwqwqwqwqw> @pleasingfungus wands seem to give -Move, I assume this isn't intentional? 09:01:26 <13qwqwqwqwqwqwqw> I assume it's because they are implemented as casting a spell 09:03:38 <06pleasingfungus> yeah, bug 09:07:43 03PleasingFungus02 07* 0.32-a0-415-gceb5a3b12e: Fix: wands don't nerf legs (elliptic) 10(62 seconds ago, 1 file, 2+ 1-) 13https://github.com/crawl/crawl/commit/ceb5a3b12e3e 10:01:15 <09gammafunk> maybe_shutdown_legs() 10:09:12 <13qwqwqwqwqwqwqw> https://crawl.xtahua.com/crawl/morgue/Sergey/crash-Sergey-20240220-170603.txt <- great beogh/monster vhi's crash 10:11:12 <04dracoomega> Hilarious, yet concerning 10:14:38 <04dracoomega> Okay, on some simple tests, I cannot immediately reproduce. Monsters seem to be correctly refusing to cast it in situations where it would land them in lava. 10:22:25 <04dracoomega> Wish I could get a better look at the terrain layout where it happened 10:27:23 <04dracoomega> Yeah, I definitely can't get it to happen. 100% cast chance on the spell, and will never use it when doing so would involve lava (but instantly uses it if I rearrange anything so there's a proper landing spot) 10:27:42 <04dracoomega> So there must be some additional weirdness going on (though I can't notice anything from the log) 10:30:18 <09hellmonk> Is it possible to get displaced from the intended landing site by something? 10:31:54 <04dracoomega> Well, basically it first tries to displace whatever is there, and if somehow there is still something there (weird situations like blinking a monster out of the way onto a dispersal trap that blinks something back onto the trap) it keeps trying a bunch of times, and then if the landing spot still isn't clear, due to some essentially-impossible circumstance, it just gives up and leaves the caster where they are 10:32:12 <04dracoomega> I think even weird things like dispersal traps would be in the log, though 10:33:53 <04dracoomega> I have actually discovered a different (if minor) bug though 10:33:54 definitely in the log, that was how I diagnosed that crash to begin with 10:34:06 <04dracoomega> Monsters with rings of flight on still won't Vhi's onto lava 10:34:12 <04dracoomega> Even though it should be entirely safe for them to do so 10:35:00 <04dracoomega> Okay, just flying monsters in general, huh 10:35:22 <04dracoomega> But there goes the theory it might be some weirdness with flight on the apostle's armour or something 10:37:41 <04dracoomega> ...wait 10:38:10 <04dracoomega> Yeah, got it 10:38:28 <04dracoomega> It's checking whether the destination is harmful to the player, not the caster. So if the player can fly, they'll act like they can, too. 10:39:57 <09hellmonk> Oh no 10:40:30 <04dracoomega> Should be straightforward to fix, at least 10:40:45 03elliptic02 07* 0.32-a0-416-gf8fd08910c: Make autoexplore wait for -Move to end 10(3 minutes ago, 1 file, 4+ 1-) 13https://github.com/crawl/crawl/commit/f8fd08910c28 10:52:18 03DracoOmega02 07* 0.32-a0-417-g42da790b35: Fix Vhi's destination checking being player-centric (Sergey) 10(2 minutes ago, 1 file, 3+ 1-) 13https://github.com/crawl/crawl/commit/42da790b35ac 11:12:24 <04dracoomega> mons_spell_is_spell is very silly. And also incorrect. Currently it is used only to determine whether a monster's spell's power is affected by brilliance or not. And excludes a small (and incomplete) list of natural abilities from this. But firstly: it's missing a bunch of things. Secondly: why aren't we just checking the 'natural ability' flag of the spell itself? Monsters with only natural ability spells can't get the 11:12:24 brilliance buff at all, but monsters that have a mix of spells and natural abilities that aren't on this list (say, draconian knights) will actually have their breath weapon get stronger from aura of brilliance 11:12:56 <04dracoomega> As far as the code is concerned, here is the full list of spells that are not spells case SPELL_HOLY_BREATH: case SPELL_SPIT_ACID: case SPELL_ACID_SPLASH: case SPELL_CHAOS_BREATH: case SPELL_COLD_BREATH: case SPELL_CHILLING_BREATH: case SPELL_FIRE_BREATH: case SPELL_SEARING_BREATH: case SPELL_ELECTRICAL_BOLT: case SPELL_FLAMING_CLOUD: >.> 11:14:25 <04dracoomega> (Okay, technically being on this list will also exclude the spell's power from being affected by Idealise or ancestor HD downscaling, but it's not like ancestors could cast any of these anyway. Brilliance is the only affect that applies to anything else) 11:36:43 shadowstone (L1 CoMo) Crash caused by signal #11: Segmentation fault (D (Sprint)) 11:37:23 shadowstone (L1 CoMo) Crash caused by signal #11: Segmentation fault (D (Sprint)) 11:38:28 shadowstone (L1 CoMo) Crash caused by signal #11: Segmentation fault (D (Sprint)) 12:10:58 <06pleasingfungus> sounds like bad, buggy code, all right 🙂 12:11:41 <09gammafunk> ...that would be the first time ever in the history of crawlcode 12:18:03 03dolorous02 07* 0.32-a0-418-g34023cf50c: Add a TODO. 10(3 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/34023cf50cdb 12:24:19 <04dracoomega> This is a remarkable amount of work to fix properly for how little the bug affects anything in practice 12:25:25 <04dracoomega> (Trying to make monster spellpower functions look at spell flags directly, which unifies at least a couple other things in a more tidy way) 12:25:54 <06dolorous_84348> Good luck with it. 12:43:15 <04dracoomega> The more I work on this, the more cases of things not being accurate I find. But at the same time, I'm like... "These are all inaccurate in ways that will almost never, ever matter in practice - and would matter very little even when they did" and wondering if it's worth the effort and chance of messing some formula up ^^; 12:45:40 <04dracoomega> (Like, a bunch of spells that are priestly check HD in ways that will make brilliance affect it, if they had brilliance. But currently they can't even get brilliance - even if somehow a deep elf priest was near them - without also having at least one wizardly spell. So this technically means that if a rare buff affected a monster that had both priest and wizard spells, it would get a power boost to some of the former 12:45:41 (inconsistently)) 12:48:15 <04dracoomega> Though I am also learning now that apparently the kind of magic that demons have is also unaffected by brilliance (well, doesn't qualify them to get the buff anyway), which is not what I would have expected, I think? 12:50:19 <06pleasingfungus> wouldn’t really worry about messing formulas up 12:50:32 <06pleasingfungus> as you said, all of this is wildly marginal 12:53:55 <04dracoomega> Well, it's more like running many of the current formula (which check 'spell HD' directly, instead of calling a refactored mons_spellpower that accounts for spell source) would mean rewriting them to use a different numerical scale and therein lies the risk of making the formula wrong 12:54:26 <04dracoomega> (I mean, mostly this means adding a 'divide by 12' somewhere in it, but y'know 12:58:05 wouldn't be the first time that went wrong 12:58:10 ??uberoctopode 12:58:10 octopode[2/6]: For four days in 2012, octopodes had eight times the normal squeeze damage (96 instead of 12), allowing them to one-shot greater mummies (among others) with ease. Introduced, and then ruined, by |amethyst; rest in peace. 12:58:24 oh, that's 8 not 12, whoops 13:05:28 <06dolorous_84348> At least you're making progress on cleaning stuff up. The TODO I put in is the result of a few fruitless hours on my part attempting to give Pan lords (and/or ghost demons in general) the option to have umbras. mon.place.cc:_place_monster_aux() handles the few monsters with haloes, but none of them are ghost demons, which are initialized after that point, and that function really needs to be split up into several functions 13:05:28 anyway. 13:09:21 <04dracoomega> Am I making progress, I wonder? (I mean, sorta. It's kind of making me think an easier solution is to make brilliance work on more things, though :P) Of course, while I think it actually makes active sense to work on magic in general (ie: should affect anything antimagicable, like demons), and could be renamed to work on priestly stuff too (Aura of Power?), it still probably shouldn't work on natural abilities. Brilliant swamp 13:09:22 worm harpoons... 13:10:27 <06dolorous_84348> Inspiration counts as progress 🙂 13:11:59 <06dolorous_84348> The only other thought I've had is regarding Yred's new flavor. The current short description on the wiki is "god of death and undeath", but the reflavor adds enough that maybe "god of ueath, undeath, and unholiness" would fit? 13:12:20 <06dolorous_84348> Just trying to get a handle on it. 13:12:48 <06dolorous_84348> For example, if you look at monster death knights, what's their motivation for joining? Something like: 13:13:51 <06dolorous_84348> "Yredelemnul! The so-called good gods let the love of my life die, and I have no one else! Have me join her after I die, and I will serve you with my life, and my body will serve you beyond my life!" 13:14:08 <06dolorous_84348> Although that would put Yred more in the role of dark psychopomp. 13:15:24 <07zureal> What are these? There doesn't seem to be anything in the learndb on it 13:15:25 <07zureal> https://cdn.discordapp.com/attachments/747522859361894521/1209594174064820255/image.png?ex=65e77d5c&is=65d5085c&hm=1d5ded731c245aea75919ed7bb93ebd1aa2a5a4636831cbfb8c1036c74598042& 13:17:28 https://github.com/crawl/crawl/commit/aef1140ae215 13:17:52 there have been a number of recent dungeon decor additions 13:17:57 <04dracoomega> Being a "God of unholiness" feels somewhat tautological to me. I mean, I guess Yred specifically likes twisting things associated with the good gods. There's all sorts of reasons why someone other than the player might want to follow such a god, even if only for power over others (a pretty wide-reaching motivator, tbh) (Monster death knights could use some mechanical work as injury mirror has kind of never really worked well on 13:17:57 them, but they're a fair bit down the list) 13:18:45 <07zureal> so just decoration, got it. Thanks 13:18:53 <06dolorous_84348> Point. There's also the question of exactly. why they fell in the first place. 13:18:54 <04dracoomega> Regarding this brilliance stuff, I only stumbled into this while starting work on the draconian breath revamp, and thought I'd just tidy it up along the way and uh... I feel like this is a boulder that momentarily looked like a pebble ^^; 13:19:04 <06dolorous_84348> Been there. 13:19:07 <04dracoomega> I mean, I don't think this is a question we should answer 13:19:18 <04dracoomega> Better to leave it vague and undefined here, imo 13:19:36 <06dolorous_84348> Agreed. 13:19:48 <04dracoomega> "It's been a longer time ago than any mortal still living. People tell stories, but only the gods know for certain." 13:20:07 <06dolorous_84348> 👍 13:58:25 <04dracoomega> Think I should put this aside for later tinkering, because at this rate it's going to be a needless roadblock to getting something actually cool done instead ^^; (Still kind of in favor of making the buff more general, whenever I do this) 14:09:43 they fell because of gravity 14:40:39 bakla (L11 CoWr) Crash caused by signal #11: Segmentation fault (Bailey) 14:41:11 <06pleasingfungus> !crashlog bakla 14:41:12 <04Cerebot> 13. bakla, XL27 GrEE, T:322563 (milestone): https://cbro.berotato.org/morgue/bakla/crash-bakla-20240129-010609.txt 14:41:24 <06pleasingfungus> ERROR in 'mon-act.cc' at line 2419: infinite handle_monsters() loop, mons[0 of 3] is cacodemon 14:41:40 <06pleasingfungus> oh, that's not the right one 14:41:45 <06pleasingfungus> that's the really cool bug we looked into a month ago 14:41:59 <06pleasingfungus> maybe the segfault will show up later. 14:56:15 !crashlog bakla 14:56:16 14. bakla, XL11 CoWr, T:11332 (milestone): https://cbro.berotato.org/morgue/bakla/crash-bakla-20240220-214038.txt 14:56:58 such a helpful backtrace 15:28:33 <09gammafunk> welp, I have improved randart stats to work with an arbitrary item spec, after a bit of unecessary wrangling with item linking issues (since we have to call dgn_place_item() to get proper handling of item specs as opposed to the previous minimal approach 15:28:33 <09gammafunk> https://cdn.discordapp.com/attachments/747522859361894521/1209627679700287598/image.png?ex=65e79c90&is=65d52790&hm=fbd5ff5bd757bf1fade103729e0522a4a41549786d97cef8270eb639597882cc& 15:29:11 <09gammafunk> And I rewrote both of those stat generators to remove all the duplicated lists of item props and other item data that can be gotten from the central accessors we already have 15:30:14 <09gammafunk> I did have to write one or two more for things we didn't actually have but that wasn't much work and things will be cleaner so people don't have to modify this obscure area of wiz mode whenever a new ego/brand/item aspect is added 15:31:12 <09gammafunk> I'm doing this in part because I want to improve the formulas for randart property assignment a bit, since a couple aspects make decisions about how to use e.g. binomial that's not ideal 15:31:38 <09gammafunk> and I want to compare results before and after changes to make sure any changes are minor and not otherwise broken 15:32:39 <09gammafunk> oh and maybe when using fixed properties we need slightly different formulas for numbers of good/bad props but it's looking like that's not the case 15:32:58 <09gammafunk> but much easier to tell that using a tool like this then just eyeballing things after a bunch of manual item creation 15:44:12 <06pleasingfungus> gammafunk: sweet! 15:44:58 <06pleasingfungus> unrelated: thinking about turning a "move" command into "rest and then move" - a new type of 'running' action. this would be interrupted if enemies were visible etc, as with other run types... 15:45:06 <06pleasingfungus> er 15:45:12 <06pleasingfungus> this is if you have -move, ie coglin 16:07:00 <04dracoomega> @pleasingfungus Not the highest priority, but if you change your species in wizmode away from Coglin while wielding two weapons, I'm not sure there's a way to remove the latter one (and then when I tried to switch into a red draconian, it asserted based something that seemed a bit like having a weapon in my shield slot, although turning into a human was fine) 16:07:13 <04dracoomega> So I had to turn back into a coglin to take the weapon off to turn into a draconian without crashing 16:34:24 03dolorous02 07* 0.32-a0-419-gb849e8b480: Add a few missing foul-flame-related bits. 10(3 minutes ago, 1 file, 3+ 2-) 13https://github.com/crawl/crawl/commit/b849e8b480be 16:35:45 Unstable branch on underhound.eu updated to: 0.32-a0-418-g34023cf50c (34) 17:31:29 <06pleasingfungus> yeah, i know it's crashy in wizmode but didn't have energy to deal with it. sorry 🙂 17:31:54 <04dracoomega> That's fine. Like I said, it's not even slightly a priority. Was just passing it along in case you didn't know. 17:33:25 shadowstone (L1 CoCK) Crash caused by signal #11: Segmentation fault (D (Sprint)) 17:47:08 <06pleasingfungus> worrying co segfaults 17:49:06 !crashlog shadowstone sprint 17:49:06 6. shadowstone, XL1 CoCK, T:70 (milestone): https://cbro.berotato.org/morgue/shadowstone/crash-shadowstone-20240221-003324.txt 17:49:47 <06pleasingfungus> starts zigsprint, equips obs axe 17:49:48 <06pleasingfungus> crash?? 17:49:50 <04Cerebot> If you crash and the state does not seem recoverable, go to Advanced Options in dgl and then Backup Save File and let the developers know you've done so when you file a report in mantis: crawl.develz.org/mantis 17:49:51 <04dracoomega> I feel a couple of these seem to have been immediately after putting stuff on 17:50:09 <06pleasingfungus> prev_cmd = CMD_MOVE_LEFT turn_is_over: 1 18:12:29 <06pleasingfungus> ok, i think it has to do with wielding an unrand that has a world_reacts function 18:15:40 <06pleasingfungus> ah 18:20:10 <06pleasingfungus> hm, amazing this ever worked 18:23:57 another thing that's never been said in the history of crawlcode 😛 18:24:15 03PleasingFungus02 07* 0.32-a0-420-gba97123464: Refactor unrand_reacts 10(3 minutes ago, 1 file, 7+ 12-) 13https://github.com/crawl/crawl/commit/ba9712346460 18:24:15 03PleasingFungus02 07* 0.32-a0-421-g65e0ca0ff2: Fix: don't segfault on offhand unrands 10(3 minutes ago, 1 file, 12+ 12-) 13https://github.com/crawl/crawl/commit/65e0ca0ff22b 18:30:32 03dolorous02 07* 0.32-a0-422-g28b100f618: Move foul_flame_monster() into melee_attack. 10(29 minutes ago, 3 files, 23+ 23-) 13https://github.com/crawl/crawl/commit/28b100f61871 18:58:48 03gammafunk02 07[brokenarts] * 0.32-a0-419-gb08f7fadb7: feat: Specifying fixed properties for randarts 10(3 days ago, 7 files, 184+ 46-) 13https://github.com/crawl/crawl/commit/b08f7fadb719 18:58:48 03gammafunk02 07[brokenarts] * 0.32-a0-420-g7ffb0a46ff: feat: Rework wizmode artefact and randart stats 10(11 hours ago, 3 files, 108+ 271-) 13https://github.com/crawl/crawl/commit/7ffb0a46ff86 19:06:36 <02Monkooky> good branch name 20:39:34 -!- The topic of #crawl-dev is: Crawl Development | https://github.com/crawl/crawl | Logs: http://s-z.org/crawl-dev/, temporarily http://crawl.akrasiac.org/logs/cheibriados/ | People with +v have commit access, devs on bridged discord as well | General Crawl-related chat to #crawl | Long stuff to a pastebin service, please 20:39:34 -!- The topic of #crawl is: Play Dungeon Crawl Stone Soup online now! Type ??online for instructions, ??lg / !lg for play stats | PM Sequell for long queries | http://crawl.develz.org | FooTV game replays: ??footv for instructions | #crawl-dev for dev discussion, #crawl-offtopic for offtopic 21:36:03 03SentientSupper02 07https://github.com/crawl/crawl/pull/3529 * 0.32-a0-423-g84ad537d5e: Start Vp in bloodless, tweak traits 10(13 days ago, 3 files, 9+ 21-) 13https://github.com/crawl/crawl/commit/84ad537d5e27 21:36:03 03SentientSupper02 07https://github.com/crawl/crawl/pull/3529 * 0.32-a0-424-g4b25e4eaae: Allow Vp to have regen and inhibited regen mutations 10(13 days ago, 1 file, 0+ 7-) 13https://github.com/crawl/crawl/commit/4b25e4eaaec0 21:36:03 03SentientSupper02 07https://github.com/crawl/crawl/pull/3529 * 0.32-a0-425-gf8ad822648: Disable Vp batform 10(13 days ago, 3 files, 4+ 10-) 13https://github.com/crawl/crawl/commit/f8ad8226482c 21:36:03 03SentientSupper02 07https://github.com/crawl/crawl/pull/3529 * 0.32-a0-426-ga104e4dd16: Further remove bat form 10(13 days ago, 1 file, 1+ 15-) 13https://github.com/crawl/crawl/commit/a104e4dd168c 21:36:03 03SentientSupper02 07https://github.com/crawl/crawl/pull/3529 * 0.32-a0-427-g0ea7d8ce0c: Allow Vp to always draw blood with fangs 10(13 days ago, 1 file, 0+ 1-) 13https://github.com/crawl/crawl/commit/0ea7d8ce0c43 21:36:03 03SentientSupper02 07https://github.com/crawl/crawl/pull/3529 * 0.32-a0-428-g628103e251: Make all batformed vampires use UC skill 10(13 days ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/628103e25132 21:36:03 03SentientSupper02 07https://github.com/crawl/crawl/pull/3529 * 0.32-a0-429-g6c8db7ee1a: Allow Ru Vampires to sac regen 10(13 days ago, 1 file, 0+ 5-) 13https://github.com/crawl/crawl/commit/6c8db7ee1a51 21:36:03 03SentientSupper02 07https://github.com/crawl/crawl/pull/3529 * 0.32-a0-430-gd58fe029e4: Remove some redundant vampire bat code 10(13 days ago, 2 files, 3+ 6-) 13https://github.com/crawl/crawl/commit/d58fe029e467 21:36:03 03SentientSupper02 07https://github.com/crawl/crawl/pull/3529 * 0.32-a0-431-gddde8f5a06: Allow vampires to vamp from demons 10(13 days ago, 8 files, 38+ 16-) 13https://github.com/crawl/crawl/commit/ddde8f5a06c5 21:36:03 03SentientSupper02 07https://github.com/crawl/crawl/pull/3529 * 0.32-a0-432-g413da9f522: Add blood meter to vampires 10(12 days ago, 5 files, 52+ 5-) 13https://github.com/crawl/crawl/commit/413da9f522fd 21:36:03 ... and 28 more commits 21:44:26 03SentientSupper02 07https://github.com/crawl/crawl/pull/3529 * 0.32-a0-460-gcf6455b6d7: Tweak blood descriptions 10(9 minutes ago, 2 files, 10+ 7-) 13https://github.com/crawl/crawl/commit/cf6455b6d79f 22:06:08 <04dracoomega> It wouldn't be a proper evening of Crawl dev if something very simple didn't take unreasonably long to get working ^^; 23:35:29 Unstable branch on crawl.develz.org updated to: 0.32-a0-422-g28b100f618 (34) 23:58:49 Windows builds of master branch on crawl.develz.org updated to: 0.32-a0-422-g28b100f618