00:08:19 03PleasingFungus02 07[two-swords-adventure] * 0.32-a0-96-g9a50951780: Show offhand weapons in @ 10(24 seconds ago, 1 file, 47+ 19-) 13https://github.com/crawl/crawl/commit/9a50951780a2 00:18:40 04Build failed for 08two-swords-adventure @ 9a509517 06https://github.com/crawl/crawl/actions/runs/7780796145 00:32:56 Unstable branch on cbro.berotato.org updated to: 0.32-a0-86-g8db1b9f803 (34) 00:55:10 Monster database of master branch on crawl.develz.org updated to: 0.32-a0-86-g8db1b9f803 02:00:20 Unstable branch on crawl.kelbi.org updated to: 0.32-a0-86-g8db1b9f803 (34) 02:00:20 Unstable branch on crawl.kelbi.org updated to: 0.32-a0-86-g8db1b9f803 (34) 02:03:31 Fork (bcrawl) on crawl.kelbi.org updated to: 0.23-a0-5140-g5775ae71e1 02:03:31 Fork (bcrawl) on crawl.kelbi.org updated to: 0.23-a0-5140-g5775ae71e1 02:05:09 Fork (bcadrencrawl) on crawl.kelbi.org updated to: 0.03-2264-g5e0720bc39 02:05:09 Fork (bcadrencrawl) on crawl.kelbi.org updated to: 0.03-2264-g5e0720bc39 03:44:14 -!- MizMahem_ is now known as MizMahem 04:48:12 <02M​onkooky> actual feature request- a way to get checkwhite to ignore line ending format 04:48:21 <02M​onkooky> like LF vs CRLF 05:31:25 Unstable branch on crawl.akrasiac.org updated to: 0.32-a0-86-g8db1b9f (34) 06:47:17 <02M​onkooky> The 'enter the mirror dimension' commit breaks things 06:48:25 <02M​onkooky> quite possibly bc tile_page.cc line 121 has for (size_t i = m_tiles.size() - 1; i >= 0; --i) 06:49:11 <02M​onkooky> where size_t is unsigned 07:21:25 -!- nabru- is now known as nabru 07:35:01 <09g​ammafunk> Does it break compilation or does it cause a crash? I got a gcc compilation warning on cdi but then a user reported a crash in trunk 07:35:21 <09g​ammafunk> And the build had succeeded 07:35:33 <09g​ammafunk> Haven't looked at CI 07:37:23 <02M​onkooky> I think breaks compilation 07:37:55 <09g​ammafunk> Clang? 07:38:44 <02M​onkooky> There's definitely crashes floating about, but I'm unable to compile and getting messages about uh tilegen.elf 07:39:14 <02M​onkooky> but I just re-set up my environment so real possible I've fucked up somewhere 07:39:27 <09g​ammafunk> Yeah warning I got was tilegen but comp succeeded 07:39:47 <02M​onkooky> tool/tile_page.cc: In member function 'int tile_page::find_ctg_end(const string&) const': tool/tile_page.cc:121:43: warning: comparison of unsigned expression in '>= 0' is always true [-Wtyp e-limits] 121 | for (size_t i = m_tiles.size() - 1; i >= 0; --i) | ~~^~~~ HOSTCXX tool/tile_list_processor.o HOSTCXX tool/main.o HOSTLINK tool/tilegen.elf GEN main.png Error 07:39:48 (dc-main.txt:12): include failed. Error: failed to process '-i' 07:39:48 <09g​ammafunk> Will look in more detail in a bit 07:41:43 <02M​onkooky> I'm gonna just make a PR that I have not even slightly tested 07:48:43 New branch created: pull/3514 (12 commits) 13https://github.com/crawl/crawl/pull/3514 07:48:45 03PleasingFungus02 07https://github.com/crawl/crawl/pull/3514 * 0.32-a0-86-g4b87cf7cb6: New species: steel elves 10(10 weeks ago, 61 files, 1669+ 270-) 13https://github.com/crawl/crawl/commit/4b87cf7cb609 07:48:45 03PleasingFungus02 07https://github.com/crawl/crawl/pull/3514 * 0.32-a0-87-g9ef32e2fa5: Steal blademasters for steel elves 10(4 days ago, 29 files, 78+ 78-) 13https://github.com/crawl/crawl/commit/9ef32e2fa5af 07:48:45 03PleasingFungus02 07https://github.com/crawl/crawl/pull/3514 * 0.32-a0-88-g9905dc4110: Remove ^P (elliptic) 10(13 hours ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/9905dc4110d2 07:48:45 03PleasingFungus02 07https://github.com/crawl/crawl/pull/3514 * 0.32-a0-89-g515ff831ec: Don't give SH from offhand weapons (elliptic) 10(9 hours ago, 1 file, 7+ 4-) 13https://github.com/crawl/crawl/commit/515ff831ec92 07:48:45 03PleasingFungus02 07https://github.com/crawl/crawl/pull/3514 * 0.32-a0-90-gba89c0c79b: Deduplicate some logic 10(9 hours ago, 1 file, 3+ 2-) 13https://github.com/crawl/crawl/commit/ba89c0c79b2b 07:48:45 03PleasingFungus02 07https://github.com/crawl/crawl/pull/3514 * 0.32-a0-91-g76be9f7807: Don't confuse double swords and bardings (elliptic) 10(9 hours ago, 1 file, 5+ 4-) 13https://github.com/crawl/crawl/commit/76be9f7807cc 07:48:45 03PleasingFungus02 07https://github.com/crawl/crawl/pull/3514 * 0.32-a0-92-g7a843b58a2: Disable offhand weapon punching 10(9 hours ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/7a843b58a262 07:48:45 03PleasingFungus02 07https://github.com/crawl/crawl/pull/3514 * 0.32-a0-93-gc58852f5c7: Adjust more shield references 10(9 hours ago, 2 files, 3+ 5-) 13https://github.com/crawl/crawl/commit/c58852f5c7ca 07:48:45 03PleasingFungus02 07https://github.com/crawl/crawl/pull/3514 * 0.32-a0-94-g5b277fbf12: Rework attack delay 10(8 hours ago, 6 files, 20+ 29-) 13https://github.com/crawl/crawl/commit/5b277fbf125b 07:48:45 03PleasingFungus02 07https://github.com/crawl/crawl/pull/3514 * 0.32-a0-95-g5282d9a410: Fix offhand delay 10(8 hours ago, 2 files, 8+ 1-) 13https://github.com/crawl/crawl/commit/5282d9a410ae 07:48:45 ... and 2 more commits 07:49:16 <02M​onkooky> wait 07:49:21 <02M​onkooky> what is it doing 07:49:29 <07z​ureal> nifty 07:49:38 <02M​onkooky> none of these are new 07:58:37 <06d​olorous_84348> I think it's a force-push of the branch steel elves are in. 07:59:24 <09g​ammafunk> yeah cdi trunk is working for me 08:00:21 <09g​ammafunk> https://cdn.discordapp.com/attachments/747522859361894521/1204079067372986368/image.png?ex=65d36d04&is=65c0f804&hm=ecbc075785764daad996f63f30ac07a84bc2474d1b0cc02e381352303a4fdc23& 08:00:27 <09g​ammafunk> sadly webtiles copy is annoying 08:00:32 <09g​ammafunk> %git 08:00:32 <04C​erebot> PleasingFungus * 0.32-a0-86-g8db1b9f803: Rework attack delay (8 hours ago, 6 files, 19+ 25-) https://github.com/crawl/crawl/commit/8db1b9f803e6 08:00:34 <02M​onkooky> oh just coincided with my pr 08:00:38 <09g​ammafunk> so that's current 08:00:45 <09g​ammafunk> hence build is not broken at least under gcc 08:02:10 <06d​olorous_84348> I have gcc (on Ubuntu), and the local tiles build is failing for me. 08:03:43 <09g​ammafunk> aha 08:03:54 <09g​ammafunk> so webtiles is fine, but probably local tiles is not 08:05:09 <09g​ammafunk> @pleasingfungus I'm in the middle of experimental setup stuff, but when you have a chance, can you take a look at the local tiles build? It may be broken (webtiles build seems fine) 08:05:31 <09g​ammafunk> also we seem to be failing CI in general going back a ways for master 08:07:34 <09g​ammafunk> Last to succeed was https://github.com/crawl/crawl/actions/runs/7776319944 and first to fail was https://github.com/crawl/crawl/actions/runs/7776422122, looks like the abyss shift lua test started failing in the abyss upon teleport 08:21:08 03nlavsky02 {gammafunk} 07[neoyred_and_newbeogh] * 0.32-a0-76-g79fac67dab: task: remove the 0.31 trunk tournament reminder 10(18 hours ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/79fac67dab30 08:21:13 <09g​ammafunk> not sure if PF's branch has that commit either (or if it needs it) 08:21:21 <09g​ammafunk> but I got a tournament warning on the branch on cdi from it 08:21:32 <09g​ammafunk> will post announce in a bit after I have a bit more time to test 08:28:57 <03w​heals> wasn't the abyss thing an issue with the statue that got fixed? 08:37:04 <09g​ammafunk> Master is still failing the abyss Lua test, it seems 08:45:17 <13q​wqwqwqwqwqwqw> it's not just the local tiles build, I get the same errors without adding TILES=y 08:45:54 <09g​ammafunk> Weird, webtiles built on cdi 08:47:00 <13q​wqwqwqwqwqwqw> well, not too surprising since local console apparently still does build-rltiles stuff 08:51:18 <05i​coson> yeah, I get a pretty immediate crash when running tests locally on a webtiles build 08:51:48 <05i​coson> segfault in raw_feature_description 08:52:31 03PleasingFungus02 07* 0.32-a0-87-g42a248e5ca: Fix an unsigned comparison (Monkooky) 10(27 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/42a248e5ca1f 08:52:42 <06p​leasingfungus> interesting that the raw_feature_description thing is still around. after i applied my own fix, i couldn't repro it anymore 08:52:46 <06p​leasingfungus> did we re-break it somehow...? 08:53:17 <06p​leasingfungus> elliptic: yeah, specifically local console builds an empty set of tiles, or something like that 08:53:20 <05i​coson> also, it does not crash when running only abyss_shift.lua 08:53:35 <06p​leasingfungus> it was abyss_walk.lua that caused it to trigger for me 08:53:35 <06p​leasingfungus> not shift 08:53:52 <06p​leasingfungus> gotta go to toddler land 08:54:11 <06p​leasingfungus> yes, my branch has and needs the mirror dimension commit 08:54:52 <05i​coson> I'm seeing it on shift, but if one crashes, entirely possible the other could too 08:55:05 <09g​ammafunk> No, trunk reminder revert commit 08:55:17 <09g​ammafunk> Was what I was referring to 08:55:32 <09g​ammafunk> I pushed it to DO's branch 09:01:37 <13q​wqwqwqwqwqwqw> (to be clear, that unsigned comparison fix does not actually fix the local compilation issues, it was just a warning for me previously) 09:02:35 <02M​onkooky> ripp 09:03:49 <05i​coson> I feel like I saw this crash in the backlog actually 09:03:52 <05i​coson> it's on env.level_vaults[mapi] 09:07:54 <03w​heals> that one should have been fixed in 09:08:03 <03w​heals> %git bc18a39 09:08:04 <04C​erebot> PleasingFungus * 0.32-a0-76-gbc18a39e1d: Don't crash in the abyss_walk test (DracoOmega) (17 hours ago, 1 file, 7+ 3-) https://github.com/crawl/crawl/commit/bc18a39e1d33 09:08:14 <05i​coson> yeah that code looks wrong 09:08:15 <05i​coson> lv is a ref, not a ptr 09:08:30 04Build failed for 08master @ 42a248e5 06https://github.com/crawl/crawl/actions/runs/7787166391 09:08:38 <03w​heals> well, it's a ref to a pointer now 09:09:00 <03w​heals> but that shouldn't cause issues here right? 09:09:46 <05i​coson> const auto &lv is a ref to vector> afaict? 09:09:58 <06p​leasingfungus> elliptical: yeah, would’ve been surprised if that change fixed much, sorry 09:10:13 <06p​leasingfungus> isn’t it a ref to the unique ptr? 09:10:20 <05i​coson> oh yeah I see 09:10:20 <06p​leasingfungus> not the containing vec 09:10:45 <06p​leasingfungus> draco posted the commit that caused the crash 09:11:02 <05i​coson> well, it's still crashing, on the attempt to cast to bool 09:11:14 <05i​coson> frame #1: 0x00000001005ab068 crawl`raw_feature_description(where=0x000000016fdfd8c8) at directn.cc:3333:9 3330 mapi = 0; 3331 3332 const auto &lv = env.level_vaults[mapi]; -> 3333 if (lv) 3334 { 3335 const auto &renames = lv->map.feat_renames; 3336 if (const string *rename = map_find(renames, feat)) 09:11:25 <06p​leasingfungus> huh 09:11:31 <06p​leasingfungus> workedforme :p 09:11:58 <03w​heals> maybe it's actually a bounds issue on the vector? 09:12:05 <05i​coson> (lldb) p &lv (const std::unique_ptr > *) $1 = nullptr 09:13:10 <05i​coson> p mapi 09:13:13 <05i​coson> oops 09:13:34 <05i​coson> yeah, env.level_vaults is empty, mapi is 0 09:14:13 <05i​coson> I'm guessing maybe INVALID_MAP_INDEX with an empty level vaults vector 09:16:24 <06p​leasingfungus> huh 09:16:32 <06p​leasingfungus> that’s a different issue from before 09:16:51 <06p​leasingfungus> i did specifically add debug prints to check if the vec was empty 09:19:29 <05i​coson> for what cases is it correct to fall back to 0 if the map index is invalid? 09:20:05 <06p​leasingfungus> draco said the idea was to support feature renames in the layout 09:20:27 <06p​leasingfungus> ie if no vault is specified, fall back to the layout 09:23:10 <06p​leasingfungus> not obvious to me whether vault zero would always be a layout 09:23:18 <05i​coson> yeah, also wondering about that 09:23:31 <05i​coson> even if it is safe it could be safer 09:23:56 <06p​leasingfungus> kind of want to revert this and find another route to the goal 09:23:56 <05i​coson> lol, abyss.cc: env.level_map_ids(p) = INVALID_MAP_INDEX; 09:28:15 <05i​coson> definitely can't find anything that directly guarantees that 09:28:39 <05i​coson> I wouldn't be surprised if 0 is not a layout in all sorts of cases, stuff like portals 09:38:55 <09g​ammafunk> If anyone does push a fix, please also check if fix needs push to two-swords-adventures and neoyred_and_newbeogh branches 09:42:54 <06p​leasingfungus> i’m planning to do a bunch of stuff for two swords in about 1.5h 09:43:39 <04d​racoomega> I didn't fold any of the early master stuff into mine 09:43:56 <04d​racoomega> Specifically because there seemed to be some immediate problem, and none of it also seemed needed 09:44:16 <04d​racoomega> So I am basically just running on 0.31 + my stuff 09:46:56 New branch created: pull/3515 (1 commit) 13https://github.com/crawl/crawl/pull/3515 09:46:56 03SentientSupper02 07https://github.com/crawl/crawl/pull/3515 * 0.32-a0-87-g9439072b97: Change how rCorr interacts with corrosion stacks on the player 10(8 hours ago, 5 files, 9+ 18-) 13https://github.com/crawl/crawl/commit/9439072b97aa 09:47:52 <06p​leasingfungus> …quadrupled? 09:51:58 <02M​onkooky> they made 1 stack of corr -1/-1 09:52:18 <02M​onkooky> so monsters apply 4x corr stacks 09:58:14 <09h​ellmonk> af_supercorr that applies 16 stacks incoming 09:59:08 <02M​onkooky> af_corrblimey 09:59:50 <09g​ammafunk> OK, I will wait a bit to announce so that a rebuild can catch your work. Experimental rebuild every 15 min (although they can take 20 minutes or so on cdi) 10:01:53 <05i​coson> it's very weird to try to figure out whether something is actually a layout 10:02:32 <05i​coson> there's a function is_overwritable_layout that checks only the tag overwritable and not layout, the latter of which is barely used in c++ code that I can find (maybe I'm searching wrong) 10:03:32 <13q​wqwqwqwqwqwqw> re: the rCorr PR, I'm not sure exactly what the motivation for the change is, like it doesn't sound awful to me or anything but it also doesn't obviously sound like a positive change 10:04:43 03DracoOmega02 07[neoyred_and_newbeogh] * 0.32-a0-77-g08d3c7efea: Fix Beogh species name changes not being visible in webtiles 10(16 minutes ago, 4 files, 80+ 78-) 13https://github.com/crawl/crawl/commit/08d3c7efea6f 10:04:43 03DracoOmega02 07[neoyred_and_newbeogh] * 0.32-a0-78-g0f959adbd1: Fix a logic check for Light the Black Torch being inverted 10(17 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/0f959adbd187 10:05:37 <13q​wqwqwqwqwqwqw> (as in, why do we want rCorr to have less variance?) 10:07:37 <06p​leasingfungus> elliptic: judging from the first paragraph and from previous discussions of this idea over the years, the idea is to reduce variance and to make the effect more obvious for eg *corr. latter seems maybe good, former seems neutral 10:07:46 <06p​leasingfungus> yeah agree re variance 10:08:33 <06p​leasingfungus> think the idea is that it’s easier to notice that you have -2 corr (instead of -4) than to notice a resist message somewhere in the log 10:08:59 <02M​onkooky> I think there's a couple things I'd argue for here first, yeah, rCorr would be much more visible this way 10:09:24 <13q​wqwqwqwqwqwqw> I don't feel strongly about this but one argument against the change is that it means you have to rest off corrosion more frequently 10:09:59 <02M​onkooky> I don't know if that's significant? 10:10:14 <02M​onkooky> hmm, maybe in pan 10:10:15 <13q​wqwqwqwqwqwqw> I think I'd also tend to classify the "less variance" part as a minor negative 10:10:32 <13q​wqwqwqwqwqwqw> I mean, I'm just thinking about it being slightly more annoying in regular play 10:10:46 <13q​wqwqwqwqwqwqw> functionally I think it's almost certainly a (minor) buff to the player 10:11:20 <02M​onkooky> Well, I don't think there's enough corr threats which never apply the corr that you'll see much difference 10:11:28 <13q​wqwqwqwqwqwqw> ? 10:11:55 <13q​wqwqwqwqwqwqw> I just mean that if you have rCorr and melee a jelly or something then this change makes it more likely you will end the fight with some amount of corrosion 10:12:03 03DracoOmega02 07[neoyred_and_newbeogh] * 0.32-a0-79-g53f5ff3a06: Remove an overlooked debug message 10(34 seconds ago, 1 file, 0+ 1-) 13https://github.com/crawl/crawl/commit/53f5ff3a060c 10:12:45 <02M​onkooky> yeah, but there's very few corr threats outside pan and slime 10:12:59 <13q​wqwqwqwqwqwqw> yeah, that's why it's not a big deal one way or the other for me 😛 10:14:46 <13q​wqwqwqwqwqwqw> it's probably reasonable to focus on how it would feel in slime, and maybe it does feel better there (certainly I think it's a minor player buff in slime, makes it much less likely you'll get unlucky with a few rolls and jump up to -16 corr quickly) 10:15:41 <13q​wqwqwqwqwqwqw> I don't have a strong feeling as to whether it's good or not to make rCorr more noticeable/impactful in slime, probably okay 10:15:49 <02M​onkooky> of those threats, I think acid dragons are the only ones you'll semi-regularly see a difference in get 1+corr stack versus not based on this change- jellies are too early to realistically have rCorr, and if shrikes are getting a chance hurt you they will probably win the coin toss at least once per fight 10:16:26 <13q​wqwqwqwqwqwqw> really I'm talking myself into this idea purely by thinking about slime and being okay with rCorr being better there (since it really should be good there) 10:18:20 <13q​wqwqwqwqwqwqw> there are also *Corr randarts and demon summoners getting rust devils, and a few monsters with corrosive bolt 10:20:12 <13q​wqwqwqwqwqwqw> oh, also oklobs are actually sort of annoying with this change, hm 10:21:42 <13q​wqwqwqwqwqwqw> maybe not that much more annoying than they already are, but if you like resetting fights against oklobs when they corrode you in the first 2-3 turns then this change means more resetting with rCorr 10:26:13 entropy weavers 10:28:55 <06p​leasingfungus> fr: enthalpy weavers 10:29:30 <06p​leasingfungus> maybe that’s just hellephants. 10:30:55 <09g​ammafunk> need hellweavers that give super corrosion 10:47:02 <05i​coson> I don't know anything about these branches, sorry, but if they have 2c8f65ca5f32ac ("Make and use a hidden metal statue feature") and bc18a39e1d331e ("Don't crash in the abyss_walk test (DracoOmega)" they need the fix, if they have only 2c8f65ca5f32ac they need both other commits 10:47:10 <09g​ammafunk> @pleasingfungus ok, you're all set up. Can you post the announce in the discord when you've pushed any necessary stuff and cdi has rebuilt? You can log in and check ?v to check version. 10:47:35 03advil02 07* 0.32-a0-88-ga335ffa919: refactor: generalize some feature description code 10(37 minutes ago, 4 files, 20+ 4-) 13https://github.com/crawl/crawl/commit/a335ffa919b0 10:51:07 <09g​ammafunk> ok, I'm out of time to check/push commits since I just barely finished setting things up. Thanks for the info, hopefully another responsible dev has time to act on that if needed (so we don't get lots of experimental crashes) at some point soonish 10:54:45 <05i​coson> also, cao scoring should now be up to date with 0.31 10:56:02 <06p​leasingfungus> thanks! will do 10:59:45 <09g​ammafunk> Thanks! 11:02:29 hi 11:03:43 hi, does anybody tried or created an project for translating docs? 11:05:06 04Build failed for 08master @ a335ffa9 06https://github.com/crawl/crawl/actions/runs/7788652080 11:11:38 <05i​coson> there's been some translation attempts of various sorts but they have often run up against the scope of the problem, especially in terms of maintenance 11:11:47 <05i​coson> to some degree there are translations but they just go very stale 11:12:04 <05i​coson> except maybe for chinese, where we have one very dedicated contributor 11:12:29 mohammad5305: by docs you mean crawl wiki? 11:12:32 <05i​coson> not seeing this locally: Error: failed to process '-c' make[1]: *** [Makefile:109: tiledef-floor.h] Error 254 11:13:32 mkf: yes 11:13:44 <06d​olorous_84348> I get that locally when building console (Ubuntu, with gcc). With local tiles, I get "Error: failed to process -i". 11:14:07 mohammad5305: that's a uphill battle. english wiki itself isn't always in sync with code. 11:14:32 <05i​coson> ah crawl wiki would be another case, that's not maintained by the devteam at all 11:14:41 <05i​coson> I was taking docs to mean the manual, maybe in-game stuff 11:17:58 <05i​coson> this is macos, so maybe some dep issue? 11:18:19 <05i​coson> looking at CI it shows up at 8db1b9f, but there's other failures in previous commits that could be masking it 11:19:07 I've been getting the -c error on linux since the mirror commit fwiw 11:19:13 <06d​olorous_84348> Most likely. It would be helpful if the error messages were more descriptive. Also, I don't understand most of the tiles code, which is why I don't often do tile-related stuff. 11:20:01 <05i​coson> oh yeah I do see it on the mirror commit 11:20:59 <05i​coson> which definitely touches rltiles! 11:24:11 I do wonder if it's somehow clang-specific, since I build with clang and LTO 11:24:33 <05i​coson> well, it's not showing on macos 11:24:45 <05i​coson> and the relevant ci is gcc 11:26:41 <06d​olorous_84348> Would the version of gcc that's being used make a difference? 11:29:33 <06d​olorous_84348> On mine, it's: g++ (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0 11:34:45 <05i​coson> macos = clang, so not sure. I know pf was almost certainly testing on mac too 11:44:14 <06d​olorous_84348> Unfortunately, I only have the one machine to code on, and installing clang on it to test just the one case seems like overkill. 12:02:39 <05i​coson> yeah, I think possibly someone who knows what that commit did may need to debug 12:03:34 <05i​coson> new scoring graph that may be easier to read than existing ones: http://crawl.akrasiac.org/scoring/date-stats-yearly.png 12:19:32 03DracoOmega02 07[neoyred_and_newbeogh] * 0.32-a0-80-g1c0e05d736: Make it more explicit how you recruit apostles 10(65 minutes ago, 3 files, 16+ 1-) 13https://github.com/crawl/crawl/commit/1c0e05d73647 12:19:32 03DracoOmega02 07[neoyred_and_newbeogh] * 0.32-a0-81-g5e59b91bd4: Fix friendly orc apostle descriptions being broken 10(36 minutes ago, 2 files, 2+ 3-) 13https://github.com/crawl/crawl/commit/5e59b91bd43d 12:19:32 03DracoOmega02 07[neoyred_and_newbeogh] * 0.32-a0-82-g7246d24a38: End Fathomless Shackles when you die as a felid (Oneirical) 10(2 minutes ago, 1 file, 4+ 0-) 13https://github.com/crawl/crawl/commit/7246d24a38b9 12:19:32 03DracoOmega02 07[neoyred_and_newbeogh] * 0.32-a0-83-g70067b86c0: Fix misformatted status description (Oneirical) 10(29 seconds ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/70067b86c0d1 12:41:28 03DracoOmega02 07[neoyred_and_newbeogh] * 0.32-a0-84-gfd63c3e15b: Be more consistant about announcing Beogh conversion offers 10(20 seconds ago, 5 files, 41+ 20-) 13https://github.com/crawl/crawl/commit/fd63c3e15b7c 13:17:00 -!- elliptic_ is now known as elliptic 13:21:52 <06p​leasingfungus> yeah, this compilation issue being non-mac makes life trickier for me 13:30:37 <06p​leasingfungus> if i can't repro it locally i don't really know how to debug it 13:30:41 <06p​leasingfungus> all i know is it it's dying somewhere in tiles gen 13:31:06 <04d​racoomega> You're on Mac? 13:32:05 <06p​leasingfungus> i know what the commit does - it adds a repeat_ctg directive for the tiles gen that duplicates an entire parts_ctg of tiles, and add mirror_horizontal/reset_mirror directives to specify that tiles should be flipped horizontal. But i don't know how to debug the compilation issue 13:32:07 <06p​leasingfungus> yes, i'm mac 13:32:23 <04d​racoomega> Thought you were on Linux for some reason 13:33:43 <04d​racoomega> If it also screws up on windows, I can try to take a look at it myself in a short while 13:34:03 <05i​coson> it's odd that there's no other errors, I don't see a way for process_line to fail without printing something to stderr 13:34:08 <06p​leasingfungus> oh, one more important chane 13:34:12 <06p​leasingfungus> *change 13:34:34 <06p​leasingfungus> generated enums within a parts_ctg all include the parts_ctg now. ex: 13:35:26 <06p​leasingfungus> TILEP_HAND1_EVENINGSTAR, TILEP_EVENINGSTAR_1, TILEP_EVENINGSTAR_2, becomes TILEP_HAND1_EVENINGSTAR, TILEP_HAND1_EVENINGSTAR_1, TILEP_HAND1_EVENINGSTAR_2, 13:37:16 <05i​coson> hm, Error: failed to process '-c' actually makes it look like it's trying to process that arg as a filename (still should be something on stderr about that) 13:37:18 <06p​leasingfungus> (generated from rltiles/dc-player.txt: %parts_ctg HAND1 ... eveningstar EVENINGSTAR eveningstar2 eveningstar3 ... 13:38:37 <06p​leasingfungus> @qwqwqwqwqwqwqw hero 13:38:47 <06p​leasingfungus> that one has gotten me repeatedly 13:38:56 03elliptic02 07* 0.32-a0-89-g8fd5419284: Rename maybe_random_div to maybe_random2_div 10(2 minutes ago, 4 files, 7+ 7-) 13https://github.com/crawl/crawl/commit/8fd5419284fe 13:38:59 <06p​leasingfungus> also, fr: a real maybe_random_div 13:39:08 <06p​leasingfungus> i'd use that in a bunch of spell damage code 13:39:20 <13q​wqwqwqwqwqwqw> yeah I expected it to be div_rand_round with a maybe 13:39:22 <13q​wqwqwqwqwqwqw> and it wasn't 13:39:24 <05i​coson> oh heh the error msg itself is bugged there 13:48:11 <05i​coson> not in a way that is obviously going to help 13:49:09 <06p​leasingfungus> 😦 13:49:59 <06p​leasingfungus> could revert it in master for now? 13:51:29 03PleasingFungus02 07* 0.32-a0-90-g35313b3b04: Revert "Enter the mirror dimension" 10(40 seconds ago, 23 files, 80+ 141-) 13https://github.com/crawl/crawl/commit/35313b3b0401 13:53:24 <05i​coson> oops 13:53:35 03advil02 07* 0.32-a0-91-gc7ef563f12: fix: improve some rltiles error messages 10(38 seconds ago, 2 files, 5+ 4-) 13https://github.com/crawl/crawl/commit/c7ef563f12df 13:53:37 <05i​coson> well, the improvements are independent I guess 13:57:47 03PleasingFungus02 07[two-swords-adventure] * 0.32-a0-91-g45088022c4: Revert "Revert "Enter the mirror dimension"" 10(76 seconds ago, 23 files, 141+ 80-) 13https://github.com/crawl/crawl/commit/45088022c42f 13:57:47 03PleasingFungus02 07[two-swords-adventure] * 0.32-a0-92-gef03ba6bf9: New species: steel elves 10(10 weeks ago, 61 files, 1725+ 291-) 13https://github.com/crawl/crawl/commit/ef03ba6bf999 13:57:47 03PleasingFungus02 07[two-swords-adventure] * 0.32-a0-93-gf44f631916: Steal blademasters for steel elves 10(4 days ago, 29 files, 78+ 78-) 13https://github.com/crawl/crawl/commit/f44f631916d8 14:03:14 <05i​coson> @pleasingfungus can you do c7ef563f12 too in case there is something informative? 14:04:37 <05i​coson> I still don't really have a clue how process_list could return false without more errors than are showing up 14:05:06 <04d​racoomega> Yeah, I've been taking a little look myself and haven't found anything useful yet 14:05:17 <04d​racoomega> But my attention is still split with Beogh stuff >.> 14:07:51 <06p​leasingfungus> yes, sure thing! 14:07:57 <06p​leasingfungus> thank you (both!) very much for looking 🙂 14:09:17 03PleasingFungus02 07[two-swords-adventure] * 0.32-a0-94-g22febb63af: Rewrite offhand weapon warnings 10(2 minutes ago, 1 file, 29+ 22-) 13https://github.com/crawl/crawl/commit/22febb63af20 14:09:17 03advil02 {PleasingFungus} 07[two-swords-adventure] * 0.32-a0-95-g39a1032d20: fix: improve some rltiles error messages 10(16 minutes ago, 2 files, 5+ 4-) 13https://github.com/crawl/crawl/commit/39a1032d2092 14:11:23 03PleasingFungus02 07[two-swords-adventure] * 0.32-a0-96-g15321cb0d2: Remove elf weddings (kate, dolorous) 10(73 seconds ago, 1 file, 4+ 4-) 13https://github.com/crawl/crawl/commit/15321cb0d2dc 14:16:27 <04d​racoomega> Yeah, it really doesn't seem like there's any way for process_line to return false without printing an error message 14:16:41 <04d​racoomega> Even though it seems like it literally must be doing so? 14:22:52 03PleasingFungus02 07[two-swords-adventure] * 0.32-a0-97-g297eb187dc: Remove spectral friendship 10(31 seconds ago, 4 files, 16+ 11-) 13https://github.com/crawl/crawl/commit/297eb187dc3b 14:30:22 04Build failed for 08master @ 8fd54192 06https://github.com/crawl/crawl/actions/runs/7790558202 14:32:28 <04d​racoomega> I have discovered something quite scary while continuing to try and debug that tile tool build failure 14:33:12 <04d​racoomega> A point where inserting a diagnostic print statement seems to make it work, and not having it there makes it fail 14:33:53 mmm, heisenbugs 14:33:57 <06p​leasingfungus> yum 14:34:00 <06d​olorous_84348> Yikes. 14:35:36 <05i​coson> it does seem plausible that this is some sort of memory corruption issue 14:35:39 <04d​racoomega> So, this is currently the main loop in tile_list_processor::process_list C++ bool success = true; while (!input.getline(read_line, bufsize).eof()) success &= process_line(read_line, list_file, line++); return success; I was expanding it a bit, so that it could at least tell me what line it's failing on, if none of the normal error messages is printing. This still crashes: C++ while (!input.getline(read_line, 14:35:40 bufsize).eof()) { bool temp_success = process_line(read_line, list_file, line++); success &= temp_success; } But this does not: C++ while (!input.getline(read_line, bufsize).eof()) { bool temp_success = process_line(read_line, list_file, line++); success &= temp_success; if (!temp_success) fprintf(stderr, "File %s #%d\n%s\n", list_file, line, read_line); } 14:37:19 um. what happens if you use `&&=` instead of `&=`? 14:38:30 <04d​racoomega> Is that even a thing? 14:40:21 huh, I guess not in c++ 14:40:41 I am still wondering if bitwise ops are wise there 14:41:22 even though it's `bool` 14:41:23 <04d​racoomega> I mean, it seems like it's just a way of saying "If any of these have ever returned false", no? 14:41:45 don't confuse bitwise and with logical and 14:41:46 <05i​coson> it's a bitwise operator, so it's kind of weird 14:42:02 <05i​coson> I don't see how it would cause this issue, but maybe worth fixing on principle 14:42:11 <04d​racoomega> Commenting out all the maybe_mirror also fixes it, by the way 14:42:21 <04d​racoomega> So it's probably a memory issue in there 14:42:45 <04d​racoomega> (Or, at least, that seems plausible) 14:43:12 if it were C instead of C++ I'd wonder if it sometimes forgets to `return` a meaningful value 14:44:38 <04d​racoomega> This is where I kind of wish I had memory analysis tools set up (that I last used like... 20 years ago now >.>) 14:45:03 <04d​racoomega> Alternately: curse C++ forever 14:45:08 04Build failed for 08two-swords-adventure @ 39a1032d 06https://github.com/crawl/crawl/actions/runs/7790859834 14:45:11 04Build failed for 08two-swords-adventure @ 15321cb0 06https://github.com/crawl/crawl/actions/runs/7790887812 14:45:18 04Build failed for 08two-swords-adventure @ f44f6319 06https://github.com/crawl/crawl/actions/runs/7790737609 14:45:39 <06d​olorous_84348> I've used valgrind sometimes (and more recently than 20 years ago), but not often enough to remember it offhand. 14:46:30 <06d​olorous_84348> And there are times I want to curse C++ forever too 🙂 14:48:26 rewrite it in C 14:49:06 <04d​racoomega> You realize that doesn't actually improve the part I'm complaining about, right? 😛 14:50:28 <04d​racoomega> Hmmm.. there are already asserts here for reading out of bounds 14:51:18 <04d​racoomega> So maybe it's another coincidence?? 14:51:57 <05i​coson> if it's sensitive enough to vanish by adding an fprintf, unfortunately ime almost anything could make it go away or change 14:52:20 04Build failed for 08two-swords-adventure @ 297eb187 06https://github.com/crawl/crawl/actions/runs/7791017406 14:56:30 <06d​olorous_84348> The only thing I can think of is that something's being optimized away without the fprintf, but if you're building it without optimizations, which is usually the case for debug builds, that can't be it. 15:06:48 03PleasingFungus02 07[two-swords-adventure] * 0.32-a0-98-g5038c47d3f: Rework dual wielding weapon delay again (elliptic) 10(32 minutes ago, 5 files, 42+ 38-) 13https://github.com/crawl/crawl/commit/5038c47d3f12 15:11:03 03Zhang Kai02 {PleasingFungus} 07* 0.32-a0-92-g301c3d356d: Update ability.txt 10(2 weeks ago, 1 file, 10+ 2-) 13https://github.com/crawl/crawl/commit/301c3d356d70 15:11:03 03Zhang Kai02 {PleasingFungus} 07* 0.32-a0-93-g18257a444a: Update backgrounds.txt 10(2 weeks ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/18257a444a46 15:11:03 03Zhang Kai02 {PleasingFungus} 07* 0.32-a0-94-g21a18ad617: Update branches.txt 10(2 weeks ago, 1 file, 10+ 7-) 13https://github.com/crawl/crawl/commit/21a18ad617f4 15:11:03 03Zhang Kai02 {PleasingFungus} 07* 0.32-a0-95-g18cdba413a: Update clouds.txt 10(2 weeks ago, 1 file, 14+ 11-) 13https://github.com/crawl/crawl/commit/18cdba413a06 15:11:03 03Zhang Kai02 {PleasingFungus} 07* 0.32-a0-96-g5344a817ef: Update features.txt 10(2 weeks ago, 1 file, 7+ 3-) 13https://github.com/crawl/crawl/commit/5344a817ef18 15:11:03 03Zhang Kai02 {PleasingFungus} 07* 0.32-a0-97-ged181fcaab: Update gods.txt 10(2 weeks ago, 1 file, 3+ 6-) 13https://github.com/crawl/crawl/commit/ed181fcaabb3 15:11:03 03Zhang Kai02 {PleasingFungus} 07* 0.32-a0-98-gd3b20e54b6: Update items.txt 10(2 weeks ago, 1 file, 136+ 12-) 13https://github.com/crawl/crawl/commit/d3b20e54b635 15:11:03 03Zhang Kai02 {PleasingFungus} 07* 0.32-a0-99-g2699e95f02: Update monsters.txt 10(2 weeks ago, 1 file, 74+ 17-) 13https://github.com/crawl/crawl/commit/2699e95f02df 15:11:03 03Zhang Kai02 {PleasingFungus} 07* 0.32-a0-100-g7189f9785e: Update mutations.txt 10(2 weeks ago, 1 file, 28+ 26-) 13https://github.com/crawl/crawl/commit/7189f9785e77 15:11:03 03Zhang Kai02 {PleasingFungus} 07* 0.32-a0-101-g78019320dc: Update skills.txt 10(2 weeks ago, 1 file, 14+ 26-) 13https://github.com/crawl/crawl/commit/78019320dcea 15:11:03 ... and 13 more commits 15:11:03 03PleasingFungus02 07[two-swords-adventure] * 0.32-a0-99-g98ba979030: Fix (un)equip FX (Monkooky) 10(60 seconds ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/98ba97903070 15:11:03 <04d​racoomega> I may have a lead 15:11:30 <04d​racoomega> ==117780== Conditional jump or move depends on uninitialised value(s) ==117780== at 0x115D9D: maybe_mirror (tile_list_processor.cc:277) I think m_mirror_horizontal is not necessarily initialized 15:13:09 03PleasingFungus02 07[two-swords-adventure] * 0.32-a0-100-g2693a44f40: Fix contagious flame brand 10(10 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/2693a44f40cd 15:14:32 <06d​olorous_84348> On a completely different note, there's a matter of lore, that new Yred made me think of. 15:14:37 <06d​olorous_84348> I remember, ages ago, dploog commenting that Lugonu tried to stage a takeover of the pantheon and failed, which is why Lugonu is exiled from both the pantheon and the dungeon. 15:14:55 <05i​coson> ahh I bet you got it 15:16:17 <05i​coson> usually shouldn't break things in that way but I'm not shocked that it could in a very compiler-dependent way 15:16:34 <04d​racoomega> It seems to work after initializing it 15:16:42 <04d​racoomega> Not that this is 100% trustworthy in this situation, but it makes sense 15:16:46 <06d​olorous_84348> How that ties into new Yred is: Zin's Recite text talks about "the fall of Lugonu", but new Yred is described as fallen. 15:16:55 <06d​olorous_84348> So I figure it could be adjusted to "the fall of Yredelemnul" and "the reprobation of Lugonu" could be added. 15:17:03 <04d​racoomega> That makes sense to me 15:17:28 <06d​olorous_84348> Zin's flavor would seem to fit terms like "reprobate", anyway. 15:17:45 <04d​racoomega> Like, I always saw Lugonu as an 'outside force' intruding on the world and probably never any part of a normal pantheon in the first place 15:18:17 <06d​olorous_84348> That works too. 15:18:19 <04d​racoomega> But it makes sense for Zin to specifically hold up Yred as an example of especially what not to be 15:18:46 <09g​ammafunk> Does Zin know how much Linley likes Yred? 15:19:02 <04d​racoomega> Do we? I have no idea what Linley thought of anything, really 15:19:26 <04d​racoomega> @pleasingfungus Since this seems to have maybe fixed the mirror-verse issue, should I unrevert with this fix? 15:21:15 <09g​ammafunk> Many years ago, before I was around, he joined IRC to wish the dcss project well. His nick was Yredelemnul 15:22:33 -!- ssm__ is now known as ssm_ 15:22:55 <09g​ammafunk> He's on record saying that when he added the God system in Linley 2.x he spent a lot of time on the evil gods like Makh and Yred because he thought they were cool, and not so much time on the good gods 15:23:37 <06d​olorous_84348> Interesting. 15:24:21 <06d​olorous_84348> Considering that there's the holy Pan floor, and new Yred is a fallen good god, is TSO supposed to be a raised evil god, then? 15:25:21 <09g​ammafunk> His other thing was to complain that nemelex deck evocation should only be when they were wielded, or something along those lines 15:25:37 <09g​ammafunk> Rip that 15:25:55 <09g​ammafunk> Think it was just the theme he liked 15:26:14 <04d​racoomega> I'd seen it argued years ago that holies and demons were physiologically 'the same thing', just with different cultures 15:26:31 <04d​racoomega> Though if not, one could reasonably imagine Holy Pan as a fortress the good gods have made in breaching Pan 15:27:39 <09g​ammafunk> Wonder if evilmike had any lore precedent for holy pan when he made it 15:28:17 <09g​ammafunk> Maybe there's something on doku wiki 15:28:27 <06d​olorous_84348> Could be. 15:29:42 <06r​egret-⸸nde※> https://cdn.discordapp.com/attachments/747522859361894521/1204192154155614249/image.png?ex=65d3d656&is=65c16156&hm=b26803e039042f52cf579e5a72c09e458e174d2ca5fbc67caf631d09df8b4077& 15:29:47 <04d​racoomega> Well then 15:29:54 <06r​egret-⸸nde※> (angels and daevas have always been part of place:Pan also) 15:31:11 How does new yred work with the abyss? 15:31:43 <04d​racoomega> Can't light the torch in the abyss, if I recall right 15:32:39 <06r​egret-⸸nde※> https://cdn.discordapp.com/attachments/747522859361894521/1204192894479638588/image.png?ex=65d3d706&is=65c16206&hm=1d32897a0a0dbe73ba663335f888aaa16d598beb2c1d3287d2ad350e846b533a& 15:34:37 <09g​ammafunk> Finally extended portals that are not zig 15:36:41 04Build failed for 08two-swords-adventure @ 5038c47d 06https://github.com/crawl/crawl/actions/runs/7791443756 15:36:43 04Build failed for 08two-swords-adventure @ 98ba9790 06https://github.com/crawl/crawl/actions/runs/7791484136 15:38:29 04Build failed for 08two-swords-adventure @ 2693a44f 06https://github.com/crawl/crawl/actions/runs/7791512917 15:38:51 <06r​egret-⸸nde※> (I'd like to use the holies for a holyhell so hellpan roulette is a consistent 11 runes, with a more V:$ style layout, and then convert the holypan level without solely holy enemies for... Depths? or V? that is an extremely long ways off though, since I need a bunch more ideas for holy mechanics since the last batch failed, and for more buffs + more monsters that could work in the fodder slots for Pan and regular dangers 15:38:51 outside of Pan) 15:44:31 New branch created: pull/3516 (42 commits) 13https://github.com/crawl/crawl/pull/3516 15:44:37 03DracoOmega02 07https://github.com/crawl/crawl/pull/3516 * 0.32-a0-44-g72845cb133: Fix minor wizmode bug with xp calculation 10(4 weeks ago, 1 file, 0+ 2-) 13https://github.com/crawl/crawl/commit/72845cb133de 15:44:37 03DracoOmega02 07https://github.com/crawl/crawl/pull/3516 * 0.32-a0-45-gc93a764e60: Make ability_name return string instead of const char* 10(3 weeks ago, 7 files, 16+ 16-) 13https://github.com/crawl/crawl/commit/c93a764e60d7 15:44:37 03DracoOmega02 07https://github.com/crawl/crawl/pull/3516 * 0.32-a0-46-g51ebc35840: Refactor testing of band follower/leader relationships 10(13 days ago, 13 files, 67+ 46-) 13https://github.com/crawl/crawl/commit/51ebc3584010 15:44:37 03DracoOmega02 07https://github.com/crawl/crawl/pull/3516 * 0.32-a0-47-g69d68bf9b7: Let monsters cast Scorch 10(13 days ago, 9 files, 76+ 28-) 13https://github.com/crawl/crawl/commit/69d68bf9b75c 15:44:37 03DracoOmega02 07https://github.com/crawl/crawl/pull/3516 * 0.32-a0-48-gc3c030e410: Implement monster foxfire (for illusions and ghosts) 10(12 days ago, 2 files, 13+ 1-) 13https://github.com/crawl/crawl/commit/c3c030e410b2 15:44:37 03DracoOmega02 07https://github.com/crawl/crawl/pull/3516 * 0.32-a0-49-ge40939e482: Searing Ray monster implementation 10(12 days ago, 10 files, 154+ 56-) 13https://github.com/crawl/crawl/commit/e40939e48213 15:44:37 03DracoOmega02 07https://github.com/crawl/crawl/pull/3516 * 0.32-a0-50-g451dd4f0d0: Heavily refactor Vhi's Electric Charge and let monsters use it 10(12 days ago, 10 files, 323+ 311-) 13https://github.com/crawl/crawl/commit/451dd4f0d0c8 15:44:37 03DracoOmega02 07https://github.com/crawl/crawl/pull/3516 * 0.32-a0-51-ga68d38270e: Implement monster Kiss of Death 10(11 days ago, 3 files, 11+ 4-) 13https://github.com/crawl/crawl/commit/a68d38270ec3 15:44:37 03DracoOmega02 07https://github.com/crawl/crawl/pull/3516 * 0.32-a0-52-gb99a2d9b40: Let monsters cast Manifold Assault (and refactor a few things) 10(11 days ago, 10 files, 85+ 103-) 13https://github.com/crawl/crawl/commit/b99a2d9b40ec 15:44:37 03DracoOmega02 07https://github.com/crawl/crawl/pull/3516 * 0.32-a0-53-gee7f200a3c: Let monsters cast Lesser Beckoning 10(11 days ago, 1 file, 12+ 0-) 13https://github.com/crawl/crawl/commit/ee7f200a3c15 15:44:37 ... and 32 more commits 15:56:34 <06d​olorous_84348> I've noticed that, when making the pull request against the neoyred_and_newbeogh branch, there's a build failure on Android there because it's still trying to compile (the now-removed) mon-grow.cc. I don't know enough about Android to try to fix it, though. 15:58:52 <04d​racoomega> Yeah, I saw that. Some file list that it still needs to be deleted from, somewhere 16:00:09 ./android-project/jni/src/Android.mk: $(CRAWL_PATH)/mon-grow.cc \ 16:01:08 <04d​racoomega> Thanks 16:01:31 <04d​racoomega> (I am still trying to figure out why mirrorverse is apparently making armour draw under players tiles) 16:05:00 <06d​olorous_84348> Good luck with it. 16:08:22 <04d​racoomega> It's not clear to me that there's anything in this commit that should be affecting this at all, but when I revert it, the problem seems to go away 16:08:29 <04d​racoomega> (And thanks ^^; ) 16:14:43 fwiw mon-grow is also still referenced in Crawl.xcodeproj and crawl.vcxproj 16:15:28 not sure how supported those are though, they bitrot rapidly 16:18:14 <04d​racoomega> I admit, I find it hard to follow most of the makefile/build process stuff. (...it took me a while to figure out how to even get my own compilation to work after removing mon-grow.cc >.>) 16:23:28 <04d​racoomega> It looks like there mere presence of %parts_ctg HAND1_MIRROR %mirror_horizontal %repeat_ctg HAND1 %end_ctg %reset_mirror in dc-player.txt is causing armour draw order to be wrong, but ??? 16:24:07 <06p​leasingfungus> draco: yes, please unrevert! 🙂 16:24:17 <04d​racoomega> Well, I haven't because it's bugged in other ways 16:24:23 <04d​racoomega> That I am still trying to figure out 16:24:40 <04d​racoomega> It builds, but paperdolls draw armor and such behind the body 16:25:14 <06p​leasingfungus> yeah, i noticed that on the stelf branch but didn't have time to fix it 16:25:33 <06p​leasingfungus> also the makefile stuff is quite hairy, yep 🙂 rarely touched, etc... 16:25:50 <04d​racoomega> Have a theory I'm working on here 16:27:31 03PleasingFungus02 07[two-swords-adventure] * 0.32-a0-101-gab1390d076: Fix the build? 10(27 seconds ago, 1 file, 1+ 0-) 13https://github.com/crawl/crawl/commit/ab1390d0769b 16:27:43 <04d​racoomega> (It sure would be nice if editing slightly dc-player.txt didn't cause a recompilation that took like 10 minutes) 16:33:16 <06p​leasingfungus> a relevant function is pack_doll_buf in tiledoll.cc, if you hadn't seen it 16:33:21 <09g​ammafunk> surprised that WSL rebuilds are that slow 16:33:22 <06p​leasingfungus> but i'm excited for your theory 🙂 16:44:29 <06p​leasingfungus> inbox status 16:44:29 <06p​leasingfungus> https://cdn.discordapp.com/attachments/747522859361894521/1204210970927439932/help.png?ex=65d3e7dc&is=65c172dc&hm=2efcc42c524fdfc6e4574a7a5b848fb4ac90c37e3bb297292a55c1e707c6b7e7& 16:45:27 <04d​racoomega> Oh boy 16:59:27 <04d​racoomega> Things I have ascertained: the presence of that block in dc-player.txt does indeed cause the problem, but: -It still causes the problem, even if you rename it, relocate it elsewhere in the file, and remove any directives inside it. ie: %parts_ctg MIRRORY %end_ctg at the end of the file still causes the same doll ordering issue. At one point I had thought that Crawl was referencing categories for tile ordering based on the order they 16:59:27 were defined in dc-player, but this does not seem to be the case 17:00:03 <04d​racoomega> So it's still not clear to me why one more category anywhere, containing nothing, breaks things like it does 17:02:35 <04d​racoomega> Oh, wait 17:11:06 <04d​racoomega> How bizarre. I have it working for the main menu but not in-game >.> 17:11:16 <04d​racoomega> I was like "It works!" but it does not work 17:11:52 <04d​racoomega> (And yes, I realize there are actually different copies of tile category enums for various parts of the game, but I thought I accounted for that) 17:13:20 <04d​racoomega> Ah, my mistake. That list is duplicated in four places, not just 3 17:13:24 <04d​racoomega> -.- 17:14:35 <06r​egret-⸸nde※> awful, awful, awful, and also, awful 17:14:36 <06r​egret-⸸nde※> :P 17:15:16 <04d​racoomega> Seems to work now, but I hate it 17:17:29 <04d​racoomega> There's 6-year-old fixme's about how much code duplication is going on here, and I simultaneously feel like I should - and also don't want to - fix this right now ^^; 17:17:43 <04d​racoomega> But I will look into doing the responsible thing 17:18:53 <04d​racoomega> A couple places have scarf logic and others don't 17:42:47 New branch created: pull/3517 (42 commits) 13https://github.com/crawl/crawl/pull/3517 17:42:53 03DracoOmega02 07https://github.com/crawl/crawl/pull/3517 * 0.32-a0-44-g72845cb133: Fix minor wizmode bug with xp calculation 10(4 weeks ago, 1 file, 0+ 2-) 13https://github.com/crawl/crawl/commit/72845cb133de 17:42:53 03DracoOmega02 07https://github.com/crawl/crawl/pull/3517 * 0.32-a0-45-gc93a764e60: Make ability_name return string instead of const char* 10(3 weeks ago, 7 files, 16+ 16-) 13https://github.com/crawl/crawl/commit/c93a764e60d7 17:42:53 03DracoOmega02 07https://github.com/crawl/crawl/pull/3517 * 0.32-a0-46-g51ebc35840: Refactor testing of band follower/leader relationships 10(13 days ago, 13 files, 67+ 46-) 13https://github.com/crawl/crawl/commit/51ebc3584010 17:42:53 03DracoOmega02 07https://github.com/crawl/crawl/pull/3517 * 0.32-a0-47-g69d68bf9b7: Let monsters cast Scorch 10(13 days ago, 9 files, 76+ 28-) 13https://github.com/crawl/crawl/commit/69d68bf9b75c 17:42:53 03DracoOmega02 07https://github.com/crawl/crawl/pull/3517 * 0.32-a0-48-gc3c030e410: Implement monster foxfire (for illusions and ghosts) 10(12 days ago, 2 files, 13+ 1-) 13https://github.com/crawl/crawl/commit/c3c030e410b2 17:42:53 03DracoOmega02 07https://github.com/crawl/crawl/pull/3517 * 0.32-a0-49-ge40939e482: Searing Ray monster implementation 10(12 days ago, 10 files, 154+ 56-) 13https://github.com/crawl/crawl/commit/e40939e48213 17:42:53 03DracoOmega02 07https://github.com/crawl/crawl/pull/3517 * 0.32-a0-50-g451dd4f0d0: Heavily refactor Vhi's Electric Charge and let monsters use it 10(12 days ago, 10 files, 323+ 311-) 13https://github.com/crawl/crawl/commit/451dd4f0d0c8 17:42:53 03DracoOmega02 07https://github.com/crawl/crawl/pull/3517 * 0.32-a0-51-ga68d38270e: Implement monster Kiss of Death 10(11 days ago, 3 files, 11+ 4-) 13https://github.com/crawl/crawl/commit/a68d38270ec3 17:42:53 03DracoOmega02 07https://github.com/crawl/crawl/pull/3517 * 0.32-a0-52-gb99a2d9b40: Let monsters cast Manifold Assault (and refactor a few things) 10(11 days ago, 10 files, 85+ 103-) 13https://github.com/crawl/crawl/commit/b99a2d9b40ec 17:42:53 03DracoOmega02 07https://github.com/crawl/crawl/pull/3517 * 0.32-a0-53-gee7f200a3c: Let monsters cast Lesser Beckoning 10(11 days ago, 1 file, 12+ 0-) 13https://github.com/crawl/crawl/commit/ee7f200a3c15 17:42:53 ... and 32 more commits 19:01:16 03DracoOmega02 07* 0.32-a0-115-g1a93b60f7d: Revert "Revert "Enter the mirror dimension"" with a fix 10(4 hours ago, 23 files, 142+ 80-) 13https://github.com/crawl/crawl/commit/1a93b60f7d6c 19:01:16 03DracoOmega02 07* 0.32-a0-116-gaf751e2436: Fix players being naked and refactor 10(67 seconds ago, 7 files, 92+ 179-) 13https://github.com/crawl/crawl/commit/af751e243603 19:07:22 <09g​ammafunk> Posting this just-discovered quote here since I'm sure some would appreciate it: > Dark corners are basically fractal — no matter how much you illuminate, there’s always a smaller but darker one. > — Brian Kernighan 19:27:25 03DracoOmega02 07[neoyred_and_newbeogh] * 0.32-a0-85-g18e2974ef3: Fix crashy Beogh wrath 10(17 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/18e2974ef3f5 20:08:11 03geekosaur02 07https://github.com/crawl/crawl/pull/3517 * 0.32-a0-86-g5f6fcf2e9f: also fix the android project 10(2 minutes ago, 1 file, 0+ 1-) 13https://github.com/crawl/crawl/commit/5f6fcf2e9f4b 20:24:41 interesting, it didn't show the original PR because it's not against master, but it shows updates to it 20:27:35 also it seems to be rather confused about PRs… 20:28:18 oh no, it did show it, it just did so confusingly 21:29:58 <06p​leasingfungus> lol 21:30:15 New branch created: pull/3519 (1 commit) 13https://github.com/crawl/crawl/pull/3519 21:30:15 03grumposus02 07https://github.com/crawl/crawl/pull/3519 * 0.32-a0-115-g9d6baa7cc3: Make rising flame valid to use on D1 if the player has the orb, and cause it to win the game. 10(18 minutes ago, 2 files, 9+ 0-) 13https://github.com/crawl/crawl/commit/9d6baa7cc3b0 21:32:43 <09g​ammafunk> that is a cool PR 21:33:07 <09g​ammafunk> very nethack quaff cursed potion of gain level vibes 21:34:26 03regret-index02 07* 0.32-a0-117-g32696db3d1: Lower the contrast on bedeviled crystal tiles (PleasingFungus) 10(6 hours ago, 14 files, 0+ 0-) 13https://github.com/crawl/crawl/commit/32696db3d1ad 21:34:26 03regret-index02 07* 0.32-a0-118-g3087d83e6e: Buff Maurice Will (ragingrage), nerf Erica 10(5 hours ago, 3 files, 8+ 8-) 13https://github.com/crawl/crawl/commit/3087d83e6e0c 21:34:26 03regret-index02 07* 0.32-a0-119-g2e8054a333: Make Xom give more chaos brand, adjust chaos brand Xom amusement 10(14 minutes ago, 3 files, 25+ 32-) 13https://github.com/crawl/crawl/commit/2e8054a33376 21:44:55 03DracoOmega02 07[neoyred_and_newbeogh] * 0.32-a0-86-g7d98568416: Fix some typoes (Oneirical) 10(54 seconds ago, 7 files, 11+ 11-) 13https://github.com/crawl/crawl/commit/7d985684167e 21:44:55 03DracoOmega02 07[neoyred_and_newbeogh] * 0.32-a0-87-gda20e54fe6: Fix new status icons not displaying in webtiles 10(42 seconds ago, 1 file, 4+ 0-) 13https://github.com/crawl/crawl/commit/da20e54fe6c9 21:44:55 03DracoOmega02 07[neoyred_and_newbeogh] * 0.32-a0-88-gb63f4025d9: Fix some Beogh status tracking being buggy when a felid dies (Oneirical) 10(24 seconds ago, 1 file, 8+ 1-) 13https://github.com/crawl/crawl/commit/b63f4025d992 21:57:03 04Build failed for 08master @ 2e8054a3 06https://github.com/crawl/crawl/actions/runs/7794761475 22:06:52 03Wizard Ike02 07https://github.com/crawl/crawl/pull/3120 * 0.31-a0-1630-g713b449437: Reactivate autopickup when polymorphing an invisible monster makes it friendly 10(9 minutes ago, 1 file, 3+ 3-) 13https://github.com/crawl/crawl/commit/713b4494370d 22:06:52 03Wizard Ike02 07https://github.com/crawl/crawl/pull/3120 * 0.31-a0-1631-g8d55aa1825: Don't reactivate autopickup when shafting a friendly invisible monster 10(3 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/8d55aa1825df 22:07:39 <06d​olorous_84348> Definitely. 23:00:22 hi all. Does anyone understand how tile rendering mode works? I mean the interaction between the crawl binary and the client-side JS. There doesn't seem to be any documentation about the message formats and I'm struggling to understand aspects 23:00:29 *webtile rendering mode 23:07:03 some questions: what's the difference between a menu and a ui dialog? How do map cells work (specifying tiles to render in which order)? 23:08:46 <04d​racoomega> I feel like the sad truth is that nobody who is active really understands it all that well 23:09:03 <04d​racoomega> I fixed several important things with it today and I sure wouldn't say I understand any of it >.> 23:10:01 <04d​racoomega> I have no recollection now who made any of the original webtile Javascript, but I don't think they've been around for a while, and all a bunch of us do is just try and keep the ship from leaking too much 23:10:27 <04d​racoomega> Maybe I am wrong and someone here is more knowledgeable. Would be nice ^^ 23:31:26 advil has written a lot, so I'm hoping he pipes up 🙏 23:32:52 <04d​racoomega> I mean, I'd be happy to be incorrect, since it's definitely out of my wheelhouse