00:45:28 Monster database of master branch on crawl.develz.org updated to: 0.32-a0-42-ga30500b4d3 01:32:57 Fork (bcrawl) on crawl.kelbi.org updated to: 0.23-a0-5140-g5775ae71e1 01:32:57 Fork (bcrawl) on crawl.kelbi.org updated to: 0.23-a0-5140-g5775ae71e1 08:10:07 -!- elliptic_ is now known as elliptic 10:16:46 <05icoson> hm, known_item_mangle has (what to me is) a very strange use of unique_ptr on stack, does anyone have any guesses as to what this is doing? https://github.com/crawl/crawl/blob/master/crawl-ref/source/known-items.cc#L311 10:17:40 <05icoson> it looks sort of like it's simply deallocating *me after it goes out of scope, but I don't know why exactly you'd do it this way 10:17:59 <05icoson> (looking at the android crash above) 15:26:10 <04dracoomega> This is a frightening comment that does not sound very much like what actually happens or how it is used case KILL_BANISHED: // Monster doesn't die, just goes back to wherever it came from. // This must only be called by monsters running out of time (or // abjuration), because it uses the beam variables! Or does it??? // Pacified monsters leave the level when this happens. 15:30:05 <03wheals> the mon-death code is pretty terrifying 15:30:34 <04dracoomega> Like, that's not how the Abyss works, this is not the kill type used by summons expiring, or pacified creatures, and no beam variables are involved 15:30:40 <04dracoomega> I think literally every part of this comment is wrong 15:30:56 <04dracoomega> Also: a few lines lower, it talks about what it's doing as if this was for KILL_RESET 15:31:19 wheals: TBF this is true for most files of the form foo.cc 15:39:12 <06pleasingfungus> foo.h not lookin too great either 15:39:34 A refreshing number of those are just lists of stuff 15:39:53 <06pleasingfungus> yeah, but have you seen those #if MAJOR_VERSIONs? 15:40:41 I dread the day you change the major version TBH, I am well aware I'm not keeping them all correct 15:41:29 ime we will also publish the reasons for any 15:41:39 sorry, mispaste 15:42:50 <06regret-⸸nde※> finding out today that branch-data.h has a giant pile of MAJOR_VERSIONs for making the portals appear in chronological order made me dread the whole glacial chasm / bastion / gutter plans >_> 15:44:22 oh good it's not like I want to bring the Hive back as oh damn 15:46:37 <06pleasingfungus> i’m sort of hoping we never bump the major version 15:46:54 <06pleasingfungus> but who can say 15:47:49 Also at my present rate of catching up I shall be dead by the time you do, in which case it will be someone else's problem 15:56:20 <09hellmonk> last major version bump was a long time ago so it seems to be working out so far 15:57:38 <04dracoomega> I'm not sure if anything has really changed since then beyond the methodology for making changes in a save compatible way getting a lot more entrenched 15:58:26 <04dracoomega> I'm not deeply familiar with all the other times major tags were bumped, but I suspect a bunch of them could have had save compat code, if people had wanted 15:58:31 <04dracoomega> (Some possibly not; who knows?) 16:01:05 some of the save compat is kinda dubious; I had a game become pretty strange because I let it sit for a year and a half 16:25:11 <05sastreii> fire, ice and acid/radioactive crevices. storm and steam will be different. keep in mind that those tiles have transparent areas so make sure to remove that automatic black outline thing (i don't know if you had in mind something like this) 16:25:12 <05sastreii> https://cdn.discordapp.com/attachments/747522859361894521/1200944625389682688/Schermata_2024-01-28_alle_00.20.29.png?ex=65c805d7&is=65b590d7&hm=1761d4dc3ec3a606002710a96a81e9a276f9a19530d018ca80a20e71a7db7e7f& 16:25:12 <05sastreii> https://cdn.discordapp.com/attachments/747522859361894521/1200944625888796844/Schermata_2024-01-28_alle_00.20.44.png?ex=65c805d7&is=65b590d7&hm=4d47538ce210f781ac754a8f2783996ef1ab29fa8d6b93c2947685aa06a2d32e& 16:25:13 <05sastreii> https://cdn.discordapp.com/attachments/747522859361894521/1200944626085920939/tiles.zip?ex=65c805d7&is=65b590d7&hm=13262fdd5539bfc927e593534a71546642fb6b12a359b637a58a8335f9b39bb3& 16:25:31 <04dracoomega> How in the bloody world could CrawlStoreValue::get_bool() result in ERROR in 'store.cc' at line 786: unknown stored value type >.> 16:25:53 <04dracoomega> Neat 16:35:56 <06pleasingfungus> draco: think the most major change since the last major version bump is making the number of minor tags unlimited 16:36:15 <06pleasingfungus> (not that any previous version ran into that, i suspect…) 16:36:26 <04dracoomega> Were they limted in a practical sense before or just a theoretical one? 16:36:47 <06regret-⸸nde※> ooo, neat 16:37:18 <06regret-⸸nde※> plenty good for my purposes, sure 16:41:47 <04dracoomega> Yes, I am completely baffled at how this completely pedestrian get_bool() is crashing 16:41:58 <04dracoomega> I am probably overlooking something really dumb 16:45:40 re minor tags, the limit was 255 16:45:56 I think we're not quite there yet but it's looming 16:46:16 <04dracoomega> Smaller limit than expected 17:22:57 <09gammafunk> geekosaur, we actually passed it 17:23:17 <09gammafunk> and it triggered a wonderful bug in PF's last experimental branch that was non-trivial to fix 17:25:14 <09gammafunk> we're at 267 minor versions right now in fact 17:25:39 huh 17:26:21 <09gammafunk> %git efeffbb62afe3e3d34bf1919b8655b58769d63ff 17:26:21 <04Cerebot> gammafunk * 0.31-a0-222-gefeffbb62a: fix: Use the correct type for the minor version (7 months ago, 3 files, 3+ 10-) https://github.com/crawl/crawl/commit/efeffbb62afe 17:26:31 <09gammafunk> that fact that this happened in an experimental was extremely lucky 17:27:14 <09gammafunk> otherwise we'd have had parts of you corrupted in save files 17:27:25 <04dracoomega> ....oh no 17:27:35 <09gammafunk> was very hard to track down, as you can imagine 17:28:48 <04dracoomega> Yeah... 17:30:41 (new dungeon feature: transporter accidents 😛 ) 17:52:06 <|amethyst> ]d 18:33:47 <08nicolae> telefrags 18:34:18 <08nicolae> if a monster is standing on the output portal of a transporter, they get fragged. secret tech. except there's a chance that you get fragged instead. 21:18:54 <06pleasingfungus> @regret-⸸nde※ if you ever want a fun spare time project, it’d be great to remove necrophages from vaults (so i can remove em the rest of the way) 21:19:13 <06pleasingfungus> i have a branch which axes em but i got drowned in necro vaults 21:19:20 <06pleasingfungus> (some months ago) 21:45:20 <06regret-⸸nde※> I... had a little inclination for saving and using them as a Conflux option, but I had absolutely no plan for doing much to actually give them anything mechanically worthwhile outside of that and also Conflux is extremely far back on the priority list at this point 21:50:02 <06regret-⸸nde※> so I'll throw it onto the 0.32 list after the other matters 21:51:13 <06pleasingfungus> zero rush 22:12:42 <06regret-⸸nde※> oh right that'll also make super-early yred a bit noticeably stronger in the new thing 22:13:46 <04dracoomega> The more I think about it, the more I am regretting not just extending the companions struct, after you mentioned it, PF. It's like... I somehow just didn't even think that was an option at this point >.>; 22:35:09 <06pleasingfungus> sometimes one gets locked into a particular way of looking at things 🙂 23:27:18 <06pleasingfungus> progress... 23:27:18 <06pleasingfungus> https://cdn.discordapp.com/attachments/747522859361894521/1201050852731928676/image.png?ex=65c868c5&is=65b5f3c5&hm=e9432f4610f1d8fc28e30614fa0ccd14c1245a40fd5818c26e1de0db473ff4e2& 23:31:04 <06pleasingfungus> (probably this will eventually be reworded to "attuning" or "attaching", depending on theme) 23:31:54 <06regret-⸸nde※> still not happy with the various theme options? :P 23:32:24 <06pleasingfungus> think multiple options are plausible and none seem overwhelmingly best 23:36:51 <06regret-⸸nde※> (...discussing that with DO and now I'm just wondering how deeply silly it'd be to address the "why does the nature spirit possessing its gear still follow a human body plan for aux armour" concept with "you have four aux slots and can fill them with four hats or gloves or cloaks". probably a complete nightmare to code regardless, and two-weapon already was thta.) 23:49:56 <06pleasingfungus> have mercy on my poor soul 23:50:01 <06pleasingfungus> i am but a humble coder 23:56:35 <06pleasingfungus> important question: [ lists armour slots. (body, hands, etc.) If you have a weapon in your off-hand, should it be displayed in [, or should we match the behavior for wielding a 2-handed weapon and show the offhand slot as (currently unavailable)? 23:57:30 <06pleasingfungus> by important i mean not very important.