00:30:09 Unstable branch on cbro.berotato.org updated to: 0.31-a0-1591-g515db51633 (34) 00:54:44 Monster database of master branch on crawl.develz.org updated to: 0.31-a0-1591-g515db51633 01:38:13 Fork (bcrawl) on crawl.kelbi.org updated to: 0.23-a0-5140-g5775ae71e1 02:59:32 <03implojin> @dracoomega a player (Wizard1ke) reported a series of crashes on CPO earlier that look related to 5eddcf2448, it seems like tracer_nonenchantment_affect_monster is trying to divide by 0? at a glance, allowing those checks and assert to be bypassed with side_effect seems to be not okay for the related code; it might be a good idea to just revert 5eddcf2448 given that it's only a half-fix to begin with and this looks kind of fragile 03:00:20 <03implojin> https://crawl.project357.org/morgue/Wizard1ke/crash-Wizard1ke-20240106-062316.txt https://crawl.project357.org/morgue/Wizard1ke/crash-Wizard1ke-20240106-062907.txt https://crawl.project357.org/morgue/Wizard1ke/crash-Wizard1ke-20240106-073435.txt etc 04:23:34 Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-5140-g5775ae71e1 05:16:30 <04dracoomega> Oh, oops. -.- (Rather than revert, since that will restore the original bug, and I think a stopgap is reasonably appropriate in the short-term, I think what I should have done is just remember to add 'fake' damage to preac as well as final here) 05:18:17 <04dracoomega> Which was an oversight 05:19:59 03DracoOmega02 07* 0.31-a0-1592-gea8d852952: Avoid a divide-by-0 10(52 seconds ago, 1 file, 3+ 0-) 13https://github.com/crawl/crawl/commit/ea8d85295299 05:20:55 <04dracoomega> I find it strange that it never happened to me in testing, though 05:21:26 <04dracoomega> Since it does rather look like it should have always been dividing by 0 there 05:22:15 <04dracoomega> But it definitely worked fine in repeatedly testing different attacks in different situations 05:27:04 <03implojin> yeah i couldn't reproduce it locally but a git log grep on the > 0 asserts brought up https://crawl.develz.org/mantis/view.php?id=1014 and https://github.com/crawl/crawl/commit/c3939b18b22f81a7d58a3784bc38961a04e32c5d so it seems like similar problems have occurred with this code in the deep past 05:29:25 <04dracoomega> What I just pushed seems like it should be safe, though 05:29:36 Unstable branch on crawl.akrasiac.org updated to: 0.31-a0-1591-g515db51 (34) 05:34:46 Unstable branch on crawl.kelbi.org updated to: 0.31-a0-1592-gea8d852952 (34) 05:35:45 <03implojin> vaguely worried that those crashlogs looked like post and final were underflowing and the results of determine_damage shouldn't be getting used with postfixed hacks like this but i haven't really looked at this 05:36:32 <04dracoomega> ...oh, oh 05:36:52 <04dracoomega> Have I misread C syntax as int preac, post, final = 0; only setting final to 0 and not all of them? >.> 05:37:29 <04dracoomega> (You say 'postfixed hacks', but the thing is - the tracer needs some number to slot into power and the value of a non-damaging effect has to be worth some equivalent damage) 05:39:30 <04dracoomega> I think I need to flip the order, to ensure that determine_damage is called even if there's a side effect -.- 05:39:51 <04dracoomega> Or will the compiler be clever about this? 05:41:51 03DracoOmega02 07* 0.31-a0-1593-ge08a94be7c: Fix some more possibly-uninitialized variables 10(34 seconds ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/e08a94be7c24 05:42:38 modargo (L18 VSEn) Crash caused by signal #8: Floating point exception (Swamp:4) 05:45:26 <04dracoomega> CAO rebuild just missed the crashfix =/ 05:45:31 <04dracoomega> It had already been pushed, even 05:46:21 <04dracoomega> (I don't have credentials to trigger one myself) 05:47:13 Moanerette (L20 DjMo) Crash caused by signal #8: Floating point exception (Elf:1) 05:48:39 <03implojin> sorry, nobody ever setup rebuild permissions for me either -.- 05:49:51 Unstable branch on crawl.kelbi.org updated to: 0.31-a0-1593-ge08a94be7c (34) 05:50:10 <04dracoomega> =/ 05:50:52 <04dracoomega> I'd say "Why does C++ even let you use uninitialized variables like this?" but that's sure C being C >.> 05:51:12 <04dracoomega> Personally a fan of 'ints are always 0 if you don't say otherwise' 05:56:10 <04dracoomega> This seems like the kind of problem that really wants a forced rebuild, though. (I'm so sorry). Hope someone with permissions can see this before too long. 05:57:37 <03implojin> no need to apologize! it's fine, thank you for looking at it, everyone's doing their best, people can deal until it gets rebuilt 05:58:28 <03implojin> whenever you and index start talking about crawl dev things all i can think about is that the folks on the team 10 years ago must have been, uh, much higher tension about things 05:58:56 <03implojin> very glad that the community is mostly not like that now. 06:04:56 <04dracoomega> It was definitely a lot more... strife-filled back then, let's say >.> 06:20:16 When are attributes versus props appropriate 06:31:18 <04dracoomega> That is a question I have asked myself several times, including literally 15 minutes ago 06:32:12 <04dracoomega> I am not really sure the answer aside from the general trend in modern days to use props more than attributes. I think the former are also slightly easier on serializing? But also more boilerplate. I'm not 100% clear to me. 06:33:13 <04dracoomega> (Basically: we never need to keep around and dummy out props down the road, which is not true for attributes) 06:33:41 <04dracoomega> Props will still be serialized by name whether we define keys or not, and props that do nothing can linger harmlessly 06:34:09 <04dracoomega> (I assume props are slower to access and use, but like... not in a way that matters >.>) 07:02:12 Daek (L10 GrEE) Crash caused by signal #8: Floating point exception (D (Sprint)) 07:19:00 I think I'm going to always favor props then, since the pattern of 'element x in this array is this specific thing' is odious 07:22:55 dufus (L16 BaMo) Crash caused by signal #8: Floating point exception (D:13) 07:44:01 03dolorous02 07https://github.com/crawl/crawl/pull/3462 * 0.31-a0-1594-g85e95c8484: Save whether the dead player left a corpse. 10(13 hours ago, 1 file, 6+ 7-) 13https://github.com/crawl/crawl/commit/85e95c84848f 07:44:01 03dolorous02 07https://github.com/crawl/crawl/pull/3462 * 0.31-a0-1595-g450abf2931: Move simpler god death messages to the database. 10(13 hours ago, 2 files, 8+ 2-) 13https://github.com/crawl/crawl/commit/450abf2931ec 07:44:01 03dolorous02 07https://github.com/crawl/crawl/pull/3462 * 0.31-a0-1596-g603b428624: Save monster holiness for undead/nonliving. 10(12 hours ago, 1 file, 7+ 13-) 13https://github.com/crawl/crawl/commit/603b428624eb 07:44:01 03dolorous02 07https://github.com/crawl/crawl/pull/3462 * 0.31-a0-1597-g5868f4e57a: Put holiness god death msgs in the database. 10(11 hours ago, 2 files, 38+ 9-) 13https://github.com/crawl/crawl/commit/5868f4e57a53 07:44:01 03dolorous02 07https://github.com/crawl/crawl/pull/3462 * 0.31-a0-1598-gb700220111: Add database key handling to god death msgs. 10(11 hours ago, 2 files, 36+ 33-) 13https://github.com/crawl/crawl/commit/b7002201111e 07:44:01 03dolorous02 07https://github.com/crawl/crawl/pull/3462 * 0.31-a0-1599-g1147d75f39: Add Hepliaklqana and Ignis death messages. 10(10 hours ago, 2 files, 10+ 0-) 13https://github.com/crawl/crawl/commit/1147d75f39dd 07:44:01 03dolorous02 07https://github.com/crawl/crawl/pull/3462 * 0.31-a0-1600-g678edb9a25: Add C, J, R, and U death messages (Oneirical, #3452) 10(10 hours ago, 2 files, 36+ 0-) 13https://github.com/crawl/crawl/commit/678edb9a2590 08:12:29 Unstable branch on crawl.akrasiac.org updated to: 0.31-a0-1593-ge08a94be7c (34) 08:15:23 <06pleasingfungus> i rebuilt it. we should update the new dev checklist to include giving rebuild privileges, if it’s not there… 08:17:33 Graveyardigan (L17 MfSh) Crash caused by signal #8: Floating point exception (Elf:1) 08:18:19 <06pleasingfungus> !tell monkooky props are appropriate for something that is only occasionally relevant to an object. attributes are appropriate for something that exists on all or most objects. attributes are simpler to reference (not need to mess around with key strings) and provide type safety, so they’re nicer other than needing more boilerplate for marshalling/unmarshalling. 08:18:20 <04Cerebot> Maximum message length is 340 characters, but you had 349. Eschew verbosity, Gladys! 08:18:28 <06pleasingfungus> ha 08:18:33 <06pleasingfungus> so close 08:19:30 03dolorous02 07https://github.com/crawl/crawl/pull/3462 * 0.31-a0-1598-g7977c377bc: Add database key handling to god death msgs. 10(12 hours ago, 2 files, 36+ 33-) 13https://github.com/crawl/crawl/commit/7977c377bce6 08:19:30 03dolorous02 07https://github.com/crawl/crawl/pull/3462 * 0.31-a0-1599-geb10b7a202: Add Hepliaklqana and Ignis death messages. 10(10 hours ago, 2 files, 10+ 0-) 13https://github.com/crawl/crawl/commit/eb10b7a202f6 08:19:30 03dolorous02 07https://github.com/crawl/crawl/pull/3462 * 0.31-a0-1600-g0297b96042: Add C, J, R, and U death messages (Oneirical, #3452) 10(10 hours ago, 2 files, 36+ 0-) 13https://github.com/crawl/crawl/commit/0297b96042f6 08:28:10 Fidicinal (L6 MuNe) Crash caused by signal #8: Floating point exception (D:5) 08:31:48 <04dracoomega> Thanks 08:32:43 <04dracoomega> When you said 'all or most objects', I'm like "Attributes can exist on things that aren't the player? >.>" 08:35:23 so should serpent's lash be using a prop rather than an attribute? 08:35:56 AutarchDCSS (L21 GnAl) Crash caused by signal #8: Floating point exception (Depths:1) 08:39:15 <04dracoomega> I think once it already exists as an attribute, there's usually not much to gain by changing it to a prop? 08:39:35 <04dracoomega> Since we can't really remove the attribute anyway, only dummy it out 08:52:18 <06pleasingfungus> i would say it should be a prop but it’s not worth changing 08:52:33 <06pleasingfungus> we can remove attributes 08:59:14 Wait, doesn't removing attributes break save compat? 08:59:47 since it's an array with enum indices? 09:33:20 <06pleasingfungus> oh 09:33:30 <06pleasingfungus> i totally misunderstood this entire conversation 09:33:49 <06pleasingfungus> you’re talking about the antique attribute system, not about fields 09:33:54 <06pleasingfungus> i forgot that existed 09:34:28 <06pleasingfungus> yeah i vaguely suspect we should just remove attributes entirely and turn them all into props. 09:35:36 <04dracoomega> I appreciate the reduced boilerplate compared to props, but they obviously have multiple other downsids 09:37:49 <04dracoomega> (Cutting all the currently-used ones out sounds like a headache, though) 10:11:46 <06pleasingfungus> i’d have to look. it’s been some time since i thought about them 10:17:52 <04dracoomega> I mean, I don't think it's too conceptually complex, but it is a lot of busywork 10:59:51 What would that do to existing saves? 11:00:18 I don't have any sort of grasp of how saves work right now 11:16:23 <04dracoomega> Save compat code would mean that we'd still have to be able to read the attribute list from saves that contained it, even if it's immediately discarded (ie: know how big a block of save data we should skip over, when upgrading from the version that had it). Save compat code is actually pretty complicated and there's a whole lot of fixups for reading from different minor tags 11:16:45 <04dracoomega> Feel free to skim tags.cc if you want a general impression 11:17:07 <04dracoomega> (I've only ever done a fairly minor amount of save compat code myself) 12:07:13 New branch created: pull/3465 (1 commit) 13https://github.com/crawl/crawl/pull/3465 12:07:13 03yrdzrfxndfvh02 {GitHub} 07https://github.com/crawl/crawl/pull/3465 * 0.31-a0-1594-g82a5df10b7: Add "Royal Mummy" title 10(3 minutes ago, 1 file, 2+ 0-) 13https://github.com/crawl/crawl/commit/82a5df10b7a1 12:12:28 <06regret-⸸nde※> https://cdn.discordapp.com/attachments/747522859361894521/1193270878260170782/image.png?ex=65ac1b1b&is=6599a61b&hm=71cae80cf7d41d71ee1f15884d6177c2b59a4ae575ced392091baa2e33cb002f& 12:12:31 <06regret-⸸nde※> >_> 12:16:21 <06regret-⸸nde※> maybe if this is a placeholder versus the different portal display for 0.32 it'd be fine if I just use the fragile hack of checking where one is 12:29:31 <09gammafunk> it's a new terrain type, right? 12:29:55 <06regret-⸸nde※> looks like https://github.com/crawl/crawl/blob/master/crawl-ref/source/dat/descript/monsters.txt#L3298, last adjusted in 4ce4c22, is currently not working at all now 12:30:01 <09gammafunk> hrm, I guess it can't be if it's to lead to the same portal 12:30:37 <09gammafunk> the syntax for that might need to be you.in_branch(...) 12:31:06 <06regret-⸸nde※> I was using a vault feature rename for now, which is fine for the description of the actual feature, but branch and portal entries always place the description of the branch / portal after the feature's own description, and I was trying to update it to avoid confusion 12:31:23 <06regret-⸸nde※> doesn't work either 12:31:24 <06regret-⸸nde※> https://cdn.discordapp.com/attachments/747522859361894521/1193275642012238017/image.png?ex=65ac1f8b&is=6599aa8b&hm=36f9a2d9337ed9e2f3930b5f8d1a95b72b21e2048cf89dca1b7360574556c191& 12:31:42 <09gammafunk> I meant for the whitered plant entry, sorry 12:32:11 <06regret-⸸nde※> either both work or both fail 12:32:44 <06regret-⸸nde※> https://cdn.discordapp.com/attachments/747522859361894521/1193275979553054811/image.png?ex=65ac1fdb&is=6599aadb&hm=8291fc1ebf9da4823005984bbce65714ec5ffa4fcdcec2df0559015b5b752383& 12:36:06 <09gammafunk> this works for me: withered plant A plant whose life has been drained away, but with its physical form still intact. It looks like it died many {{ if you.branch() == "Crypt" or you.branch() == "Tomb" then return "centuries"; else return "years"; end }} ago. %%%% 12:36:33 <06regret-⸸nde※> if you generate them in-game, it always returns centuries 12:36:43 <06regret-⸸nde※> regardless of where one is 12:36:53 <09gammafunk> not for me 12:37:18 <09gammafunk> dungeon 12:37:18 <09gammafunk> https://cdn.discordapp.com/attachments/747522859361894521/1193277128091910215/image.png?ex=65ac20ed&is=6599abed&hm=51dfccc4fc0a7e6ab06dc5c17b4e8f7f9d3956b9faf80fc9df06c477d08ec189& 12:37:32 <06regret-⸸nde※> is it being placed by vault? 12:37:38 <09gammafunk> crypt 12:37:39 <09gammafunk> https://cdn.discordapp.com/attachments/747522859361894521/1193277215576699000/image.png?ex=65ac2102&is=6599ac02&hm=cdbb9c83162988158398d5aea1e1724638fa2218ff442dc477826ffd2cef6721& 12:37:44 <09gammafunk> no, placed via wizmode monster 12:37:58 <06regret-⸸nde※> ...that is not what shows up here in tiles 12:38:03 <09gammafunk> gah 12:38:15 <04dracoomega> I am getting 'centuries' in Depths and D myself 12:38:24 <04dracoomega> For what it's worth 12:38:30 <09gammafunk> I am in a full debug build 12:38:36 <09gammafunk> also in wizard mode, obviously 12:38:43 <06regret-⸸nde※> building console now 12:41:02 <09gammafunk> it also seems that the lua in that 4ce4c22 commit was wrong regardless, since you.branch() only ever returns the branch string and accepts no arguments (the dlua you.in_branch(...) function does of course accept an argument) 12:41:12 <09gammafunk> and you.branch() is clua 12:43:09 <09gammafunk> looks like I also get the right respective results when using ?/ in D/Crypt 12:47:04 <06regret-⸸nde※> https://cdn.discordapp.com/attachments/747522859361894521/1193279590060269729/withered.gif?ex=65ac2338&is=6599ae38&hm=9f9f3ed4612dd44c2b4638fe081374e9b1bd6017cd4f0950648c167883b94e74& 13:00:33 <09gammafunk> do you have my corrected code above? because it does work for me 13:00:58 <09gammafunk> and does not work in latest trunk without that fix (doing what you have there) 13:02:30 <09gammafunk> https://cdn.discordapp.com/attachments/747522859361894521/1193283472480010452/Screencast_from_01-06-2024_020125_PM.webm?ex=65ac26d5&is=6599b1d5&hm=0a45ad457052b3b49acb05703b87e2df2a12fa737d4e10533524cd8fede4641e& 13:03:24 <09gammafunk> I can test the rename of ice caves but I'd need the relevant code 13:04:04 <06regret-⸸nde※> ...missed part of the syntax 13:04:10 <06regret-⸸nde※> working now 13:54:54 03regret-index02 07* 0.31-a0-1594-ge0997bbf37: Placeholder: rename + retile hard mode ice cave entries 10(15 minutes ago, 6 files, 27+ 5-) 13https://github.com/crawl/crawl/commit/e0997bbf375b 13:54:54 03regret-index02 07* 0.31-a0-1595-g3d35757396: Nudge up kobold blastminer ranged damage (Monkooky) 10(86 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/3d3575739603 13:54:54 03regret-index02 07* 0.31-a0-1596-g300232130d: Adjust a few small monster bits 10(60 seconds ago, 2 files, 47+ 37-) 13https://github.com/crawl/crawl/commit/300232130d9b 14:31:07 Unstable branch on crawl.kelbi.org updated to: 0.31-a0-1596-g300232130d (34) 14:42:59 03nlavsky02 07* 0.31-a0-1597-ge7908ec95f: fix: don't gain extra lives after losing gems 10(3 minutes ago, 1 file, 1+ 0-) 13https://github.com/crawl/crawl/commit/e7908ec95f56 14:51:18 Unstable branch on crawl.kelbi.org updated to: 0.31-a0-1597-ge7908ec95f (34) 15:41:55 <06pleasingfungus> sigh 15:50:27 <09gammafunk> good commit title 15:50:45 <09gammafunk> at least it was only a note! 16:27:04 Unstable branch on underhound.eu updated to: 0.31-a0-1597-ge7908ec95f (34) 18:51:36 03dolorous02 07https://github.com/crawl/crawl/pull/3462 * 0.31-a0-1598-g6d62b8d381: Save whether the dead player left a corpse. 10(24 hours ago, 1 file, 6+ 7-) 13https://github.com/crawl/crawl/commit/6d62b8d3817b 18:51:36 03dolorous02 07https://github.com/crawl/crawl/pull/3462 * 0.31-a0-1599-g4d82cf719a: Move simpler god death messages to the database. 10(24 hours ago, 2 files, 8+ 2-) 13https://github.com/crawl/crawl/commit/4d82cf719adb 18:51:36 03dolorous02 07https://github.com/crawl/crawl/pull/3462 * 0.31-a0-1600-gb4579a723b: Save monster holiness for undead/nonliving. 10(23 hours ago, 1 file, 7+ 13-) 13https://github.com/crawl/crawl/commit/b4579a723b8e 18:51:36 03dolorous02 07https://github.com/crawl/crawl/pull/3462 * 0.31-a0-1601-g8901f2ba20: Put holiness god death msgs in the database. 10(23 hours ago, 2 files, 38+ 9-) 13https://github.com/crawl/crawl/commit/8901f2ba209c 18:51:36 03dolorous02 07https://github.com/crawl/crawl/pull/3462 * 0.31-a0-1602-g327e37cdcb: Add database key handling to god death msgs. 10(22 hours ago, 2 files, 36+ 33-) 13https://github.com/crawl/crawl/commit/327e37cdcbd3 18:51:36 03dolorous02 07https://github.com/crawl/crawl/pull/3462 * 0.31-a0-1603-ga7bf3d6772: Make giving death messages to gods w/o them easy. 10(16 minutes ago, 1 file, 22+ 0-) 13https://github.com/crawl/crawl/commit/a7bf3d677219 18:51:36 03dolorous02 07https://github.com/crawl/crawl/pull/3462 * 0.31-a0-1604-gd433a5f13e: Add Hepliaklqana and Ignis death messages. 10(12 minutes ago, 1 file, 8+ 0-) 13https://github.com/crawl/crawl/commit/d433a5f13edd 18:51:36 03dolorous02 07https://github.com/crawl/crawl/pull/3462 * 0.31-a0-1605-g2a8f6ed23b: Add C, J, R, and U death messages (Oneirical, #3452) 10(9 minutes ago, 1 file, 32+ 0-) 13https://github.com/crawl/crawl/commit/2a8f6ed23bf5 19:04:10 New branch created: pull/3466 (1 commit) 13https://github.com/crawl/crawl/pull/3466 19:04:10 03910rd02 07https://github.com/crawl/crawl/pull/3466 * 0.31-a0-1594-g26704b5715: Add tiles for martyr's knell shade and spell icon (#3463) 10(2 hours ago, 4 files, 2+ 1-) 13https://github.com/crawl/crawl/commit/26704b57151b 19:09:24 03dolorous02 07https://github.com/crawl/crawl/pull/3462 * 0.31-a0-1603-gce9a8925ec: Make giving death messages to gods w/o them easy. 10(34 minutes ago, 1 file, 40+ 16-) 13https://github.com/crawl/crawl/commit/ce9a8925ec91 19:09:24 03dolorous02 07https://github.com/crawl/crawl/pull/3462 * 0.31-a0-1604-gaeea0a5a0f: Add Hepliaklqana and Ignis death messages. 10(30 minutes ago, 1 file, 8+ 0-) 13https://github.com/crawl/crawl/commit/aeea0a5a0fd7 19:09:24 03dolorous02 07https://github.com/crawl/crawl/pull/3462 * 0.31-a0-1605-g9f793edda5: Add C, J, R, and U death messages (Oneirical, #3452) 10(27 minutes ago, 1 file, 32+ 0-) 13https://github.com/crawl/crawl/commit/9f793edda5ed 19:12:19 <04dracoomega> For what it's worth, I'm not really a fan of recoloring the shade a lot closer to spectrals. 19:12:49 <04dracoomega> Which can plausibly frequently co-exist 19:13:21 <04dracoomega> (Also, the tile was deliberately colored similar to the glyph it uses in console, not that this is super critical on its own) 19:21:39 Ah, I see. I didn't look at the console glyph. I can resubmit with just a (possibly different) spell icon if it is intended to keep the shade as is. 19:21:42 All of the player-castable summoning spells, including Necro/Summon like Haunt, also consistently follow the "summoning circle underneath" convention (even if some of the monster-only summons haven't been updated to do so) 19:22:58 That was one of the things I was thinking of changing. 19:24:33 (I'm aware that Malign Gateway is an exception, but it is unique in general) 19:26:59 <08wormsofcan> how many of the new spells need icons 19:27:20 <08wormsofcan> I should have some time to make a few of them tomorrow night 19:31:20 03dolorous02 07https://github.com/crawl/crawl/pull/3462 * 0.31-a0-1603-gf64b8bfb08: Make giving death messages to gods w/o them easy. 10(56 minutes ago, 1 file, 46+ 24-) 13https://github.com/crawl/crawl/commit/f64b8bfb081a 19:31:20 03dolorous02 07https://github.com/crawl/crawl/pull/3462 * 0.31-a0-1604-g9609e55931: Add Hepliaklqana and Ignis death messages. 10(52 minutes ago, 1 file, 8+ 0-) 13https://github.com/crawl/crawl/commit/9609e5593184 19:31:20 03dolorous02 07https://github.com/crawl/crawl/pull/3462 * 0.31-a0-1605-g177d264079: Add C, J, R, and U death messages (Oneirical, #3452) 10(49 minutes ago, 1 file, 32+ 0-) 13https://github.com/crawl/crawl/commit/177d26407906 19:40:44 03dolorous02 07https://github.com/crawl/crawl/pull/3462 * 0.31-a0-1603-gcae4b6563c: Make giving death messages to gods w/o them easy. 10(65 minutes ago, 1 file, 51+ 24-) 13https://github.com/crawl/crawl/commit/cae4b6563cdc 19:40:44 03dolorous02 07https://github.com/crawl/crawl/pull/3462 * 0.31-a0-1604-g3585dba15b: Add Hepliaklqana and Ignis death messages. 10(62 minutes ago, 1 file, 8+ 0-) 13https://github.com/crawl/crawl/commit/3585dba15b64 19:40:44 03dolorous02 07https://github.com/crawl/crawl/pull/3462 * 0.31-a0-1605-ga67567fc41: Add C, J, R, and U death messages (Oneirical, #3452) 10(58 minutes ago, 1 file, 32+ 0-) 13https://github.com/crawl/crawl/commit/a67567fc418d 19:48:10 to my eyes, Fugue of the Fallen feels like the largest thematic discrepancy from the Wereblood icon it uses 19:53:29 <04dracoomega> Oh, right. I was actually going to say "Most of these were replacing existing spells, and while the new icons are not necessarily a perfect match - ie: Call Canine Familiar doesn't show an inugami, but still shows a dog - are probably still okay" but that one also is a bit off 19:53:38 <04dracoomega> Somehow I forgot about it 19:53:44 does Mercury Vapours need more than a recolor? 19:54:18 but yes, besides Martyr's Knell, no spell is entirely without a unique icon, if only one from a previous version 19:54:34 <04dracoomega> I'm not convinced it even needs that, tbh 19:54:41 fair enough 19:55:51 <06regret-⸸nde※> https://en.wikipedia.org/wiki/Mercury-vapor_lamp#/media/File:MercuryVaporLamp.jpg funnily enough, it turns out looking up the words "mercury vapour" brings up green lamps :P 20:01:36 03dolorous02 07https://github.com/crawl/crawl/pull/3462 * 0.31-a0-1603-g3f4accc1d5: Make all gods use death messages if available. 10(86 minutes ago, 1 file, 32+ 42-) 13https://github.com/crawl/crawl/commit/3f4accc1d5ea 20:01:36 03dolorous02 07https://github.com/crawl/crawl/pull/3462 * 0.31-a0-1604-g1dca230640: Add Hepliaklqana and Ignis death messages. 10(82 minutes ago, 1 file, 8+ 0-) 13https://github.com/crawl/crawl/commit/1dca230640f9 20:01:36 03dolorous02 07https://github.com/crawl/crawl/pull/3462 * 0.31-a0-1605-g5656c794d5: Add C, J, R, and U death messages (Oneirical, #3452) 10(79 minutes ago, 1 file, 32+ 0-) 13https://github.com/crawl/crawl/commit/5656c794d5fc 20:06:50 03dolorous02 07https://github.com/crawl/crawl/pull/3462 * 0.31-a0-1603-g5bb1703b8b: Make all gods use death messages if available. 10(2 hours ago, 1 file, 36+ 42-) 13https://github.com/crawl/crawl/commit/5bb1703b8bbd 20:06:50 03dolorous02 07https://github.com/crawl/crawl/pull/3462 * 0.31-a0-1604-g5ceb535e22: Add Hepliaklqana and Ignis death messages. 10(88 minutes ago, 1 file, 8+ 0-) 13https://github.com/crawl/crawl/commit/5ceb535e22be 20:06:50 03dolorous02 07https://github.com/crawl/crawl/pull/3462 * 0.31-a0-1605-g3058f1cc6e: Add C, J, R, and U death messages (Oneirical, #3452) 10(85 minutes ago, 1 file, 32+ 0-) 13https://github.com/crawl/crawl/commit/3058f1cc6e84 20:07:12 <06regret-⸸nde※> (...now I'm just wondering if a short fulminant gold first-hand-source quote could be found use for fulminant prism, to help explain the school shift) 20:23:32 03dolorous02 07https://github.com/crawl/crawl/pull/3462 * 0.31-a0-1603-g9a044b5da3: Make all gods use death messages if available. 10(2 hours ago, 1 file, 38+ 44-) 13https://github.com/crawl/crawl/commit/9a044b5da303 20:23:32 03dolorous02 07https://github.com/crawl/crawl/pull/3462 * 0.31-a0-1604-gc58f8df60a: Add Hepliaklqana and Ignis death messages. 10(2 hours ago, 1 file, 8+ 0-) 13https://github.com/crawl/crawl/commit/c58f8df60aed 20:23:32 03dolorous02 07https://github.com/crawl/crawl/pull/3462 * 0.31-a0-1605-g47d5ec106a: Add C, J, R, and U death messages (Oneirical, #3452) 10(2 hours ago, 1 file, 32+ 0-) 13https://github.com/crawl/crawl/commit/47d5ec106a4c 20:40:27 -!- The topic of #crawl-dev is: Crawl Development | https://github.com/crawl/crawl | Logs: http://s-z.org/crawl-dev/, temporarily http://crawl.akrasiac.org/logs/cheibriados/ | People with +v have commit access, devs on bridged discord as well | General Crawl-related chat to #crawl | Long stuff to a pastebin service, please 20:40:28 -!- The topic of #crawl is: Play Dungeon Crawl Stone Soup online now! Type ??online for instructions, ??lg / !lg for play stats | PM Sequell for long queries | http://crawl.develz.org | FooTV game replays: ??footv for instructions | #crawl-dev for dev discussion, #crawl-offtopic for offtopic 21:10:36 <09gammafunk> hrm, batch qw just exited with 21:10:51 <09gammafunk> > crawl/crawl-ref/source/dat/des/branches/crypt.des:718: Map 'nicolae_crypt_fancy_cubbyholes' has no (possible) exits; use TAGS: no_exits if this is intentional 21:11:01 <09gammafunk> anything change about that vault recently? 21:55:20 What's the checklist for spell creation, presuming I don't want it to do anything or be actually present 22:04:48 <03implojin> huh, kind of surprised we don't have a standalone spell creation checklist in docs/develop 22:05:29 <03implojin> anyway i'd cross reference some recentish commits that added new spells: plasma beam looks like a pretty straightforward one: https://github.com/crawl/crawl/commit/5a111fc481b5a4c9010f6aded76d8e19689f7794 22:07:54 03910rd02 07https://github.com/crawl/crawl/pull/3466 * 0.31-a0-1595-g0e02ee6698: reverted Martyr's Knell shade tile and updated spell icon 10(89 seconds ago, 2 files, 0+ 0-) 13https://github.com/crawl/crawl/commit/0e02ee6698de 22:11:33 <06regret-⸸nde※> the vault was only recently added and- 22:11:45 <06regret-⸸nde※> oh. it can nsubst the @ into the middle of the vault and not the edge 22:12:06 <06regret-⸸nde※> 'll push a fix once I'm done eating 22:37:08 03regret-index02 07* 0.31-a0-1598-g94871bc2e8: Fix an occasional connectivity bug 10(54 seconds ago, 1 file, 5+ 5-) 13https://github.com/crawl/crawl/commit/94871bc2e865 22:49:39 Unstable branch on crawl.kelbi.org updated to: 0.31-a0-1598-g94871bc2e8 (34) 23:02:10 03PleasingFungus02 07* 0.31-a0-1599-g1b3c7e429d: Fix sturdy frame description (acrobat) 10(2 minutes ago, 1 file, 2+ 1-) 13https://github.com/crawl/crawl/commit/1b3c7e429d1d 23:19:23 Unstable branch on crawl.kelbi.org updated to: 0.31-a0-1599-g1b3c7e429d (34) 23:26:11 03PleasingFungus02 07* 0.31-a0-1600-g17a54de940: Refactor Sigil of Binding 10(19 minutes ago, 1 file, 22+ 24-) 13https://github.com/crawl/crawl/commit/17a54de94008 23:26:11 03PleasingFungus02 07* 0.31-a0-1601-ga0385a40c4: Fix bound monsters being swappable (acrobat) 10(78 seconds ago, 4 files, 19+ 9-) 13https://github.com/crawl/crawl/commit/a0385a40c4e2 23:29:01 <04dracoomega> Funny, when I saw Fix bound monsters being swappable I was like "I am positive I made sure they were not" but uh... as you note, seemingly only for monsters swapping with other monsters 23:31:25 03PleasingFungus02 07* 0.31-a0-1602-g1c3f895ad5: Limit GDR application (DracoOmega) 10(2 minutes ago, 1 file, 6+ 8-) 13https://github.com/crawl/crawl/commit/1c3f895ad50c 23:33:36 right 23:33:36 I've added a new spell that does nothing. 23:33:37 I'm getting crash on launch. 23:33:37 I have no idea how to diagnose this, since the crash logs are entirely useless 23:35:17 Unstable branch on crawl.develz.org updated to: 0.31-a0-1599-g1b3c7e429d (34) 23:35:56 <04dracoomega> Crash logs on windows are pretty useless. I assume there's no assert at the top of it? 23:36:44 <04dracoomega> Because if there's any visible error at all, I might be able to help 23:36:50 <04dracoomega> Have added lots of spells in my day ^^; 23:37:01 oh wow yeah ok 23:37:05 I am blind 23:37:23 so it's apparently neither a monspell nor a player spell? 23:37:41 (spell 'Wizard Pinball' is not declared as a monster spell but is not a player spell) 23:37:58 <04dracoomega> Put it in a spellbook. Any book. 23:38:07 <04dracoomega> That is what the game uses to determine that it's properly a player spell 23:38:15 incredible 23:38:51 I was specifically not doing that to minimize the places that could error >:( 23:38:56 <04dracoomega> (There is technically a way to have it count as a player spell without that - which is used by some 'fake' spells like demonspawn Hurl Damnation - but putting it in a book is simplest here) 23:39:38 <04dracoomega> Make sure that the spells in books are sorted in spell level order, though! 23:39:43 <04dracoomega> Or that will also assert >.> 23:40:49 03PleasingFungus02 07* 0.31-a0-1603-gbec6b6ccbf: Fix: don't crash in \ (lowenheim) 10(48 seconds ago, 1 file, 4+ 1-) 13https://github.com/crawl/crawl/commit/bec6b6ccbf85 23:40:49 <06regret-⸸nde※> if only we could make several other things assert when they weren't properly sorted 23:41:12 <04dracoomega> Frankly, I would rather fewer asserts for cosmetic-only problems >.> 23:41:17 <04dracoomega> If anything 23:41:31 <06regret-⸸nde※> but then we'd get around to all the other sorting needed in the one go! 23:41:37 <06regret-⸸nde※> nothing bad could possibly go wrong with this 23:56:02 Unstable branch on crawl.kelbi.org updated to: 0.31-a0-1601-ga0385a40c4 (34) 23:57:58 Windows builds of master branch on crawl.develz.org updated to: 0.31-a0-1603-gbec6b6ccbf 23:58:17 <06pleasingfungus> closed a dozen issues tonight 23:58:18 <06pleasingfungus> feeling good