00:26:26 Unstable branch on cbro.berotato.org updated to: 0.31-a0-1278-g11c5b68f87 (34) 00:54:48 Monster database of master branch on crawl.develz.org updated to: 0.31-a0-1278-g11c5b68f87 01:32:42 Fork (bcrawl) on crawl.kelbi.org updated to: 0.23-a0-5140-g5775ae71e1 03:44:53 03regret-index02 07* 0.31-a0-1279-gad7a08865a: Buff and shorten Vitrify, update UI around it, spread it a little more 10(10 minutes ago, 8 files, 31+ 25-) 13https://github.com/crawl/crawl/commit/ad7a08865a5a 03:44:53 03regret-index02 07* 0.31-a0-1280-g1fbed5ca12: Juggle arcanist and occultist spells one last time, hopefully 10(8 minutes ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/1fbed5ca1206 04:05:01 Unstable branch on crawl.kelbi.org updated to: 0.31-a0-1280-g1fbed5ca12 (34) 04:22:03 Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-5140-g5775ae71e1 05:22:08 Unstable branch on crawl.akrasiac.org updated to: 0.31-a0-1280-g1fbed5c (34) 06:34:53 @regret-index: Dude, not trying to be rude here but each of your commits reads like a background story for an anime character/political manifesto. 06:34:53 If one of you fine gentlemen would be so kind as to tell him if he stops by. Thank you. 06:34:54 -A stand-in for random players who actually read the commits 07:58:02 <03w​heals> players complaining about too much communication from the devs, that's a new one 08:05:31 <05i​coson> bizarre 08:06:19 <05i​coson> also, kinda not ok actually 08:10:48 <05i​coson> given the commit message by r-i that I've read (which are v good, seem like appropriate lengths to me) that comment appears to be not actually about the commit messages 08:27:39 I actually wonder if given how minimally devs are in this channel it might be good to set something like +R on it, I'm not sure webchat / drive-bys are adding much value 08:33:15 <06p​leasingfungus> sounds reasonable 09:16:50 <09g​ammafunk> Does +R affect botessa? 09:17:16 <09g​ammafunk> Have to check if it authentictes 09:37:55 <05i​coson> It only affects public stuff but yeah we’d have to check the bots 09:51:28 <09g​ammafunk> I seem to recall it does Auth, but am on mobile. It runs on cdo if anyone wants to check 11:04:58 -!- elliptic_ is now known as elliptic 11:57:44 03elliptic02 07* 0.31-a0-1281-ge6b85068f3: Don't let Kiku wrath drain all the player's MHP in a single turn (Oneirical) 10(5 minutes ago, 1 file, 1+ 2-) 13https://github.com/crawl/crawl/commit/e6b85068f384 12:04:02 Unstable branch on crawl.kelbi.org updated to: 0.31-a0-1281-ge6b85068f3 (34) 13:12:51 03PleasingFungus02 07* 0.31-a0-1282-g2402ceb476: Remove orc gem 10(8 minutes ago, 6 files, 21+ 38-) 13https://github.com/crawl/crawl/commit/2402ceb47680 13:14:56 03DracoOmega02 07[full_merger_alchemist] * 0.31-a0-1274-gcad9028a1e: Decouple the Plutonium Sword from transmutation miscasts 10(22 minutes ago, 2 files, 25+ 50-) 13https://github.com/crawl/crawl/commit/cad9028a1ea0 13:14:56 03DracoOmega02 07[full_merger_alchemist] * 0.31-a0-1275-gb01c5a3c83: Provisional titles for Alchemy 10(22 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/b01c5a3c830b 13:14:56 03DracoOmega02 07[full_merger_alchemist] * 0.31-a0-1276-g4df2a6c0f9: Adjust randbook words for Alchemy 10(44 seconds ago, 1 file, 83+ 208-) 13https://github.com/crawl/crawl/commit/4df2a6c0f93e 13:15:59 03PleasingFungus02 07* 0.31-a0-1283-gcef503e1cc: Remove $ (regret-index) 10(80 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/cef503e1cc08 13:19:07 03PleasingFungus02 07* 0.31-a0-1284-g03ee008336: Make malign offering less noisy (Hal) 10(2 minutes ago, 1 file, 2+ 1-) 13https://github.com/crawl/crawl/commit/03ee00833658 13:41:16 04Build failed for 08full_merger_alchemist @ 4df2a6c0 06https://github.com/crawl/crawl/actions/runs/7240761738 13:43:08 03PleasingFungus02 07* 0.31-a0-1285-gb2fffa6d40: Increase Tomb gem time (Oneirical) 10(72 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/b2fffa6d40a8 13:46:16 03PleasingFungus02 07* 0.31-a0-1286-gdddd49282e: Tweak some gem colours 10(33 seconds ago, 1 file, 3+ 3-) 13https://github.com/crawl/crawl/commit/dddd49282e82 13:50:57 Unstable branch on crawl.kelbi.org updated to: 0.31-a0-1283-gcef503e1cc (34) 14:05:38 Unstable branch on crawl.kelbi.org updated to: 0.31-a0-1286-gdddd49282e (34) 14:21:44 03DracoOmega02 07[full_merger_alchemist] * 0.31-a0-1277-g4c5f37bd53: Maybe fix tag upgrade build? 10(57 seconds ago, 1 file, 2+ 0-) 13https://github.com/crawl/crawl/commit/4c5f37bd5347 14:45:55 04Build failed for 08full_merger_alchemist @ 4c5f37bd 06https://github.com/crawl/crawl/actions/runs/7241073687 14:49:54 03regret-index02 07* 0.31-a0-1287-g2f004bd33d: Fix some absent gems and a crystalized boss. 10(44 seconds ago, 7 files, 74+ 69-) 13https://github.com/crawl/crawl/commit/2f004bd33df0 14:53:31 <06r​egret-⸸nde※> draco's not managing to entirely figure out why alchemist branch keeps failing builds, she can't reproduce the tag_update errors and manually updating tag to check that produces an unsurprising number of other issues 15:05:34 Unstable branch on crawl.kelbi.org updated to: 0.31-a0-1287-g2f004bd33d (34) 15:29:08 The game is supposed to compile with a different major version, so it's likely that each issue needs to be fixed. 15:43:07 03regret-index02 07* 0.31-a0-1288-g8606b069a1: Double klown pie Vitrify (flugkiller) 10(48 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/8606b069a147 15:43:07 03regret-index02 07* 0.31-a0-1289-gcfba0412b6: Bump up Bai Suzhen's transformation threshhold a little. 10(40 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/cfba0412b659 15:43:07 03regret-index02 07* 0.31-a0-1290-g4d4119cd44: Buff protean progenitors in various differing ways 10(4 minutes ago, 3 files, 13+ 10-) 13https://github.com/crawl/crawl/commit/4d4119cd4476 15:43:07 03regret-index02 07* 0.31-a0-1291-g5386780bc2: Re-order alligator attacks 10(11 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/5386780bc24c 15:48:01 <03s​emi_tonal> my guess would be that it's because it doesn't update util/art-data.pl, so there's a mismatch when it tries to map ARTP properties in some way? 15:50:38 <03s​emi_tonal> art-data.pl generates all the unrand definitions from art-data.txt, i haven't looked fully into it but it has mappings for each type of spell enhancer so those would presumably need to be adjusted to account for the changes 15:50:40 Unstable branch on crawl.kelbi.org updated to: 0.31-a0-1291-g5386780bc2 (34) 16:14:25 03PleasingFungus02 07* 0.31-a0-1292-g0cff9e4079: Wizmode: show item value in xv 10(2 minutes ago, 1 file, 1+ 0-) 13https://github.com/crawl/crawl/commit/0cff9e407986 16:14:25 03PleasingFungus02 07* 0.31-a0-1293-g5190ab2d73: Add a price for artefact spell enhancers 10(67 seconds ago, 1 file, 5+ 0-) 13https://github.com/crawl/crawl/commit/5190ab2d731e 16:19:48 Unstable branch on crawl.kelbi.org updated to: 0.31-a0-1293-g5190ab2d73 (34) 16:25:26 Unstable branch on underhound.eu updated to: 0.31-a0-1291-g5386780bc2 (34) 16:27:30 art-data.pl doesn't seem to consider versions at all, so it would only work if you changed the makefile or added "#if TAG_MAJOR_VERSION = 34\n" and the like into @art_order in the script. 16:28:20 "== 34", that is. 16:31:35 <06r​egret-⸸nde※> draco sends her thanks in pointing towards art-data.pl 16:33:14 <06p​leasingfungus> @regret-⸸nde※ fyi that my last shopping change will also need a tweak for the school merger, sorry 16:42:20 There's also a transmutation reference in describe.cc, and spschool in spl-util.h isn't supposed to have gaps. 16:44:43 03DracoOmega02 07[full_merger_alchemist] * 0.31-a0-1278-g8c2574dfc5: Another attempt at fixing tag upgrade compilation 10(43 seconds ago, 3 files, 28+ 9-) 13https://github.com/crawl/crawl/commit/8c2574dfc556 16:54:15 04Build failed for 08full_merger_alchemist @ 8c2574df 06https://github.com/crawl/crawl/actions/runs/7241741820 17:15:01 03PleasingFungus02 07* 0.31-a0-1294-g1c27f8a97b: Don't fear Zot 10(35 minutes ago, 1 file, 1+ 5-) 13https://github.com/crawl/crawl/commit/1c27f8a97bae 17:15:01 03PleasingFungus02 07* 0.31-a0-1295-g407de8339a: Hide clock for held gems by default (elliptic) 10(22 minutes ago, 8 files, 54+ 18-) 13https://github.com/crawl/crawl/commit/407de8339a5f 17:18:09 New branch created: alchemfix (7 commits) 13https://github.com/crawl/crawl/tree/alchemfix 17:18:09 03DracoOmega02 07[alchemfix] * 0.31-a0-1273-gc7f3d483f9: Merge Poison Magic and Transmutations into a single school: Alchemy 10(20 hours ago, 81 files, 260+ 274-) 13https://github.com/crawl/crawl/commit/c7f3d483f9db 17:18:09 03DracoOmega02 07[alchemfix] * 0.31-a0-1274-gcad9028a1e: Decouple the Plutonium Sword from transmutation miscasts 10(4 hours ago, 2 files, 25+ 50-) 13https://github.com/crawl/crawl/commit/cad9028a1ea0 17:18:09 03DracoOmega02 07[alchemfix] * 0.31-a0-1275-gb01c5a3c83: Provisional titles for Alchemy 10(4 hours ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/b01c5a3c830b 17:18:09 03DracoOmega02 07[alchemfix] * 0.31-a0-1276-g4df2a6c0f9: Adjust randbook words for Alchemy 10(4 hours ago, 1 file, 83+ 208-) 13https://github.com/crawl/crawl/commit/4df2a6c0f93e 17:18:09 03DracoOmega02 07[alchemfix] * 0.31-a0-1277-g4c5f37bd53: Maybe fix tag upgrade build? 10(3 hours ago, 1 file, 2+ 0-) 13https://github.com/crawl/crawl/commit/4c5f37bd5347 17:18:09 03DracoOmega02 07[alchemfix] * 0.31-a0-1278-g8c2574dfc5: Another attempt at fixing tag upgrade compilation 10(34 minutes ago, 3 files, 28+ 9-) 13https://github.com/crawl/crawl/commit/8c2574dfc556 17:18:09 03regret-index02 07[alchemfix] * 0.31-a0-1279-gf261fb1073: Adjust various vaults with Tmut/Pois books and Pois staves 10(6 seconds ago, 10 files, 21+ 22-) 13https://github.com/crawl/crawl/commit/f261fb1073c1 17:21:18 03PleasingFungus02 07* 0.31-a0-1296-g8770774cb4: Fix hiding lost unvisited gems (CarefulOdds) 10(88 seconds ago, 1 file, 5+ 2-) 13https://github.com/crawl/crawl/commit/8770774cb4d7 17:23:24 03PleasingFungus02 07* 0.31-a0-1297-g0d254b9dff: Continue removing gems from descent 10(82 seconds ago, 1 file, 2+ 1-) 13https://github.com/crawl/crawl/commit/0d254b9dffa0 17:24:26 Branch full_merger_alchemist updated to be equal with alchemfix: 13https://github.com/crawl/crawl/tree/full_merger_alchemist 17:36:33 So, as I continue to try to stamp out various technical issues with the spell school merger, I've run into this worrisome issue. Save file upgrading from previous versions seems to work fine the majority of the time, but just a *few* of them crash on load with `ASSERT(item.base_type != OBJ_BOOKS) in 'artefact.cc' at line 1141 failed.` as it 17:36:33 unmarshalls items and I currently have no idea why. 17:40:47 In fact, one of them seems to lock up wsl whenever it happens, making me restart the whole thing 17:44:31 <06p​leasingfungus> DracoOmega: i can try to take a look in a bit, hopefully 🤞 17:45:15 <06p​leasingfungus> can you post the full crash log, and/or a save that causes this crash? quite hard to investigate without those 17:45:39 04Build failed for 08alchemfix @ f261fb10 06https://github.com/crawl/crawl/actions/runs/7241930788 17:48:57 Unstable branch on crawl.kelbi.org updated to: 0.31-a0-1295-g407de8339a (34) 17:51:24 <06r​egret-⸸nde※> https://cdn.discordapp.com/attachments/747522859361894521/1186108418382106624/test.cs?ex=65920c8b&is=657f978b&hm=b0c20a6a657b198cf4c636a2a6433a4ae5a7976d4ce1834c7db759bafc0da86c& 17:51:25 <06r​egret-⸸nde※> https://cdn.discordapp.com/attachments/747522859361894521/1186108418872844368/crash-test-20231217-212056.txt?ex=65920c8b&is=657f978b&hm=518b797063f76080959af6cb43c0b12cd194adf9fb45b684f45b33251b42f492& 17:51:38 <06r​egret-⸸nde※> ...nice display of the save, discord 17:51:48 04Build failed for 08full_merger_alchemist @ f261fb10 06https://github.com/crawl/crawl/actions/runs/7241973846 17:52:16 <06r​egret-⸸nde※> ...curses. 17:52:37 03PleasingFungus02 07* 0.31-a0-1298-g0c0848231e: Darken non-present monster resists 10(54 seconds ago, 1 file, 6+ 2-) 13https://github.com/crawl/crawl/commit/0c0848231e78 17:53:21 I sure wish that I could figure out how to make these debug statements print to console. Or to *anything* for that matter >.> 17:55:39 <06p​leasingfungus> you want the lower level cpp printf function 17:55:59 That was the first thing I tried, and it produced nothing 17:56:12 <06p​leasingfungus> interesting 17:56:29 <06p​leasingfungus> also condolences re developing on windows 17:56:32 (Apparently `fprintf(stderr,` finally is something that functions, though) 17:56:51 Hey, printf *did* work on actual Windows builds. It stopped working since I've been using WSL :P 17:57:16 Well, the item at least is a transmutations randbook 17:57:47 This is not terribly surprising, though I still don't know why it would take a codepath that books aren't expected to take, since the game clearly still thinks it's a book 17:59:42 Okay, one of these other crashes is a randart necromancy book, actually. 17:59:56 03regret-index02 07[full_merger_alchemist] * 0.31-a0-1280-g76d0e41253: Catch another old transmutations vault 10(60 seconds ago, 1 file, 4+ 23-) 13https://github.com/crawl/crawl/commit/76d0e412530a 18:04:36 Unstable branch on crawl.kelbi.org updated to: 0.31-a0-1298-g0c0848231e (34) 18:05:06 04Build failed for 08full_merger_alchemist @ 76d0e412 06https://github.com/crawl/crawl/actions/runs/7242219305 18:08:37 grep -r -E 'poison\|transmutation' dat/des # 🙂 18:09:37 ...wait, I think I found it and it's silly 18:09:59 actually that doesn't need the backslash 18:10:11 Very silly error, if I'm right 18:10:33 <06r​egret-⸸nde※> I was relying too much on crawl actually just loading up (non-lua) vaults and complaining when there's a changed item >_> 18:10:40 <06r​egret-⸸nde※> but of course crawl doesn't actually load the sprints 18:15:09 <06p​leasingfungus> that fix does look promising 🙂 18:15:36 03DracoOmega02 07[full_merger_alchemist] * 0.31-a0-1281-g3eb493e74c: Fix some crashes on upgrading saves 10(2 minutes ago, 1 file, 1+ 0-) 13https://github.com/crawl/crawl/commit/3eb493e74c05 18:15:36 Yes, it's so straightforward and every other bit of similar code is doing the same thing. I probably even copy-pasted it at first, but somehow it got lost 18:15:40 <06p​leasingfungus> (sorry, am back on mobile once more for a while) 18:15:59 <06p​leasingfungus> seems like there should be helper code to make that simpler 18:16:13 Can't help but wonder if it's ACTUALLY a good idea to asset on polling artifact properties if this just means people need to check everywhere 18:16:14 <06p​leasingfungus> ‘is this a non-book artefact with property x’? 18:16:20 <06p​leasingfungus> or that yes 18:16:41 <06p​leasingfungus> could just have artefact property return 0 for non artefacts or non books 18:16:47 If the player somehow equipped a book on their head and the book gained a property that does something, that's already a huge other problem 18:17:05 And the problem is not that we asked the book if it gives regeneration 18:18:16 <06p​leasingfungus> indeed 🙂 18:20:56 04Build failed for 08full_merger_alchemist @ 3eb493e7 06https://github.com/crawl/crawl/actions/runs/7242325442 18:56:16 New branch created: pull/3398 (2 commits) 13https://github.com/crawl/crawl/pull/3398 18:56:16 03David Lawrence Ramsey02 07https://github.com/crawl/crawl/pull/3398 * 0.31-a0-1299-g9e92c07184: Properly message when you're vitrified more. 10(16 minutes ago, 1 file, 2+ 0-) 13https://github.com/crawl/crawl/commit/9e92c071840d 18:56:16 03David Lawrence Ramsey02 07https://github.com/crawl/crawl/pull/3398 * 0.31-a0-1300-g4001583846: Make initial monster vitrify messages end in "!". 10(12 minutes ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/4001583846d2 22:33:58 03regret-index02 07[full_merger_alchemist] * 0.31-a0-1282-g62d7c604a9: Some hopefully last Poison / Transmutations catches 10(63 seconds ago, 6 files, 12+ 13-) 13https://github.com/crawl/crawl/commit/62d7c604a993 22:37:16 04Build failed for 08full_merger_alchemist @ 62d7c604 06https://github.com/crawl/crawl/actions/runs/7244074372 22:39:23 ayayaya (L23 OpVM) ERROR in 'tags.cc' at line 5035: Invalid item: (quantity: 0) gold piece (D:13) 22:46:30 03PleasingFungus02 07* 0.31-a0-1299-g9785b71c3f: Simplify some inugami code and fix a minor bug 10(20 minutes ago, 4 files, 44+ 53-) 13https://github.com/crawl/crawl/commit/9785b71c3f6b 22:46:30 03PleasingFungus02 07* 0.31-a0-1300-gb6740aa4e6: Fix a sneaky inugami bug 10(6 minutes ago, 4 files, 8+ 4-) 13https://github.com/crawl/crawl/commit/b6740aa4e6d4 23:09:33 Unstable branch on crawl.kelbi.org updated to: 0.31-a0-1300-gb6740aa4e6 (34) 23:23:00 03DracoOmega02 07[full_merger_alchemist] * 0.31-a0-1283-g939801ae12: Fix a test failure 10(27 seconds ago, 1 file, 10+ 0-) 13https://github.com/crawl/crawl/commit/939801ae1201 23:28:21 04Build failed for 08full_merger_alchemist @ 939801ae 06https://github.com/crawl/crawl/actions/runs/7244423061 23:35:05 Unstable branch on crawl.develz.org updated to: 0.31-a0-1300-gb6740aa4e6 (34) 23:57:20 Windows builds of master branch on crawl.develz.org updated to: 0.31-a0-1300-gb6740aa4e6