00:44:30 Fork (bcrawl) on crawl.kelbi.org updated to: 0.23-a0-5014-gf9597c7f93 03:22:35 Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-5014-gf9597c7f93 05:24:47 Unstable branch on crawl.akrasiac.org updated to: 0.31-a0-740-g87205ac (34) 05:42:15 Behavioral (L27 VSAr) ASSERT(type == (SV_INT)) in 'store.cc' at line 885 failed. (Lair:5) 05:42:42 Behavioral (L27 VSAr) ASSERT(type == (SV_INT)) in 'store.cc' at line 885 failed. (Lair:5) 05:43:01 Behavioral (L27 VSAr) ASSERT(type == (SV_INT)) in 'store.cc' at line 885 failed. (Lair:5) 05:44:43 Behavioral (L27 VSAr) ASSERT(type == (SV_INT)) in 'store.cc' at line 885 failed. (Lair:5) 05:45:10 Behavioral (L27 VSAr) ASSERT(type == (SV_INT)) in 'store.cc' at line 885 failed. (Lair:5) 06:56:47 <06pleasingfungus> oops, i broke save compat 07:50:59 NinjaNoafa (L8 FeSu) ASSERT(type == (SV_INT)) in 'store.cc' at line 885 failed. (D:6) 08:43:15 <06pleasingfungus> !crashlog Behavioral 08:43:16 <04Cerebot> 20. Behavioral, XL27 VSAr, T:52877 (milestone): https://crawl.kelbi.org/crawl/morgue/Behavioral/crash-Behavioral-20230912-124453.txt 09:04:22 03PleasingFungus02 07* 0.31-a0-741-gbe3b949103: Fix save compat? 10(58 seconds ago, 1 file, 7+ 0-) 13https://github.com/crawl/crawl/commit/be3b949103ae 09:11:36 04Build failed for 08master @ be3b9491 06https://github.com/crawl/crawl/actions/runs/6161992025 09:21:00 Unstable branch on crawl.kelbi.org updated to: 0.31-a0-741-gbe3b949103 (34) 09:22:10 03PleasingFungus02 07* 0.31-a0-742-g4b8cbeaf33: Fix tag upgrade build? 10(41 seconds ago, 1 file, 2+ 0-) 13https://github.com/crawl/crawl/commit/4b8cbeaf33f0 09:27:12 <05icoson> re how that could happen, prior to cb44df74be13a448 that prop was set with mons->props[MONSTER_TILE_KEY] = mspec.props[MONSTER_TILE_KEY].get_short(); which I think will force type short 09:35:05 <06pleasingfungus> yeah, i was just a bit confused that the fix-up code i’d tried to add into tags.cc didn’t have any effect 09:35:12 <06pleasingfungus> assume i overlooked something silly 09:37:20 <05icoson> ah, I see 09:37:46 <05icoson> hm, the original fixup code seems to be conditioned on a bunch of stuff 09:38:10 <05icoson> if (m.props.exists(MONSTER_TILE_NAME_KEY)) and also some tileidx stuff 09:38:21 <05icoson> probably just needs to happen unconditionally? 09:38:52 <05icoson> well, conditioned on it being set and type short 09:39:31 <05icoson> I also don't 100% know what m.props[MONSTER_TILE_KEY] = int(index); will do if it's already set and is a short? 09:48:55 04Build failed for 08master @ 4b8cbeaf 06https://github.com/crawl/crawl/actions/runs/6162184864 09:58:40 Unstable branch on crawl.akrasiac.org updated to: 0.31-a0-742-g4b8cbeaf33 (34) 10:06:57 03PleasingFungus02 07* 0.31-a0-743-g45f7035092: Continue removing Stuck 10(21 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/45f7035092f0 10:07:46 <06pleasingfungus> yeah, i did set it up unconditionally, but possibly there's something weird happening with it already being set as a short - maybe i needed to clear it before re-setting it as an int 10:11:01 Unstable branch on crawl.kelbi.org updated to: 0.31-a0-742-g4b8cbeaf33 (34) 10:15:46 <05icoson> are you sure? all I'm seeing is in the scope of if (m.props.exists(MONSTER_TILE_NAME_KEY)) and an else for some other conditional 10:17:11 <05icoson> well, the inner conditional doesn't matter 10:18:59 <06pleasingfungus> to be clear 10:19:04 <06pleasingfungus> i didn't merge the code change to tags.cc 10:19:08 <06pleasingfungus> since it didn't work when i tested it locally 10:19:15 <05icoson> ahhh 10:20:09 <06pleasingfungus> sorry for confusion 10:21:11 Unstable branch on cbro.berotato.org updated to: 0.31-a0-743-g45f7035092 (34) 10:21:12 <06pleasingfungus> the bug is super easy to repro, just take a meatsprint save from before the marshlight change (like this one) and load it up (without the hacky save compat thing i added in the commit we're talking about) 10:21:13 <06pleasingfungus> https://cdn.discordapp.com/attachments/747522859361894521/1151205888326123661/Bimoguas.cs 10:21:14 Unstable branch on crawl.kelbi.org updated to: 0.31-a0-743-g45f7035092 (34) 12:06:52 <05icoson> it looks like there are two places to consider doing the fixup and the one that is necessary (at least for that save) is not the most obvious one 12:07:27 <05icoson> doesn't appear that store objects would need to be reset to change type (which is surprising to me, but we) 12:11:32 03advil02 07* 0.31-a0-744-gbc345e7fcb: fix: tags.cc fixup for monster tile prop type change 10(2 minutes ago, 2 files, 14+ 7-) 13https://github.com/crawl/crawl/commit/bc345e7fcbdd 12:22:40 Unstable branch on crawl.kelbi.org updated to: 0.31-a0-744-gbc345e7fcb (34) 12:36:58 <06pleasingfungus> thanks! 15:26:04 Unstable branch on underhound.eu updated to: 0.31-a0-744-gbc345e7fcb (34) 19:33:24 03hellmonk02 07[descentmessage] * 0.31-a0-739-g044040c7cc: better peek status fix 10(67 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/044040c7ccd7 19:37:40 <06pleasingfungus> @hellmonk ha, i forgot delver 19:37:43 <06pleasingfungus> nice fix 19:37:44 <09hellmonk> me too 19:37:50 <09hellmonk> until literally 3 minutes ago 19:38:22 <09hellmonk> conveniently remembered just as I was finding out that absdepth isn't in player 19:39:56 <09hellmonk> only things left on my list atm are stair color coding and X[ bug, then it will be time for whatever grand branch restructuring thing you have planned 19:55:23 <06pleasingfungus> oh boy 21:55:46 New branch created: pull/3301 (4 commits) 13https://github.com/crawl/crawl/pull/3301 21:55:46 Branch pull/3301 updated to be equal with descentmessage: 13https://github.com/crawl/crawl/pull/3301 22:35:13 Unstable branch on crawl.develz.org updated to: 0.31-a0-744-gbc345e7fcb (34) 22:57:44 Windows builds of master branch on crawl.develz.org updated to: 0.31-a0-744-gbc345e7fcb 23:16:23 Unstable branch on cbro.berotato.org updated to: 0.31-a0-744-gbc345e7fcb (34) 23:54:59 Monster database of master branch on crawl.develz.org updated to: 0.31-a0-744-gbc345e7fcb