00:38:44 Fork (bcrawl) on crawl.kelbi.org updated to: 0.23-a0-5014-gf9597c7f93 01:11:08 http://crawl.akrasiac.org/rawdata/aesen/aesen.txt 01:11:54 game can't be resumed (?), clicking on Descent (experimental) in webtiles on cao brings up the new character menu 01:12:27 doesn't look like the run is over though 01:15:37 <03implojin> @aesen: that's likely related to the change in save slot handling for descent mode 01:15:51 <03implojin> >even after changing save slots there's still some bug with the cao lobby I can't figure out in the time I have, but I just disabled the save info display. Any games started prior to the rebuild I just did would need to be accessed manually via http://crawl.akrasiac.org:8080/#play-dcss-git 01:17:01 yeah that worked 01:17:17 <03implojin> oh, sorry, forgot i can't edit messages through the irc bridge, the save slot thing would only apply if you began the game earlier 01:17:24 <03implojin> glad to hear it 01:17:45 lobby says its dcss-git now lol 01:18:16 <03implojin> yeah that handling is very likely bugged for descent games that existed prior to the save slot change, kate had to manually delete at least one descent game locally 01:18:39 cool thanks, guess ill have to finish this one then 03:23:25 Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-5014-gf9597c7f93 05:02:38 03kate-02 07* 0.31-a0-692-gf03d1854d5: Clarify shop wording when going in to debt in Descent 10(16 hours ago, 1 file, 19+ 6-) 13https://github.com/crawl/crawl/commit/f03d1854d57e 05:03:41 New branch created: okawaru_gifts (2 commits) 13https://github.com/crawl/crawl/tree/okawaru_gifts 05:03:41 03kate-02 07[okawaru_gifts] * 0.31-a0-693-g18ae0ed89d: Remove Okawaru's weapon/armour gifting 10(2 weeks ago, 2 files, 9+ 28-) 13https://github.com/crawl/crawl/commit/18ae0ed89dbd 05:03:41 03kate-02 07[okawaru_gifts] * 0.31-a0-694-g9b18df5199: Give Okawaru a capstone of weapon/armour acquirement 10(12 days ago, 10 files, 155+ 20-) 13https://github.com/crawl/crawl/commit/9b18df51995b 05:04:53 <03semi_tonal> will probably poke at that a little more before merging but it's pretty much ready to go i think, the messaging could be better on gaining/losing the abilities 05:05:37 <03semi_tonal> and maybe i'll be inspired to really dive into the acquirement code and make it more complicated/combine them into a single tied ability where you pick multiple items or something but i think the straightforward approach is also fine 05:07:51 Unstable branch on crawl.akrasiac.org updated to: 0.31-a0-692-gf03d185 (34) 05:19:08 Unstable branch on crawl.kelbi.org updated to: 0.31-a0-692-gf03d1854d5 (34) 05:20:26 <05icoson> I’m not sure if this is practical but I wonder if offering a few weaker gifts earlier in addition would keep more of the current playfeel, eg something medium at 3*? 05:24:30 <03semi_tonal> possibly, although testing this mainly reminder me of how unexciting oka gifts typically actually are 05:26:44 <03semi_tonal> like, obviously you do get good stuff by virtue of seeing a bunch, but on average they are not very good, the acquirement-level capstone on its own seems like better overall lootfeel maybe 06:55:57 <08wormsofcan> oh question about the new oka capstone, when does it pick the items, is there some funny incentive to keep piety under 6* or not examine the ability until you're ready to commit to the item selection 06:58:08 <08wormsofcan> also is there a "really acquire an item while floating over lava/deep water?" check 07:18:13 <09gammafunk> This was a question I had as well, is acquirement quality being used and is that higher than normal oka quality? And is oka quality just normal floor quality? 07:19:15 <09gammafunk> Is acquirement quality being used in the branch, and is that different from current oka quality, I should say 07:20:15 <03semi_tonal> it's using acquirement quality which is significantly better than normal oka quality, yeah 07:20:36 <09gammafunk> The knee-jerk reactions I saw completely ignored gift quality differences between the two systems of course 07:21:53 <03semi_tonal> and it uses the acquirement scroll interface so you the items are picked when you activate the ability, and you can back out if you don't want to decide yet (although it does need a deep water check it looks like, since that seems to be handled separately for scroll acquirement) 07:26:45 -!- elliptic_ is now known as elliptic 09:15:48 <05icoson> possibly some excitement/playfeel from oka before this change does come from very occasionally getting exciting things early (not trying to say that giving a lot of junk to accomplish this makes much sense) 09:16:30 <05icoson> a lot of the kneejerk reactions are maybe ultimately about the loss of this 09:17:27 kate: darn it, did you write an acquirement-like menu for god gifting? I wanted one in '22 and had to write my own 09:18:46 ??oka[attic] 09:18:46 okawaru[5/6]: I picture oka as this old guy going through his attic and just discarding old junk as gifts 09:20:36 <06pleasingfungus> ??okawaru[FAN 09:20:37 <04Cerebot> okawaru[6/6]: < valrus> I AM OKAWARU, GOD OF COMBAT AND FIVE DOLLARS FOR THE OSCILLATING FAN IS MY FINAL OFFER 09:20:52 <09hellmonk> Let okawaru gift a -2 hat at every piety level 09:20:59 <09hellmonk> Big op buff 09:39:17 <09gammafunk> We still need to deduplicate menu code for acquirement 09:40:01 <09gammafunk> When I wrote the menu years ago it was easiest to copy a fairly large amount of code 09:40:49 <09gammafunk> Oh actually never mind 09:41:24 <09gammafunk> That was a problem with exegesis maybe? The other menu I made 09:42:02 <09gammafunk> It's been so long since both exegesis and "new" acquirement that I've forgotten 09:42:40 <05icoson> iirc I've done at least some refactoring of it as part of other menu work 09:43:15 <09gammafunk> Nice 09:43:33 <09gammafunk> Maybe current state is fine then 09:43:46 <05icoson> %git b7493b8c6f3f 09:43:48 <04Cerebot> advil * 0.29-a0-940-gb7493b8c6f: feat: add CMD_MENU_EXAMINE and support code (1 year, 2 months ago, 18 files, 384+ 271-) https://github.com/crawl/crawl/commit/b7493b8c6f3f 09:43:49 <05icoson> and so on 10:26:38 <13qwqwqwqwqwqwqw> you don't currently get weapon/armour gifts until 5 stars and I suspect without the gift timeout from that you will get to 6 stars quite soon after that, so I think this change probably actually makes it MORE likely to get exciting things early, not less 10:26:38 qw-keys activated 10:26:57 <13qwqwqwqwqwqwqw> wow, good sequell 10:26:57 qw-keys deactivated 10:41:48 <13qwqwqwqwqwqwqw> you should really think of this type of oka change as frontloading gifts anyway, i.e. making them more exciting/powerful early but then you don't get to accumulate tons of great stuff over the course of the game 10:49:09 <13qwqwqwqwqwqwqw> (having 2 really exceptional oka gifts still equipped at the end of a 3-rune game is quite standard, so this change is certainly a nerf to the quality of gear that endgame oka characters end up with - but the piety savings that can be used on abilities are probably very substantial, and I suspect oka will need a bunch of tweaking after a change like this) 12:06:39 <06pleasingfungus> @dracoomega looks like we're good to merge hexslinger changes whenever you are, btw 12:06:58 <06pleasingfungus> probably want to squash and clean up commits slightly first 12:12:46 <04dracoomega> Since I've never done it before, I heard it was bad policy to squash or rebase anything that had ever been pushed publicly since it messes with everyone else's view of history and can cause all sorts of funky problems. Or did you mean like... take the commits in that branch, squash all major things related to one spell (and its subsequent bugfixes) into a single topical commit and then push that to master directly instead of merging 12:12:47 in the current state of the hexslinger branch on github? 12:17:38 in general it's expected for PR branches 12:19:09 <06pleasingfungus> yes, exactly "did you mean like" 12:19:24 <06pleasingfungus> that might be a pain to do properly, so it'd also be fine to squash everything in one monster commit 12:19:31 <06pleasingfungus> one commit per spell would be ideal but it might be a pain to untangle 12:20:17 <04dracoomega> I think it should be fine. By a rule, I do that a lot internally before I push anything, so I'm used to that sort of disentangling ^^; 12:20:53 <06pleasingfungus> sounds good 🙂 12:21:13 <04dracoomega> I'll stab at that in a little bit 12:32:21 Where would i find the randart generation code 12:35:10 <06pleasingfungus> artefact.cc 12:35:59 <06pleasingfungus> https://github.com/crawl/crawl/blob/master/crawl-ref/source/artefact.cc#L883 this is probably a reasonable place to start 12:37:42 thanks mate 12:39:31 i need it for my dnd campaign 12:43:56 <06pleasingfungus> huh 12:43:57 <06pleasingfungus> have fun! 12:46:25 its got a wacky tone 12:47:27 and stuff like this +5 flail of Cheese {spect, rPois Int+5 Dex-5} will just make it better 12:48:39 <06pleasingfungus> if you want the names, you want, uh 12:49:25 <06pleasingfungus> https://github.com/crawl/crawl/blob/master/crawl-ref/source/dat/database/rand_wpn.txt https://github.com/crawl/crawl/blob/master/crawl-ref/source/dat/database/rand_all.txt https://github.com/crawl/crawl/blob/master/crawl-ref/source/dat/database/rand_arm.txt this gets you most names 12:49:42 <06pleasingfungus> and the list of properties is right above the code i linked to in artefact.cc 13:07:27 i found those in game files 13:07:33 thanks for the hhelp 13:36:15 <05icoson> I bet it would be possible to write a lua script that would just generate a bunch of randart names 14:29:15 <05icoson> oh god, so much more about game mode than I realized is hardcoded in dgamelaunch-config 14:33:50 <06pleasingfungus> oh no 14:37:08 <05icoson> it's all straightforward to fix but I think because of this servers will need more finicky updates than I realized to enable descent (possibly none of this except the launcher script matters) 15:05:41 <09gammafunk> I really need to get that one branch I made merged 15:25:11 Unstable branch on underhound.eu updated to: 0.31-a0-692-gf03d1854d5 (34) 16:44:45 <04dracoomega> Well, this took hours of busywork. I hope I fixed the last of the squashing problems correctly, but I've stopped seeing anything out of place with it, anyway 16:45:15 03DracoOmega02 07* 0.31-a0-693-g574d41e441: Add Sigil of Binding: new level 3 Hexes spell 10(2 weeks ago, 27 files, 270+ 8-) 13https://github.com/crawl/crawl/commit/574d41e44171 16:45:15 03DracoOmega02 07* 0.31-a0-694-g470c21bd56: Replace (player) Portal Projectile with Dimensional Bullseye 10(2 weeks ago, 32 files, 184+ 53-) 13https://github.com/crawl/crawl/commit/470c21bd5633 16:45:15 03DracoOmega02 07* 0.31-a0-695-g74abd10e9e: Experimental spell: Jinxbite (level 2 Hexes) 10(2 weeks ago, 18 files, 280+ 16-) 13https://github.com/crawl/crawl/commit/74abd10e9e24 16:45:15 03DracoOmega02 07* 0.31-a0-696-ga7a09d1bdf: Make Inner Flame irresistable, downscale damage and clouds based on power 10(12 days ago, 8 files, 52+ 7-) 13https://github.com/crawl/crawl/commit/a7a09d1bdf03 16:45:15 03DracoOmega02 07* 0.31-a0-697-g9db281c723: Change Hexslinger starting spells 10(2 weeks ago, 1 file, 4+ 3-) 13https://github.com/crawl/crawl/commit/9db281c7239a 16:45:15 03DracoOmega02 07* 0.31-a0-698-g4a7cf283bb: Fix splitting/merging of creatures sharing some enchants it should not 10(2 days ago, 1 file, 16+ 2-) 13https://github.com/crawl/crawl/commit/4a7cf283bb64 17:06:45 04Build failed for 08master @ 4a7cf283 06https://github.com/crawl/crawl/actions/runs/6103558012 17:18:07 Unstable branch on crawl.kelbi.org updated to: 0.31-a0-698-g4a7cf283bb (34) 17:24:57 tag_upgrade failure, plus a warning about misleading indentation that might mean unbrace is called for 17:40:27 <04dracoomega> Weird. I actually did run unbrace on this first 17:41:34 <04dracoomega> Darn it 17:41:59 <04dracoomega> I tried not to miss things, I swear. This is what happens when you turn ~26 commits into 6 in a different order, I guess >.> 17:42:35 <04dracoomega> Something about bullseye is still using portal projectile values heere 17:46:27 <04dracoomega> This function seems to be very different than the last state of hexslinger_changes branch and I don't know how that happened =/ 17:59:37 03hellmonk02 07[dededescent] * 0.31-a0-693-gaab0cb133d: feat: Shorten D to 12 floors (Descent) 10(12 minutes ago, 1 file, 5+ 0-) 13https://github.com/crawl/crawl/commit/aab0cb133d95 17:59:37 03hellmonk02 07[dededescent] * 0.31-a0-694-g33988ae154: fix debt bugs 10(66 seconds ago, 1 file, 3+ 2-) 13https://github.com/crawl/crawl/commit/33988ae15466 17:59:37 03hellmonk02 07[dededescent] * 0.31-a0-695-gf3963ef552: checkwhite 10(58 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/f3963ef5524f 17:59:47 <09gammafunk> @dracoomega congrats on getting it all prepared and merged! Will get a lot more playtesting now that it's in trunk 18:04:47 <04dracoomega> Thanks! Just need to unbreak things now! >.> 18:04:57 <04dracoomega> And hope nothing else got messed up by rebasing 18:05:14 <04dracoomega> (Also: still itching to see the other new spells I pushed be used, tbh ^^; ) 18:15:20 03DracoOmega02 07* 0.31-a0-699-g830162fb6c: Fix something that got broken by Dimensional Bullseye rebase earlier 10(18 minutes ago, 1 file, 22+ 88-) 13https://github.com/crawl/crawl/commit/830162fb6ccc 18:19:23 Unstable branch on crawl.kelbi.org updated to: 0.31-a0-699-g830162fb6c (34) 18:22:12 <06pleasingfungus> i still need to review the reaver thing 18:29:37 04Build failed for 08dededescent @ f3963ef5 06https://github.com/crawl/crawl/actions/runs/6104086350 18:33:21 unbrace 18:33:37 ng-init.cc 18:42:34 03hellmonk02 07[dededescent] * 0.31-a0-696-g8e5232ede9: rework descent delver 10(3 minutes ago, 1 file, 5+ 0-) 13https://github.com/crawl/crawl/commit/8e5232ede952 18:42:34 03hellmonk02 07[dededescent] * 0.31-a0-697-g7c049a0fb4: unbrace 10(3 minutes ago, 1 file, 0+ 2-) 13https://github.com/crawl/crawl/commit/7c049a0fb4f4 18:58:18 03gammafunk02 07* 0.31-a0-700-gf13585253f: feat: Add a more convenient exit to a WizLab (elliptic) 10(3 minutes ago, 1 file, 6+ 6-) 13https://github.com/crawl/crawl/commit/f13585253f7a 19:04:27 Unstable branch on crawl.kelbi.org updated to: 0.31-a0-700-gf13585253f (34) 19:07:35 <04dracoomega> Polymorph code is nonsense 19:08:46 <04dracoomega> Like, there's a bunch more about it that's nonsense than this, but:cpp switch (power) { case PPT_LESS: return tgt_pow > src_pow - 3 + relax * 3 / 2 || (power == PPT_LESS && tgt_pow < src_pow - relax / 2); 19:08:59 <04dracoomega> I like how these case statements have conditionals that check whether or not they're still under the right case label 19:10:36 <06pleasingfungus> it’s very bad 19:11:27 <04dracoomega> I did a bunch of git blames moving backwards on it to see where some of it came from, and the core of it is from the initial revision and not changed since 19:11:30 <06pleasingfungus> i hope you enjoy my more modern poly stuff stuck in the middle 19:12:00 <04dracoomega> I frankly am tempted to rip it out and do something more sane with it 19:12:45 <04dracoomega> Like I realize it's a behavioral change, but at the same time, an effect that is textually and explicitly supposed to result in lower HD forms probably shouldn't frequently result in higher HD ones 19:12:55 <06pleasingfungus> like i think the code for /poly is okish 19:12:58 <04dracoomega> In very unintuitive ways because the code is weird to read 19:13:34 <04dracoomega> This also has weird shapeshifter effects. Since the odds of going up/down HD directly correlates to the number of monsters that exist at different HDs 19:13:52 <04dracoomega> Which is probably what results in shapeshifters often just going down over time 19:14:19 <04dracoomega> Poly wands seem fine these days, mostly, sure 19:15:30 <04dracoomega> I think Degeneration card for Nemelex is way too common a pull from decks of destruction anyway, but also: turning a death yak into a quicksilver dragon from a card that explicitly tells it to turn into something weaker feels very... um... not great, imo 19:18:09 <04dracoomega> Instead of all this 'pick a random monster and test if it's okay, with weird randomized sliding tolerance on what 'okay' means the longer we take at this', I don't think I see why the code can't just enumerate all valid monsters within its randomized HD tolerance scale and then just pick one of them 19:19:01 <04dracoomega> Which is a lot clearer code to read, has better guarantees where we want guarantees, and doesn't have its odds become lopsided just based on what monsters happen to exist 19:33:09 <06pleasingfungus> sure 19:33:15 <06pleasingfungus> think that’s correct 19:33:32 <06pleasingfungus> just need someone to take the time to refactor it 23:53:02 Unstable branch on cbro.berotato.org updated to: 0.31-a0-700-gf13585253f (34)