00:36:17 Fork (bcrawl) on crawl.kelbi.org updated to: 0.23-a0-5014-gf9597c7f93 00:43:46 <08wormsofcan> did a review of nem cards and I noticed two things that should probably be fixed 00:43:57 <08wormsofcan> first one is here: https://github.com/crawl/crawl/blob/7ca08c1ff9a91e13451e31d97905eb84a85ab6d3/crawl-ref/source/decks.cc#L1178 00:45:00 <08wormsofcan> it looks like orb always does the ood spam effect at power level 0 and 2, and a regular ood at level 1, that doesn't seem intended (I think old orb did old mystic blast at level 1) 00:45:24 <08wormsofcan> er, level 0, not 1 00:45:48 <08wormsofcan> second oddity is here: https://github.com/crawl/crawl/blob/7ca08c1ff9a91e13451e31d97905eb84a85ab6d3/crawl-ref/source/decks.cc#L1377 00:46:43 <08wormsofcan> this seems to be a leftover from when rangers had 4 tiers of summons, this line of code would upgrade one of the summons to a higher tier if it only summoned two monsters 00:47:13 <08wormsofcan> but currently this code doesn't seem to do anything and can probably be removed 00:49:38 <08wormsofcan> commit that changed how rangers work for reference: https://github.com/crawl/crawl/commit/01ebcbcbcd56af9a65b74bb76e181550a8263005 00:56:31 <08wormsofcan> yeah looks like old orb did not do orb spam at power level 0 because it didn't use the ZAP_IOOD beam (it used ZAP_ISKENDERUNS_MYSTIC_BLAST) which got removed when the spell was removed 03:19:29 -!- node11_ is now known as Tiktik 03:23:45 Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-5014-gf9597c7f93 05:07:17 Unstable branch on crawl.akrasiac.org updated to: 0.31-a0-618-g7ca08c1 (34) 07:46:09 AdnanSaban (L4 GrFi) Crash caused by signal #6: Aborted (D:4) 07:47:09 AdnanSaban (L4 GrFi) Crash caused by signal #6: Aborted (D:4) 08:05:29 03PleasingFungus02 07[great-magnetic-field] * 0.31-a0-646-g5b5cb7e6c2: Crumbling fixes 10(2 minutes ago, 1 file, 3+ 2-) 13https://github.com/crawl/crawl/commit/5b5cb7e6c20e 08:10:24 AdnanSaban (L4 GrFi) Crash caused by signal #6: Aborted (D:4) 08:14:34 04Build failed for 08great-magnetic-field @ 5b5cb7e6 06https://github.com/crawl/crawl/actions/runs/5940630730 08:52:03 <05icoson> hm, game types can't be removed from the enum https://github.com/crawl/crawl/blame/great-magnetic-field/crawl-ref/source/game-type.h#L12 without breaking the save browser (not just a matter of save compat) 08:52:39 <05icoson> fixing that will break all existing saves higher than that in the enum 08:52:48 <05icoson> which hopefully doesn't matter at this point? 08:53:37 <05icoson> I would push a fix but I'm not super familiar with exactly where that branch is 08:55:16 <05icoson> but, please don't leave that #ifdef in when merging 🙂 08:55:19 <05icoson> also, basic question about that branch: what's the thinking re stairs situations that put you in a complete mess (e.g. I just got pikel + menkaure + an gnoll pack in an open area on D:4 08:57:05 <06pleasingfungus> just push a fix please 08:57:25 <06pleasingfungus> see my second to last commit 08:57:45 <06pleasingfungus> basically you get rift wizard previews 08:58:01 <06pleasingfungus> you can peek down stone stairs freely before committing to one 09:00:08 <05icoson> oh, huh, I really did not notice that the stair stayed put 09:00:13 <05icoson> before action 09:01:26 <05icoson> wonder if there's some ui way to signal that (perhaps would want a configurable way to get a y/n prompt before an action?) 09:03:23 <05icoson> also, duh, that won't affect existing saves, sorry 09:03:27 <05icoson> it's a tag upgrade issue only 09:04:01 03advil02 07[great-magnetic-field] * 0.31-a0-647-gf7c4d81134: fix: tag upgrade CI fix 10(2 minutes ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/f7c4d8113473 09:05:30 <09hellmonk> I guess we can remove extra protection from monsters starting in los of the stairs now 09:06:01 <06pleasingfungus> probably yeah 09:15:21 <05icoson> heh if there was supposed to be that, it might not have been working 09:16:14 <05icoson> tbf menkaure only came into view when I tried to reposition 09:28:09 <05icoson> one idea might be to have a "peeking" (or w/e) status light 09:50:01 <06pleasingfungus> status light sounds reasonable 09:50:02 <06pleasingfungus> into that 09:51:04 03PleasingFungus02 07* 0.31-a0-619-gb34f6ce469: Remove unused AOOP code 10(33 seconds ago, 2 files, 0+ 14-) 13https://github.com/crawl/crawl/commit/b34f6ce469da 10:21:23 03nicolae02 07* 0.31-a0-620-gd1cbd99268: Fix up spacing, punctuation, etc. in a quote 10(77 seconds ago, 1 file, 3+ 3-) 13https://github.com/crawl/crawl/commit/d1cbd99268b7 10:24:32 03PleasingFungus02 07[great-magnetic-field] * 0.31-a0-648-gc1281f503d: Ironman stairs tweaks (advil) 10(2 minutes ago, 8 files, 56+ 30-) 13https://github.com/crawl/crawl/commit/c1281f503d5a 10:32:42 Unstable branch on crawl.kelbi.org updated to: 0.31-a0-619-gb34f6ce469 (34) 10:44:53 <05icoson> possibly that "no sense waiting" change would apply to intentional shafts as well 10:45:01 <05icoson> *should 10:45:42 <05icoson> oh, shafts appear to take time 10:49:24 <05icoson> or maybe some other code is handling them already 10:49:52 Unstable branch on crawl.kelbi.org updated to: 0.31-a0-620-gd1cbd99268 (34) 10:51:35 <05icoson> also, was wondering whether there is a non-gendered version of "ironman" to consider? Not sure what what tbh 10:52:18 <06pleasingfungus> yeah we've been bikeshedding the name 10:52:23 <06pleasingfungus> we've agreed that ironman shouldn't be the final version 10:52:30 <06pleasingfungus> trying to remember some names i liked 10:53:23 <06pleasingfungus> > (nicolae): Relentless. Inexorable. Adamant. Zot-Bound. On Rails. Undaunted. No Return. Downfall. Born To Rune. i vaguely liked "descent mode", "relentless mode" or "dauntless mode", but not in love with any of those yet 10:53:39 <05icoson> "descent" is my favorite of those three 10:54:18 <06pleasingfungus> hm, would adding descent mode be a good prompt to finally replace the tile that's ripped from the old Descent game's box 10:54:57 <09hellmonk> Decent mode 10:55:06 <09hellmonk> Because the gameplay is decent 10:57:22 <05icoson> have you considered "hellcrawl" :gloweye: 10:57:39 <06pleasingfungus> think that implies the mode being much harder, which i don't really want to 10:57:42 <06pleasingfungus> (serious response to a joke) 10:57:50 <05icoson> heckcrawl 10:58:03 <06pleasingfungus> do want the mode to end up being broadly similar in difficulty to crawl standard 11:05:36 <05icoson> I guess there are two questions, what its name is and what people will actually call it 11:08:31 <05icoson> another small thing, "the exit collapses" is weird when you shaft into los of stairs. I can't figure out how to condition on that very easily, but maybe it would simpler to just have a message like "The exits collapse" whenever the stairs crumble independent of whether you can see? 11:17:53 <06pleasingfungus> i sort of like the exit collapses x2 11:18:03 <06pleasingfungus> but the exits collapse is fine too 11:18:27 <06pleasingfungus> would also print when you hatch in, which is maybe a positive 11:18:58 <06pleasingfungus> hm, the hatch insta collapse should probably also trigger for shafts 11:19:07 <05icoson> it seems to? 11:19:20 <05icoson> I'm not entirely sure why but that's why I said it seems like time passes 11:19:48 <05icoson> fo shafting is different too 11:19:49 <06pleasingfungus> interesting 11:20:04 <05icoson> fo shafting is the full time, regular shafting shows 8 auts iirc 11:21:00 <05icoson> but if I do wizmode mapping immediately after taking a shaft via terrain, there are no stairs 11:21:04 <05icoson> *upstairs 11:21:53 <06pleasingfungus> huh 11:22:08 <06pleasingfungus> presumably from the end of turn that takes time thing 11:30:18 <05icoson> if that were not conditioned on los you'd get "the exit collapses x3" (or x1) consistently 11:33:00 <06pleasingfungus> sure 11:33:09 <06pleasingfungus> well, sometimes x4 with hatches etc 11:51:53 <08nicolae> Dungeon Collapse. the dungeon collapses behind you. 11:52:27 <06pleasingfungus> could work 11:52:31 <06pleasingfungus> Collapse mode... 11:55:17 <08nicolae> Crawllapse 12:04:16 <09hellmonk> Bikeshed mode 12:08:31 <08nicolae> i suggested that yesterday in the roguelikes discord 12:08:55 <08nicolae> two data points is enough for a trendline 12:08:58 <08nicolae> bikeshed mode it is 14:24:04 Please no - Hack 1.0.3 would tell you the dungeon collapsed (ending the game) for any number of bugs (as you probably know) and I'm a bit scarred from '88 14:25:20 <06pleasingfungus> hm, i'm actually fairly unfamiliar with the crash behavior of a game released years before i was born 😛 14:25:58 I'm not saying you're younger than my keyboard, _but_. 14:29:32 (more seriously, no _big_ deal, but I would wince at variations on "Suddenly, the dungeon collapses. --More--" and I presumably am not the only one. 14:29:36 ) 14:31:48 <06pleasingfungus> "The exits collapse" are a little different from that, fwiw. 14:34:46 Yeah, fair enough. "the dungeon collapses behind you" was a bit close to the bone (and it's not a big deal) 14:37:00 <06pleasingfungus> i don't think nicolae's description was intended as in-game text. 14:37:11 <06pleasingfungus> maybe as an in-game description for the mode, i guess. 14:56:45 <08nicolae> yes that 15:24:55 Could you do without stairs, and have the player jump down a hole each time? If you want a preview of the next level, you can look before you leap. 15:26:15 Unstable branch on underhound.eu updated to: 0.31-a0-620-gd1cbd99268 (34) 16:46:51 <06pleasingfungus> you could, but it'd be more UI work 16:47:08 <06pleasingfungus> players already know how to go down stairs; they don't know how to look, necessarily 16:47:59 <06pleasingfungus> well, i should say just more code work generally 17:36:15 <|amethyst> re: hack being years older than pf: "It's people like that who make you realize how little you've accomplished. It is a sobering thought, for example, that when Mozart was my age, he had been dead for two years." –T. Lehrer (In my case, seven years) 17:46:26 <06pleasingfungus> tom lehrer rips 17:57:01 <|amethyst> He recently released his songs to the public domain: https://tomlehrersongs.com/ 18:01:33 <06pleasingfungus> excellent. 18:09:55 Lehrer did come to mind but I figured I should let that one go 18:49:01 <09hellmonk> @pleasingfungus getting a crash when stair peeking back out of the zot entrance ASSERT(you.on_current_level) in 'files.cc' at line 2128 failed. 18:49:14 <09hellmonk> appears to be related to pregen 18:56:41 03hellmonk02 07[great-magnetic-field] * 0.31-a0-649-g6cbde957c9: missing vault tag 10(74 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/6cbde957c90e 19:01:56 <06pleasingfungus> hm, i didn’t test zot 19:12:11 <|amethyst> hellmonk: I don't suppose you have a stack trace for that (or, equivalently, can reproduce the crash on a public server)? 19:12:46 <09hellmonk> it's on ironcrawl branch only, not a mainline problem 19:23:19 <09gammafunk> if I don't hear Big Iron play when I start up this branch, gonna be disappointed 19:24:33 <|amethyst> A few years ago I bought Marty Robbin's greatest hits ("Gunfighter Ballads and Trail Songs"), so I'm here for that 19:25:49 <|amethyst> https://www.youtube.com/watch?v=G1NwCnMDoqc for those who are not so familiar with country-western 19:27:24 <|amethyst> Also, my father-in-law likes that song quite a bit, and also worked as a chemical engineer in a steel mill until he retired many years ago... My wife, when she was young, though the song was saying "pig iron" 19:27:43 <|amethyst> (which is a thing, metallurgically) 19:29:15 <|amethyst> s/ough/ought/ 19:57:19 <06pleasingfungus> @hellmonk if you voluntarily take a shaft in ironman, should it still have a chance of dropping you 1-3 floors? 19:57:25 <09hellmonk> imo no 19:57:41 <09hellmonk> but not super strong opinion on it 20:05:26 <06pleasingfungus> sounds right 20:05:32 <06pleasingfungus> think it’s way too impactful otherwise 20:05:48 <06pleasingfungus> ends up being pretty close to a hatch with the change 20:05:50 <06pleasingfungus> but that’s fine 20:35:28 joshe (L7 MfSh) Crash caused by signal #6: Aborted (D:5) 20:36:26 joshe (L7 MfSh) Crash caused by signal #6: Aborted (D:5) 20:37:22 <|amethyst> dgn_place_item upon level-down 20:38:33 <|amethyst> grunt_nemelex_the_gamble , if that helps 20:45:00 joshe (L8 MfSh) Crash caused by signal #6: Aborted (D:5) 20:46:30 joshe (L8 MfSh) Crash caused by signal #6: Aborted (D:5) 20:51:05 <06pleasingfungus> hm 22:35:04 Unstable branch on crawl.develz.org updated to: 0.31-a0-620-gd1cbd99268 (34) 22:57:24 Windows builds of master branch on crawl.develz.org updated to: 0.31-a0-620-gd1cbd99268 23:43:55 Unstable branch on cbro.berotato.org updated to: 0.31-a0-620-gd1cbd99268 (34) 23:54:42 Monster database of master branch on crawl.develz.org updated to: 0.31-a0-620-gd1cbd99268