00:31:31 Fork (bcrawl) on crawl.kelbi.org updated to: 0.23-a0-4884-gcf1f1e11f7 04:22:17 Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-4884-gcf1f1e11f7 05:06:57 Unstable branch on crawl.akrasiac.org updated to: 0.30-a0-920-g7493c07 (34) 07:14:24 <06advil> hm, moncast.lua is crashing on plasma beam (ERROR in 'mon-cast.cc' at line 1590: Unknown monster spell 'Plasma Beam' cast by test statue) 07:15:53 03advil02 07[reconfiguration] * 0.30-a0-889-g4da65ceac7: fix: tweak some fixed length option details 10(44 seconds ago, 5 files, 22+ 6-) 13https://github.com/crawl/crawl/commit/4da65ceac7b5 07:47:21 04Build failed for 08reconfiguration @ 4da65cea 06https://github.com/crawl/crawl/actions/runs/4480088358 07:58:25 <03wheals> that's funny, is S_NORMAL the name of a macro somewhere in glibc? 08:01:52 <03wheals> on master branch by the way, it looks like the tests are broken since the test statue is trying to cast plasma beam 08:07:23 <06advil> I think S_NORMAL must be a windows thing 08:07:29 <06advil> https://microsoft.github.io/windows-docs-rs/doc/windows/Win32/System/WindowsProgramming/constant.S_NORMAL.html 08:07:37 <06advil> I see that in one file we #undef it 08:08:50 <06advil> not entirely sure how it's getting included there, though I was lazy and included a non-trivial .h in a header in that commit 08:13:41 <06advil> so I'll just pull the relevant enum into its own .h rather than figure this out 08:17:07 03kate-02 07* 0.30-a0-921-gb09b86bb1d: Fix a test failure (advil) 10(7 minutes ago, 1 file, 1+ 0-) 13https://github.com/crawl/crawl/commit/b09b86bb1dd9 08:17:07 03advil02 07[reconfiguration] * 0.30-a0-890-g9af7f4f119: fix: pull an enum into its own file 10(2 minutes ago, 3 files, 18+ 16-) 13https://github.com/crawl/crawl/commit/9af7f4f11941 08:19:48 <06advil> re that comment: unfortunately "isn't a monster spell" seems to be currently defined as, "not handled in any number of places in mon-cast.cc"; it tries to look up the spell in a bunch of big switches and in spell_to_logic 08:20:58 <03wheals> oh sorry advil, somehow i completely missed that you noticed the master test failure before i did 08:21:04 <06advil> heh no problem 08:33:48 Unstable branch on crawl.kelbi.org updated to: 0.30-a0-921-gb09b86bb1d (34) 11:08:44 huh, dcss-ci fixed itself? 11:26:18 03PleasingFungus02 07* 0.30-a0-922-gb1aff02ba6: Allow randartifying staves (dwetuski) 10(57 seconds ago, 3 files, 19+ 13-) 13https://github.com/crawl/crawl/commit/b1aff02ba65c 11:46:03 Unstable branch on crawl.kelbi.org updated to: 0.30-a0-922-gb1aff02ba6 (34) 11:49:25 I wonder if we could have beam attacks (e.g., shock) automatically have the target optimize their aim to hit both the thing they were going to hit plus another (or as many as possible) monsters just with a different angle. 11:49:44 For example, the default aim of shock shows https://i.imghurr.com/e/PHSovD04ss.jpg when I'd rather have https://i.imghurr.com/e/S927pR8e1F.jpg 11:50:28 I kind of expect simple_targeting = false to do that even though it often doesn't seem to 11:52:04 Another example. The default is https://i.imghurr.com/e/VBv2tkFIdJ.jpg, but I would rather https://i.imghurr.com/e/pKSv4yWpYc.jpg 11:54:19 And for a more complex example where there's a rebound: The default is https://i.imghurr.com/e/zCzs42jWWh.jpg, and I would rather https://i.imghurr.com/e/BNFtN5gluV.jpg 11:54:52 There's an argument to be made that it's nice to feel clever for figuring out a really good rebound like the last answer but it's also not always fun to always have to use manual targeting when you're using a beam spell 11:58:13 Yeah, I think simple_targeting = false is supposed to do what I'm saying here but it's probably more limited than I'd like (and is probably better suited for directly AOE stuff). 12:01:54 I'm talking very much out of my butt here but I would imagine that even just brute forcing all the possible target positions for a beam spell and selecting the option that has the highest expected damage (to avoid for example trying to target something that'd be immune) while also avoiding things like hitting allies 12:08:03 <06advil> hard to even know what simple_targeting even does, I've refactored that code several times but even I try not to mess with the _find_monster_expl calls 12:08:29 <06advil> from comments I suspect it may do something for explosions, but no reason to believe it handles bounces 12:11:49 Ah, huh. It does imply in options_guide that it tries to hit multiple things for both boomy stuff and zappy stuff 12:46:12 <05kate> simple_targeting is false usually, right? ie the current default behaviour is that it tries to be clever and hit multiple things, yeah 12:49:37 <05kate> but the option to turn it off exists basically because the attempts to be clever aren't always great, or at least make it hard to reason about what the spell will aim at - i prefer predictability over it trying to be clever (but trying to make it better at being clever when it's enabled would be reasonable) 12:52:20 <05kate> eg in perryprog's shock example i think it's prioritising aiming at something that's almost dead over hitting multiple things, which is certainly a very reasonable thing to prioritise, but it seems very hard for smart targeting to really always do what the player wants/expects 13:51:12 New branch created: sturm-und-drang (1 commit) 13https://github.com/crawl/crawl/tree/sturm-und-drang 13:51:12 03PleasingFungus02 07[sturm-und-drang] * 0.30-a0-923-g5a83f13587: Untested thundercloud refactor 10(28 seconds ago, 1 file, 14+ 41-) 13https://github.com/crawl/crawl/commit/5a83f13587da 13:52:15 03PleasingFungus02 07[sturm-und-drang] * 0.30-a0-924-gc2a7645979: Fix 10(34 seconds ago, 1 file, 15+ 0-) 13https://github.com/crawl/crawl/commit/c2a764597996 13:53:19 03PleasingFungus02 07[sturm-und-drang] * 0.30-a0-925-g630a4d6c9e: Simplify 10(26 seconds ago, 1 file, 3+ 10-) 13https://github.com/crawl/crawl/commit/630a4d6c9e1b 13:59:37 03PleasingFungus02 07[sturm-und-drang] * 0.30-a0-926-g65bfc7e90d: Remove another special case 10(24 seconds ago, 1 file, 1+ 2-) 13https://github.com/crawl/crawl/commit/65bfc7e90d0b 14:01:15 Yeah, I think the case where it was choosing the damaged orc is probably fine. I think the case that could definitely be better improved would be when the target that it wants to hit has a method of aiming that hits both it and multiple other monsters that the default aim isn't using, like in the last case. 14:04:05 A similar thing also happens when you're just shooting things in an almost-straight line, but it chooses an orthogonal path that only hits the first monster instead of a slightly angled path that hits more stuff. 14:05:56 03PleasingFungus02 07* 0.30-a0-923-g828ccac5a3: Remove an unused return type (Monkooky) 10(73 seconds ago, 2 files, 5+ 8-) 13https://github.com/crawl/crawl/commit/828ccac5a3e5 14:10:56 14:12:25 so very helpful… 14:21:12 14:21:18 14:21:21 14:40:39 Unstable branch on crawl.kelbi.org updated to: 0.30-a0-923-g828ccac5a3 (34) 16:10:26 <13Sastreii> some new tiles for randart staves 16:10:27 <13Sastreii> https://cdn.discordapp.com/attachments/747522859361894521/1087875898977562654/Schermata_2023-03-21_alle_23.35.58.png 16:10:27 <13Sastreii> https://cdn.discordapp.com/attachments/747522859361894521/1087875899237605466/magic_staves.zip 16:10:41 <13Sastreii> they also have a matching doll tile 16:10:42 <13Sastreii> https://cdn.discordapp.com/attachments/747522859361894521/1087875959161639052/magic_staves_doll.zip 16:13:31 <09gammafunk> awesome, thanks a lot! 16:19:29 <08nicolae> oh damn, now i want to find a randart stave ASAP 16:23:57 Unstable branch on underhound.eu updated to: 0.30-a0-923-g828ccac5a3 (34) 16:28:12 Does this mean you can now find antimagic staves? 16:35:49 <08nicolae> i haven't looked at the code but i'm assuming it's just the regular kinds of staves but with little extra bits on 'em 16:38:36 <10PleasingFungus> Sastreii: these ruuuule 16:38:39 <10PleasingFungus> thank you! 16:46:36 nicolae: Just looked. Staves brands use completely different code to weapon ones, so can't share. 16:47:28 <10PleasingFungus> at some point we should unify staves and weapons 16:47:34 <10PleasingFungus> i thought about doing it as part of randartification, but wussed out 16:47:36 <10PleasingFungus> possibly an error! 16:57:57 03PleasingFungus02 07* 0.30-a0-924-g0ad0bf95bc: Add new randart staff tiles (Sastreii) 10(40 seconds ago, 18 files, 27+ 0-) 13https://github.com/crawl/crawl/commit/0ad0bf95bc10 17:19:44 Unstable branch on crawl.kelbi.org updated to: 0.30-a0-924-g0ad0bf95bc (34) 19:07:03 New branch created: pull/3053 (1 commit) 13https://github.com/crawl/crawl/pull/3053 19:07:03 03Monkooky02 07https://github.com/crawl/crawl/pull/3053 * 0.30-a0-884-g77b7d71900: Fix and refactor thunderclouds 10(59 seconds ago, 2 files, 31+ 100-) 13https://github.com/crawl/crawl/commit/77b7d719000f 20:42:29 03Monkooky02 07https://github.com/crawl/crawl/pull/3053 * 0.30-a0-923-ge86297e306: Fix and refactor thunderclouds 10(2 hours ago, 2 files, 31+ 100-) 13https://github.com/crawl/crawl/commit/e86297e306f3 20:42:29 03Monkooky02 07https://github.com/crawl/crawl/pull/3053 * 0.30-a0-925-g6b6c3c7f32: Merge branch 'lightning-as-fast' of https://github.com/Monkooky/crawl into lightning-as-fast 10(48 minutes ago, 0 files, 0+ 0-) 13https://github.com/crawl/crawl/commit/6b6c3c7f321e 20:42:29 03Monkooky02 07https://github.com/crawl/crawl/pull/3053 * 0.30-a0-926-g9a1e153c02: Pass by reference (PleasingFungus) 10(29 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/9a1e153c0264 23:34:59 Unstable branch on crawl.develz.org updated to: 0.30-a0-924-g0ad0bf95bc (34) 23:45:49 Unstable branch on cbro.berotato.org updated to: 0.30-a0-924-g0ad0bf95bc (34) 23:56:59 Windows builds of master branch on crawl.develz.org updated to: 0.30-a0-924-g0ad0bf95bc