00:46:56 Unstable branch on cbro.berotato.org updated to: 0.30-a0-772-g5528072125 (34) 00:48:01 cashto (L19 TeSu) ASSERT(mindex <= MAX_MONSTERS) in 'mon-util.cc' at line 434 failed. (Elf:3) 00:54:24 Monster database of master branch on crawl.develz.org updated to: 0.30-a0-772-g5528072125 01:50:52 Stable (0.29) branch on cbro.berotato.org updated to: 0.29.1-14-g9c671dbff4 01:56:16 Stable (0.28) branch on crawl.kelbi.org updated to: 0.28.0-61-g67df4f89a8 02:23:06 Stable (0.29) branch on crawl.kelbi.org updated to: 0.29.1-14-g9c671dbff4 02:30:34 Stable (0.28) branch on cbro.berotato.org updated to: 0.28.0-61-g67df4f89a8 02:47:11 Fork (bcrawl) on crawl.kelbi.org updated to: 0.23-a0-4850-gd9e8576752 03:13:10 Fork (bcadrencrawl) on crawl.kelbi.org updated to: 0.03-1501-gea43db8f7f 03:37:30 Fork (stoatsoup) on crawl.kelbi.org updated to: 0.23-s2-176-g065d2efb83 04:23:18 Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-4850-gd9e8576752 05:20:28 Stable (0.28) branch on crawl.akrasiac.org updated to: 0.28.0-61-g67df4f8 05:47:03 Unstable branch on crawl.akrasiac.org updated to: 0.30-a0-772-g5528072 (34) 09:32:33 <05kate> oh that crash looks good 09:33:00 <05kate> somehow a hep ancestor being swapped with a monster after being banished 09:33:17 <05kate> or after the player is shafted, in the case of the one from yesterday 09:41:58 <06advil> does anyone know if there's a way, short of not having a bool operator at all, to prevent implicit contextual conversion of a class to bool? I understand the historical logic behind letting this happen with explicit, but was really hoping to have a way of requiring an explicit cast (which just seems to be a gap?) 09:44:43 <06advil> for some of the logical operator cases I can overload them, leading to errors without an explicit cast, but this still leaves simple control flow expressions 09:55:56 <06advil> I guess like 80% of the cases this is relevant to are for just one function (you_can_wear) 12:26:36 03nlavsky02 07* 0.30-a0-773-gbab4234b37: fix: display the malmutated status icon in webtiles 10(10 minutes ago, 1 file, 1+ 0-) 13https://github.com/crawl/crawl/commit/bab4234b3794 12:36:02 <08nlavsky> Checking recent changes: players: wow, flying sharks! me: wow, ui::error()! 12:36:18 <08nlavsky> (although, sharks are cool too) 12:39:46 <08nlavsky> Also, to add to the "Remaining weird things" list from 9a087e29e19546, it looks like looking up any misc item via ?/i shows the description of the manual of Fighting now. 12:44:29 <06advil> That sounds more like it must be a new weird thing 12:58:06 <08nlavsky> It looks like replacing if (item_kind.base_type == OBJ_UNASSIGNED) with if (item_kind.base_type != OBJ_BOOKS && item_kind.sub_type != BOOK_MANUAL) in items.cc:_get_manual_by_exact_name() fixes the problem, although I have absolutely no idea what I'm doing 13:10:25 <08nlavsky> Oh, no! ?/ibook of cantrips shows a correct description, but ?/ibook of armaments shows the manual of Fighting's desc. 13:14:44 Unstable branch on crawl.kelbi.org updated to: 0.30-a0-773-gbab4234b37 (34) 13:14:46 <08nlavsky> Books of Dangerous friends, decay, displacement - these have manual of Fighting's desc. Old books (???), like Burglary or Changes, have correct descs in lookup-help. In-game, all book descs look fine, though. 13:15:03 <10PleasingFungus> enum greater than manual 13:16:09 <10PleasingFungus> this is not an explanation 13:16:16 <10PleasingFungus> just a consistent factor 13:19:30 <06advil> lol, if (item.base_type != OBJ_BOOKS || item.sub_type != BOOK_MANUAL) is ... not right 13:19:51 <06advil> wait 13:19:53 <06advil> or is it 13:24:07 <10PleasingFungus> i would need to actually look at code 13:24:38 <06advil> ok, I see what's going on 13:26:54 <06advil> nlavsky's solution is correct 13:29:43 <08nlavsky> Should I push this to fix the lookup for misc items, or do you have another fix for that, @advil ? 13:29:56 <06advil> there's something still weird about it 13:45:06 <06advil> it needed || not && 13:45:20 03advil02 07* 0.30-a0-774-g4aa5aa1482: fix: stop describing things as manuals of fighting (nlavsky) 10(2 minutes ago, 1 file, 15+ 5-) 13https://github.com/crawl/crawl/commit/4aa5aa148252 13:45:30 <08nlavsky> Nice 13:49:52 <08nlavsky> So, manuals are the only thing that uses item.plus as a sub-sub-type? 13:50:17 Unstable branch on crawl.kelbi.org updated to: 0.30-a0-774-g4aa5aa1482 (34) 13:59:56 <06advil> sort of, plus is a union so some other things use it for state. The only one that looks like a type per se is corpses (and tbh I can't even remember if this lines up with how corpses are implemented right now...) 14:00:15 <06advil> hm, also I see that there is a skill_type explicitly in the union, though none of this code uses it 14:00:44 <06advil> as far as the item name cache is concerned it's the only one though 14:06:02 <08nlavsky> monster_type mon_type:16; ///< corpse/chunk monster type the very important old feature to separate chunks of different species! 14:09:13 <10PleasingFungus> i put in so much work to merge chunks……. 14:09:53 <09gammafunk> !clapall total ghoul nutrition 14:09:54 <04Cerebot> 👏 t 👏 o 👏 t 👏 a 👏 l 👏 👏 g 👏 h 👏 o 👏 u 👏 l 👏 👏 n 👏 u 👏 t 👏 r 👏 i 👏 t 👏 i 👏 o 👏 n 👏 14:13:17 <09gammafunk> a couple weeks ago I had a dream/nightmare where I was in an interview and they showed me a single diff with every change I had ever made to any project on github and they wanted me to explain and justify each line 14:15:57 <06advil> was it printed out 14:18:11 <09gammafunk> it was on a laptop or at least a computer screen of some kind. The only other thing I recall is freezing up and not being able to offer a good explanation for the first chunk 14:27:11 <05kate> all the more reason to get your lifetime lines of code into the negative, at least that way when that situation inevitably comes up for real your answer to the majority of them can be "this line was bad so i removed it" 14:27:46 <09gammafunk> lol 14:29:10 gonna be hard to explain that when a few pages earlier you were justifying why you were adding that very line 14:30:13 <05kate> aha, that just indicates how you've grown wiser over the years! 14:30:21 <08nlavsky> "The sculpture is already complete within the marble block, before I start my work. It is already there, I just have to chisel away the superfluous material." 14:31:18 >two days between commits 14:31:41 <08nlavsky> ( ©️ Michelangelo) 15:49:47 <09gammafunk> hrm, is there a way to see mmhp from lua 15:50:28 <09gammafunk> don't really need this, but seems not 15:57:40 03kate-02 07* 0.30-a0-775-gec953de308: Give Arcjolt full LOS range 10(23 hours ago, 2 files, 3+ 3-) 13https://github.com/crawl/crawl/commit/ec953de30897 15:57:40 03kate-02 07* 0.30-a0-776-g08fbeb92c1: Adjust channeling backfire effects 10(23 hours ago, 1 file, 10+ 6-) 13https://github.com/crawl/crawl/commit/08fbeb92c1a1 16:04:31 Unstable branch on crawl.kelbi.org updated to: 0.30-a0-776-g08fbeb92c1 (34) 16:11:43 <10PleasingFungus> ooh, people will be happy re channeling changes 16:12:29 <10PleasingFungus> @kate looks like there’s still a max arcjolt range constant? 16:12:43 <05kate> oh oops, indeed there is 16:14:28 03kate-02 07* 0.30-a0-777-ga9a30cbeda: Remove an unused constant (PleasingFungus) 10(76 seconds ago, 1 file, 0+ 1-) 13https://github.com/crawl/crawl/commit/a9a30cbeda97 16:18:36 <09gammafunk> think it's kind of neat how -Cast failed to be a great part of sif but it seems to be finding its own as a penalty for other things 16:18:55 <09gammafunk> rip Divine Energy 16:20:36 <09gammafunk> I actually feel sort of bad that I didn't think or replacing the confusion with -Cast since I both proposed that effect initially (kate made the actual implementation iirc) and regularly complained about how annoying the confusion effect was for CBoE etc 16:21:00 <09gammafunk> proposed that effect for Sif's divine energy, I mean 16:22:07 <09gammafunk> actually it's maybe possible I was thinking that Divine Energy just use single-tile Silence so maybe -Cast was all kate 16:22:19 <09gammafunk> was a long time ago, memory hazy 16:22:50 <05kate> heh, i don't recall either yeah, same sort of idea though 16:23:10 <09gammafunk> yeah, I do recall that Lasty didn't like the idea of Silence and felt it was too high a penalty 16:23:52 <05kate> i think silence also has duration and radius all tied together so it'd probably have had to be a separate implementation in some form anyway 16:23:52 Unstable branch on crawl.kelbi.org updated to: 0.30-a0-777-ga9a30cbeda (34) 16:24:04 <09gammafunk> right 16:24:26 Unstable branch on underhound.eu updated to: 0.30-a0-776-g08fbeb92c1 (34) 16:24:29 <09gammafunk> I think this was also an issue with klown pie silence at one point 16:27:30 <09gammafunk> yeah I see we went with a mute effect for applying to monsters, and presumably we use a low duration for the player so that it will be single square 16:38:39 New branch created: maybe_kleene (2 commits) 13https://github.com/crawl/crawl/tree/maybe_kleene 16:38:40 03advil02 07[maybe_kleene] * 0.30-a0-775-g93946b981c: refactor: rewrite maybe_bool 10(2 hours ago, 14 files, 222+ 76-) 13https://github.com/crawl/crawl/commit/93946b981c64 16:38:40 03advil02 07[maybe_kleene] * 0.30-a0-776-g14737618c3: refactor: convert old maybe_bools to new maybe_bools 10(7 minutes ago, 44 files, 202+ 247-) 13https://github.com/crawl/crawl/commit/14737618c3d5 16:44:19 <09gammafunk> wow, a tour de force of truth 16:52:04 <06advil> lol 16:55:17 04Build failed for 08maybe_kleene @ 14737618 06https://github.com/crawl/crawl/actions/runs/4158796018 17:02:26 and the truth will out… 17:14:21 03advil02 07[maybe_kleene] * 0.30-a0-775-gb4342f1f79: refactor: rewrite maybe_bool 10(3 hours ago, 14 files, 223+ 76-) 13https://github.com/crawl/crawl/commit/b4342f1f79ad 17:14:21 03advil02 07[maybe_kleene] * 0.30-a0-776-g2f2148033a: refactor: convert old maybe_bools to new maybe_bools 10(42 minutes ago, 44 files, 203+ 248-) 13https://github.com/crawl/crawl/commit/2f2148033a79 17:29:04 03advil02 07[maybe_kleene] * 0.30-a0-775-gc1dcbe2388: refactor: rewrite maybe_bool 10(3 hours ago, 14 files, 226+ 76-) 13https://github.com/crawl/crawl/commit/c1dcbe238822 17:29:04 03advil02 07[maybe_kleene] * 0.30-a0-776-g9dca3019f3: refactor: convert old maybe_bools to new maybe_bools 10(57 minutes ago, 44 files, 203+ 248-) 13https://github.com/crawl/crawl/commit/9dca3019f35f 17:50:41 lol nice arcjolt buffs 17:51:10 arcjolt still seems crazy strong to me but agreed that even having chains of ≈ 5 monsters is quite rare 17:58:05 <10PleasingFungus> more simplification than buff 17:59:00 I mean, in the most technical min-max sense of the word 18:11:06 03advil02 07[maybe_kleene] * 0.30-a0-777-g7c586b6276: build: maybe fix android build 10(30 seconds ago, 1 file, 1+ 0-) 13https://github.com/crawl/crawl/commit/7c586b6276c8 18:11:21 <06advil> I wonder what all those java.lang.NumberFormatException: Not a number: 33x errors are 23:56:48 Windows builds of master branch on crawl.develz.org updated to: 0.30-a0-777-ga9a30cbeda