04:23:04 <Lantell> Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-4850-gd9e8576752
06:20:38 -!- runrin_ is now known as runrin
06:20:38 -!- TAS-2012v is now known as TAS_2012v
13:54:36 <NotCheibriados> 03kate-02 07* 0.30-a0-716-g8ab98d0bbf: Allow equipping finger amulet rings in batform (#2835) 10(4 hours ago, 1 file, 2+ 1-) 13https://github.com/crawl/crawl/commit/8ab98d0bbfae
13:54:36 <NotCheibriados> 03kate-02 07* 0.30-a0-717-g8ad61386b6: Refactor messaging on escaping engulf (#2859) 10(52 minutes ago, 9 files, 27+ 30-) 13https://github.com/crawl/crawl/commit/8ad61386b6d4
13:54:36 <NotCheibriados> 03kate-02 07* 0.30-a0-718-geaa24f58ff: Fix Green Draconian breath not piercing enemies (#2832) 10(6 minutes ago, 5 files, 17+ 1-) 13https://github.com/crawl/crawl/commit/eaa24f58ffff
13:57:14 <Discord|> <10P​leasingFungus> goodbugs
13:58:48 <Discord|> <05k​ate> yeah, had a feeling the drac breath one was my fault with the noise changes somehow but it took me a bit to track down exactly how!
13:59:09 <Discord|> <05k​ate> since the zap was still set up properly as a piercing beam the whole time, it just then also got treated like a cloud spell in one particular place
14:10:29 <Discord|> <10P​leasingFungus> nice.
16:23:43 <Lantell> Unstable branch on underhound.eu updated to: 0.30-a0-718-geaa24f58ff (34)
17:40:14 <Henzell> GoodxKnight (L22 GrFi) Crash caused by signal #6: Aborted (Elf:3)
17:40:15 <Henzell> Fallibilist (L21 MfFi) Crash caused by signal #6: Aborted (Elf:3)
17:43:08 <geekosaur> uh oh?
18:10:23 <Discord|> <09g​ammafunk> GoodXKnight, cao
20:41:31 <jv84> i browsed many issues and it seems that many have been resolved but not closed
20:42:10 <jv84> but i don't want to mention any because "you know better"
20:42:21 <jv84> and also i said many!
20:44:48 <jv84> most of the issues are about game dynamics. some of them are compilation issues. but i reported a memory leak in the arena.
20:48:22 <jv84> some positive comments in the final post might just signal an issue worth closing. :)
20:50:15 <jv84> somehow i feel you're overburdened already. not unlike me.
21:11:30 <Discord|> <10P​leasingFungus> gone… like a ghost in the night
21:12:17 <Discord|> <10P​leasingFungus> !tell jv84 do you mean mantis issues or github issues? the former is semi-abandoned, though it’d take an enormous amount of work to clean it up and import it onto github
21:12:19 <Discord|> <04C​erebot> PleasingFungus: OK, I'll let jv84 know.
23:12:19 <Monkooky> What are thoughts on duck typing
23:12:57 <Monkooky> currently the inacc code is
23:12:58 <Monkooky> int actor::inaccuracy() const
23:12:58 <Monkooky> {
23:12:59 <Monkooky> const item_def *amu = slot_item(EQ_AMULET);
23:12:59 <Monkooky> return amu && is_unrandom_artefact(*amu, UNRAND_AIR);
23:13:00 <Monkooky> }
23:14:20 <Monkooky> which to my eye is unnecessarily obtuse, but if that's conventional and not crawlcode I'll stick with the pattern
23:14:46 <Discord|> <10P​leasingFungus> the concern is that we abbreviate amu != null to amu?
23:15:02 <Discord|> <10P​leasingFungus> i think that's pretty idiomatic in our codebase, we use that all over the place
23:15:09 <Discord|> <10P​leasingFungus> but maybe i'm misunderstanding
23:15:15 <Discord|> <10P​leasingFungus> i'm not sure i'd call it duck typing, fwiw....
23:16:06 <Monkooky> no the concern is that we use amu && is_unrandom_artefact... as an int
23:16:41 <Monkooky> this returns 0 or 1, and then the result is multiplied by 5 to get the actual inaccuracy penalty
23:17:27 <Discord|> <10P​leasingFungus> oh lol
23:17:30 <Discord|> <10P​leasingFungus> that's terrible
23:17:43 <Discord|> <10P​leasingFungus> we do that in a few places and it sucks everywhere
23:17:48 <Discord|> <10P​leasingFungus> (it's still not duck typing)
23:18:34 <Discord|> <10P​leasingFungus> it's most common with stuff like this - also shows up for eg resists
23:18:38 <Discord|> <10P​leasingFungus> stuff that'd be pips on %
23:19:50 <Discord|> <10P​leasingFungus> amusingly (?), player::inaccuracy is written much more reasonably
23:20:00 <Discord|> <10P​leasingFungus> (if a little redundantly wrt amulet of the air)
23:56:44 <Gretell> Windows builds of master branch on crawl.develz.org updated to: 0.30-a0-718-geaa24f58ff