00:15:45 Lightli (L9 TeRe) ASSERT(wiz_cast || !(flags & spflag::testing)) in 'spl-cast.cc' at line 1874 failed. (Bailey) 00:20:33 Lightli (L9 TeRe) ASSERT(wiz_cast || !(flags & spflag::testing)) in 'spl-cast.cc' at line 1874 failed. (D:7) 00:20:45 Lightli (L9 TeRe) ASSERT(wiz_cast || !(flags & spflag::testing)) in 'spl-cast.cc' at line 1874 failed. (D:7) 00:21:21 Lightli (L10 TeRe) ASSERT(wiz_cast || !(flags & spflag::testing)) in 'spl-cast.cc' at line 1874 failed. (D:7) 00:23:21 Lightli (L10 TeRe) ASSERT(wiz_cast || !(flags & spflag::testing)) in 'spl-cast.cc' at line 1874 failed. (D:7) 00:26:50 Lightli (L10 TeRe) ASSERT(wiz_cast || !(flags & spflag::testing)) in 'spl-cast.cc' at line 1874 failed. (D:7) 00:27:19 Lightli (L10 TeRe) ASSERT(wiz_cast || !(flags & spflag::testing)) in 'spl-cast.cc' at line 1874 failed. (D:7) 00:27:29 Lightli (L10 TeRe) ASSERT(wiz_cast || !(flags & spflag::testing)) in 'spl-cast.cc' at line 1874 failed. (D:7) 00:27:41 Lightli (L10 TeRe) ASSERT(wiz_cast || !(flags & spflag::testing)) in 'spl-cast.cc' at line 1874 failed. (D:7) 00:27:53 Lightli (L10 TeRe) ASSERT(wiz_cast || !(flags & spflag::testing)) in 'spl-cast.cc' at line 1874 failed. (D:7) 00:28:01 Lightli (L10 TeRe) ASSERT(wiz_cast || !(flags & spflag::testing)) in 'spl-cast.cc' at line 1874 failed. (D:7) 00:28:08 Lightli (L10 TeRe) ASSERT(wiz_cast || !(flags & spflag::testing)) in 'spl-cast.cc' at line 1874 failed. (D:7) 00:28:18 Lightli (L10 TeRe) ASSERT(wiz_cast || !(flags & spflag::testing)) in 'spl-cast.cc' at line 1874 failed. (D:7) 00:28:29 Lightli (L10 TeRe) ASSERT(wiz_cast || !(flags & spflag::testing)) in 'spl-cast.cc' at line 1874 failed. (D:7) 00:28:45 Lightli (L10 TeRe) ASSERT(wiz_cast || !(flags & spflag::testing)) in 'spl-cast.cc' at line 1874 failed. (D:7) 00:28:51 Lightli (L10 TeRe) ASSERT(wiz_cast || !(flags & spflag::testing)) in 'spl-cast.cc' at line 1874 failed. (D:7) 00:28:57 Lightli (L10 TeRe) ASSERT(wiz_cast || !(flags & spflag::testing)) in 'spl-cast.cc' at line 1874 failed. (D:7) 00:29:02 Lightli (L10 TeRe) ASSERT(wiz_cast || !(flags & spflag::testing)) in 'spl-cast.cc' at line 1874 failed. (D:7) 00:29:12 Lightli (L10 TeRe) ASSERT(wiz_cast || !(flags & spflag::testing)) in 'spl-cast.cc' at line 1874 failed. (D:7) 00:29:20 Lightli (L10 TeRe) ASSERT(wiz_cast || !(flags & spflag::testing)) in 'spl-cast.cc' at line 1874 failed. (D:7) 00:29:26 Lightli (L10 TeRe) ASSERT(wiz_cast || !(flags & spflag::testing)) in 'spl-cast.cc' at line 1874 failed. (D:7) 00:29:32 Lightli (L10 TeRe) ASSERT(wiz_cast || !(flags & spflag::testing)) in 'spl-cast.cc' at line 1874 failed. (D:7) 00:29:39 Lightli (L10 TeRe) ASSERT(wiz_cast || !(flags & spflag::testing)) in 'spl-cast.cc' at line 1874 failed. (D:7) 00:29:45 Lightli (L10 TeRe) ASSERT(wiz_cast || !(flags & spflag::testing)) in 'spl-cast.cc' at line 1874 failed. (D:7) 00:30:55 Lightli (L10 TeRe) ASSERT(wiz_cast || !(flags & spflag::testing)) in 'spl-cast.cc' at line 1874 failed. (D:7) 00:31:04 Lightli (L10 TeRe) ASSERT(wiz_cast || !(flags & spflag::testing)) in 'spl-cast.cc' at line 1874 failed. (D:7) 00:31:13 Lightli (L10 TeRe) ASSERT(wiz_cast || !(flags & spflag::testing)) in 'spl-cast.cc' at line 1874 failed. (D:7) 00:31:18 Lightli (L10 TeRe) ASSERT(wiz_cast || !(flags & spflag::testing)) in 'spl-cast.cc' at line 1874 failed. (D:7) 00:31:22 Lightli (L10 TeRe) ASSERT(wiz_cast || !(flags & spflag::testing)) in 'spl-cast.cc' at line 1874 failed. (D:7) 00:31:26 Lightli (L10 TeRe) ASSERT(wiz_cast || !(flags & spflag::testing)) in 'spl-cast.cc' at line 1874 failed. (D:7) 00:31:31 Lightli (L10 TeRe) ASSERT(wiz_cast || !(flags & spflag::testing)) in 'spl-cast.cc' at line 1874 failed. (D:7) 00:31:37 Lightli (L10 TeRe) ASSERT(wiz_cast || !(flags & spflag::testing)) in 'spl-cast.cc' at line 1874 failed. (D:7) 00:31:46 Lightli (L10 TeRe) ASSERT(wiz_cast || !(flags & spflag::testing)) in 'spl-cast.cc' at line 1874 failed. (D:7) 00:31:52 Lightli (L10 TeRe) ASSERT(wiz_cast || !(flags & spflag::testing)) in 'spl-cast.cc' at line 1874 failed. (D:7) 00:31:58 Lightli (L10 TeRe) ASSERT(wiz_cast || !(flags & spflag::testing)) in 'spl-cast.cc' at line 1874 failed. (D:7) 00:32:06 Lightli (L10 TeRe) ASSERT(wiz_cast || !(flags & spflag::testing)) in 'spl-cast.cc' at line 1874 failed. (D:7) 00:32:16 Lightli (L10 TeRe) ASSERT(wiz_cast || !(flags & spflag::testing)) in 'spl-cast.cc' at line 1874 failed. (D:7) 00:32:23 Lightli (L10 TeRe) ASSERT(wiz_cast || !(flags & spflag::testing)) in 'spl-cast.cc' at line 1874 failed. (D:7) 00:32:29 Lightli (L10 TeRe) ASSERT(wiz_cast || !(flags & spflag::testing)) in 'spl-cast.cc' at line 1874 failed. (D:7) 00:32:38 Lightli (L10 TeRe) ASSERT(wiz_cast || !(flags & spflag::testing)) in 'spl-cast.cc' at line 1874 failed. (D:7) 00:37:09 <08wormsofcan> that was mutation scumming with on-demand crashes, lightli said he'll stop 00:50:31 Unstable branch on cbro.berotato.org updated to: 0.30-a0-672-gc3a7216ad8 (34) 00:54:29 Monster database of master branch on crawl.develz.org updated to: 0.30-a0-672-gc3a7216ad8 00:55:28 <03wheals> lightli successfully removed 01:16:13 New branch created: pull/2948 (1 commit) 13https://github.com/crawl/crawl/pull/2948 01:16:13 03OctopodesWeekly02 07https://github.com/crawl/crawl/pull/2948 * 0.30-a0-673-g4910cc22b8: Acrospider 10(5 minutes ago, 7 files, 37+ 3-) 13https://github.com/crawl/crawl/commit/4910cc22b8d5 01:44:17 Fork (bcrawl) on crawl.kelbi.org updated to: 0.23-a0-4850-gd9e8576752 02:07:40 03OctopodesWeekly02 07https://github.com/crawl/crawl/pull/2948 * 0.30-a0-674-gd839f260ed: Acrospider fixes 10(54 seconds ago, 4 files, 4+ 1-) 13https://github.com/crawl/crawl/commit/d839f260ed59 04:23:04 Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-4850-gd9e8576752 05:29:30 Unstable branch on crawl.akrasiac.org updated to: 0.30-a0-672-gc3a7216 (34) 06:31:59 03nlavsky02 07* 0.30-a0-673-g5a0d6e57be: feat: add tiles to the mutation description popup 10(8 minutes ago, 2 files, 26+ 3-) 13https://github.com/crawl/crawl/commit/5a0d6e57be52 06:49:03 Unstable branch on crawl.kelbi.org updated to: 0.30-a0-673-g5a0d6e57be (34) 07:07:04 <06advil> btw if someone wants to make a really boring tile, the main menu mac "reveal options file in finder" button is still missing one (there's a PR to do something similar on linux, so it's only os-specific in terms of implementation so far) 07:12:05 <06advil> somewhat confused about this spell bug, because _learn_spell_checks should be checking lots of things, and the lua call doesn't skip it 07:12:18 <06advil> if that function is not doing enough the fix should probably be there, not in lua-specific code 07:15:55 <06advil> hm, maybe that function isn't checking everything it should though 07:17:33 <06advil> it checks removedness but never does seem to check player spells 07:20:43 <08nlavsky> you_can_memorise should probably have a spell_available_to_memorize check 07:20:47 <06advil> I'm also pretty sure the non-player spells won't be castable without wizmode? (that actually looks like the crash lightli was scumming) 07:21:03 <06advil> yeah, possibly 07:21:23 <06advil> though that one is used elsewhere in some way 07:22:42 <06advil> I might get to this later this morning but if someone makes a change like that in the meantime, can you do it separately from removing the checks in lua code, so that it will backport easily? 07:22:48 I could make you a really bad programmer art tile :-( 07:26:25 <06advil> ok, no crash, just 07:26:25 <06advil> https://cdn.discordapp.com/attachments/747522859361894521/1065275976235352114/Screen_Shot_2023-01-18_at_9.26.00_AM.png 07:57:13 <10PleasingFungus> advil: it’s not just that - the lua never checked that the spell to memorize was in your library (or offered by veh). that’s an issue that only applies to the lua route - other memorization code implicitly checks that 07:58:00 <06advil> yeah, that does need to be in the lua code I think 07:58:18 <10PleasingFungus> once we have that, we don’t need a player spell check 07:58:19 <06advil> (unless someone makes veh add to library) 07:58:40 <10PleasingFungus> assuming that only player spells are in your library 🙂 07:58:47 <06advil> hm, can you memorise a veh spell with that lua change? 07:58:59 <10PleasingFungus> yes? should work 07:59:03 <06advil> oh, I see 07:59:21 <06advil> actually, I think this should all be in _learn_spell_checks 07:59:23 <06advil> not lua 07:59:25 <10PleasingFungus> so just a squashed version of those last two commits should backport nicely 07:59:27 <10PleasingFungus> hm 07:59:30 <10PleasingFungus> why? 07:59:49 <06advil> because it forms a natural category with the other checks in that function 08:00:01 <06advil> and then all calls to learn_spell apply the same checks 08:01:20 <06advil> and better to not have game logic in the lua calls 08:01:45 <10PleasingFungus> hm, it’s not the end of the world one way or the other, but i guess i see learn spellchecks as asking ‘can you memorize this spell that’s in your library/veh gifts?’ 08:02:28 <10PleasingFungus> since again, all other calls to that function already draw the spell from the available set 08:02:33 <06advil> one hopes 08:02:46 <10PleasingFungus> so it feels like stuttering to repeat the check in there 08:03:26 <10PleasingFungus> ‘here’s a spell in your library. can you memorize it? well, are you high enough xl, is it useful, is it in your library…?’ 08:03:52 <06advil> _learn_spell_checks already repeats a whole bunch of stuff that the menus head off too 😄 08:03:58 <06advil> seems more failure-proof to do all the checks there 08:04:03 <10PleasingFungus> shrug 08:04:10 <06advil> e.g. local tiles calls learn_spell , how much confidence do you have that it's still right? 08:04:13 <06advil> it probably is 08:04:22 <10PleasingFungus> i saw that yes 08:04:36 <10PleasingFungus> and i am confident in that 08:04:39 <06advil> tbh this bug exists because I assumed _learn_spell_checks does what it says 08:04:53 <06advil> but it does some but not all of what it says 08:05:11 <10PleasingFungus> mostly because i don’t know how you could get non library spells into the tile memorization menu 08:06:46 <06advil> let me put it another way: it's not less stuttering to put the game logic for "can a spell be memorised" in three places instead of two... 08:08:08 <10PleasingFungus> hm, i don’t understand, sorry 08:08:51 <10PleasingFungus> at present, for every memorization route, we list all library spells once. now we’ll list them twice 08:09:05 <10PleasingFungus> not a big deal, but still ‘more stuttering’ 08:09:30 <06advil> what 08:13:50 <06advil> I guess you mean because the implementation of the spell check builds a spell_set? 08:15:00 <06advil> I would just rather have all this logic in one place (independent of implementation) 08:15:15 <10PleasingFungus> that’s not really what i mean, no 08:15:45 <10PleasingFungus> but i am tired of trying to explain myself via a tiny phone keyboard 08:16:02 <10PleasingFungus> so go ahead and do whatever you think is best - again, it’s really not a big deal 08:16:21 <09gammafunk> I like spells :wfrDerp: 08:17:57 adviltest (L20 HOFi) ASSERT(hit_calc) in 'beam.cc' at line 466 failed. (D:1) 08:18:10 <06advil> !crashlog 08:18:59 adviltest (L20 HOFi) ASSERT(hit_calc) in 'beam.cc' at line 466 failed. (D:1) 08:19:23 !crashlog 08:19:29 24924. adviltest, XL20 HOFi, T:102 (milestone): http://crawl.akrasiac.org/rawdata/adviltest/crash-adviltest-20230118-151858.txt 08:20:34 adviltest (L20 HOFi) ASSERT(hit_calc) in 'beam.cc' at line 466 failed. (D:1) 08:46:37 03advil02 07* 0.30-a0-674-g870441aebb: fix: don't crash on &z zaps with no player tohit 10(3 minutes ago, 1 file, 24+ 0-) 13https://github.com/crawl/crawl/commit/870441aebbcd 08:46:37 03PleasingFungus02 07* 0.30-a0-675-gf9ce66f82c: New unrand 10(4 minutes ago, 3 files, 1+ 0-) 13https://github.com/crawl/crawl/commit/f9ce66f82ca8 08:46:37 03PleasingFungus02 07* 0.30-a0-676-g0ad051ed3b: New unrand: the consecrated labrys 10(4 minutes ago, 5 files, 40+ 7-) 13https://github.com/crawl/crawl/commit/0ad051ed3b7d 08:46:49 <10PleasingFungus> oh no unsquashed commit 08:47:14 <10PleasingFungus> @wormsofcan added a new 'labrys' unrand that's currently using a recolor of obsidian axe's tiles, if that's something you'd enjoy messing with 🙂 08:52:55 03PleasingFungus02 07* 0.30-a0-677-gfcc1e2b2af: Revert "feat: standardize popup exiting keys" 10(3 minutes ago, 12 files, 95+ 96-) 13https://github.com/crawl/crawl/commit/fcc1e2b2aff5 08:59:14 03PleasingFungus02 07* 0.30-a0-678-gd14727376c: Refactor memorization code (advil) 10(2 minutes ago, 3 files, 8+ 3-) 13https://github.com/crawl/crawl/commit/d14727376ca6 09:00:19 <06advil> hm, if joining religions is broken there's just a bool that needs to be changed 09:00:22 assuming that crawlcode does what it says on the tin, that's where they get'cha 09:02:52 <06advil> in describe_god_with_join 09:03:26 03PleasingFungus02 07* 0.30-a0-679-gba7862b69d: Unbreak wizmode memorization 10(30 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/ba7862b69deb 09:06:40 03PleasingFungus02 07[stone_soup-0.26] * 0.26.1-16-g4e020e15dc: Fix: remove incredible memorization powers 10(7 minutes ago, 1 file, 13+ 0-) 13https://github.com/crawl/crawl/commit/4e020e15dccc 09:06:41 03PleasingFungus02 07[stone_soup-0.27] * 0.27.1-36-g1b1ada6b1e: Fix: remove incredible memorization powers 10(7 minutes ago, 1 file, 13+ 0-) 13https://github.com/crawl/crawl/commit/1b1ada6b1eec 09:06:41 03PleasingFungus02 07[stone_soup-0.28] * 0.28.0-56-g4927b6849a: Fix: remove incredible memorization powers 10(7 minutes ago, 1 file, 13+ 0-) 13https://github.com/crawl/crawl/commit/4927b6849aa5 09:06:41 03PleasingFungus02 07[stone_soup-0.29] * 0.29.1-13-g9f3cf754e1: Fix: remove incredible memorization powers 10(7 minutes ago, 1 file, 13+ 0-) 13https://github.com/crawl/crawl/commit/9f3cf754e1f9 09:19:21 03advil02 07* 0.30-a0-680-g6c2b13695a: Revert "Revert "feat: standardize popup exiting keys"" 10(12 minutes ago, 12 files, 96+ 95-) 13https://github.com/crawl/crawl/commit/6c2b13695a77 09:19:21 03advil02 07* 0.30-a0-681-g83e5d64585: fix: allow enter to join religions 10(12 minutes ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/83e5d6458590 09:19:21 03advil02 07* 0.30-a0-682-g9571b93c2c: fix: swap default for ui::key_exits_popup 10(2 minutes ago, 3 files, 8+ 7-) 13https://github.com/crawl/crawl/commit/9571b93c2c08 09:22:30 03advil02 07* 0.30-a0-683-g636a5c3615: lint: fix a weird indent 10(55 seconds ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/636a5c3615a9 09:25:32 @advil: not sure if the commits have already covered this, but some of those monster spells were definitely castable 09:25:43 <06advil> which ones? 09:25:49 seracfall was, pretty sure that was the monster version of banishment too 09:26:04 <06advil> was your character in wizmode? 09:26:07 also player wand pseudospells were castable as spells 09:26:09 no 09:26:17 i can upload the save if you want, it was a megazig char i had laying around 09:26:28 Unstable branch on crawl.kelbi.org updated to: 0.30-a0-678-gd14727376c (34) 09:27:11 <06advil> I think PF's commits should cover all those, and I'm not surprised the wand ones were castable, but monster spells if castable are missing a check 09:27:32 Strip Willpower was castable 09:27:46 Primal Wave 09:28:00 Summon Dragon but that was formerly player spell 09:28:10 Pyroclastic Surge 09:28:20 Sentinel's Mark 09:28:35 Virulence 09:28:42 Dimension Anchor 09:28:50 Sticky Flame Range 09:28:59 Call Down Lightning 09:29:28 probably nonexhaustive but there's a missing check somewhere 09:29:37 (unless it was fixed this morning) 09:30:29 <10PleasingFungus> the key missing check was checking that the spell to be memorized was in the player's library 😛 09:30:39 well, yes 09:30:40 that 09:30:46 <06advil> ah, that check is indeed not complete 09:30:54 <10PleasingFungus> oh?! 09:30:57 <06advil> the cast check sorry 09:31:01 <10PleasingFungus> advil: tyvm for fixing the religion check, btw! 09:31:42 <06advil> it only errors if _do_cast returns spret::none, not sure under what circumstances that even will or won't happen 09:32:00 oh, if it helps, every spell i included in that screenshot in the issue was castable 09:32:05 <06advil> guess it does for contrip? 09:32:15 <06advil> I'm not sure if the cast check really needs fixed I guess 09:32:25 it maybe doesn't need fixed if the player can't actually memorise them now 09:32:35 but maybe? who knows what's possible in future 09:32:45 <10PleasingFungus> the world is full of mystery and wonders 09:32:46 couldn't hurt to add an assert 09:33:01 <10PleasingFungus> an assert would crash the game, right? which is what happens now? 09:33:26 well, it happens now if you try to memorise it, not when casting them, if another route opens to cast them, then? 09:34:05 i should probably actually read the total commits this morning before offering input 09:35:31 <06advil> these checks are a bit ad hoc because this code path should only be for wizmode cast, and I'm guessing whoever wrote that added an error msg only for the fallback case, maybe zap spells will work fine on the regular cast path even if monster only (esp. after the fix above) 09:35:36 <06advil> it may be that historically the spflag::monster flag wasn't accurate enough to use for this, too 09:36:16 yes i got the impression that part of the problem there was explicitly because that code was written to handle the wizmode case, maybe the wizmode casting should be separate? 09:36:29 idk thats duplication though 09:36:52 <06advil> wizmode casting is very heuristic and tries to reuse the regular cast code as much as possible 09:46:14 Unstable branch on crawl.kelbi.org updated to: 0.30-a0-683-g636a5c3615 (34) 10:04:50 oh there were also a whole bunch of monster spells that were "castable" but didn't cleanly error and instead did fun things re: crashing the process, Smiting was one of them 10:06:34 <06advil> yes, anything with a zap and missing player tohit will crash the memorise menu 10:07:00 <06advil> I just committed a fix for this for wizmode, but left the crash for regular players who manage to memorise one of these spells 10:07:12 smiting straight up segfaulted if i remember correctly, the crash you're talking about was a different one 10:10:56 gong 10:10:56 GONNNNG! 10:10:58 sometihng broke 10:11:48 i have the +3 mad mage maulers around my neck, apparently 10:12:03 nice 10:12:27 You deliver devastating headbutts? 10:12:30 <09gammafunk> Wow 10:12:31 that used to be dreamshard 10:12:41 then i updated. now its gloves. 10:12:42 <09gammafunk> Good bugs today 10:13:00 https://crawl.kelbi.org/#watch-aesen 10:13:09 <09gammafunk> That sounds like a bad save compat problem 10:13:21 <06advil> that actually seems like we could just leave it, unless they crash when you try to remove them 10:13:42 <06advil> assuming the enum value got reused? 10:13:44 I've seen bugs like that locally when making changes to enums 10:14:04 <06advil> yes, save compat would need to remove the item from equip, but maybe no one bothered 10:15:15 yeah no, that crashed 10:15:35 aesen (L25 DrCA) ASSERT(you.equip[slot] == equip.link) in 'delay.cc' at line 701 failed. (Mismatched link in EquipOffDelay::finish: slot is 3 with link 22, link is 50) (Depths:4) 10:15:43 <06advil> heh 10:16:43 fun 10:16:51 <06advil> can you make a save backup? 10:17:02 in webtiles? 10:17:09 <09gammafunk> ??save backup 10:17:20 <09gammafunk> Rip 10:17:30 <06advil> yeah, sequell is being weird from discord 10:17:37 sure 10:17:42 ??save backup 10:17:42 save backup[1/1]: To get a Save backup, you have to log in via SSH (console), then select (T)runk -> (A)dvanced -> (B)ackup -> (N)ormal . This will give you a link that will allow developers to get a copy of your save and help find bugs. 10:17:52 <09gammafunk> Maybe I need to restart cere 10:20:19 03advil02 07* 0.30-a0-684-g3ae23987fd: fix: add an explicit spflag::monster check in _do_cast 10(17 minutes ago, 1 file, 3+ 0-) 13https://github.com/crawl/crawl/commit/3ae23987fdcc 10:20:19 03advil02 07* 0.30-a0-685-g031d1225b2: fix: prevent a miscast crash on wizmode casting 10(2 minutes ago, 1 file, 8+ 0-) 13https://github.com/crawl/crawl/commit/031d1225b206 10:22:48 http://crawl.kelbi.org/saves/aesen-crawl-git-636a5c3615-230118-1722.tar.bz2 10:22:59 <06advil> thanks 10:23:12 should be depths:4 with mad maulers as necklace 10:25:59 i wouldnt have minded losing dreamshard, but getting -Cast on a caster on zot:5 is kind of rough lol 10:26:14 pajamin (L10 FoFi) ERROR in 'tileweb.cc' at line 234: Socket write error: Resource temporarily unavailable (D:8) 10:26:15 Serfuzz (L15 OgBe) ERROR in 'tileweb.cc' at line 234: Socket write error: Resource temporarily unavailable (Orc:2) 10:26:23 <09gammafunk> Uh oh 10:26:24 spells are for nerds anyway just punch those orbs 10:26:53 <09gammafunk> Problem with Cao @advil? 10:27:38 <09gammafunk> >spells are for nerds anyway just punch those orbs Mumo challenge player propaganda 10:29:48 i will never not shill for dck 10:29:48 Serfuzz (L15 OgBe) ERROR in 'tileweb.cc' at line 234: Socket write error: Resource temporarily unavailable (Orc:2) 10:29:48 <09gammafunk> You take the player out of 4chan but you never take the 4chan out of the player... 10:29:48 <06advil> hm I can't ssh in right now 10:29:48 <06advil> seems bad 10:29:48 <09gammafunk> Oof 10:29:48 <06advil> apache is responding though 10:29:48 <06advil> can you connect? 10:30:29 <06advil> there it goes, maybe 10:30:57 <09gammafunk> I can try on ssh mobile (:yogidaFeels: ) 10:32:14 <09gammafunk> ??console 10:32:22 <09gammafunk> Dammit 10:32:30 <06advil> I did manage to get it 10:32:33 <06advil> *in 10:33:51 <06advil> 2023-01-18 10:29:09,759 WARN: Slow callback (117.766s): wait_for= cb=[_HandlerDelegate.execute..() at /usr/local/lib/python3.10/site-packages/tornado/web.py:2361]> 10:33:59 <06advil> 🙃 10:34:39 Unstable branch on crawl.kelbi.org updated to: 0.30-a0-685-g031d1225b2 (34) 10:36:00 <09gammafunk> Slow lobby? 10:36:05 <10PleasingFungus> bet this is my fault 10:36:16 <06advil> something like this is usually not crawl at all ime 10:36:37 <10PleasingFungus> by this i mean the save compat issue 10:37:15 <09gammafunk> I too can log in but I'll leave it to you advil 10:37:18 <10PleasingFungus> i think i added the new unrand in the wrong place 10:37:31 <10PleasingFungus> trying to figure out if i can fix games that started in the meanwhile 10:37:32 <10PleasingFungus> hm 10:38:06 <06advil> uh oh, did the enum values change 10:38:29 <10PleasingFungus> yeah i think i inserted it into the middle of the list - didn't realize that art-data.txt generated enums via the ordering of the list there, though i really should've 10:38:31 <10PleasingFungus> brain off 10:38:51 <10PleasingFungus> anyway, let's say i move this to the right place. how do i detect games that were started after holy axe was added so that i can shuffle their enums around 10:39:13 <10PleasingFungus> (everything after holy axe's current/broken enum should be moved back 1 once we move holy axe to the right spot) 10:41:04 <06advil> check the name of HOLY_AXE? 10:41:20 <06advil> er, name + number 10:41:32 <10PleasingFungus> i don't understand 10:41:34 <06advil> or just number 10:41:35 <09gammafunk> ??test 10:41:43 <10PleasingFungus> the question is 10:42:20 <10PleasingFungus> someone launches a game in the last few hours and they get, say, the lightning scales. 10:42:29 <10PleasingFungus> that's the enum directly after the (misplaced) holy axe. 10:43:24 <10PleasingFungus> then i move holy axe's enum to the end of the list. that fixes older saves, but now lightning scales in this new save becomes the unrand one earlier, obsidian axe 10:43:30 <10PleasingFungus> or possibly one later. let me think about it for a sec 10:43:42 <10PleasingFungus> uh, one later. 10:44:00 <10PleasingFungus> so it'd become black knight's barding, which is at least thematically appropriate. 10:44:17 <10PleasingFungus> i think this is actually probably impossible to fix. oh well 10:44:38 <10PleasingFungus> i don't think there's any way to tell from the save whether the enum is the intended one or the off-by-one version 10:45:10 <06advil> yeah, seems hard 10:45:12 <10PleasingFungus> ah well 10:45:13 <10PleasingFungus> sorry all 10:45:52 04Build failed for 08stone_soup-0.28 @ 4927b684 06https://github.com/crawl/crawl/actions/runs/3950688815 10:45:54 does it really not save the commithash anywhere in the savefile 10:45:57 <06advil> if you move everything back, current holy axes that are wielded become lightning scales, and so you could just fix up that case, leave everything else ok? 10:46:07 03PleasingFungus02 07* 0.30-a0-686-g08df3a68dd: Remove Morg (moreso) (dilly) 10(13 minutes ago, 3 files, 3+ 3-) 13https://github.com/crawl/crawl/commit/08df3a68dd06 10:46:12 <06advil> *leave everything else as is 10:46:23 <10PleasingFungus> impojin: it does not 10:46:25 <10PleasingFungus> *implojin 10:46:26 <09gammafunk> OK so for some reason messages aren't processed via relay in channels that use relay edit 10:46:49 <06advil> well the commit hash probably is there somewhere but I wouldn't want to rely on it for save compat 10:46:53 that seems like maybe it should for future tags.cc things? 10:46:58 <10PleasingFungus> advil: i don't understand, sorry 10:47:10 03PleasingFungus02 07* 0.30-a0-687-gfa0a19f920: Fix consecrated labrys enum order 10(9 minutes ago, 1 file, 14+ 14-) 13https://github.com/crawl/crawl/commit/fa0a19f92076 10:47:16 all of this stuff in tags is ad-hoc that could presumably? be replaced with commithash checks 10:47:19 <06advil> well, I guess all arts after that point may be off 10:47:24 (if that were actually stored) 10:48:14 <10PleasingFungus> advil: yes, that's what i was saying - all unrands starting with lightning scales will be wrong 10:48:20 <10PleasingFungus> it's not just holy axe that's busted by this move to and back 10:48:39 <10PleasingFungus> ??epic bugs[16 10:48:44 <10PleasingFungus> sigh, relay 10:48:51 ??epic bugs[16 10:48:51 epic bugs[16/27]: shit I think there's no way to actually fix this bug wheals accidentally converted all ego weapons into holy wrath weapons 10:49:06 it's not the same as this bug but it's vaguely reminiscent 10:50:20 <09gammafunk> Hash should be in save, how else could it know when to transfer *eg dgl transfer prompt 10:50:53 <06advil> it is in save (it's shown in ?v and other places), though doesn't that one work via the dgl database? 10:51:35 ??aesen 10:51:35 aesen[1/1]: trunk is the furthest we have strayed from god 10:51:51 <09gammafunk> Well for a given save file 10:51:54 i said this like a week ago, seems appropriate 10:52:02 good luck with this 10:52:02 <06advil> in this case save hash could maybe work in that there are just two affected cko hashes? 10:52:02 accurate tbh 10:52:03 <09gammafunk> It doesn't check db 10:52:40 <06advil> I'm still not sure relying on hashes for save compat is a very good idea 10:52:47 <09gammafunk> Yeah 10:53:29 i guess the problem is cleanly mapping hash ordering from within the marshalling code? 10:54:03 <10PleasingFungus> trivia: anyone with a post-labrys save file who managed to generate a ring of the octopus king will transform that ring into the axe of woe when they upgrade to the current version 10:54:07 <09gammafunk> Maybe if you're 100% about never force pushing and probably other conditions I can't think of 10:54:15 oh, yeah 10:54:21 04Build failed for 08stone_soup-0.27 @ 1b1ada6b 06https://github.com/crawl/crawl/actions/runs/3950690107 10:54:26 is force pushing to trunk a thing that ever happens? 10:54:38 <09gammafunk> Yes (*) 10:54:41 i guess you don't want to rely on it not being a thing 10:54:42 <09gammafunk> Er 10:54:48 <09gammafunk> No (*) 10:55:38 <09gammafunk> But we absolutely try to avoid cuz it can break webtiles installs 10:56:01 <06advil> the repo is now locked so that it can't happen 10:56:33 <09gammafunk> Oh cool 10:57:26 <09gammafunk> advil is the only one I've seen brave enough to do it :gammafHeh: 10:58:09 <09gammafunk> Force pushing I mean 10:58:34 <06advil> heh I only did it by accident didn't I? 10:58:46 <06advil> maybe once by stupidity when I was a new dev and didn't really understand 10:59:08 <06advil> it wouldn't actually solve this case because the problem is cko games that already have the broken versions 10:59:58 <09gammafunk> No I recall a somewhat recent force push involving release tag 11:00:25 <09gammafunk> Maybe that doesn't quite count, but think it was annotated tag 11:05:52 <06advil> ah, yeah that affected tags only 11:06:01 <06advil> no commit hashes were harmed 11:17:20 -!- TAS-2012v is now known as TAS_2012v 11:22:43 Unstable branch on crawl.kelbi.org updated to: 0.30-a0-687-gfa0a19f920 (34) 11:48:03 03advil02 07* 0.30-a0-688-gbdb63f398d: fix: remove whitespace in some menus 10(2 minutes ago, 1 file, 6+ 5-) 13https://github.com/crawl/crawl/commit/bdb63f398d0a 12:05:24 Unstable branch on crawl.kelbi.org updated to: 0.30-a0-688-gbdb63f398d (34) 12:24:34 Stable (0.26) branch on underhound.eu updated to: 0.26.1-16-g4e020e15dc 13:24:11 Stable (0.27) branch on underhound.eu updated to: 0.27.1-36-g1b1ada6b1e 14:24:43 Stable (0.28) branch on underhound.eu updated to: 0.28.0-56-g4927b6849a 14:37:08 03advil02 07* 0.30-a0-689-g8d191d4e4e: fix: don't check spflag::monster for non-spell casts 10(2 minutes ago, 1 file, 6+ 4-) 13https://github.com/crawl/crawl/commit/8d191d4e4ecc 14:50:36 Unstable branch on crawl.kelbi.org updated to: 0.30-a0-689-g8d191d4e4e (34) 15:02:05 my game worked again after commit fa0a19f920768f213a0907a6bb8f7978e389f4d0, thanks 15:02:42 im guessing games started after introducing the new unrand and updated after that commit would still be weird 15:13:40 <06advil> yes 15:13:47 <06advil> but it's not clear it's fixable 15:14:12 <06advil> it's a pretty small time window on cko only, so we'll see if any cases actually come up 15:17:06 03advil02 07* 0.30-a0-690-g4c74721511: refactor: handle spflag::testing and spflag::monster together 10(8 minutes ago, 1 file, 4+ 3-) 13https://github.com/crawl/crawl/commit/4c7472151176 15:17:06 03advil02 07* 0.30-a0-691-g754fce4c43: fix: prevent a divide by zero in weird cases 10(6 minutes ago, 1 file, 2+ 0-) 13https://github.com/crawl/crawl/commit/754fce4c433b 15:24:43 Stable (0.29) branch on underhound.eu updated to: 0.29.1-13-g9f3cf754e1 15:34:19 Unstable branch on crawl.kelbi.org updated to: 0.30-a0-691-g754fce4c43 (34) 16:23:47 Unstable branch on underhound.eu updated to: 0.30-a0-691-g754fce4c43 (34) 17:18:24 mmoncure (L4 DEHu) ERROR in 'tileweb.cc' at line 234: Socket write error: Resource temporarily unavailable (D:5) 17:18:24 Oswolf (L16 DjNe) ERROR in 'tileweb.cc' at line 234: Socket write error: Resource temporarily unavailable (Lair:2) 17:18:30 <09gammafunk> ruh roh 17:18:49 <09gammafunk> @advil the spider returns? 20:48:49 my inbox on this machine has 30k messages in it lol 21:03:00 <08wormsofcan> 30k... unread? 21:10:14 yeah from a busted cron job 21:16:48 <10PleasingFungus> womp womp 21:41:59 <12ebering> From: clippy@crond.microsoft.com Subject: It looks like you're trying to schedule a job 23:04:49 Stable branch on crawl.develz.org updated to: 0.26.1-16-g4e020e15dc (34)