00:15:14 Unstable branch on cbro.berotato.org updated to: 0.30-a0-578-gdee14c521f (34) 00:53:53 Monster database of master branch on crawl.develz.org updated to: 0.30-a0-578-gdee14c521f 01:31:34 Fork (bcrawl) on crawl.kelbi.org updated to: 0.23-a0-4850-gd9e8576752 01:56:18 Fork (stoatsoup) on crawl.kelbi.org updated to: 0.23-s2-166-g2357964f5d 04:22:56 Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-4850-gd9e8576752 05:06:55 Unstable branch on crawl.akrasiac.org updated to: 0.30-a0-578-gdee14c5 (34) 07:51:54 03nicolae02 07[nicolae-netstalgia-0522] * 0.29-a0-458-g0a9a84e0a3: Remove the big room homages for now 10(2 minutes ago, 1 file, 1+ 181-) 13https://github.com/crawl/crawl/commit/0a9a84e0a32c 07:51:54 03nicolae02 07[nicolae-netstalgia-0522] * 0.29-a0-459-g4a74cbe9e0: Checkwhite! 10(32 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/4a74cbe9e08e 07:51:54 Branch pull/2547 updated to be equal with nicolae-netstalgia-0522: 13https://github.com/crawl/crawl/pull/2547 07:56:01 <08nicolae> oof 07:56:07 03nicolae02 {GitHub} 07[nicolae-netstalgia-0522] * 0.30-a0-587-g0c5ede547b: Merge branch 'master' into nicolae-netstalgia-0522 10(29 seconds ago, 0 files, 0+ 0-) 13https://github.com/crawl/crawl/commit/0c5ede547b77 07:56:07 Branch pull/2547 updated to be equal with nicolae-netstalgia-0522: 13https://github.com/crawl/crawl/pull/2547 07:58:13 03nicolae02 {GitHub} 07* 0.30-a0-579-g71422dec44: Add some nostalgic vaults taken/borrowed from Nethack (#2547) 10(12 seconds ago, 2 files, 83+ 0-) 13https://github.com/crawl/crawl/commit/71422dec449f 08:00:20 03nicolae02 {GitHub} 07[nicolae-0722-misc-vaults] * 0.30-a0-590-gc37e1b9610: Merge branch 'master' into nicolae-0722-misc-vaults 10(34 seconds ago, 0 files, 0+ 0-) 13https://github.com/crawl/crawl/commit/c37e1b961007 08:00:21 Branch pull/2601 updated to be equal with nicolae-0722-misc-vaults: 13https://github.com/crawl/crawl/pull/2601 08:07:25 Unstable branch on crawl.kelbi.org updated to: 0.30-a0-579-g71422dec44 (34) 08:13:59 03nicolae02 {GitHub} 07* 0.30-a0-580-g472bc636d8: Svaults sfor sbranches (#2632) 10(47 seconds ago, 5 files, 736+ 0-) 13https://github.com/crawl/crawl/commit/472bc636d828 08:18:12 Unstable branch on crawl.kelbi.org updated to: 0.30-a0-580-g472bc636d8 (34) 08:21:54 <08nicolae> i was gonna get around to merging https://github.com/crawl/crawl/pull/2601 but nobody's left a comment yet 08:58:22 Apparently someone's unable to load their char on cko 09:05:58 04Build failed for 08nicolae-netstalgia-0522 @ 0a9a84e0 06https://github.com/crawl/crawl/actions/runs/3812586506 09:18:33 04Build failed for 08nicolae-netstalgia-0522 @ 4a74cbe9 06https://github.com/crawl/crawl/actions/runs/3812588137 09:18:35 04Build failed for 08nicolae-netstalgia-0522 @ 0c5ede54 06https://github.com/crawl/crawl/actions/runs/3812599322 09:18:37 04Build failed for 08nicolae-0722-misc-vaults @ c37e1b96 06https://github.com/crawl/crawl/actions/runs/3812607077 09:18:38 04Build failed for 08master @ 71422dec 06https://github.com/crawl/crawl/actions/runs/3812603684 09:19:51 04Build failed for 08master @ 472bc636 06https://github.com/crawl/crawl/actions/runs/3812660289 09:41:59 03kate-02 07* 0.30-a0-581-g084b5e0cf6: Fix a missing ENDMAP 10(48 seconds ago, 1 file, 1+ 0-) 13https://github.com/crawl/crawl/commit/084b5e0cf6c6 09:43:30 -!- Glord is now known as g10rd 09:48:08 Unstable branch on crawl.kelbi.org updated to: 0.30-a0-581-g084b5e0cf6 (34) 10:02:21 <08nicolae> oh goddammit 10:02:35 <08nicolae> i must have fucked that up while resolving the conflict 10:03:16 <08nicolae> i have dishonored my ancestors 10:33:44 <09gammafunk> hrm, I seem to have left some review comments, did they not show? 10:42:45 <09gammafunk> ah I see, they don't until it's complete 10:44:55 New branch created: pull/2909 (1 commit) 13https://github.com/crawl/crawl/pull/2909 10:44:55 03Aliscans02 07https://github.com/crawl/crawl/pull/2909 * 0.30-a0-582-g99e9c262fd: Add a few missing options to options_guide.txt 10(75 seconds ago, 1 file, 35+ 10-) 13https://github.com/crawl/crawl/commit/99e9c262fdf6 11:09:28 finally crawl gets some proper shops :) 11:27:20 <06advil> on cdo, anyone know if this is expected?: Your branch and 'local/master' have diverged, and have 2 and 213 different commits each, respectively. (use "git pull" to merge the remote branch into yours) 11:27:40 <06advil> it may be 11:32:40 <06advil> hm, something is weird here for sure 11:32:47 <10PleasingFungus> that seems extremely odd 11:37:23 03Aliscans02 07https://github.com/crawl/crawl/pull/2873 * 0.30-a0-491-g88aa173e06: Make a couple of changes following feedback. 10(69 seconds ago, 2 files, 23+ 34-) 13https://github.com/crawl/crawl/commit/88aa173e0688 11:37:23 <06advil> cdo has some local commit(s) and I think it may rebase on top of them? 11:38:01 <06advil> the weirdness that I'm sure of is that at the end of e.g. generating the install, it does ln -sf "stone_soup-0.30-a0-368-g86fb4627a9-win32-installer.exe" "stone_soup-latest-win32-installer.exe" 11:38:07 <06advil> and then a few lines later, mv: cannot stat 'source/stone_soup-0.30-a0-581-g084b5e0cf6-win32-installer.exe': No such file or directory 11:40:53 <06advil> looks like there may have been some weird interaction with the webtiles version think I added? not sure why git shows deleted: crawl-ref/source/webserver/webtiles/version.txt 11:47:27 <10PleasingFungus> ah gotcha 11:49:52 <09gammafunk> yeah, those local commits need to remain, they are the local build scripts iirc 11:57:55 <08nicolae> that'll do it 11:59:04 <09gammafunk> I'm going to finish my review now so you can see all the comments I've made, the hydra factorization vault is a cool concept but needs some rebalancing and I want to spend some time on that right now 12:00:57 <08nicolae> it needs debalancing 12:01:42 <09gammafunk> a debalanced hydra would simply fall over and flail around on the floor 12:01:53 <09gammafunk> it's very clear that you know nothing of hydra biology 12:02:44 <09gammafunk> review submitted, the suggestions I had for the nicolae_trove_branded_display_cases vault were a bit open ended, and feel free to discuss here if you have other ideas or need feedback after any changes 12:04:27 <09gammafunk> didn't realize that incomplete reviews didn't show any of the comments made so far, but in retrospect that should have been obvious 13:01:50 <09gammafunk> hrm, after looking at this some more, it does seem that everything in the hydra vault is fine, really 13:02:35 <09gammafunk> a couple more syntax suggestions and one suggestion re: loot is all I'll add 13:18:31 <09gammafunk> @nicolae ok, PR fully reviewed with my suggestions for the hydra vault as well 13:27:04 <08nicolae> ah, home from an errand, time to look at gammafunk's suggestions and ignore them utterly 14:03:09 <09gammafunk> Go ahead, the players will revolt and it will be the biggest dcss debacle since stat locked gnolls 14:07:22 <10PleasingFungus> i wonder what the biggest dcss debacle was 14:07:30 <10PleasingFungus> depends how you define it probably 14:08:43 <10PleasingFungus> nominees include md, shadow traps, and the various ancient and mostly forgotten dev drama 14:09:25 * geekosaur still remembers the great revert war 14:28:23 <09gammafunk> honestly I don't think shadow traps were that big of a debacle, just a thing people didn't like, and there have been a lot of things players don't like 14:28:53 <09gammafunk> md removal was a big deal with a lot of player complaining certainly 14:30:11 <09gammafunk> do think that forest dispersal and the fallout that resulted in like 4 people stepping back from the project was probably the single biggest dramatic thing 14:30:29 <10PleasingFungus> probably 14:30:44 <10PleasingFungus> i only remember 3 14:34:10 <09gammafunk> you probably don't remember SamB, who contributed mostly build-related stuff, but he was an irc regular both before and after I joined the team. He wasn't happy with the result either and said as much before leaving 14:34:54 <10PleasingFungus> ahh 14:34:57 <10PleasingFungus> rip 14:35:10 <10PleasingFungus> the name is very faintly familiar 14:35:13 <10PleasingFungus> sad affair 14:39:41 <09gammafunk> I would sort of nominate the general apex of trolling that was reached between post 0.20 through 0.24, but that wasn't really due to any changes in the project itself per se, although it did coincide with relatively fewer changes in those releases. We had lost 1kb and grunt, PF retired, kate wasn't around too much, and we didn't have advil until some time in 0.21, and no ebering, hellmonk, or bennu PF (the returned form of PF) 14:39:49 <09gammafunk> Was just a hard time for the project in general 14:41:02 <08nicolae> of course, the project did not truly realize the full potential of its comeback until that fateful day when nicolae returned, and everyone cheered 14:41:48 <09hellmonk> glad it's over tbh 14:41:55 <09gammafunk> yes 15:15:30 03nicolae02 07[nicolae-0722-misc-vaults] * 0.30-a0-591-g6abbf6629b: Make some changes based on feedback (gammafunk) 10(72 seconds ago, 4 files, 66+ 33-) 13https://github.com/crawl/crawl/commit/6abbf6629b4f 15:15:30 Branch pull/2601 updated to be equal with nicolae-0722-misc-vaults: 13https://github.com/crawl/crawl/pull/2601 15:19:23 <08nicolae> @gammafunk made some changes, hope you like em, also did you have any thoughts on the stuff in https://github.com/crawl/crawl/pull/2896 it's not vaults but i figure it's a big list of stuff, might as well have an eyeball or two on it before i windmill slam the merge button 15:21:00 <08nicolae> or at least have some plausible deniability so when somebody gets a randbook with an accidental innuendo name i can say "hey i TOLD them to look at it," 15:27:34 <10PleasingFungus> i told them to… look at it 😉 15:34:23 <09gammafunk> I will not stand by as this project is inundated with a flood of outrageous gerunds 15:43:50 03PleasingFungus02 07* 0.30-a0-582-gcd7af8bf02: Add new splash screen (Micah C) 10(7 minutes ago, 4 files, 4+ 1-) 13https://github.com/crawl/crawl/commit/cd7af8bf0218 15:45:45 <08nicolae> i thought you liked my gerunds 15:48:23 Unstable branch on crawl.kelbi.org updated to: 0.30-a0-582-gcd7af8bf02 (34) 15:48:31 "you're ger(o)unded!" 15:49:12 <09gammafunk> yes, I like the gerunds, which are outrageous, but I will not be simply standing by as we are inundated by them 15:49:24 <09gammafunk> I will probably be taking a light nap 15:50:48 <09gammafunk> I left my approval. My only contribution was to look up the definition of "sibylline" because I had no idea what that meant 15:51:11 <10PleasingFungus> i hope you found the meaning by consulting an appropriate oracle 15:52:13 03PleasingFungus02 07* 0.30-a0-583-g19bae12e61: Improve doom hound description 10(3 minutes ago, 1 file, 4+ 3-) 13https://github.com/crawl/crawl/commit/19bae12e61f0 15:52:14 <09gammafunk> somewhat unfortunate that my only possibly reaction emoji after searching for "prophet" is 🥠 15:52:36 <09gammafunk> although 🔮 would have worked 15:53:04 Windows builds of master branch on crawl.develz.org updated to: 0.30-a0-581-g084b5e0cf6 15:54:38 <06advil> I think I have unwedged the cdo windows build 15:55:23 <06advil> not sure exactly what was wrong with it, except that the repo was in an odd state, but possibly whatever code there is in those scripts that is supposed to detect errors isn't working 15:55:31 <09gammafunk> interesting 15:55:46 <09gammafunk> I wonder if my messing around with monster builds could have caused it 15:55:57 <06advil> that is in a separate repo I think 15:55:59 <09gammafunk> would sort of need to pinpoint when it broke 15:56:02 <09gammafunk> ah 15:56:19 <09gammafunk> yep, I see 15:57:44 <09gammafunk> weird, we have a clone of "gruesome", a roguelike made by darren grey that lets you play as a grue 15:58:03 <09gammafunk> with various commits made by 1kb! 16:00:04 <09gammafunk> https://cdn.discordapp.com/attachments/747522859361894521/1058882261551939716/image.png 16:02:51 <09gammafunk> I just cast Shadow Ball (costs 2 SP) on an adventurer walking around with a lamp. It blinded her and I was able to devour 16:03:52 Unstable branch on crawl.kelbi.org updated to: 0.30-a0-583-g19bae12e61 (34) 16:13:11 03PleasingFungus02 07* 0.30-a0-584-ge794ca7099: Make Doom Hounds' Howl Will-resistable 10(3 minutes ago, 2 files, 20+ 12-) 13https://github.com/crawl/crawl/commit/e794ca709921 16:17:24 03nicolae02 {GitHub} 07* 0.30-a0-585-g93115170b9: Add more entries to randbook.txt (#2896) 10(33 seconds ago, 1 file, 1400+ 389-) 13https://github.com/crawl/crawl/commit/93115170b904 16:17:47 <08nicolae> oh yeah there's gonna be some visits to dictionary dot com 16:18:50 Unstable branch on crawl.kelbi.org updated to: 0.30-a0-584-ge794ca7099 (34) 16:23:28 Unstable branch on underhound.eu updated to: 0.30-a0-583-g19bae12e61 (34) 16:33:28 Unstable branch on crawl.kelbi.org updated to: 0.30-a0-585-g93115170b9 (34) 16:45:06 <08nlavsky> my fav new title: "@_the_bookmagic@ and You" 16:45:10 <09gammafunk> hrm, so looking at targeters more closely, there's no simple way to tell if, say, the beam targeter affects an intervening monster when targeting a monster later in the beam path? Specifically for the purpose of knowing whether the shot could be blocked by hitting one of said intervening monsters 16:46:08 <08nlavsky> Also # Various wizards/mages/alchemists from real-world history/folklore # I avoided modern/pop-culture figures ... w:1 Nicolae 👀 16:46:29 <09gammafunk> obviously you have a set of monsters that all have AFF_YES for their respective locations, but that doesn't really tell you whether one monster is in front of another 16:46:47 <09gammafunk> I guess you can combine that set with the set of distances of the relevant monsters though 16:47:10 <09gammafunk> since each point along the ray path has a different distance from the fire origin 17:14:17 Can someone help illuminate tile-flags.h? 17:14:48 Specifically how the background flags are tied to overlay images 17:17:09 <09gammafunk> via DungeonCellBuffer::pack_background( in tiledgnbuff.cc 17:17:59 <09gammafunk> checks for the flag, adds a corresponding tile to the DungeonCellBuffer background 17:18:06 beaut, thanks 17:18:38 <09gammafunk> of course the javascript implementation for webtiles does it's own analogous thing 17:21:01 and then tile-feat.html specifies the actual images? 17:22:53 <09gammafunk> for webtiles? No, I don't think those files are directly used by the client 17:23:02 <09gammafunk> the html files, I mean 17:27:30 <09gammafunk> everything the webtiles client uses is in the webserver subdir, the enum values are encoded in webserver/game_data/static/tileinfo*.js 17:27:52 <09gammafunk> which are auto-generated 17:28:35 <09gammafunk> the client works directly with the generated tilesheets, not with individual files 17:31:39 <09gammafunk> and those same js files have coordinates in the tilesheets etc, the logic in the web client I was referring to would be in webserver/game_data/static/cell_renderer.js, again grep for an example like LANDING to see the relevant code. This has to be modified in a corresponding way if you're adding new background tile flags and tiles 17:34:03 @gammafunk: you can test beam interaction with mons using clua like so, although I've no idea if there's a more "proper" way to do it built into the beam code somewhere 17:34:12 https://github.com/Implojin/implo-rc/blob/main/init.lua#L495 17:35:40 <09gammafunk> oh, spells.path, interesting 17:35:50 going to go back to playing splatoon now so leave me a message if there's followups 17:35:54 <09gammafunk> I assume this doesn't work with general quiver stuff though, like a luancher? 17:36:38 <09gammafunk> I can check it out further, thanks 17:38:37 <09gammafunk> yeah this is the type of interface I need, just need it for the quiver in general 17:39:47 <09gammafunk> also would be good to implement this in a cleaner way, using targeters and not setting up a beam, since it would both work with all kinds of spells and would work with non-spell things 17:43:45 <09gammafunk> @advil I was thinking of creating a lua interface to targeters that would to the clua spells.path function but for anything in the quiver. Basically it would use targeting_iterator and probably specifcally targeter::affected_iterator, including the threshold parameter. The only question is setup required to load the targeter of the quiver and whether there are any gotchas for stuff like information leaks. I suppose it would be ideal 17:43:45 if you could call this for any spell/ability/item even if it wasn't quivered, but that's probably getting ahead of things 18:11:34 <09gammafunk> hrm, looking a bit closer at how the quiver works, seems like that might not be so simple 18:18:23 consider everything in my rc gpl'ed if it would help to pull it into crawlcode somewhere, but it's presumably better to implement that stuff on the c side if it doesn't exist already, the existing cell_see_cell and such checks are not very useful for lof purposes 18:19:01 lots of subtle bugs if you try to go that way 18:20:22 <09gammafunk> no, this would be something we'd basically completely do from the c++ side as part of the lua api 18:20:33 <09gammafunk> it would work similarly to spells 18:20:57 <09gammafunk> although yeah maybe you're talking about checking blocking based on the results of that api 18:28:04 <09gammafunk> seems odd to me that spells.path always sets aimed_at_spot 18:29:00 <09gammafunk> to true, that is 19:11:43 I think spells.path was trying to replicate the behavior of aiming a targeter using . 19:11:54 at the given coords 19:15:32 actually if you wanted to do this on the c++ side you could presumably just test beam.path_taken like rampage does 19:17:23 well, i guess it depends on what you're trying to do and if you're comparing against fancier spell stencils 19:27:47 <09gammafunk> I think you'd just want to use the targeter class and avoid directly messing with beams at all 19:28:19 <09gammafunk> Since all spells/abilities/launchers etc have a corresponding targeter yet many of those things don't use a beam at all 19:28:38 <09gammafunk> The issue is resolving the thing quivered to a targeter 19:29:21 <09gammafunk> once you have a targeter you even have a nice iterator for the set of affected cells, which includes whether it's AFF_YES or AFF_MAYBE 19:30:43 <09gammafunk> but looking at the quiver code, it's not precisely in the business of resolving actions to targeters, it calls a relevant higher level function 19:31:43 <09gammafunk> however it may be possible to break the actions into relevant cases and call a relevant thing to look up the desired targeter 19:33:15 <09gammafunk> what I'm going to do for now is just use the monster target evaluation code we already have for qw (modifying it slightly for ranged combat) and use the fancy new(ish) crawl.do_targeted_command() 19:33:28 <09gammafunk> and use the fact that this returns false if no action was performed, allowing me to proceed to the next target 19:33:47 <06advil> I'm not sure of the exact context but a general problem is that targeters are only sometimes used for actual casting, and more often just used for ui 19:33:47 <09gammafunk> and if it happened to shoot at a monster and hit something in the way, well that monster shouldn't have been standing there! 19:34:10 <06advil> I added those iterators as part of a larger effort towards unifying them, but it's still very sporadic 19:34:45 <09gammafunk> right, so it sounds like I'll have to roll a bit of my own logic for determining what targeter I need 19:35:39 <09gammafunk> kind of branching it based on the thing I'm looking up, like if it's a spell or if it's a launcher 19:36:16 <06advil> %git 5fe6d566ddce74 19:36:16 <04Cerebot> advil * 0.29-a0-1064-g5fe6d566dd: fix: make frog hop targeting exactly match fuzzing (5 months ago, 5 files, 125+ 26-) https://github.com/crawl/crawl/commit/5fe6d566ddce 19:37:07 <06advil> that commit gives an example of the kind of mismatch that often exists 19:37:29 <06advil> it's definitely concentrated in the exotic targeters ofc 19:41:08 <09gammafunk> cpp // somewhat magical value for centre that I have copied from elsewhere const coord_def centre(9,9); Nice 19:41:28 <06advil> heh that looks like a comment I would write 19:47:24 <10PleasingFungus> well, as long as it’s only somewhat magical, 20:36:31 <09gammafunk> hrm, I may be able to get what I need for now using spells.path if all the relevant wands have a spell I'm allowed to look up with that interface 20:38:54 <09gammafunk> > crawl.mpr(spells.max_range("Iceblast")) 5 \o/ 20:41:08 <09gammafunk> nice, and spells.path works as well 20:41:35 <09gammafunk> now I need a los-range non-penetrating spell to use for launchers 20:42:13 <09gammafunk> and I guess a hex would work for that 20:42:42 <09gammafunk> better yet, magic dart 20:59:35 <08nicolae> hey, there's me. i'm discord| 21:03:46 <09gammafunk> Implojin: Yeah, I will actually end up using this spells.path interface for now, since it meets my needs for ranged combat, so thanks for pointing out its existance. I might turn aimed_at_spot into a parameter (defaulting to true) 21:14:45 <09gammafunk> although one thing I need is a spell with both penetration and los range that doesn't bounce (maybe not bouncing isn't important though) 21:17:58 <09gammafunk> looks like quicksilver bolt (presumably purple drac breath) would work 21:19:43 digging should technically also count 21:22:23 <09gammafunk> digging would problematically travel through walls 21:22:27 <09gammafunk> well, diggable ones 21:22:50 <09gammafunk> would would give false results about whether monsters with intervening walls would get hit 21:26:33 Ah, right 21:34:25 another thing that would be really handy if you start extending clua targeting is to have monster ability damage exposed somewhere in l-moninf 21:35:36 sounds like you're doing something playerside though so maybe not necessary for your thing, but right now the only way to get that is with string.gmatch patterns against mons:desc(true) which is pretty fragily given the different ways the game tries to display mons ability damage 21:35:44 fragile 21:36:46 <09hellmonk> this is totally unrelated to the current conversation but the current implementation of shatter can hit monsters that the player does not know about when you cast it. Would be nice to fix this somehow, in theory you could get no warning penance tho I think the setup for that isn't something that will naturally occur 21:37:49 <09gammafunk> Implojin: yes, that's definitely something I've been thinking about once I move into threat evaluation. I suppose a simple monster spell interface that just gives range and damage die would be the starting point 21:38:21 yeah i think between my scripts and your work on qw we're probably running into similar issues 21:39:07 <10PleasingFungus> seems pretty fixable tbqh 21:39:11 <09gammafunk> presumably that's when they're behind a wall that gets shattered and the iteration proceeds to hit the now-revealed monster? 21:39:17 <09hellmonk> yeah 21:40:16 <10PleasingFungus> make a set of initially visible monsters and only hit them 21:40:33 <10PleasingFungus> maybe exclude stuff behind transparent rock if you want 21:40:37 <10PleasingFungus> bada bing bada boom 21:55:19 <09gammafunk> yeah, shatter would essentially require los_no_trans before casting had begun 23:51:10 Windows builds of master branch on crawl.develz.org updated to: 0.30-a0-585-g93115170b9