00:07:13 <08nicolae> wait since when can i delete reactions 00:07:21 <08nicolae> what the fuck 00:07:34 <08nicolae> i'm sorry! i should not have pressed that x 00:07:41 <08nicolae> i'm a monster 00:31:49 Unstable branch on cbro.berotato.org updated to: 0.30-a0-534-gdc55766716 (34) 00:54:32 Monster database of master branch on crawl.develz.org updated to: 0.30-a0-534-gdc55766716 01:34:15 Fork (bcrawl) on crawl.kelbi.org updated to: 0.23-a0-4850-gd9e8576752 04:22:25 Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-4850-gd9e8576752 05:17:04 Unstable branch on crawl.akrasiac.org updated to: 0.30-a0-534-gdc55766 (34) 06:38:44 <09gammafunk> @nlavsky grats on becoming orange and officially getting the dev bit! 07:29:44 <12ebering> @nlavsky no it means you must recruit a new community contributor who cleans up edge cases 😉 07:34:00 <08nlavsky> Edge cases is my specialty, so I'd need to find someone who cleans up edge cases of edge cases. 09:14:03 03nlavsky02 07* 0.30-a0-535-g2c0b3469a7: docs: update some links in the new developer docs 10(2 minutes ago, 1 file, 3+ 3-) 13https://github.com/crawl/crawl/commit/2c0b3469a738 09:15:00 <08nlavsky> Unlimited power! 09:19:08 Unstable branch on crawl.kelbi.org updated to: 0.30-a0-535-g2c0b3469a7 (34) 10:16:50 <06advil> discussion topic: should we close new bug reports on mantis 10:38:25 <10PleasingFungus> advantage is less duplication of bugs, fewer places to look, fewer dev accounts to maintain 10:38:54 <10PleasingFungus> disadvantage is maybe losing reports from oldschool reporters 10:39:45 This oldschool reporter stopped Mantising a while back 12:10:46 I've been trying to grasp the knockback code with intent of refactoring it, and was hoping I could confirm a few things 12:10:46 First; as written, knockback is applied along whatever ray the spell follows. This means, for example, that you can control to a high degree where phial of floods sends creatures by aiming past them. 12:10:47 This currently only affects phial of floods. 12:10:47 Is this something that should be preserved? It feels unintended 12:10:48 Second; the actual knockback has side effects, namely advancing the beam 12:10:48 lines 4639 - 4662 of beam.cc are the relevant code. 12:10:49 If I read this right 12:10:49 Is this something that needs to be preserved for some dumb hack? 12:12:02 * if I read this right, the ray gets advanced during knockback, and only gets reset to it's original state if the actor being knocked collides with something 12:16:15 I think this affects force lance and (something else I'm forgetting) 12:19:58 Well, force lance (and wind drake gust) aren't ever player aimed, so it's always the default ray from mons to you 12:20:15 yeh, I was thinking of when force lance was also a player spell 12:20:52 so it may be a leftover 12:21:44 hm, I think at one point there was also a player spell that could knockback up to 4 spaces if you pressed . after firing it, but I think that became searing ray? 12:26:22 chilling breath maybe? 12:26:59 wait no that's drac breath 12:36:56 <10PleasingFungus> re aiming past, i’m not sure it’s a problem to allow player control 12:37:21 <10PleasingFungus> vaguely wonder if it’d avoid some fiddly positioning 12:39:06 <10PleasingFungus> strongly suspect the side effect is not important, but can’t say 12:40:36 I want to get rid of both of these bc I want to decouple knockback from beams 12:59:50 <10PleasingFungus> sounds fine. also, why 13:00:00 <10PleasingFungus> (fine to remove both) 13:00:44 you sure you want to touch the beam code? 🙂 13:00:59 I've spent... an awful long time figuring it out 13:01:20 to middling success 13:01:23 someone understands it now?? 13:01:31 I think so! 13:01:35 kind of! 13:03:26 but yeah, right now knockback switches on ORIGIN_SPELL to determine whether knockback should be applied, and how much 13:04:15 but for non-spell knockback this requires a dummy spell or an evil hack 13:06:32 for example, storm card right now creates a beam and rewrites the knockback code 13:12:25 <10PleasingFungus> beam code is arguably not as bad as it once was 13:12:27 <10PleasingFungus> maybe 16:09:12 03advil02 07* 0.30-a0-536-gdf6ecd2dc0: refactor: simplify `wield_weapon` signature 10(30 hours ago, 4 files, 13+ 45-) 13https://github.com/crawl/crawl/commit/df6ecd2dc0cb 16:09:12 03advil02 07* 0.30-a0-537-g6c4b56ed3b: refactor: separate weapon swap from regular wield code 10(25 hours ago, 8 files, 71+ 60-) 13https://github.com/crawl/crawl/commit/6c4b56ed3b05 16:09:12 03advil02 07* 0.30-a0-538-g7acccb668d: feat: unified equip menu 10(7 hours ago, 10 files, 226+ 208-) 13https://github.com/crawl/crawl/commit/7acccb668da7 16:09:12 03advil02 07* 0.30-a0-539-gcd1ce1e3ba: feat: add a generalized unequip menu 10(2 minutes ago, 11 files, 319+ 164-) 13https://github.com/crawl/crawl/commit/cd1ce1e3ba0b 16:19:04 <08nlavsky> One Ring Command to rule equip them all! 16:20:57 <05kate> ooh, exciting 16:22:02 <05kate> that's got to be up there in terms of longest-standing FRs 16:22:49 <06advil> it was surprisingly easy to do (once I'd refactored everything else in that file repeatedly) 16:23:34 <06advil> though tbh I do not expect this to be a bug free feature merge, just based on how much this touches 16:24:40 Unstable branch on underhound.eu updated to: 0.30-a0-535-g2c0b3469a7 (34) 16:32:16 03advil02 07* 0.30-a0-540-g0af01429fa: fix: mark a static (Aliscans) 10(46 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/0af01429fa3c 16:43:37 Unstable branch on crawl.kelbi.org updated to: 0.30-a0-539-gcd1ce1e3ba (34) 16:48:40 Unstable branch on crawl.kelbi.org updated to: 0.30-a0-540-g0af01429fa (34) 17:10:02 New branch created: pull/2896 (2 commits) 13https://github.com/crawl/crawl/pull/2896 17:10:02 Branch pull/2896 updated to be equal with nicolae-more-randbooks: 13https://github.com/crawl/crawl/pull/2896 17:10:07 <08nicolae> just now realized i forgot to actually make a pull request for that 18:29:41 -!- jfcaron_ is now known as jfcaron 21:35:28 -!- valentine7 is now known as valenthyme 23:17:24 -!- Guest83 is now known as superradish 23:54:52 -!- Guest83 is now known as superradish