00:50:09 Unstable branch on cbro.berotato.org updated to: 0.30-a0-469-g84de5afbc5 (34) 00:54:19 Monster database of master branch on crawl.develz.org updated to: 0.30-a0-469-g84de5afbc5 01:48:40 Fork (bcrawl) on crawl.kelbi.org updated to: 0.23-a0-4850-gd9e8576752 03:55:50 03Aliscans02 07https://github.com/crawl/crawl/pull/2873 * 0.30-a0-438-g5d8e3f0999: Only declare from_webtiles with USE_TILE_WEB. 10(24 seconds ago, 1 file, 2+ 0-) 13https://github.com/crawl/crawl/commit/5d8e3f0999b0 04:23:12 Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-4850-gd9e8576752 05:30:32 Unstable branch on crawl.akrasiac.org updated to: 0.30-a0-469-g84de5af (34) 08:08:28 03advil02 07[android] * 0.30-a0-494-g05911a2283: docs: add a note about android to INSTALL.md 10(3 minutes ago, 1 file, 6+ 0-) 13https://github.com/crawl/crawl/commit/05911a22837d 08:27:02 <06advil> wondering about thinning out the ci matrix a bit 08:27:05 03advil02 07[android] * 0.30-a0-495-g367de1291c: build: tweak CI order for android 10(86 seconds ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/367de1291c5e 08:45:56 03advil02 07* 0.30-a0-470-g6ac2e24f95: build: remove a duplicate CI job 10(10 minutes ago, 1 file, 0+ 5-) 13https://github.com/crawl/crawl/commit/6ac2e24f953a 08:45:56 03advil02 07* 0.30-a0-471-g4f163fc199: build: cut a job from CI 10(2 minutes ago, 1 file, 3+ 0-) 13https://github.com/crawl/crawl/commit/4f163fc199d4 08:50:35 Unstable branch on crawl.kelbi.org updated to: 0.30-a0-471-g4f163fc199 (34) 12:23:36 New branch created: nosteppy (1 commit) 13https://github.com/crawl/crawl/tree/nosteppy 12:23:36 03hellmonk02 07[nosteppy] * 0.30-a0-468-gc456f30de6: Adjust constriction 10(26 hours ago, 3 files, 7+ 8-) 13https://github.com/crawl/crawl/commit/c456f30de6ce 12:24:39 New branch created: pull/2883 (1 commit) 13https://github.com/crawl/crawl/pull/2883 12:24:39 Branch pull/2883 updated to be equal with nosteppy: 13https://github.com/crawl/crawl/pull/2883 12:26:45 03advil02 07[android] * 0.30-a0-496-gc78de03d82: build: attempt to enable ccache for android 10(2 minutes ago, 1 file, 3+ 0-) 13https://github.com/crawl/crawl/commit/c78de03d826b 13:29:10 -!- allbery_b is now known as geekosaur 14:35:19 <10PleasingFungus> aliscans: https://github.com/crawl/crawl/actions/runs/3730743317/jobs/6328154086 has a more useful error for your PR: initfile.cc:5730:34: error: non-virtual member function marked 'override' hides virtual member function int highlight_colour() const override ^ ./menu.h:175:17: note: hidden overloaded virtual function 'MenuEntry::highlight_colour' declared here: different number of 14:35:19 parameters (1 vs 0) virtual int highlight_colour(bool /*unused in superclass*/ = false) const 14:36:32 <10PleasingFungus> something weird going on there tbh 14:36:39 <10PleasingFungus> since i don't see that bool param in menu.h 14:45:51 That extra parameter is in trunk, so I wonder if it's somehow getting confused? 14:49:44 <10PleasingFungus> could be a cache issue of some kind 14:52:23 The version at https://github.com/Aliscans/crawl/actions/runs/3730742808/jobs/6332718771 was more successful, only failing the Catch2 step. 14:54:12 <06advil> the error message is pasting the relevant line from menu.h, no? 14:54:27 With Catch2, it fails to compile with an error for MINSIGSTKSZ. At https://github.com/catchorg/Catch2/issues/2421 they think that's a version conflict. 14:54:36 advil: It's not my line, though. 14:56:59 It was added in 43e804b486, and my PR was from before then. 14:58:20 <06advil> oh, as in your patch is against a version before that param was added? 14:58:31 <06advil> odd 14:59:08 <10PleasingFungus> yes, the relevant line in menu.h does not have that parameter in aliscans' branch - i checked it out locally to confirm 14:59:37 <06advil> I might just try clicking the rerun button? 15:01:29 <06advil> error: ‘int EGP_MenuEntry::highlight_colour() const’ marked ‘override’, but does not override is consistent with the other error 15:01:59 <06advil> which is what I see on the catch2 failure 15:02:20 <06advil> well, sort of consistent 15:03:31 <06advil> I think that's just a matter of how gcc vs clang errors for that case 15:03:39 advil: No, the one on the branch is a separate build which actually compiles the game before failing to compile catch2-tests/test_main.c. 15:04:07 <06advil> oh, you may need to merge some stuff from trunk for catch2 to build 15:05:54 <06advil> yeah your patch is against 7412bad402dd, which was the first of a series of 5 CI-fixing commits that (among other things) upgraded catch2 15:06:24 <06advil> CI was broken by some upstream changes right before that 15:06:38 <06advil> you will need all 5 probably 15:06:52 <06advil> %git 5d0fae55698c 15:06:53 <04Cerebot> advil * 0.30-a0-428-g5d0fae5569: build: ignore catch2 in unbrace (10 days ago, 1 file, 1+ 0-) https://github.com/crawl/crawl/commit/5d0fae55698c 15:10:11 It sounds as though updating the branch to trunk and fixing whatever issues that throws up may help with both errors. 15:10:56 <06advil> %git 7412bad402dd..5d0fae55698c 15:10:56 <04Cerebot> advil * 5d0fae55698c: build: ignore catch2 in unbrace (10 days ago, 1 file, 1+ 0-) https://github.com/crawl/crawl/commit/5d0fae55698c 15:11:06 <06advil> ah well, didn't think that would work 15:11:33 <06advil> yes, updating to trunk might help 15:11:44 <06advil> hm those highlighter CI failures do replicate 15:11:52 <06advil> very odd, nothing about the source should be cached 15:11:58 I'll give that a go, then. Thanks for your help so far. 15:23:50 <10PleasingFungus> @Sastreii sorry for delay! santa hat is online 🙂 15:23:57 03PleasingFungus02 07* 0.30-a0-472-gecbe3e46b9: Give Sigmund some holiday spirit (CanOfWorms) 10(30 minutes ago, 10 files, 29+ 2-) 13https://github.com/crawl/crawl/commit/ecbe3e46b98e 15:23:57 03PleasingFungus02 07* 0.30-a0-473-gde979b18e0: Add cozy, easy-to-wear holiday hats (Sastreii) 10(14 minutes ago, 6 files, 9+ 1-) 13https://github.com/crawl/crawl/commit/de979b18e02c 15:23:57 03PleasingFungus02 07* 0.30-a0-474-g5673dd7ce6: Enable Grinch Mode 10(58 seconds ago, 5 files, 16+ 2-) 13https://github.com/crawl/crawl/commit/5673dd7ce6a3 15:23:58 <10PleasingFungus> @wormsofcan sigmund now fully candy caned up 15:25:08 <06advil> well, I seem to be able to replicate the weird repo state by following the checkout steps in the action (essentially fetching the PR), even though when I fetch from your branch directly I do not get 15:25:21 <06advil> the weird state 15:27:47 <06advil> the last thing I see is a merge commit whose hash doesn't appear in the branch fetched directly 15:28:19 <06advil> Specifically, Merge 5d8e3f0999b0beeca3cf2f5d4cadefa55fbfbd41 into 84de5afbc506cfc1e143d0978f5262264e0fc8a3 15:28:28 <06advil> where the latter is definitely after the change to the menu highlighter 15:28:49 <06advil> but I really have no clue why this wouldn't appear in the branch the PR is based on 15:29:17 <06advil> ^ Aliscans 15:30:28 <06advil> hm I wonder if chei has it 15:30:30 <06advil> %git 4b4137d8b60ab 15:30:31 <04Cerebot> Aliscans {GitHub} * 0.30-a0-484-g4b4137d8b6: Merge 5d8e3f0999b0beeca3cf2f5d4cadefa55fbfbd41 into 84de5afbc506cfc1e143d0978f5262264e0fc8a3 (12 hours ago, 0 files, 0+ 0-) https://github.com/crawl/crawl/commit/4b4137d8b60a 15:30:35 <06advil> yeah, that one 15:39:10 04Build failed for 08master @ 5673dd7c 06https://github.com/crawl/crawl/actions/runs/3735671703 15:43:08 Sorry, I was just looking at it. I have had a local hook which I was using to stop git from committing changes to fixedarray.h. Maybe it somehow changed the PR in some way without changing the branch. 16:00:39 Unstable branch on crawl.kelbi.org updated to: 0.30-a0-474-g5673dd7ce6 (34) 16:20:34 03PleasingFungus02 07* 0.30-a0-475-g03497ec522: Remove MONS_NO_MONSTER from Orc spawn tables 10(82 seconds ago, 2 files, 1+ 2-) 13https://github.com/crawl/crawl/commit/03497ec52293 16:24:09 Unstable branch on underhound.eu updated to: 0.30-a0-474-g5673dd7ce6 (34) 16:34:46 Unstable branch on crawl.kelbi.org updated to: 0.30-a0-475-g03497ec522 (34) 16:35:01 04Build failed for 08master @ 03497ec5 06https://github.com/crawl/crawl/actions/runs/3735993722 17:15:22 <09gammafunk> the grinch can even ruin Halloween? I should have known 17:17:02 <09hellmonk> halloween is grinch night gammafunk 17:17:06 <09hellmonk> respect the lore 17:35:21 <10PleasingFungus> shoulda made it yes/no/always and allowed all holiday stuff on year round 17:36:04 <10PleasingFungus> i wonder what chinese holiday would have the best gimmick tiles. lunar new year? 18:16:57 <09gammafunk> I don't know any chinese holiday aside from lunar new year 18:17:17 <09gammafunk> have players start in a pocket lehudib wizlab 18:19:08 <10PleasingFungus> midautumn festival has moon cakes 18:19:26 <10PleasingFungus> but we removed food… 18:19:49 make it moon pies and bring back jesters 😛 18:19:55 <10PleasingFungus> rethem klown effects? red bean instead of cherry 18:19:59 <10PleasingFungus> etc 18:22:02 <09gammafunk> that would be cute 18:22:36 <09gammafunk> probably better if it's a thing that appears earlier though 18:25:19 03Aliscans02 07https://github.com/crawl/crawl/pull/2873 * 0.30-a0-472-gbe55acbca9: Create a GUI to set GameOption options. 10(11 days ago, 11 files, 324+ 95-) 13https://github.com/crawl/crawl/commit/be55acbca982 18:25:19 03Aliscans02 07https://github.com/crawl/crawl/pull/2873 * 0.30-a0-473-g5c46db0304: Only set a few special menu colours when a keyword is a complete word. 10(11 days ago, 1 file, 22+ 22-) 13https://github.com/crawl/crawl/commit/5c46db0304e6 18:25:19 03Aliscans02 07https://github.com/crawl/crawl/pull/2873 * 0.30-a0-474-gcd986ac64a: Display the first name in the GameOption::names list. 10(9 days ago, 2 files, 15+ 19-) 13https://github.com/crawl/crawl/commit/cd986ac64a5d 18:25:19 03Aliscans02 07https://github.com/crawl/crawl/pull/2873 * 0.30-a0-475-g29a9f87684: Set Options.prefs_dirty when relevant options are set in the GUI. 10(9 days ago, 3 files, 57+ 33-) 13https://github.com/crawl/crawl/commit/29a9f8768417 18:25:19 03Aliscans02 07https://github.com/crawl/crawl/pull/2873 * 0.30-a0-476-g0cd549d6b6: Add a search command, which filters the displayed list of options. 10(9 days ago, 1 file, 108+ 6-) 13https://github.com/crawl/crawl/commit/0cd549d6b63c 18:25:19 03Aliscans02 07https://github.com/crawl/crawl/pull/2873 * 0.30-a0-477-g53f585f8bd: Add help feature to the options menu and some submenus. 10(9 days ago, 4 files, 135+ 35-) 13https://github.com/crawl/crawl/commit/53f585f8bdee 18:25:19 03Aliscans02 07https://github.com/crawl/crawl/pull/2873 * 0.30-a0-478-g07b561d8f9: Arrange the options according to the help files. 10(9 days ago, 4 files, 107+ 27-) 13https://github.com/crawl/crawl/commit/07b561d8f965 18:25:19 03Aliscans02 07https://github.com/crawl/crawl/pull/2873 * 0.30-a0-479-g547247cc5f: Allow GameOption options to be saved to disk. 10(9 days ago, 1 file, 37+ 3-) 13https://github.com/crawl/crawl/commit/547247cc5f27 18:25:19 03Aliscans02 07https://github.com/crawl/crawl/pull/2873 * 0.30-a0-480-gf087e78fcc: Clear the "undocumented option" list. 10(9 days ago, 3 files, 29+ 11-) 13https://github.com/crawl/crawl/commit/f087e78fcc02 18:25:19 03Aliscans02 07https://github.com/crawl/crawl/pull/2873 * 0.30-a0-481-gb9c83ac437: unbrace (for last change but 1) 10(9 days ago, 1 file, 0+ 2-) 13https://github.com/crawl/crawl/commit/b9c83ac43783 18:25:19 ... and 4 more commits 18:27:36 <10PleasingFungus> yeah, that was my concern 18:37:54 03Aliscans02 07https://github.com/crawl/crawl/pull/2873 * 0.30-a0-486-g9753b71037: Compensate for a change caused by a rebase. 10(8 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/9753b7103779