00:01:30 03scarf02 07https://github.com/crawl/crawl/pull/2813 * 0.30-a0-344-ge50e7cd232: chore: remove unused includes 10(70 seconds ago, 1 file, 0+ 2-) 13https://github.com/crawl/crawl/commit/e50e7cd2327f 00:31:19 Fork (bcrawl) on crawl.kelbi.org updated to: 0.23-a0-4850-gd9e8576752 00:47:32 Monster database of master branch on crawl.develz.org updated to: 0.30-a0-341-g682706514a 01:10:43 hello, how do i get first timer contributor approval? 02:41:12 ... what's that? 02:42:31 it's a github workflow restriction 02:42:38 https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks 02:45:44 You just send vanilla pull requests, nothing else 02:46:16 what do you mean? that's unrelated to workflow run approval 02:46:32 You don't do anything else. You send them a PR, they decide what to do with it. 02:46:51 You don't need to ask for this. 02:47:05 alright 04:22:55 Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-4850-gd9e8576752 08:52:32 <06a​dvil> er, you do need to ask for that 08:52:37 <06a​dvil> I'll go ahead and click the button 08:54:00 <06a​dvil> Pinkbeast: when a first time contributor submits a PR, CI won't run until we click this button; presumably true by default for all repos these days 08:54:00 <06a​dvil> https://cdn.discordapp.com/attachments/747522859361894521/1038118928049787000/Screen_Shot_2022-11-04_at_11.52.53_AM.png 09:07:08 yeh, it's true for our repos as well. I typically review the change and then click the button 10:53:26 advil> But I've never asked for it 10:53:57 Won't you just see the PR and click the button if you think it's appropriate. 10:54:26 (disclaimer: I have the 'rona so I may be missing something obvious, brain not exactly working) 12:03:57 * Pinkbeast looks at _acquirement_shield_type(), now my brain hurts double 12:45:01 <06a​dvil> I mean yes, but it seems completely reasonable for someone to ask for it? 12:45:29 <06a​dvil> and this is semi-recent so anyone who has contributed before doesn't need it 12:57:23 I don't think I was trying to say it was unreasonable, just that AFAIK it wasn't necessary 12:58:12 (scarf seems on IRC only for short periods when you're not awake, hence trying to give the best answers I can) 12:59:29 New branch created: pull/2814 (2 commits) 13https://github.com/crawl/crawl/pull/2814 12:59:29 03Nikolai Lavsky02 07https://github.com/crawl/crawl/pull/2814 * 0.30-a0-342-gae0f2e52a0: fix: cap Resonance Strike damage 10(86 minutes ago, 2 files, 3+ 1-) 13https://github.com/crawl/crawl/commit/ae0f2e52a048 12:59:29 03Nikolai Lavsky02 07https://github.com/crawl/crawl/pull/2814 * 0.30-a0-343-g21a5b6a9cf: feat: display Resonance Strike damage in xv 10(10 minutes ago, 6 files, 29+ 8-) 13https://github.com/crawl/crawl/commit/21a5b6a9cf53 16:51:09 03advil02 07* 0.30-a0-342-g04419e6e1e: fix: cache some info across webserver reloads 10(2 days ago, 1 file, 11+ 8-) 13https://github.com/crawl/crawl/commit/04419e6e1ee2 16:51:09 03advil02 07* 0.30-a0-343-gfaeacb97bc: fix: eliminate some double error logging in webtiles 10(35 hours ago, 1 file, 6+ 0-) 13https://github.com/crawl/crawl/commit/faeacb97bc45 16:51:09 03advil02 07* 0.30-a0-344-gc8fac2a973: refactor: centralize some webtiles call construction code 10(35 hours ago, 4 files, 45+ 34-) 13https://github.com/crawl/crawl/commit/c8fac2a973f9 16:51:09 03advil02 07* 0.30-a0-345-gf0b7877050: fix: correctly handle game mode with non-mode options 10(34 hours ago, 1 file, 23+ 3-) 13https://github.com/crawl/crawl/commit/f0b787705046 16:51:09 03advil02 07* 0.30-a0-346-ge9b783979b: refactor: reorganize webtiles.config 10(7 minutes ago, 1 file, 94+ 69-) 13https://github.com/crawl/crawl/commit/e9b783979b42 16:51:09 03advil02 07* 0.30-a0-347-gf58ed5266c: refactor: clean up save info collection 10(4 minutes ago, 2 files, 91+ 51-) 13https://github.com/crawl/crawl/commit/f58ed5266caa 17:04:19 Unstable branch on crawl.kelbi.org updated to: 0.30-a0-347-gf58ed5266c (34) 19:02:42 Unstable branch on crawl.akrasiac.org updated to: 0.30-a0-347-gf58ed5266c (34) 23:14:44 Unstable branch on cbro.berotato.org updated to: 0.30-a0-347-gf58ed5266c (34) 23:34:55 Unstable branch on crawl.develz.org updated to: 0.30-a0-347-gf58ed5266c (34) 23:55:52 Windows builds of master branch on crawl.develz.org updated to: 0.30-a0-347-gf58ed5266c