00:31:35 Fork (bcrawl) on crawl.kelbi.org updated to: 0.23-a0-4850-gd9e8576752 04:22:14 Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-4850-gd9e8576752 05:06:39 Unstable branch on crawl.akrasiac.org updated to: 0.30-a0-341-g6827065 (34) 05:59:27 I'm sure this has been suggested before, but I'm kinda curious if reducing post-fight wait times would be possible by enhancing regen by some factor whenever there's no monsters in your line of sight. 06:25:57 New branch created: pull/2802 (1 commit) 13https://github.com/crawl/crawl/pull/2802 06:25:57 03Zhang Kai02 {GitHub} 07https://github.com/crawl/crawl/pull/2802 * 0.30-a0-342-g01726ff736: Create status.txt 10(32 seconds ago, 1 file, 736+ 0-) 13https://github.com/crawl/crawl/commit/01726ff73656 06:28:01 perryprog, fwiw I think hellmonk has some plan along those lines? 06:28:35 don't recall exactly, may have been just bumping regen a bit 06:28:45 without the "no monsters in sight" part 06:30:44 https://github.com/crawl/crawl/tree/regenerator seems to be it 06:31:06 increase regen a bit, lower maxhp, shorten zot clock a bit, from the looks of it 06:31:18 may have stalled 06:34:42 huh 09:15:45 <10PleasingFungus> i just bumped regen across the board instead 09:15:53 <10PleasingFungus> per a suggestion from elliptic 09:20:16 ✔️ 10:01:28 -!- Yermak_ is now known as Yermak 11:29:13 -!- daethoven89 is now known as daethoven8 12:07:23 <09gammafunk> Holy crap that check basically is a giant void in discord dark mode 12:13:18 hmm, just got another crash from an ?acq in player::could_wield 12:23:01 Filed a ticket. Didn't happen the second time FWIW. 12:46:25 Small PR I'd like to put in - added lua func item.inscribe(str, bool append) to edit inscriptions without sendkeys() spam 12:46:42 Seem aight? I'm pretty new to submitting PRs 12:55:27 yay repro'd the crash under a debugger 13:00:11 <05kate> sockthot: that seems like a reasonable thing to add, yeah. i think we have a little bit of a backlog of lua PRs to merge but iirc most of them are fairly simple so hopefully one of us will get time to go through them soon, maybe i'll try and poke at the existing ones this weekend 13:00:14 seems to be crashing on 13:00:15 !source item-prop.cc:1949 13:00:15 https://github.com/crawl/crawl/blob/master/crawl-ref/source/item-prop.cc#L1949 13:02:44 kate: thanks! will do 13:04:11 New branch created: pull/2805 (1 commit) 13https://github.com/crawl/crawl/pull/2805 13:04:12 03bfaires02 07https://github.com/crawl/crawl/pull/2805 * 0.30-a0-340-g4ea04e90a0: Add lua function item.inscribe(inscription="", append=true) 10(2 days ago, 1 file, 33+ 0-) 13https://github.com/crawl/crawl/commit/4ea04e90a059 14:22:49 fun bonus of it only seeming to crash without debug symbols 14:31:30 <06advil> for debugging that crash I would probably start by adding a whole bunch more ASSERTs than that code seems to have, probably #1 is validating subtype in is_weapon_wieldable 14:33:24 <06advil> the way Weapon_index is populated also looks prone to bugs in Weapon_prop that I don't see checks for (though I'm not sure this would cause a segfault) 14:38:43 In this case looks like it's an issue with the item somehow as I'm segfaulting while trying to even print its name (spooky!) 15:00:11 (lldb) po item.name((description_level_type)1, false, true, true, true, 0) / "a +1 great mace" / (lldb) po (weapon_type) item.sub_type / WPN_TRIPLE_SWORD | 0x40 15:00:12 HMMMMM 15:01:23 <06advil> well, I do see a plausible source of this 15:01:39 <06advil> https://github.com/crawl/crawl/blob/master/crawl-ref/source/acquire.cc#L1216 resets thing_created but does not update acq_item 15:11:14 okay good news is it turns out I can repro with optimization and debug symbols so I'm in lldb just before the segfault would happen (as confirmed by a po that fails with a memory error) 15:14:11 Wait, shouldn't Weapon_index only work for numbers in 0–56 (since it's NUM_WEAPONS long) 15:15:32 So getting Weapon_index[101] (great axe) is going to give some random chunk of memory, which then is a segfault when that's given to Weapon_prop 15:16:33 wait why would NUM_WEAPONS be 57 15:16:45 enums are weird 15:17:57 <06advil> that's why I was suggesting adding an ASSERT there 15:18:04 <06advil> that checks the range 15:18:25 <06advil> but I do think most likely it is a corrupt &item_def from earlier in the call chain 15:18:31 me too 15:19:26 <06advil> that code I linked is a good candidate but in practice it's not sufficient because thing_created will tend to be the most recently deleted item number 15:20:40 <06advil> possibly if there was previous item deleted but not its item number culled, that would set up a crash from that code 15:20:56 (Ignore what I said about enums stuff, I confused myself because (weapon_type)101 was giving triple sword but that's not the triple sword's actual value) 15:36:33 looks like at some point _acquirement_weapon_subtype is returning 101 (OBJ_RANDOM) which then gets set as the tested subtype for the item that gets passed to is_weapon_wieldable 15:53:13 oh I think I might know what it is, lol 16:02:07 SK_SLINGS isn't supposed to be a thing any weapon uses anymore, right? 16:03:03 because it's still in the skill enum in a location that will be checked when picking the weapon skill that _acquirement_weapon_subtype uses to choose a weapon subtype from 16:03:34 so it checks every single weapon subtype, searching for something that uses slings, and then always bails out of the loop early leaving result set to an invalid subtype of 101 16:14:51 yipiee that does indeed seem to be the problem. Making _acquirement_weapon_skill ignore useless skills makes the crash not happen, it seems 16:49:52 New branch created: pull/2806 (2 commits) 13https://github.com/crawl/crawl/pull/2806 16:49:53 03Perry Fraser02 07https://github.com/crawl/crawl/pull/2806 * 0.30-a0-342-g1d2b7e66a7: Don't crash when generating slings for ?acqs 10(30 minutes ago, 1 file, 3+ 0-) 13https://github.com/crawl/crawl/commit/1d2b7e66a759 16:49:53 03Perry Fraser02 07https://github.com/crawl/crawl/pull/2806 * 0.30-a0-343-g2a9a72e40b: Add asserts for valid weapon subtypes for ?acqs. 10(7 minutes ago, 2 files, 9+ 1-) 13https://github.com/crawl/crawl/commit/2a9a72e40b99 16:53:02 03Perry Fraser02 07https://github.com/crawl/crawl/pull/2806 * 0.30-a0-343-g1140b178c7: Add asserts for valid weapon subtypes for ?acqs. 10(10 minutes ago, 2 files, 6+ 1-) 13https://github.com/crawl/crawl/commit/1140b178c703 16:54:05 03Perry Fraser02 07https://github.com/crawl/crawl/pull/2806 * 0.30-a0-343-gb97e7d5166: Add asserts for valid weapon subtypes for ?acqs. 10(11 minutes ago, 2 files, 5+ 0-) 13https://github.com/crawl/crawl/commit/b97e7d5166b2 16:54:48 smh NotCheibriados calling me out 17:28:37 -!- werekitten is now known as mu 23:34:58 Unstable branch on crawl.develz.org updated to: 0.30-a0-341-g682706514a (34) 23:56:29 Windows builds of master branch on crawl.develz.org updated to: 0.30-a0-341-g682706514a