00:32:21 <Kelbell> Fork (bcrawl) on crawl.kelbi.org updated to: 0.23-a0-4664-g6ac40a12b4
03:24:00 <Lantell> Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-4664-g6ac40a12b4
08:53:09 <advil> mantis 12702 is some good stuff
08:57:55 <Pinkbeast> Wow.
08:59:37 <Pinkbeast> . o O (look up all unrands you don't want to use so monsters can't slit you up with them)
09:23:39 <gammafunk> advil: yeah going to push a fix for that
09:23:47 <advil> oh I have something in progress
09:23:49 <advil> can I do it?
09:23:52 <gammafunk> please do
09:23:53 <advil> there is a related bug
09:23:56 <gammafunk> my fix is currently not working
09:25:29 <gammafunk> apparently a call to set_unique_item_status(*item, UNIQ_NOT_EXISTS); is not sufficient
09:25:29 <advil> hm that should do it but maybe it depends on the timing
09:25:29 <gammafunk> was going to add an XXX comment how we really need a better "get item only to read its properties" function/methodology
09:25:29 <gammafunk> yeah, it's not working when I test locally
09:26:04 <gammafunk> it's the approach taken by the acquirement menu code, and it does work there
09:26:33 <advil> I have a fix that essentially does that and it is working (though that is wrong in the general case -- what if the item *has* been generated!)
09:26:34 <gammafunk> if you acquire and don't choose a given unrand that was offered, that successfully puts the unrand back in generation, based on my testing
09:26:42 <gammafunk> hah
09:27:06 <gammafunk> right, I suppose you would need to check the current status before making the item?
09:27:16 <advil> yeah...probably acquirement code has that check elsewhere
09:29:49 <gammafunk> you know, it may not properly handle the case you're describing
09:30:20 <gammafunk> hrm
09:31:59 <gammafunk> I suppose said case can't happen, since if the item has been generated, acquirement couldn't recieve it as a result
09:31:59 <gammafunk> this doesn't need to be handled specially in the menu code, it's just in the general item creation code
09:31:59 <gammafunk> but in the case of ?/, that does sound like a case that needs proper consideration, since ?/ wouldn't care about what's been generated
09:35:10 <advil> yeah, that's what I was thinking
09:35:24 <advil> I guess there's an odd interaction if you run around with an unrand in your acquire menu
09:35:32 <advil> but I don't see that that one could be handled in any other way
09:36:12 <advil> I don't really see why my fix would work when what you were describing doesn't, but I did test it (just with &% which respects you.unique_items) and it does work
09:37:16 <NotCheibriados> 03advil02 07* 0.29-a0-394-g12a1711: fix: unbreak UNIQ_LOST_IN_ABYSS 10(10 minutes ago, 1 file, 7+ 4-) 13https://github.com/crawl/crawl/commit/12a17119fad2
09:37:16 <NotCheibriados> 03advil02 07* 0.29-a0-395-g1b0d357: fix: don't let help mark unrands as existing 10(8 minutes ago, 1 file, 13+ 2-) 13https://github.com/crawl/crawl/commit/1b0d357a2724
09:37:16 <NotCheibriados> 03advil02 07* 0.29-a0-396-g17b9a4b: fix: remove debug code 10(3 minutes ago, 1 file, 0+ 1-) 13https://github.com/crawl/crawl/commit/17b9a4b632d9
09:49:55 <geekosaur> clearly you need a dependent map :˛
09:51:52 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.29-a0-396-g17b9a4b632 (34)
10:00:22 <Discord|> <06a‚Äãdvil> possibly that whole lost in abyss mechanic should get removed
10:00:41 <Discord|> <06a‚Äãdvil> iirc abyss vaults can still place items though?
10:03:26 <NotCheibriados> 03advil02 07[stone_soup-0.28] * 0.28.0-48-g22c5df5: fix: unbreak UNIQ_LOST_IN_ABYSS 10(36 minutes ago, 1 file, 7+ 4-) 13https://github.com/crawl/crawl/commit/22c5df52e633
10:03:26 <NotCheibriados> 03advil02 07[stone_soup-0.28] * 0.28.0-49-g6dfe1f5: fix: don't let help mark unrands as existing 10(34 minutes ago, 1 file, 13+ 2-) 13https://github.com/crawl/crawl/commit/6dfe1f597d0b
10:04:40 <Discord|> <05k‚Äãate> i've been meaning to cut it at some point yeah, i don't think it has much chance of actual relevance even with it technically working again
10:50:25 <Discord|> <09g‚Äãammafunk> @advil re: the odd unrand interaction with the scroll, yeah I thought of that too when implementing acquirement cancelation, but it seems the only sensible approach. It's hard to get much value by holding onto an acquirement that offers an unrand just to get it out of circulation
10:50:33 <Discord|> <09g‚Äãammafunk> by the way, given that make_item_unrandart() creats a new rng subgenerator, does that cause a problem in any way in terms of the ?/ help UI affecting the non-UI rng?
10:51:14 <Discord|> <09g‚Äãammafunk> I probably don't quite remember how that rng class stuff is working
10:56:59 <Discord|> <09g‚Äãammafunk> ah, I see the difference between what you did and what I did
10:56:59 <Discord|> <09g‚Äãammafunk> !source item.cc
10:56:59 <Discord|> <04C‚Äãerebot> Can't find item.cc.
10:57:26 <Discord|> <09g‚Äãammafunk> !source items.cc:4279
10:57:27 <Discord|> <04C‚Äãerebot> https://github.com/crawl/crawl/blob/master/crawl-ref/source/items.cc#L4279
10:58:34 <Discord|> <09g‚Äãammafunk> @advil the instance I tried to fix was here, which by adding a case for when that create_for_real variable is false, which apparently wasn't the relevant case for ?/. Not sure what the context is for that get_item_by_name() case is when create_for_real is false, but that does look like another instance that should be fixed
10:58:58 <Discord|> <09g‚Äãammafunk> tested your fix, and that does work for me as well when placing a test vault with an unrand
11:20:44 <Discord|> <09g‚Äãammafunk> hrm, this is weird, the code I tried to change seems like it might never be used
11:23:00 <Discord|> <09g‚Äãammafunk> looks like it does, just in wizard mode
11:23:19 <Discord|> <09g‚Äãammafunk> and in that case, it's always getting actually created
11:24:18 <Discord|> <06a‚Äãdvil> huh, yeah it looks like that was semi-intended to be handling the unrand case at some point, but that's not how PF implemented it
11:24:34 <Discord|> <06a‚Äãdvil> for lookup
11:27:05 <Discord|> <10P‚ÄãleasingFungus> code is hard
11:27:10 <Discord|> <06a‚Äãdvil> I can sort of see why given how base type is used there
11:27:44 <Discord|> <06a‚Äãdvil> seems like get_item_by_name can't really handle base type not being set properly
11:30:12 <Discord|> <06a‚Äãdvil> re the rng question, I think what should happen is that it will use the current generator to set up the subgenerator, but I'm not immediately sure which one that would be at that point in the code
11:30:48 <Discord|> <09g‚Äãammafunk> that's what I was hoping
11:30:56 <Discord|> <09g‚Äãammafunk> otherwise fun source of seed divergence
11:31:06 <Discord|> <06a‚Äãdvil> it definitely won't be a levelgen one
11:31:10 <Discord|> <06a‚Äãdvil> so that's not a worry
11:31:12 <Discord|> <09g‚Äãammafunk> oh, ok
11:31:19 <Discord|> <06a‚Äãdvil> but it may provide a means of tweaking the gameplay rng
11:31:24 <Discord|> <09g‚Äãammafunk> ah
11:47:46 <NotCheibriados> 03advil02 07* 0.29-a0-397-g846e4a0: fix: use rng::UI for help lookup (gammafunk) 10(3 minutes ago, 1 file, 7+ 2-) 13https://github.com/crawl/crawl/commit/846e4a0bbcbf
11:56:24 <Discord|> <09g‚Äãammafunk> interesting, didn't realize that was a case where you'd have to introduce a block to get a sequence point
11:56:56 <Discord|> <06a‚Äãdvil> I'm not sure it is
11:57:15 <Discord|> <06a‚Äãdvil> I've been googling to try to figure that out but so far no clear answers
11:57:26 <Discord|> <06a‚Äãdvil> I guess it's too basic
11:57:48 <Discord|> <09g‚Äãammafunk> heh, then I guess I can stop reading the rng guidelines to try to find it!
11:58:09 <Discord|> <09g‚Äãammafunk> went backed and check that after reading that commit
11:58:40 <Discord|> <06a‚Äãdvil> I just wasn't 100% sure that there is a guaranteed order for the constructor calls, so I got paranoid and added that
12:02:33 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.29-a0-397-g846e4a0bbc (34)
12:10:39 <Discord|> <06a‚Äãdvil> I'm 98% sure it's unnecessary, too bad I can't get it to 100%
13:26:13 <Lantell> Stable (0.28) branch on underhound.eu updated to: 0.28.0-49-g6dfe1f597d
13:36:38 <Discord|> <13S‚Äãastreii> oops i did it again. trying to find a new look to Eresh since the original tile is very confusing imo. the first from the left is the final one, but i've experimented some hairstyles. my previous attempt got rejected because it wasn't humanlike enough.
13:36:39 <Discord|> <13S‚Äãastreii> https://cdn.discordapp.com/attachments/747522859361894521/973685016355823616/Schermata_2022-05-10_alle_22.25.34.png
13:36:39 <Discord|> <13S‚Äãastreii> https://cdn.discordapp.com/attachments/747522859361894521/973685016737488976/Schermata_2022-05-10_alle_22.26.06.png
13:36:48 <Discord|> <13S‚Äãastreii> https://cdn.discordapp.com/attachments/747522859361894521/973685055744532550/Eresh_Hairdresser.zip
14:21:37 <Discord|> <09g‚Äãammafunk> eresh_hairdresser.zip
14:25:22 <perryprog> whatever is picked, it's certainly out of this world
15:23:55 <Lantell> Unstable branch on underhound.eu updated to: 0.29-a0-397-g846e4a0bbc (34)
15:25:48 <Discord|> <03w‚Äãheals> heh, the comment on line 4268 of items.cc is good
15:26:20 <Discord|> <03w‚Äãheals> the bug was pre-known...
15:43:34 <advil> except that comment was wrong about where the bug would happen
15:43:34 <Discord|> <09h‚Äãellmonk> Bring back the gigantic titty eresh
15:51:54 <Discord|> <09g‚Äãammafunk> dungeon crawl: after dark
16:15:39 <NotCheibriados> New branch created: pull/2538 (3 commits) 13https://github.com/crawl/crawl/pull/2538
16:15:40 <NotCheibriados> 03Nikolai Lavsky02 07https://github.com/crawl/crawl/pull/2538 * 0.29-a0-397-g28b7fba: feat: show current skill level in &s 10(16 minutes ago, 1 file, 4+ 3-) 13https://github.com/crawl/crawl/commit/28b7fba95579
16:15:40 <NotCheibriados> 03Nikolai Lavsky02 07https://github.com/crawl/crawl/pull/2538 * 0.29-a0-398-gf049da4: fix: don't crash when &s-ing a useless skill 10(13 minutes ago, 1 file, 6+ 0-) 13https://github.com/crawl/crawl/commit/f049da493e1f
16:15:40 <NotCheibriados> 03Nikolai Lavsky02 07https://github.com/crawl/crawl/pull/2538 * 0.29-a0-399-gc887793: fix: remove a stray function declaration 10(13 minutes ago, 1 file, 0+ 1-) 13https://github.com/crawl/crawl/commit/c8877935fdda
17:48:43 <Kelbell> 910rd (L23 DjFE) ERROR in 'tags.cc' at line 4760: Invalid item: (quantity: 0) gold piece (D:15)
18:07:41 <Discord|> <10P‚ÄãleasingFungus> reference eresh
18:07:41 <Discord|> <10P‚ÄãleasingFungus> https://cdn.discordapp.com/attachments/747522859361894521/973753225335439400/ereshkigal.png
18:08:33 <Discord|> <10P‚ÄãleasingFungus> i'm quite fond of it, tbh...
18:10:53 <Discord|> <10P‚ÄãleasingFungus> old vs new
18:10:53 <Discord|> <10P‚ÄãleasingFungus> https://cdn.discordapp.com/attachments/747522859361894521/973754032113991740/unknown.png
18:10:54 <Discord|> <10P‚ÄãleasingFungus> https://cdn.discordapp.com/attachments/747522859361894521/973754032365633626/unknown.png
18:13:00 <Discord|> <10P‚ÄãleasingFungus> idk. new one is cool but old one is just so iconic to me. perhaps i'm blinded by nostalgia
18:32:33 <Discord|> <09g‚Äãammafunk> I do actually like the current tile too
18:32:45 <Discord|> <09g‚Äãammafunk> the sort of binary outline weirdly works
18:33:00 <Discord|> <09g‚Äãammafunk> the new tile adds some interesting detail, although the pose doesn't quite work for me
18:33:41 <Discord|> <09g‚Äãammafunk> the old tile's pose is somewhat of a weak point, looks like she's just saying 'hi', very casual, but I like the other details of it
18:34:22 <Discord|> <09g‚Äãammafunk> for the new tile, maybe the galaxy/stars could be a little more subtle?
18:35:05 <Discord|> <09g‚Äãammafunk> one of the cool things about the old tile is the way her star cloak sort of "sweeps" around her, that kind of classic "wearing a cloak, standing in the wind"
18:35:19 <Discord|> <09g‚Äãammafunk> and it having a chaotic outline is neat too
18:36:00 <Discord|> <09g‚Äãammafunk> agree that the old one is somewhat confusing to look at
18:54:05 <perryprog> I do admit I've always thought the old one was the coolest hell lord tile thingy
18:54:53 <perryprog> agree that pose could use work, but I do generally like the new one. Also agreed that the outline of the old is very visually interesting.
19:46:42 <Discord|> <10P‚ÄãleasingFungus> hm
19:46:54 <Discord|> <10P‚ÄãleasingFungus> @hellmonk did you mean for new animate dead to cause guys killed by your enemies to rise as hostiles
19:47:09 <Discord|> <09h‚Äãellmonk> no
19:47:11 <Discord|> <09h‚Äãellmonk> lol
19:47:16 <Discord|> <09h‚Äãellmonk> good bug
19:47:20 <Discord|> <10P‚ÄãleasingFungus> üôÇ
19:47:26 <Discord|> <10P‚ÄãleasingFungus> i have a few minutes to work on this
19:47:28 <Discord|> <10P‚ÄãleasingFungus> we'll see how it goes
19:52:23 <Discord|> <10P‚ÄãleasingFungus> hm
19:52:30 <Discord|> <10P‚ÄãleasingFungus> i can't believe we're removing "the dead are hopping"
21:04:27 <Discord|> <10P‚ÄãleasingFungus> Some gastropods living on the ground not always move in a crawl. Conches (Strombidae) also use their sabre-shaped operculum. Their operculum dug into the ground, they catapult themselves forward, so they jump over the ocean floor. When they are threatened, they can also use their operculum to deal painful blows.
21:04:29 <Discord|> <10P‚ÄãleasingFungus> fr:
22:34:41 <Gretell> Unstable branch on crawl.develz.org updated to: 0.29-a0-397-g846e4a0bbc (34)
22:55:42 <Gretell> Windows builds of master branch on crawl.develz.org updated to: 0.29-a0-397-g846e4a0bbc
23:21:44 <Cbrotell> Unstable branch on cbro.berotato.org updated to: 0.29-a0-397-g846e4a0bbc (34)
23:53:49 <Gretell> Monster database of master branch on crawl.develz.org updated to: 0.29-a0-397-g846e4a0bbc