00:20:06 Unstable branch on cbro.berotato.org updated to: 0.29-a0-25-g7f48f510a0 (34) 00:54:06 Monster database of quite-the-item branch on crawl.develz.org updated to: 0.29-a0-26-g66b1d58e9c 01:21:41 Stable (0.28) branch on cbro.berotato.org updated to: 0.28-b1-25-g9875b3fc8c 01:32:59 Stable (0.28) branch on crawl.kelbi.org updated to: 0.28-b1-25-g9875b3fc8c 01:33:54 Fork (bcrawl) on crawl.kelbi.org updated to: 0.23-a0-4567-gb362bb5a12 03:36:33 <03wheals> the issue with the fear scroll is that the both the targeter and the scroll itself have 1000 power, but the scroll effect caps that to 200 while the targeter does not 03:36:33 <03wheals> this is also mantis #12665 04:22:37 Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-4567-gb362bb5a12 07:09:29 <06advil> re mertail etc I added those myself the other day, I think spicyCebolla just didn't see the commit 07:24:42 <09hellmonk> Is there a reason it has to do that instead of just making them have 200 power also 07:31:28 <03wheals> probably no reason, no, though the bug would still exist if the 1000s were changed to 200s (since it gets multiplied by 3/2 before the power cap) 09:35:31 <10PleasingFungus> that's a good set of fixes 09:35:54 <10PleasingFungus> god 09:36:05 <10PleasingFungus> i can't believe the ridiculous switch-case in 238b2ceb197f990cfa6a458103f62cd1d05e7323 is still around 09:36:13 <10PleasingFungus> i looked at that thing in 2014 and thought 'this is awful' 09:36:23 <10PleasingFungus> if only i was a dev so that i could fix it 09:36:46 03wheals02 07* 0.29-a0-26-g9887b6b: fix: on the spellcasting menu casts the last spell again 10(2 hours ago, 5 files, 78+ 86-) 13https://github.com/crawl/crawl/commit/9887b6b0900e 09:36:46 03wheals02 07* 0.29-a0-27-g236b832: fix: scroll of fear success chance (#12665, Yermak) 10(82 minutes ago, 1 file, 2+ 1-) 13https://github.com/crawl/crawl/commit/236b832b7717 09:36:46 03wheals02 07* 0.29-a0-28-g15a0a6f: fix: standardize penance piety display (#12565) 10(77 minutes ago, 1 file, 0+ 3-) 13https://github.com/crawl/crawl/commit/15a0a6fec6bb 09:36:46 03wheals02 07* 0.29-a0-29-g171a82f: fix: restore spacebar behaviour in autoexplore autopickup prompt (#12671) 10(48 minutes ago, 1 file, 1+ 0-) 13https://github.com/crawl/crawl/commit/171a82f51980 09:36:46 03wheals02 07* 0.29-a0-30-g0aac2ac: fix: easy_floor_use when your (sub-)inventory is empty (#12667) 10(39 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/0aac2aca22f0 09:36:46 03wheals02 07* 0.29-a0-31-g238b2ce: fix: time out drain when returning to a level (#12663) 10(35 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/238b2ceb197f 09:36:46 03wheals02 07* 0.29-a0-32-g9398408: fix: select all menu items when pressing a type shortcut 10(12 minutes ago, 1 file, 13+ 26-) 13https://github.com/crawl/crawl/commit/93984085d6ee 09:38:03 <03wheals> at least it isn't in misc.cc anymore 09:38:03 <10PleasingFungus> lol 09:38:03 <10PleasingFungus> or stuff2.cc 09:39:16 <03wheals> @advil about the comment on menu.cc:1735, are there any singleselect menus where it wouldn't be better to snap/set hover when you press a secondary hotkey, compared to selecting the MenuEntry? 09:39:38 multidrop ones iirc 09:40:18 rewriting that code to actually do what that comment suggests is definitely something that should be done, but it's kind of a pain because that code is essentially written for multidrop selection 09:40:25 so I deferred the project 09:41:40 thanks for the fixes! 09:45:50 <06advil> oh I somehow did not read the word "singleselect" in your question 09:45:57 <06advil> so then, no 09:46:44 <06advil> the pain is because any arbitrary menu item is supposed to be able to have multiple hotkeys that allow selecting it 09:47:31 <06advil> I suppose that if it's an InvMenuEntry maybe it's safe to assume that a secondary hotkey is uniformly a type hotkey? I may already be assuming that somewhere else 09:48:01 <06advil> in the wield menu (etc) code that removes those hotkeys 09:48:18 <03wheals> yeah, i'm slightly concerned about making the change because that's a general Menu method, not an inventory one 09:48:23 <06advil> yeah, exactly 09:48:48 <06advil> I also do not 100% understand how the preselect stuff even works 09:48:56 <03wheals> i removed the preselect stuff :) 09:48:59 <06advil> which makes me hestitate to modify that bit of code 09:49:02 <06advil> haha nice 09:49:06 <06advil> hope you didn't break anything! 09:49:12 <03wheals> it was only used for the spellcasting menu, which was already broken 09:49:21 <06advil> isn't it used for drop resumption? 09:49:27 <06advil> when a multiturn drop is interrupted 09:49:39 03advil02 07* 0.29-a0-33-g0a9fdd5: fix: menu selection for `prompt_invent_menu`s (gressup) 10(7 minutes ago, 1 file, 16+ 5-) 13https://github.com/crawl/crawl/commit/0a9fdd57f5d6 09:50:54 <03wheals> no, that's also called preselect but it's really just selecting the entries beforehand 09:50:54 <06advil> lol 09:50:54 <03wheals> preselect was basically a way to mimic the cursor before it existed 09:50:54 <06advil> rookie mistake, believe variable names mean something 09:51:05 <06advil> huh, I thought I removed all that, don't remember it interacting with preselects? 09:51:16 <06advil> but anyways, I will believe you 09:51:27 <06advil> because the alternative would be trying to figure that stuff out again 😄 09:51:47 <03wheals> yeah that was a different system to implement a cursor haha 09:51:53 <06advil> lol nice 10:06:43 Unstable branch on crawl.kelbi.org updated to: 0.29-a0-33-g0a9fdd57f5 (34) 10:16:00 <06advil> just got an answer to this, apparently people used them on the identify menu in particular (currently not working) 10:16:00 <03wheals> lmao, incredible 10:16:00 <03wheals> yeah, that's not working because of fc454544111 i assume 10:16:44 <03wheals> well, if i make it snap then they can use ! instead 10:17:03 <06advil> yeah, I didn't realize the scroll item select submenus reused UseItemMenu 10:17:24 <03wheals> i think ideally all of them would rather than prompt_invent_menu 10:17:39 <06advil> heh the people who complain the most don't want to use cursors at all 10:18:03 <06advil> though it would be possible (perhaps best?) to keep the current behavior with arrow selection off 10:18:58 <10PleasingFungus> don't think of it as complaining 10:19:10 <10PleasingFungus> think of it as a series of humble pleas to the demigod-like devs 10:22:08 <10PleasingFungus> their crops are withering in the fields... devs, please send rain 10:23:09 <03wheals> merge conflict :( 10:23:27 <06advil> sry 10:27:17 03advil02 07* 0.29-a0-34-g190321e: fix: restore item class hotkeys to id menu (Lici) 10(6 minutes ago, 1 file, 4+ 2-) 13https://github.com/crawl/crawl/commit/190321e9dd26 10:31:04 Unstable branch on crawl.akrasiac.org updated to: 0.29-a0-33-g0a9fdd5 (34) 10:32:35 Unstable branch on crawl.kelbi.org updated to: 0.29-a0-34-g190321e9dd (34) 10:35:16 <03wheals> ok i found a place where we do want secondary hotkeys to select the item, the lookup help menu (we want uppercase and lowercase to both work) 10:36:40 <03wheals> so i might have to rethink this commit 10:52:11 <06advil> did you write it for all Menus? 10:53:56 <06advil> I sort of wonder if this should just be a different kind of hotkey (which is also a not entirely uninvolved change) 10:53:56 <06advil> could even adjust the api so a scroll/select hotkey is associated with headers 10:55:15 <06advil> hm, or even, if a header has a hotkey, the activate behavior is scroll+cycle_highlight 10:55:49 <06advil> that kind of change might not be good for right now 10:56:19 <03wheals> yeah, it's definitely something to wait for after release for, the current state isn't perfect but it's good enough 11:31:20 03wheals02 07* 0.29-a0-35-gccf8362: feat: allow closing the webtiles chat with F12 (Yermak) 10(35 minutes ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/ccf83627c4e0 11:31:20 03wheals02 07* 0.29-a0-36-gb1d7ae0: fix: Numpad '*' and '+' in newgame menu (#12666) 10(15 minutes ago, 1 file, 9+ 0-) 13https://github.com/crawl/crawl/commit/b1d7ae04607f 11:33:04 Unstable branch on crawl.kelbi.org updated to: 0.29-a0-36-gb1d7ae0460 (34) 12:00:17 <06advil> > // This sucks! 12:00:19 <06advil> lol 12:00:41 <06advil> I would like to make those work in local tiles and figure out a better mapping scheme for the ADD2 stuff 12:00:47 <06advil> (not sure if that's the part that sucks or not) 12:02:04 amazing, wheals 12:02:12 that f12 thing has been pesky for years n years 12:08:16 <06advil> prize for the most reported non-bug this season def goes to stat choice 12:10:42 <03wheals> Yeah what sucks is that we have to handle the numpad keys and their equivalents all over the place, what i just fixed isn't even the only bug related to numpad-* that yermak reported on mantis 12:10:53 <06advil> yeah 12:11:08 <03wheals> before i go further i want to add a helper function that maps them to the non-numpad keys, but even a limited application could break things so thats another thing ill leave till later 12:11:10 <06advil> I sort of want to add CMD_MENU_PAGE_UP and so on 12:11:48 <06advil> yeah, it's annoyingly risky to touch that stuff 12:12:16 <06advil> and also local tiles uses SDL keycodes which are completely different (some day I'd like to map those into crawl internal keycodes) 12:38:57 it is a shame that the 3-9-15 pattern is a little unintuitive to explain as a sequence, but not much that can be done about that 12:39:44 ("every three levels" versus "every six levels starting from level 3" or "on levels 3, 9, 15, etc." 12:39:45 ) 13:02:00 dimondsprtn (L12 DjFE) Crash caused by signal #6: Aborted (D:10) 13:02:30 !crashlog dimondsprtn 13:02:31 1. DimondSprtn, XL4 HaBr, T:1568 (milestone): http://crawl.berotato.org/crawl/morgue/DimondSprtn/crash-DimondSprtn-20170302-232128.txt 13:03:23 too fast I guess 13:04:18 !crashlog dimondsprtn 13:04:18 2. dimondsprtn, XL12 DjFE, T:15522 (milestone): https://crawl.kelbi.org/crawl/morgue/dimondsprtn/crash-dimondsprtn-20220131-200148.txt 13:22:34 <06advil> well, i've replicated this weird putty color swap thing, remains completely opaque to me whether this is a bug in our code or a weirdness with blink_brightens_background 13:22:34 <06advil> https://cdn.discordapp.com/attachments/747522859361894521/937805075554922496/Screen_Shot_2022-01-31_at_3.20.48_PM.png 13:23:03 <06advil> I don't suppose anyone here has seen this before 13:24:09 <10PleasingFungus> ‘you’re welcome’ 13:24:24 <10PleasingFungus> (re stat choice) 13:24:46 <10PleasingFungus> i knew we’d get those bug reports but i changed it anyway. absolute madman 13:52:00 <06advil> also putty with blink_brightens_background is refusing to render sequences of background color with no foreground that are longer than 13 characters 🤷 13:53:42 <06advil> https://cdn.discordapp.com/attachments/747522859361894521/937812618066952202/Screen_Shot_2022-01-31_at_3.52.25_PM.png 13:55:19 <10PleasingFungus> i vaguely wonder if the stealth bar should just be a number 13:55:30 <10PleasingFungus> i love bars as much as the next guy. probably moreso 13:55:33 <10PleasingFungus> but it keeps confusing peopl 13:55:46 <12ebering> ??choko scale 13:55:47 <04Cerebot> I don't have a page labeled choko_scale in my learndb. 13:55:51 <12ebering> ??how hairy 13:55:52 <04Cerebot> I don't have a page labeled how_hairy in my learndb. 13:55:53 <12ebering> what 13:55:59 <12ebering> ?/choko beard 13:56:00 <04Cerebot> Matching entries (1): beard_stats[1]: Beard values for 0.10 are: beardless < 10, choko beard < 30, some beard < 60, quite a beard < 90, very beardy < 120, extreme beard < 150, extraordinary beard < 190, incredible beard < 240, uncanny beard < 300, almost entirely beard >= 300 13:56:18 <10PleasingFungus> ??hair stats 13:56:18 <04Cerebot> hair stats[1/1]: extremely bad hair <10, awful hair <30, poor hair <60, choko hair <90, normal hair <120, quite good hair<160, very nice hair<220, extreme hair<300, extraordinary hair <400, incredible hair <520, uncanny hair <700, almost entirely hair >=700 13:56:25 <10PleasingFungus> separate entries, mysteriously 13:56:34 <12ebering> separate stats! 13:56:39 <10PleasingFungus> i suppose so 14:14:30 <06advil> it's even worse than this because very sporadically putty does render the longer ones 14:15:00 PF: the stat change is actually objectively good because it's (very minorly) a player buff 14:15:22 mostly-joke: the windows version of crawl comes with a sane FOSS ssh client that ppl can use instead of putty 14:18:10 03advil02 07* 0.29-a0-37-g2ed287c: fix: indicate compatibility mode for putty in more cases 10(37 minutes ago, 1 file, 5+ 3-) 13https://github.com/crawl/crawl/commit/2ed287c6d881 14:18:10 03advil02 07* 0.29-a0-38-ga1db9ad: fix: color spell letters by utility in more menus 10(35 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/a1db9ad13e6c 14:18:10 03advil02 07* 0.29-a0-39-g581ba40: docs: more color diagnostics for terminal 10(3 minutes ago, 1 file, 22+ 7-) 13https://github.com/crawl/crawl/commit/581ba40fa7cd 14:32:21 <06advil> huh, more specifically in that buggy case with >13 chars, it's drawing the background using the non-brightened version, which for lightgray is just black 14:33:07 Unstable branch on crawl.kelbi.org updated to: 0.29-a0-39-g581ba40fa7 (34) 15:01:37 wheals, incidentally, does "fix: select all menu items when pressing a type shortcut" fix also #12571? 15:04:29 <03wheals> no, that was a separate thing we were discussing 15:04:30 <03wheals> the r? -> reading the first scroll was fixed, but i? -> still describes the first scroll 15:05:14 <03wheals> Yermak: you may have missed it among all the other messages, do you know if 12632 is still happening? 15:06:31 nope, haven't played berserkers lately, I'll check 15:47:19 it occurs to me that artifacts are generally more powerful than gods - except ash. ash can now destroy artis if you curse them 15:47:40 Trog can't even _find_ artifacts 15:47:51 lol 16:23:20 Unstable branch on underhound.eu updated to: 0.29-a0-39-g581ba40fa7 (34) 17:19:27 <12ebering> @gammafunk I've pushed small tweaks (Ignis and Arena handling, Yred and Makh altar tiles), and also made Zig Diving a proportional category with a max of 27 complete zigs. 17:21:24 <12ebering> hopefully will figure out a way to make most of the remaining categories proportional to the leader's outcome 17:22:09 <12ebering> hm. the two categories that that's hardest to do is the win-order race categories 17:22:54 <12ebering> I'm pretty nostalgic about them but a lot of players don't like them 17:23:14 <12ebering> and they're the hardest to convert 17:32:15 could races be a non-scoring thing, for prestige/fun? 17:32:22 they are a *blast* for those who are in them... 17:33:43 <12ebering> I mean we can do whatever. the constraint is things I can type into the computer and test tonight, don't think anyone else has much time and ready knowledge of the tournament scripts 17:35:51 wheals, yeah, berserkers still pick up artefact books 19:02:30 Papr (L2 DgCj) Crash caused by signal #11: Segmentation fault (D:2) 19:05:15 !crashlog Papr 19:05:15 1. Papr, XL2 DgCj, T:1555 (milestone): https://crawl.kelbi.org/crawl/morgue/Papr/crash-Papr-20220201-020105.txt 19:05:33 oh no 19:05:36 gui code 19:05:38 * perryprog runs away 19:13:26 -!- allbery_b is now known as geekosaur 19:30:42 <09gammafunk> cool, will make those changes live in the morning 19:51:32 <06advil> hm, haven't seen that crash before but it is in floor wielding 20:10:50 <06advil> well, I was able to get crawl to crash so hard at that menu that glibc fprintf'd a stack trace beginning with *** glibc detected *** /usr/games/crawl-git-0a9fdd57f5: double free or corruption (fasttop): 0x0000000003515880 *** 20:11:02 <06advil> I guess I won't disclose the method for the moment in this channel 20:13:00 eek, that's bad 20:13:44 definitely will be curious to see what's going on there though 20:17:16 <06advil> so far I can't replicate it locally 20:21:07 <06advil> the replication circumstances seem extremely specific to this one case, so maybe I don't need to worry so much 20:21:46 <06advil> if I go to the location of that crash on the same seed and hold down *, sooner or later it crashes spectacularly 20:22:03 <06advil> (at the wield menu) 20:22:57 <12ebering> Yermak: did you create the harmful clouds in that bug report? 20:25:59 <06advil> got it to happen in lldb: crawl(47797,0x10d60fd40) malloc: Incorrect checksum for freed object 0x12805aa28: probably modified after being freed. Corrupt value: 0x20736d6574492079 crawl(47797,0x10d60fd40) malloc: *** set a breakpoint in malloc_error_break to debug 20:26:28 <06advil> maybe is happening in vmake_stringf 20:27:38 <06advil> not sure I will have much more time to look into this one until wednesday, but once I tried to use the exact seed/char/circumstances (don't even have other items) it seems to replicate pretty reliably 20:30:24 ebering, poison 20:32:17 oh, and yes, it was my clouds 20:53:21 <06advil> oh, I bet I got it actually 21:03:12 03advil02 07* 0.29-a0-40-g8eb35ef: fix: eliminate a bad memory access 10(9 minutes ago, 2 files, 12+ 3-) 13https://github.com/crawl/crawl/commit/8eb35efe6070 21:11:14 Unstable branch on crawl.kelbi.org updated to: 0.29-a0-40-g8eb35efe60 (34) 21:18:02 <10PleasingFungus> neat 21:55:09 03Oneirical02 {GitHub} 07https://github.com/crawl/crawl/pull/2361 * 0.29-a0-46-g356e363: Merge branch 'crawl:master' into master 10(7 minutes ago, 0 files, 0+ 0-) 13https://github.com/crawl/crawl/commit/356e363bfa61 21:55:09 03Oneirical02 {GitHub} 07https://github.com/crawl/crawl/pull/2361 * 0.29-a0-47-g89eeed8: add tile to dc-invocations.txt 10(5 minutes ago, 1 file, 1+ 0-) 13https://github.com/crawl/crawl/commit/89eeed8812b7 21:55:09 03Oneirical02 {GitHub} 07https://github.com/crawl/crawl/pull/2361 * 0.29-a0-48-g782da04: add new jiyva oozemancy tile 10(5 minutes ago, 1 file, 0+ 0-) 13https://github.com/crawl/crawl/commit/782da04904b6 21:59:21 <12ebering> @gammafunk I pushed a few more changes to the 0.28 tourney branch; there are two that we might not want to take but I'm in favor enough to have implemented them: converting "ranked scoring" to "relative scoring": e.g in turncount you win (best tc / your best tc ) * 10000 points and in nemelex you win ( your nemelex pts / current top nemelex pts ) * 10000 points 21:59:34 <12ebering> In implementing this I nixed the win order categories (rip) 22:01:33 03Oneirical02 {GitHub} 07https://github.com/crawl/crawl/pull/2361 * 0.29-a0-49-g685e7d2: revert from master, oops 10(6 minutes ago, 1 file, 0+ 1-) 13https://github.com/crawl/crawl/commit/685e7d269a0e 22:01:33 03Oneirical02 {GitHub} 07https://github.com/crawl/crawl/pull/2361 * 0.29-a0-50-g2746212: revert from master, oops 10(5 minutes ago, 1 file, 0+ 0-) 13https://github.com/crawl/crawl/commit/274621265bf0 22:02:43 <12ebering> but I think that's it for the changes I'll be able to implement 22:03:36 aw, rip 22:04:18 what language is your scoring stuff in? the nethackscoreboard gal knows perl, python, rust pretty well 22:04:44 <12ebering> python2.7 22:05:08 <12ebering> see the dcss_tourney repo in the crawl org on github 22:05:27 cool 22:05:50 i think over on discord you lowkey mentioned that you're the only person able to work on it 22:06:23 one could interpret that as mayyyybe a call for volunteers >_> 22:06:29 <12ebering> yes 22:06:36 <12ebering> but uh 22:08:19 you have some kinda irl thing to focus on now it sounds like? 22:08:19 <12ebering> yes I had this evening that's just passed to tweak and update 22:08:19 <12ebering> but not time for major re-designs 22:08:19 <12ebering> and definitely 0 time to do the front end side since chequers did that 22:08:35 <12ebering> it's the perinnial problem with the t scripts: they get run once every 6ish months and in-between there's little motivation to work on them 22:08:56 well, thanks for doing it! 22:09:52 TNNT is the same way. at the end they collect feedback and come up with some things they might implement. and partway through october it's like "yall we got 2 weeks to fix bugs and implement 0.8 new things" 22:11:10 <12ebering> yeah, for 0.25 I headed up a big overhaul of the tournament scripts 22:11:29 <12ebering> but didnt seize the opportunity to also make them modern python (oops) 22:14:18 New branch created: pull/2394 (2 commits) 13https://github.com/crawl/crawl/pull/2394 22:14:18 03Oneirical02 {GitHub} 07https://github.com/crawl/crawl/pull/2394 * 0.29-a0-41-gf05144b: connect tile to ability 10(5 minutes ago, 1 file, 1+ 0-) 13https://github.com/crawl/crawl/commit/f05144bb222e 22:14:18 03Oneirical02 {GitHub} 07https://github.com/crawl/crawl/pull/2394 * 0.29-a0-42-g870372f: Add files via upload 10(5 minutes ago, 1 file, 0+ 0-) 13https://github.com/crawl/crawl/commit/870372f43a39 23:09:49 <03wheals> &rc yermak 23:09:52 <04Cerebot> https://crawl.kelbi.org/crawl/rcfiles/crawl-git/Yermak.rc 23:13:41 Is there a reason for Ru sac choices not to be instant? 23:14:31 <03wheals> Yermak: two things, you have ae ^= <03wheals> if you remove the second thing, then change the first to ae += <03wheals> let me know if that helps 23:18:44 wheals, but I don't autopickup other useless artefacts, e.g. hats for Fo. 23:18:44 <03wheals> yeah, because you have a line in the lua method that says if it.is_useless then return false end 23:18:44 <03wheals> artefact books aren't useless for berserkers, they only are if you don't plan to switch away from trog ever ;) 23:19:07 especially if the book's in a timed portal 23:19:13 Ok, what about hats for Mi that growed their horns to lvl3? They're not entirely useless, but I still odn't pick up them. 23:21:57 Anyway, thanks, wheals. 23:25:13 <03wheals> yeah, crawl isn't super consistent about useless vs non useless items when they're potentially useful in the medium term