00:42:42 Unstable branch on cbro.berotato.org updated to: 0.28-a0-1347-g113dc556a4 (34) 00:55:11 Monster database of master branch on crawl.develz.org updated to: 0.28-a0-1347-g113dc556a4 01:33:02 Fork (bcrawl) on crawl.kelbi.org updated to: 0.23-a0-4506-g453a05f5f4 01:51:57 Fork (bcadrencrawl) on crawl.kelbi.org updated to: 0.03-730-g1c0bbdecc3 02:17:45 -!- allbery_b is now known as geekosaur 04:22:40 Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-4506-g453a05f5f4 07:21:15 <08nicolae> heard we were talkin about spider dongs in here 07:28:52 totally relevant documentary: https://www.youtube.com/watch?v=sHzdsFiBbFc 07:30:08 03Perry Fraser02 07https://github.com/crawl/crawl/pull/2314 * 0.28-a0-1335-g8400e8f: fixup! fix: display_bar should clamp negative values 10(5 minutes ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/8400e8fadedd 07:40:10 This is more of a "standard PR etiquette" question than anything else, but I'm curious—is it "worth" bothering with another commit for fixing something like the mismatched & spacing that I introduced in that fixup commit? 07:41:28 <10PleasingFungus> sure? or you can squash it in and force push, if there’s no active ongoing review 07:41:57 <10PleasingFungus> it should end up squashed eventually, but doesn’t really matter before then 07:43:18 <10PleasingFungus> is that what you were asking? 07:43:18 yes, I think so :) 07:44:40 follow up question: is there a standard formatting for ref/deref spacing? (E.g., string& foo versus string &foo) I see a lot of both in most functions, so I assume just match what's nearby? 07:47:03 And the reason I was asking is because it felt... weird to have three force pushes on a single PR, but I suppose it doesn't actually matter like you said 🙃 07:47:58 <10PleasingFungus> i’d go with the latter, for the classic reason: 07:49:13 03Perry Fraser02 07https://github.com/crawl/crawl/pull/2314 * 0.28-a0-1335-g64a0994: fixup! fix: display_bar should clamp negative values 10(24 minutes ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/64a0994c1cba 07:49:41 <10PleasingFungus> if you type “string& foo, bar;” what type is bar? 07:49:41 <10PleasingFungus> well 07:49:41 <10PleasingFungus> actually that’s probably nonsense 07:49:41 <10PleasingFungus> but that’s the reason one uses string foo instead of string foo 07:49:47 <10PleasingFungus> and might as well be consistent 07:50:16 👍 thanks again! 10:11:40 Unstable branch on crawl.akrasiac.org updated to: 0.28-a0-1347-g113dc55 (34) 10:32:20 New branch created: pull/2319 (1 commit) 13https://github.com/crawl/crawl/pull/2319 10:32:21 03Monkooky02 07https://github.com/crawl/crawl/pull/2319 * 0.28-a0-1348-gecdaf24: Implement unrandart Club of the Night 10(63 minutes ago, 8 files, 49+ 1-) 13https://github.com/crawl/crawl/commit/ecdaf2469115 10:58:08 >you should merge it for the pun. 10:58:08 my kind of thinking 15:03:19 <05kate> https://github.com/crawl/crawl/issues/2320 this is a good one, i guess storm form doesn't actually have a status description currently but if it did then they would overlap 15:03:52 <05kate> i guess one of stormform or heavenly storm needs a different status light 15:43:34 03advil02 07* 0.28-a0-1348-g050f353: fix: restore rest behavior when > rest_wait_percent 10(8 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/050f3537b943 15:47:49 Unstable branch on crawl.kelbi.org updated to: 0.28-a0-1348-g050f3537b9 (34) 16:03:25 New branch created: pull/2322 (1 commit) 13https://github.com/crawl/crawl/pull/2322 16:03:26 03Monkooky02 07https://github.com/crawl/crawl/pull/2322 * 0.28-a0-1348-gef6391c: make throatcutter a urand 10(9 minutes ago, 3 files, 1+ 1-) 13https://github.com/crawl/crawl/commit/ef6391cd81c7 16:16:16 03Monkooky02 07https://github.com/crawl/crawl/pull/2322 * 0.28-a0-1350-g112baeb: Merge https://github.com/crawl/crawl 10(8 minutes ago, 0 files, 0+ 0-) 13https://github.com/crawl/crawl/commit/112baeb60d6a 16:16:16 03Monkooky02 07https://github.com/crawl/crawl/pull/2322 * 0.28-a0-1351-g726ad2f: Revert "Merge https://github.com/crawl/crawl" 10(7 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/726ad2fed031 16:23:34 Unstable branch on underhound.eu updated to: 0.28-a0-1348-g050f3537b9 (34) 16:27:54 <10PleasingFungus> @kate wdyt about calling the light 'heavenly'? 16:28:23 03kate-02 07* 0.28-a0-1349-g9cd67a6: Update some status light descriptions 10(83 minutes ago, 2 files, 41+ 30-) 13https://github.com/crawl/crawl/commit/9cd67a661cce 16:28:23 03kate-02 07* 0.28-a0-1350-gcbcab8c: Don't gender some non-unique enemies 10(72 minutes ago, 2 files, 6+ 6-) 13https://github.com/crawl/crawl/commit/cbcab8c68d17 16:29:33 <05kate> i feel like it used to be something like that and it felt really wrong to me, but that might be the best option 16:29:48 <05kate> ah it used to be "Hevn" which was v. ugly imo, "Heavenly" is probably fine 16:31:53 <10PleasingFungus> thanks! 🙂 16:32:54 Unstable branch on crawl.kelbi.org updated to: 0.28-a0-1350-gcbcab8c68d (34) 16:34:44 03kate-02 07* 0.28-a0-1351-ga5cd5ca: Rename Heavenly Storm's status light (PleasingFungus) 10(3 minutes ago, 2 files, 2+ 3-) 13https://github.com/crawl/crawl/commit/a5cd5cae6f00 16:48:37 Unstable branch on crawl.kelbi.org updated to: 0.28-a0-1351-ga5cd5cae6f (34) 17:12:46 03kate-02 07* 0.28-a0-1352-g1c5e12c: Fix some descriptions (Ge0ff) 10(11 minutes ago, 2 files, 2+ 2-) 13https://github.com/crawl/crawl/commit/1c5e12ca7f2f 17:14:11 -!- allbery_b is now known as geekosaur 17:17:31 Unstable branch on crawl.kelbi.org updated to: 0.28-a0-1352-g1c5e12ca7f (34) 17:51:14 03PleasingFungus02 07* 0.28-a0-1353-gc3160e8: Tweak channel status descriptions 10(6 minutes ago, 1 file, 6+ 6-) 13https://github.com/crawl/crawl/commit/c3160e8207e0 18:02:47 Unstable branch on crawl.kelbi.org updated to: 0.28-a0-1353-gc3160e8207 (34) 19:22:35 <08nicolae> the message The broodmother summons spiders is missing punctuation at the end 19:32:46 Unstable branch on crawl.kelbi.org updated to: 0.28-a0-1354-g62fc55f08d (34) 19:33:28 03kate-02 07* 0.28-a0-1354-g62fc55f: Fix Summon Spider messaging (nicolae) 10(6 minutes ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/62fc55f08dd1 19:45:45 <08nicolae> also re: You finish putting on your orb, is that really the right verb 19:45:51 <08nicolae> you 19:45:56 <08nicolae> you're just holding it, not like... wearing it 19:47:30 <08nicolae> You finish putting your orb of jorts in the proper grip. 19:51:04 <08nicolae> i'm not sure how best to phrase that but i feel like that's the right flavor 19:51:30 <08nicolae> like you gotta hold it just right and it takes a few turns to get your fingers/paws/suckers/pedipalps situated properly 19:51:42 <05kate> could just be "equipping" rather than "putting on" maybe, to still suggest it taking multiple turns 19:51:46 <08nicolae> granted this is not like a major issue 19:51:49 <08nicolae> true 19:52:17 <05kate> since yeah, "wielding" is sort of the obvious term but that implies it'd be like a weapon and only take a turn 19:53:53 <08nicolae> You finish properly positioning your orb of jorts. 19:59:03 03kate-02 07* 0.28-a0-1355-gcf31067: Mark some orbs as useless when appropriate 10(4 minutes ago, 1 file, 13+ 0-) 13https://github.com/crawl/crawl/commit/cf31067fe6aa 20:00:14 <09gammafunk> I think you could imply some kind of magical attunement (that requires your attention) 20:00:15 <09gammafunk> You finish focusing on the ORB 20:02:57 Unstable branch on crawl.kelbi.org updated to: 0.28-a0-1355-gcf31067fe6 (34) 20:03:28 you finish completing a short rest and are attuned with the ORB. 20:05:04 <08nicolae> The orb is now your friend. 20:06:36 the Dungeon Branch reminds you that the ORB will never threaten to stab you and, in fact, cannot speak. 21:02:31 <09hellmonk> looks like arachne lair rune has had some messed up substs for a long time 21:04:04 !vault johnstein_spider_rune_arachne_lair 21:04:04 1/1. https://github.com/crawl/crawl/blob/master/crawl-ref/source/dat/des/branches/spider.des#L2205 21:04:15 Looks like normal alphabet soup to me. 21:17:23 <10PleasingFungus> lol 21:17:25 <10PleasingFungus> languages are hard 21:21:45 <09hellmonk> man, the death scarab spider vault places like 50 monsters outside the scarab room 21:22:03 03|amethyst02 07* 0.28-a0-1356-g2ad6d04: Handle correct name of Japanese language. 10(16 minutes ago, 1 file, 3+ 1-) 13https://github.com/crawl/crawl/commit/2ad6d0431527 21:23:21 <09hellmonk> no wonder people die to this one lol 21:23:21 <02|amethyst> btw, I don't know if this is something wrong on my end, or a problem with the Makefiles.... 21:23:21 oh you can always blame Makefiles. They're the perfect scapegoat. 21:23:29 <02|amethyst> but I had to manually rebuild tiledef-player.h (make -j32 'EXTERNAL_FLAGS_L= -Og -DDEBUG_STATISTICS ' 'EXTERNAL_LDFLAGS= -Og -DDEBUG_STATISTICS ' DEBUG=y USE_PCRE=y WEBTILES=y did not do so) 21:26:21 <02|amethyst> it's possible that I just had some incorrect timestamps for some reason 21:32:25 Unstable branch on crawl.kelbi.org updated to: 0.28-a0-1356-g2ad6d04315 (34) 21:57:05 <02|amethyst> oh, also, I'm not entirely happy about orbs having the same colour as cloaks/scarves 22:01:34 <02|amethyst> I guess cyan like shields is probably not the greatest, but we could at least steal one colour from randart armour 22:35:49 <|amethyst> though, given that we use white for both cloaks and scarves, maybe cyan wouldn't be the worst 22:57:06 <10PleasingFungus> @kate very goodbug for you: if you exegesis a channeled spell (eg mcc) without actually having any spells memorized, at end of turn, can_cast_spells is checked (to make sure you haven't gone berserk or w/e), returns false, and instantly ends the channeling 22:57:17 <10PleasingFungus> because you can't cast spells if you haven't memorised any spells 23:33:23 -!- Yermak_ is now known as Yermak